@gobing-ai/spur 0.2.5 → 0.2.8

package/spur-cli/config/templates/feature/default.md

@@ -0,0 +1,41 @@
+---
+schema_version: 1
+id: "{{ ID }}"
+name: "{{ NAME }}"
+status: backlog
+priority: P2
+tags: []
+created_at: "{{ CREATED_AT }}"
+updated_at: "{{ CREATED_AT }}"
+---
+
+# {{ ID }}: {{ NAME }}
+
+## Goal
+
+{{ GOAL }}
+
+## Scope
+
+- In:
+- Out:
+
+## Acceptance Criteria
+
+```gherkin
+Feature: {{ NAME }}
+
+  Scenario: Basic acceptance
+    Given some precondition
+    When some action
+    Then some expected outcome
+```
+
+## Tasks
+
+<!-- AUTO-GENERATED by spur feature refresh -->
+<!-- END AUTO-GENERATED -->
+
+## Notes
+
+## History

package/spur-cli/config/templates/task/brainstorm.md

@@ -0,0 +1,29 @@
+---
+schema_version: 1
+name: "{{ NAME }}"
+description: ""
+status: backlog
+type: brainstorm
+profile: standard
+feature_id: null
+parent_wbs: null
+priority: P2
+tags: []
+dependencies: []
+created_at: "{{ CREATED_AT }}"
+updated_at: "{{ CREATED_AT }}"
+---
+
+## {{ WBS }}. {{ NAME }}
+
+### Background
+
+{{ BACKGROUND }}
+
+### Q&A
+
+### Plan
+
+### References
+
+### History

package/spur-cli/config/templates/task/feature-impl.md

@@ -0,0 +1,50 @@
+---
+schema_version: 1
+name: "{{ NAME }}"
+description: ""
+status: backlog
+type: task
+profile: standard
+feature_id: null
+parent_wbs: null
+priority: P2
+tags: []
+dependencies: []
+created_at: "{{ CREATED_AT }}"
+updated_at: "{{ CREATED_AT }}"
+---
+
+## {{ WBS }}. {{ NAME }}
+
+### Background
+
+{{ BACKGROUND }}
+
+### Acceptance Criteria
+
+```gherkin
+Feature: {{ NAME }}
+
+  Scenario: Basic acceptance
+    Given a precondition
+    When an action is taken
+    Then an expected result occurs
+```
+
+- [ ] Acceptance checklist item
+
+### Design
+
+### Plan
+
+- [ ] Implementation step
+
+### Solution
+
+### Testing
+
+### Review
+
+### References
+
+### History

package/spur-cli/config/templates/task/issue.md

@@ -0,0 +1,33 @@
+---
+schema_version: 1
+name: "{{ NAME }}"
+description: ""
+status: backlog
+type: issue
+profile: standard
+feature_id: null
+parent_wbs: null
+priority: P2
+tags: ["bug"]
+dependencies: []
+created_at: "{{ CREATED_AT }}"
+updated_at: "{{ CREATED_AT }}"
+---
+
+## {{ WBS }}. {{ NAME }}
+
+### Background
+
+{{ BACKGROUND }}
+
+### Root Cause
+
+### Solution
+
+### Testing
+
+### Review
+
+### References
+
+### History

package/spur-cli/config/templates/task/meta.md

@@ -0,0 +1,31 @@
+---
+schema_version: 1
+name: "{{ NAME }}"
+description: ""
+status: backlog
+type: meta
+profile: standard
+feature_id: null
+parent_wbs: null
+priority: P2
+tags: ["meta"]
+dependencies: []
+created_at: "{{ CREATED_AT }}"
+updated_at: "{{ CREATED_AT }}"
+---
+
+## {{ WBS }}. {{ NAME }}
+
+### Background
+
+{{ BACKGROUND }}
+
+### Plan
+
+- [ ] Implementation step
+
+### Testing
+
+### References
+
+### History

package/spur-cli/config/templates/task/review.md

@@ -0,0 +1,52 @@
+---
+schema_version: 1
+name: "{{ NAME }}"
+description: ""
+status: backlog
+type: review
+template: review
+profile: standard
+feature_id: null
+parent_wbs: null
+priority: P2
+tags: ["review"]
+dependencies: []
+created_at: "{{ CREATED_AT }}"
+updated_at: "{{ CREATED_AT }}"
+---
+
+## {{ WBS }}. {{ NAME }}
+
+### Background
+
+{{ BACKGROUND }}
+
+#### Review Findings
+
+The code-review findings this task must address — logged here as **input** (what was found
+in the reviewed PR/commit/diff). Fix in priority order (P1 → P2 → …); re-review after.
+
+| Severity | File | Finding | Recommendation |
+| -------- | ---- | ------- | -------------- |
+| P1       |      |         |                |
+| P2       |      |         |                |
+
+### Plan
+
+- [ ] Fix P1 findings
+- [ ] Fix P2 findings
+- [ ] Re-review the changed code
+
+### Review
+
+Post-implementation reflection — filled **after** the first fix round: what went wrong, what
+remains to fix before closing, and any **back-issues** (new findings surfaced by the fix).
+
+| Severity | File | Finding | Recommendation |
+| -------- | ---- | ------- | -------------- |
+| P1       |      |         |                |
+| P2       |      |         |                |
+
+### References
+
+### History

package/spur-cli/config/templates/task/standard.md

@@ -0,0 +1,48 @@
+---
+schema_version: 1
+name: "{{ NAME }}"
+description: ""
+status: backlog
+type: task
+profile: standard
+feature_id: null
+parent_wbs: null
+priority: P2
+tags: []
+dependencies: []
+created_at: "{{ CREATED_AT }}"
+updated_at: "{{ CREATED_AT }}"
+---
+
+## {{ WBS }}. {{ NAME }}
+
+### Background
+
+{{ BACKGROUND }}
+
+### Acceptance Criteria
+
+```gherkin
+Feature: {{ NAME }}
+
+  Scenario: Basic acceptance
+    Given a precondition
+    When an action is taken
+    Then an expected result occurs
+```
+
+- [ ] Acceptance checklist item
+
+### Plan
+
+- [ ] Implementation step
+
+### Solution
+
+### Testing
+
+### Review
+
+### References
+
+### History

package/spur-cli/config/workflows/feature-dev.yaml

@@ -1,117 +1,125 @@
 $schema: "@gobing-ai/spur/schemas/state-machine-workflow.schema.json"
-"$schema": "@gobing-ai/ts-dual-workflow-engine/schemas/state-machine-workflow.schema.json"
+"$schema": "@gobing-ai/spur/schemas/state-machine-workflow.schema.json"
 kind: state-machine
 name: feature-dev
 description: >
-  End-to-end feature-development loop: brainstorm → new-task → refine → implement →
-  check (autofix+spur-check) → fix (until clean) → verify. Agent-driven steps use
-  agent.run; the check gate uses rule.check for deterministic constraint gating.
-  The session latch (Q8) auto-continues agent sessions across steps — no per-step
-  `continue` wiring needed.
+  End-to-end FEATURE development loop: brainstorm → plan (decompose) → execute-tasks →
+  feature-verify → done. Drives a whole feature (one description → a feature with BDD AC →
+  many tasks → all tasks done → feature verified), NOT a single task — for one deliverable
+  use task-pipeline.yaml directly.
+
+  The engine has no native for-each over a dynamic task list, so the execute-tasks step
+  DELEGATES the fan-out: a single agent.run instructs the agent to run every pending task
+  under the feature through task-pipeline.yaml, enumerated via `spur task list --feature`.
+  This mirrors how /sp:dev-run --mode full delegates its inner work loop (ADR-022: orchestration
+  is configuration — zero new engine code).
+
+  Shape: brainstorm → plan → execute-tasks(delegated loop) → feature-verify → done
+         (plan failure or a non-PASS task short-circuits to `failed`).
+
+  Vars (passed as a JSON object via `--vars`):
+    featureId — the feature ID this loop drives (required), e.g. `--vars '{"featureId":"B3"}'`
+    agent     — agent the agent.run steps invoke; override `--vars '{"agent":"claude"}'`
+    profile   — `auto` skips the per-task HITL approval inside task-pipeline
+    spurBin   — PATH-independent spur invocation (CLI overrides at run start; literal fallback)
+
+  Seeded by `spur init`; adapt the agent.run inputs to your project's command set.
 iterationBound: 20
 initialState: brainstorm
 terminalStates:
   - done
   - failed
 vars:
-  taskId: TASK-ID
+  featureId: ""
+  agent: "omp"
+  profile: "standard"
+  spurBin: "spur"
 
 states:
   - id: brainstorm
-    description: Turn vague intent into a structured feature list via /rd3:dev-brainstorm
-    onEnter:
-      - kind: agent.run
-        options:
-          input: /rd3:dev-brainstorm
-
-  - id: new-task
-    description: Convert the feature list into a task file via /rd3:dev-new-task
-    onEnter:
-      - kind: agent.run
-        options:
-          input: /rd3:dev-new-task
-
-  - id: refine
-    description: Auto-refine the task definition via /rd3:dev-refine
-    onEnter:
-      - kind: agent.run
-        options:
-          input: /rd3:dev-refine ${vars.taskId} --focus all --auto
-
-  - id: implement
-    description: Implement + verify the task via /rd3:dev-run
-    onEnter:
-      - kind: agent.run
-        options:
-          input: /rd3:dev-run ${vars.taskId} --auto --verify
-
-  - id: check
     description: >
-      Deterministic constraint gate via rule.check (recommended-pre-check preset).
-      Catches formatting, type, and structural issues before verification.
+      Turn vague intent into a validated feature with BDD acceptance criteria via
+      /sp:dev-brainstorm --feature. The grilling interview maps the decision space; the
+      --feature exit authors AC and loops `spur feature check` until clean. Record the
+      derived feature ID into ${vars.featureId} for the downstream steps.
     onEnter:
-      - kind: rule.check
+      - kind: agent.run
         options:
-          preset: recommended-pre-check
-          failOn: warning
+          agent: ${vars.agent}
+          input: /sp:dev-brainstorm --feature
 
-  - id: fix
+  - id: plan
     description: >
-      Fix failures from the check gate. The latched agent session carries context
-      from the previous steps so the fixer knows what went wrong.
+      Decompose the validated feature into a CLI-validated task batch via /sp:dev-plan.
+      The batch-create gate (task-batch.schema.json) rejects a malformed decomposition,
+      so a bad plan never lands tasks.
     onEnter:
       - kind: agent.run
         options:
-          input: "Fix the failures from the previous check pass for task ${vars.taskId}; run /rd3:dev-fixall or /rd3:dev-unit as appropriate."
+          agent: ${vars.agent}
+          input: /sp:dev-plan --feature ${vars.featureId}
 
-  - id: verify
-    description: Cross-agent verification via /rd3:dev-verify
+  - id: execute-tasks
+    description: >
+      Drive EVERY pending task under the feature to done. The agent enumerates the work with
+      `spur task list --feature ${featureId} --status todo --json`, then runs each task through
+      task-pipeline.yaml (refine → implement → test → review → verify → record → done). It
+      stops and reports on the first non-PASS verdict — a failing task fails the feature.
     onEnter:
       - kind: agent.run
         options:
-          input: /rd3:dev-verify ${vars.taskId} --auto --fix all --force --channel codex/auto
+          agent: ${vars.agent}
+          input: >
+            Run every pending task under feature ${vars.featureId} to done. Enumerate with
+            `${vars.spurBin} task list --feature ${vars.featureId} --status todo --json`, then
+            for each task run the task-pipeline (e.g. /sp:dev-refine <wbs> --auto --next, which
+            chains implement → verify → done). Stop and report on the first non-PASS verdict.
+
+  - id: feature-verify
+    description: >
+      Certify the feature is complete: `spur feature check ${featureId} --strict` validates the
+      AC, traceability, and that all linked tasks are done. A clean strict check is the only
+      proof the feature is shippable.
 
   - id: done
-    description: Terminal — feature implemented, checked, and verified successfully.
+    description: Terminal — feature planned, all tasks executed, and the feature verified.
 
   - id: failed
-    description: Terminal — check loop exhausted iterationBound without passing.
+    description: Terminal — plan rejected, a task failed verification, or the feature check did not pass.
 
 transitions:
-  # Linear prefix: brainstorm → new-task → refine → implement → check
+  # Linear prefix: brainstorm → plan → execute-tasks
   - from: brainstorm
-    to: new-task
-    description: Feature list captured; create the task file
-
-  - from: new-task
-    to: refine
-    description: Task file created; refine it
-
-  - from: refine
-    to: implement
-    description: Task refined; implement it
-
-  - from: implement
-    to: check
-    description: Implementation done; run the gate
-
-  # Check gate: action-ok guard FIRST so a passing check short-circuits to verify.
-  - from: check
-    to: verify
-    description: Check passed — advance to cross-agent verification
+    to: plan
+    description: Feature validated; decompose it into tasks
     guard:
-      kind: action-ok
+      kind: always
 
-  - from: check
-    to: fix
-    description: Check failed — route to a fix attempt
+  - from: plan
+    to: execute-tasks
+    description: Tasks created; execute them
+    guard:
+      kind: always
 
-  # Fix loop: always return to check after a fix attempt
-  - from: fix
-    to: check
-    description: Fix applied; re-run the gate
+  - from: execute-tasks
+    to: feature-verify
+    description: All tasks reported done; verify the feature
+    guard:
+      kind: always
 
-  # Verify → done
-  - from: verify
+  # ── feature-verify gate: strict check certifies done, else fail ──
+  # Declaration order: the pass guard is tried FIRST.
+  - from: feature-verify
     to: done
-    description: Verification passed — workflow complete
+    description: Strict feature check passed — the feature is complete.
+    guard:
+      kind: shell
+      options:
+        command: "${vars.spurBin} feature check ${vars.featureId} --strict"
+  - from: feature-verify
+    to: failed
+    description: Strict feature check failed — block before done; investigate incomplete tasks or AC.
+    guard:
+      kind: shell
+      options:
+        command: '! ${vars.spurBin} feature check ${vars.featureId} --strict'

package/spur-cli/config/workflows/feature-lifecycle.yaml

@@ -0,0 +1,100 @@
+$schema: "@gobing-ai/spur/schemas/state-machine-workflow.schema.json"
+"$schema": "@gobing-ai/spur/schemas/state-machine-workflow.schema.json"
+kind: state-machine
+name: feature-lifecycle
+description: >
+  Feature lifecycle FSM (design §2.3, §5.1, DD-13). States are the canonical
+  FeatureStatus vocabulary; transitions encode the §2.3 graph including the
+  `verifying` status (DD-13). Guards invoke `${vars.spurBin} feature check`
+  at the active→verifying and verifying→done placements. `cancelled` is terminal.
+  Guard commands reference the check verb (0057) — structural validation passes
+  today, behavioral wiring activates as the verb ships. Unconditional transitions
+  use the `always` guard (externally-driven via `requestTransition`, not
+  auto-advance).
+initialState: backlog
+terminalStates:
+  - cancelled
+vars:
+  spurBin: 'spur'
+  featureId: X
+
+states:
+  - id: backlog
+    description: Initial state — feature exists but not yet started.
+  - id: active
+    description: Actively being worked on. P0 in active/verifying is the project goal (B09).
+  - id: verifying
+    description: >
+      Feature verification work (DD-13). Makes verification derivable —
+      listable, event-triggerable, assignable.
+  - id: blocked
+    description: Impediment; work suspended.
+  - id: done
+    description: Completed and verified.
+  - id: cancelled
+    description: Terminal — abandoned.
+
+transitions:
+  # Forward path: backlog → active → verifying → done
+  - from: backlog
+    to: active
+    description: Start feature work
+    guard:
+      kind: always
+  - from: active
+    to: verifying
+    description: >
+      Enter feature verification. Warns unless all linked tasks are done/cancelled.
+    guard:
+      kind: shell
+      options:
+        command: '${vars.spurBin} feature check ${vars.featureId}'
+  - from: verifying
+    to: done
+    description: >
+      Feature verified — complete. Runs strict check (AC validated, traceability clean).
+    guard:
+      kind: shell
+      options:
+        command: '${vars.spurBin} feature check ${vars.featureId} --strict'
+
+  # Rework: verifying → active (mandatory History entry)
+  - from: verifying
+    to: active
+    description: Rework — feature sent back to active (mandatory History entry)
+    guard:
+      kind: always
+
+  # Blocked ↔ active — bidirectional
+  - from: active
+    to: blocked
+    description: Blocked by an impediment
+    guard:
+      kind: always
+  - from: blocked
+    to: active
+    description: Impediment resolved
+    guard:
+      kind: always
+
+  # Cancel: any non-terminal → cancelled (terminal)
+  - from: backlog
+    to: cancelled
+    description: Cancel feature
+    guard:
+      kind: always
+  - from: active
+    to: cancelled
+    description: Cancel feature
+    guard:
+      kind: always
+  - from: verifying
+    to: cancelled
+    description: Cancel feature
+    guard:
+      kind: always
+  - from: blocked
+    to: cancelled
+    description: Cancel feature
+    guard:
+      kind: always