@gnuechtel/nx-cucumber 24.3.1 → 24.3.2

package/README.md

@@ -172,6 +172,11 @@ affected until a repaired Nx patch is adopted. See
 
 This plugin requires [Node.js](https://nodejs.org/), [Nx](https://nx.dev/) and [Cucumber](https://github.com/cucumber/cucumber-js). Version 24.3.0 targets Nx `>=24 <25` and Node.js 24 or 26; published 2.x packages remain the Nx-22 path. Plugin 23.x remains available for Nx 23. Browser automation uses the [Playwright library](https://playwright.dev/docs/library) when selected by the generator. Consult `package.json` for all dependency requirements and `.gitlab-ci.yml` for the pinned CI versions. Minor and patch versions follow this plugin's changes independently of Nx.
 
+For generated Cucumber/Playwright runners on Linux and macOS, reclaiming an
+occupied server port requires `lsof` in `PATH` (for example,
+`apt-get install lsof` on Debian-based Linux). An unused port needs no additional
+utility. Windows uses `netstat` and `taskkill`.
+
 ## Quick start
 
 To immediately use this plugin with a new example React application use the following commands:
@@ -277,7 +282,7 @@ The `e2e` target behavior depends on the selected test runner:
 - **Core runner:** no explicit `e2e` target is generated. The `e2e` task is inferred by the plugin from `cucumber.js`.
 - **Playwright runner:** explicit command targets are generated:
   - `e2e-prepare` installs Playwright Chromium (Linux uses `--with-deps`) and is configured with `cache: false`.
-  - `e2e` runs a generated `run-e2e.js` lifecycle script that manages the full dev server lifecycle (clear port, start server, wait for readiness, run Cucumber, stop server) using only Node.js built-ins.
+  - `e2e` runs a generated `run-e2e.js` lifecycle script that manages the full dev server lifecycle (clear port, start server, wait for readiness, run Cucumber, stop server) using Node.js built-ins and the Unix `lsof` utility for reclaiming occupied ports.
   - `e2e-ci` runs `e2e-prepare` and then `e2e`.
 
 ### Additional project generator options

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gnuechtel/nx-cucumber",
-  "version": "24.3.1",
+  "version": "24.3.2",
   "description": "Plugin to use Cucumber within Nx workspaces",
   "license": "MIT",
   "repository": {

package/src/generators/project/files/playwright/run-e2e.js.template

@@ -55,15 +55,20 @@ async function run() {
           stdio: 'pipe',
         });
       } else {
-        // Let Nx terminate its own detached task processes before forcing exit.
+        // The shell can close before its descendants. Give the whole process
+        // group a grace period, then stop any remaining server processes.
         process.kill(-server.pid, 'SIGTERM');
-        if (!processClosed) {
-          await Promise.race([
-            new Promise((resolve) => server.once('close', resolve)),
-            sleep(5_000),
-          ]);
+        const deadline = Date.now() + 5_000;
+        while (Date.now() < deadline) {
+          try {
+            process.kill(-server.pid, 0);
+          } catch (error) {
+            if (error.code === 'ESRCH') return;
+            throw error;
+          }
+          await sleep(50);
         }
-        if (!processClosed) process.kill(-server.pid, 'SIGKILL');
+        process.kill(-server.pid, 'SIGKILL');
       }
     } catch {
       /* process already exited */
@@ -74,16 +79,12 @@ async function run() {
   const deadline = Date.now() + SERVER_START_TIMEOUT_MS;
   while (!(await portOpen(PORT))) {
     if (processClosed) {
-      console.error(
-        '[nx-cucumber] Server process exited before becoming ready',
-      );
+      console.error('[nx-cucumber] Server process exited before becoming ready');
       process.exit(1);
     }
     if (Date.now() > deadline) {
       await teardown();
-      console.error(
-        `[nx-cucumber] Server did not respond on port ${PORT} within ${SERVER_START_TIMEOUT_MS / 1000}s`,
-      );
+      console.error(`[nx-cucumber] Server did not respond on port ${PORT} within ${SERVER_START_TIMEOUT_MS / 1000}s`);
       process.exit(1);
     }
     await sleep(500);
@@ -130,13 +131,29 @@ async function clearPort() {
       /* port already free */
     }
   } else {
+    let listenerPids = '';
     try {
-      cp.execSync(`lsof -ti :${PORT} | xargs kill -9`, {
-        shell: true,
-        stdio: 'pipe',
+      listenerPids = cp.execFileSync('lsof', ['-nP', '-t', `-iTCP:${PORT}`, '-sTCP:LISTEN'], {
+        encoding: 'utf8',
+        stdio: ['ignore', 'pipe', 'pipe'],
       });
-    } catch {
-      /* port already free */
+    } catch (error) {
+      if (error.code === 'ENOENT') {
+        throw new Error(
+          `[nx-cucumber] lsof is required to reclaim port ${PORT}. Install lsof or free the port manually.`,
+        );
+      }
+      // Exit 1 with no output means the listener disappeared after the probe.
+      if (error.status !== 1 || error.stdout?.length || error.stderr?.length) {
+        throw new Error(`[nx-cucumber] Failed to inspect port ${PORT} with lsof (${error.code || error.status}).`);
+      }
+    }
+    for (const pid of new Set(listenerPids.trim().split(/\s+/).filter(Boolean))) {
+      try {
+        process.kill(Number(pid), 'SIGKILL');
+      } catch (error) {
+        if (error.code !== 'ESRCH') throw error;
+      }
     }
   }