@gnsx/three 0.184.7 → 0.184.8

package/examples/jsm/inspector/Inspector.js

@@ -514,6 +514,7 @@ class Inspector extends RendererInspector {
 
 }
 
+// WITH_GENESYS
 const STORAGE_KEY_THREE_INSPECTOR = 'threejs-inspector';
 
 function getStorageOrNull() {
@@ -581,5 +582,6 @@ function setItem( id, state ) {
 	}
 
 }
+// !WITH_GENESYS
 
 export { Inspector, getItem, setItem };

package/examples/jsm/inspector/tabs/Settings.js

@@ -232,7 +232,9 @@ class Settings extends Parameters {
 
 		const extUrl = new URL( extension.url, new URL( _EXTENSIONS_PATH, import.meta.url ) ).href;
 
+		// WITH_GENESYS
 		const module = await import( /* webpackIgnore: true */ extUrl );
+		// !WITH_GENESYS
 
 		const keys = Object.keys( module );
 		const ExtensionClass = module[ keys[ 0 ] ];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gnsx/three",
-  "version": "0.184.7",
+  "version": "0.184.8",
   "description": "JavaScript 3D library",
   "type": "module",
   "main": "./build/three.cjs",

package/src/nodes/accessors/RendererReferenceNode.js

@@ -76,3 +76,29 @@ export default RendererReferenceNode;
  * @returns {RendererReferenceNode}
  */
 export const rendererReference = ( name, type, renderer = null ) => new RendererReferenceNode( name, type, renderer );
+
+// WITH_GENESYS
+/**
+ * Clears strong links from a {@link RendererReferenceNode} to a disposed renderer.
+ * Module-level nodes (e.g. `toneMappingExposure`) set `.reference` each frame via
+ * `updateReference()` and are not cleared by {@link Renderer#dispose} otherwise.
+ *
+ * @param {RendererReferenceNode} node - The reference node to detach.
+ * @param {Renderer} renderer - The renderer being disposed.
+ */
+export function detachRendererReference( node, renderer ) {
+
+	if ( node.reference === renderer ) {
+
+		node.reference = null;
+
+	}
+
+	if ( node.renderer === renderer ) {
+
+		node.renderer = null;
+
+	}
+
+}
+// !WITH_GENESYS

package/src/renderers/common/RenderObjects.js

@@ -72,6 +72,7 @@ class RenderObjects {
 		 */
 		this.chainMaps = {};
 
+		// WITH_GENESYS
 		/**
 		 * Strongly tracks every render object created through {@link createRenderObject}
 		 * so {@link dispose} can iterate them. ChainMap is `WeakMap`-backed and not
@@ -86,6 +87,7 @@ class RenderObjects {
 		 * @type {Set<RenderObject>}
 		 */
 		this._renderObjects = new Set();
+		// !WITH_GENESYS
 
 	}
 
@@ -187,6 +189,7 @@ class RenderObjects {
 	 */
 	dispose() {
 
+		// WITH_GENESYS
 		// Snapshot first: `RenderObject.dispose()` fires `onDispose` which
 		// mutates `_renderObjects` (and the chain map). Iterating the live set
 		// would skip entries.
@@ -199,6 +202,7 @@ class RenderObjects {
 
 		}
 
+		// !WITH_GENESYS
 		this.chainMaps = {};
 
 	}
@@ -225,7 +229,9 @@ class RenderObjects {
 
 		const renderObject = new RenderObject( nodes, geometries, renderer, object, material, scene, camera, lightsNode, renderContext, clippingContext );
 
+		// WITH_GENESYS
 		this._renderObjects.add( renderObject );
+		// !WITH_GENESYS
 
 		renderObject.onDispose = () => {
 
@@ -235,7 +241,9 @@ class RenderObjects {
 
 			chainMap.delete( renderObject.getChainArray() );
 
+			// WITH_GENESYS
 			this._renderObjects.delete( renderObject );
+			// !WITH_GENESYS
 
 		};
 

package/src/renderers/common/Renderer.js

@@ -33,6 +33,10 @@ import { RenderTarget } from '../../core/RenderTarget.js';
 import { DoubleSide, BackSide, FrontSide, SRGBColorSpace, NoToneMapping, LinearFilter, HalfFloatType, RGBAFormat, PCFShadowMap, VSMShadowMap } from '../../constants.js';
 
 import { float, vec3, vec4, Fn } from '../../nodes/tsl/TSLCore.js';
+// WITH_GENESYS
+import { detachRendererReference } from '../../nodes/accessors/RendererReferenceNode.js';
+import { toneMappingExposure } from '../../nodes/display/ToneMappingNode.js';
+// !WITH_GENESYS
 import { reference } from '../../nodes/accessors/ReferenceNode.js';
 import { highpModelNormalViewMatrix, highpModelViewMatrix } from '../../nodes/accessors/ModelNode.js';
 import { context } from '../../nodes/core/ContextNode.js';
@@ -2529,13 +2533,20 @@ class Renderer {
 
 			} );
 
+			// WITH_GENESYS
 			// Drop the strong reference to the active `RenderContext` so module-level
 			// `WeakMap<RenderContext, …>` caches can release entries once
 			// `_renderContexts.dispose()` has cleared its dictionary.
 			this._currentRenderContext = null;
+			// !WITH_GENESYS
 
 		}
 
+		// WITH_GENESYS
+		// Module-level TSL `toneMappingExposure` retains the last renderer in `.reference`.
+		detachRendererReference( toneMappingExposure, this );
+		// !WITH_GENESYS
+
 		this.setRenderTarget( null );
 		this.setAnimationLoop( null );
 

package/src/renderers/common/Textures.js

@@ -55,6 +55,7 @@ class Textures extends DataMap {
 		 */
 		this._htmlTextures = new Set();
 
+		// WITH_GENESYS
 		/**
 		 * Strongly tracks every texture that has had a `'dispose'` listener
 		 * installed by {@link updateTexture}. `DataMap` is `WeakMap`-backed and
@@ -76,6 +77,7 @@ class Textures extends DataMap {
 		 * @type {Set<RenderTarget>}
 		 */
 		this._renderTargets = new Set();
+		// !WITH_GENESYS
 
 	}
 
@@ -203,7 +205,9 @@ class Textures extends DataMap {
 
 			renderTarget.addEventListener( 'dispose', renderTargetData.onDispose );
 
+			// WITH_GENESYS
 			this._renderTargets.add( renderTarget );
+			// !WITH_GENESYS
 
 		}
 
@@ -425,7 +429,9 @@ class Textures extends DataMap {
 
 			texture.addEventListener( 'dispose', textureData.onDispose );
 
+			// WITH_GENESYS
 			this._textures.add( texture );
+			// !WITH_GENESYS
 
 		}
 
@@ -595,7 +601,9 @@ class Textures extends DataMap {
 			this.delete( renderTarget );
 			this.backend.delete( renderTarget );
 
+			// WITH_GENESYS
 			this._renderTargets.delete( renderTarget );
+			// !WITH_GENESYS
 
 			this.info.memory.renderTargets --;
 
@@ -646,7 +654,9 @@ class Textures extends DataMap {
 
 			this.delete( texture );
 
+			// WITH_GENESYS
 			this._textures.delete( texture );
+			// !WITH_GENESYS
 
 			this.info.destroyTexture( texture );
 
@@ -654,6 +664,7 @@ class Textures extends DataMap {
 
 	}
 
+	// WITH_GENESYS
 	/**
 	 * Frees internal resources. Destroys every tracked render target and
 	 * texture so the `'dispose'` listeners installed by {@link updateTexture}
@@ -689,6 +700,7 @@ class Textures extends DataMap {
 		super.dispose();
 
 	}
+	// !WITH_GENESYS
 
 }