@gmisoftware/react-native-pay 0.0.12 → 0.0.14

package/src/plugin/__tests__/withApplePay.test.ts

@@ -0,0 +1,83 @@
+import {
+  withApplePay,
+  setApplePayEntitlement,
+  setApplePayMerchantIdentifiersInInfoPlist,
+} from '../withApplePay'
+
+const mockWithEntitlementsPlist = jest.fn(
+  (config: Record<string, unknown>, action: (input: any) => any) =>
+    action('modResults' in config ? config : { modResults: config })
+)
+const mockWithInfoPlist = jest.fn(
+  (config: Record<string, unknown>, action: (input: any) => any) =>
+    action('modResults' in config ? config : { modResults: config })
+)
+
+jest.mock('expo/config-plugins', () => ({
+  withEntitlementsPlist: (config: any, action: (input: any) => any) =>
+    mockWithEntitlementsPlist(config, action),
+  withInfoPlist: (config: any, action: (input: any) => any) =>
+    mockWithInfoPlist(config, action),
+}))
+
+describe('withApplePay', () => {
+  it('adds a single merchant entitlement', () => {
+    const result = setApplePayEntitlement('merchant.com.one', {})
+    expect(result).toEqual({
+      'com.apple.developer.in-app-payments': ['merchant.com.one'],
+    })
+  })
+
+  it('adds multiple merchants and de-duplicates existing values', () => {
+    const result = setApplePayEntitlement(
+      ['merchant.com.a', 'merchant.com.b', 'merchant.com.a', ''],
+      {
+        'com.apple.developer.in-app-payments': ['merchant.com.a'],
+      }
+    )
+    expect(result).toEqual({
+      'com.apple.developer.in-app-payments': [
+        'merchant.com.a',
+        'merchant.com.b',
+      ],
+    })
+  })
+
+  it('writes merchant identifiers into Info.plist', () => {
+    const result = setApplePayMerchantIdentifiersInInfoPlist(
+      ['merchant.com.a', 'merchant.com.b', 'merchant.com.a', ''],
+      {}
+    )
+
+    expect(result).toEqual({
+      ReactNativePayApplePayMerchantIdentifiers: [
+        'merchant.com.a',
+        'merchant.com.b',
+      ],
+    })
+  })
+
+  it('does not modify config when merchantIdentifier is missing', () => {
+    const config = { name: 'app' }
+    const result = withApplePay(config as any, {})
+    expect(result).toBe(config)
+    expect(mockWithEntitlementsPlist).not.toHaveBeenCalled()
+    expect(mockWithInfoPlist).not.toHaveBeenCalled()
+  })
+
+  it('applies entitlements when merchantIdentifier is provided', () => {
+    const config = {}
+    const result = withApplePay(config as any, {
+      merchantIdentifier: 'merchant.com.test',
+    })
+
+    expect(mockWithEntitlementsPlist).toHaveBeenCalledTimes(1)
+    expect(mockWithInfoPlist).toHaveBeenCalledTimes(1)
+    expect(result).toEqual({
+      modResults: {
+        'com.apple.developer.in-app-payments': ['merchant.com.test'],
+        'ReactNativePayApplePayMerchantIdentifiers': ['merchant.com.test'],
+      },
+    })
+  })
+})

package/src/plugin/__tests__/withGooglePay.test.ts

@@ -0,0 +1,66 @@
+const mockAddMetaDataItemToMainApplication = jest.fn()
+const mockGetMainApplicationOrThrow = jest.fn()
+const mockRemoveMetaDataItemFromMainApplication = jest.fn()
+const mockWithAndroidManifest = jest.fn(
+  (config: Record<string, unknown>, action: (input: any) => any) =>
+    action({ modResults: config })
+)
+
+jest.mock('expo/config-plugins', () => ({
+  AndroidConfig: {
+    Manifest: {
+      addMetaDataItemToMainApplication: (...args: any[]) =>
+        mockAddMetaDataItemToMainApplication(...args),
+      getMainApplicationOrThrow: (...args: any[]) =>
+        mockGetMainApplicationOrThrow(...args),
+      removeMetaDataItemFromMainApplication: (...args: any[]) =>
+        mockRemoveMetaDataItemFromMainApplication(...args),
+    },
+  },
+  withAndroidManifest: (config: any, action: (input: any) => any) =>
+    mockWithAndroidManifest(config, action),
+}))
+
+import { setGooglePayMetaData, withGooglePay } from '../withGooglePay'
+
+describe('withGooglePay', () => {
+  beforeEach(() => {
+    mockGetMainApplicationOrThrow.mockReturnValue({ name: 'main-app' })
+  })
+
+  it('enables Google Pay metadata when enabled=true', () => {
+    const manifest = { application: [] }
+    const result = setGooglePayMetaData(true, manifest as any)
+
+    expect(result).toBe(manifest)
+    expect(mockGetMainApplicationOrThrow).toHaveBeenCalledWith(manifest)
+    expect(mockAddMetaDataItemToMainApplication).toHaveBeenCalledWith(
+      { name: 'main-app' },
+      'com.google.android.gms.wallet.api.enabled',
+      'true'
+    )
+    expect(mockRemoveMetaDataItemFromMainApplication).not.toHaveBeenCalled()
+  })
+
+  it('removes Google Pay metadata when enabled=false', () => {
+    const manifest = { application: [] }
+    const result = setGooglePayMetaData(false, manifest as any)
+
+    expect(result).toBe(manifest)
+    expect(mockGetMainApplicationOrThrow).toHaveBeenCalledWith(manifest)
+    expect(mockRemoveMetaDataItemFromMainApplication).toHaveBeenCalledWith(
+      { name: 'main-app' },
+      'com.google.android.gms.wallet.api.enabled'
+    )
+    expect(mockAddMetaDataItemToMainApplication).not.toHaveBeenCalled()
+  })
+
+  it('wires withAndroidManifest and applies metadata by plugin prop', () => {
+    const config = { name: 'app' }
+    const result = withGooglePay(config as any, { enableGooglePay: true })
+
+    expect(mockWithAndroidManifest).toHaveBeenCalledTimes(1)
+    expect(result).toEqual({ modResults: { name: 'app' } })
+    expect(mockAddMetaDataItemToMainApplication).toHaveBeenCalled()
+  })
+})

package/src/plugin/withApplePay.ts

@@ -1,13 +1,18 @@
-import { withEntitlementsPlist, type ConfigPlugin } from 'expo/config-plugins'
+import {
+  withEntitlementsPlist,
+  withInfoPlist,
+  type ConfigPlugin,
+} from 'expo/config-plugins'
 import type { ReactNativePayPluginProps } from './type'
 
+const APPLE_PAY_ENTITLEMENT_KEY = 'com.apple.developer.in-app-payments'
+const APPLE_PAY_INFO_PLIST_KEY = 'ReactNativePayApplePayMerchantIdentifiers'
+
 export function setApplePayEntitlement(
   merchantIdentifiers: string | string[],
   entitlements: Record<string, any>
 ): Record<string, any> {
-  const key = 'com.apple.developer.in-app-payments'
-
-  const merchants: string[] = entitlements[key] ?? []
+  const merchants: string[] = entitlements[APPLE_PAY_ENTITLEMENT_KEY] ?? []
 
   if (!Array.isArray(merchantIdentifiers)) {
     merchantIdentifiers = [merchantIdentifiers]
@@ -20,11 +25,26 @@ export function setApplePayEntitlement(
   }
 
   if (merchants.length) {
-    entitlements[key] = merchants
+    entitlements[APPLE_PAY_ENTITLEMENT_KEY] = merchants
   }
   return entitlements
 }
 
+export function setApplePayMerchantIdentifiersInInfoPlist(
+  merchantIdentifiers: string | string[],
+  infoPlist: Record<string, any>
+): Record<string, any> {
+  const merchants: string[] = Array.isArray(merchantIdentifiers)
+    ? merchantIdentifiers.filter(Boolean)
+    : [merchantIdentifiers].filter(Boolean)
+
+  if (merchants.length) {
+    infoPlist[APPLE_PAY_INFO_PLIST_KEY] = [...new Set(merchants)]
+  }
+
+  return infoPlist
+}
+
 export const withApplePay: ConfigPlugin<ReactNativePayPluginProps> = (
   expoConfig,
   { merchantIdentifier }
@@ -34,11 +54,19 @@ export const withApplePay: ConfigPlugin<ReactNativePayPluginProps> = (
     return expoConfig
   }
 
-  return withEntitlementsPlist(expoConfig, (config) => {
+  const withEntitlements = withEntitlementsPlist(expoConfig, (config) => {
     config.modResults = setApplePayEntitlement(
       merchantIdentifier,
       config.modResults
     )
     return config
   })
+
+  return withInfoPlist(withEntitlements, (config) => {
+    config.modResults = setApplePayMerchantIdentifiersInInfoPlist(
+      merchantIdentifier,
+      config.modResults
+    )
+    return config
+  })
 }

package/src/types/Payment.ts

@@ -72,7 +72,9 @@ export interface PaymentToken {
   paymentData: string // Base64 encoded Data from PKPaymentToken
 }
 export interface PaymentRequest {
-  merchantIdentifier: string
+  // Optional Apple Pay override for apps with multiple configured merchant IDs.
+  // When omitted, iOS resolves the first configured entitlement automatically.
+  applePayMerchantIdentifier?: string
   merchantName?: string
   countryCode: string
   currencyCode: string
@@ -84,6 +86,7 @@ export interface PaymentRequest {
   billingContactRequired?: boolean
   shippingContactRequired?: boolean
   // Google Pay specific configuration (Android only)
+  googlePayMerchantId?: string
   googlePayEnvironment?: GooglePayEnvironment
   googlePayGateway?: string
   googlePayGatewayMerchantId?: string

package/src/utils/__tests__/paymentHelpers.test.ts

@@ -0,0 +1,127 @@
+import {
+  CommonNetworks,
+  calculateTotal,
+  createPaymentItem,
+  createPaymentRequest,
+  formatAmount,
+  formatNetworkName,
+  isNetworkSupported,
+  parseAmount,
+  sanitizePaymentRequest,
+} from '../paymentHelpers'
+
+describe('paymentHelpers', () => {
+  it('creates payment items with default and explicit type', () => {
+    expect(createPaymentItem('Coffee', 4.99)).toEqual({
+      label: 'Coffee',
+      amount: 4.99,
+      type: 'final',
+    })
+    expect(createPaymentItem('Shipping', 2.5, 'pending')).toEqual({
+      label: 'Shipping',
+      amount: 2.5,
+      type: 'pending',
+    })
+  })
+
+  it('calculates totals from line items', () => {
+    expect(
+      calculateTotal([
+        createPaymentItem('Product', 10),
+        createPaymentItem('Tax', 2.15),
+        createPaymentItem('Shipping', 3.35),
+      ])
+    ).toBeCloseTo(15.5)
+  })
+
+  it('creates payment requests with sane defaults', () => {
+    const request = createPaymentRequest({
+      amount: 19.99,
+      label: 'Pro Plan',
+    })
+
+    expect(request).toEqual({
+      countryCode: 'US',
+      currencyCode: 'USD',
+      paymentItems: [{ label: 'Pro Plan', amount: 19.99, type: 'final' }],
+      supportedNetworks: [
+        CommonNetworks.VISA,
+        CommonNetworks.MASTERCARD,
+        CommonNetworks.AMEX,
+        CommonNetworks.DISCOVER,
+      ],
+      merchantCapabilities: ['3DS'],
+    })
+  })
+
+  it('allows overriding defaults in payment requests', () => {
+    const request = createPaymentRequest({
+      amount: 39.99,
+      label: 'Deluxe',
+      countryCode: 'PL',
+      currencyCode: 'PLN',
+      supportedNetworks: ['visa'],
+      merchantCapabilities: ['EMV'],
+      merchantName: 'My Store',
+      applePayMerchantIdentifier: 'merchant.com.apple.override',
+      googlePayMerchantId: 'google-pay-merchant-id',
+    })
+
+    expect(request.countryCode).toBe('PL')
+    expect(request.currencyCode).toBe('PLN')
+    expect(request.supportedNetworks).toEqual(['visa'])
+    expect(request.merchantCapabilities).toEqual(['EMV'])
+    expect(request.merchantName).toBe('My Store')
+    expect(request.applePayMerchantIdentifier).toBe(
+      'merchant.com.apple.override'
+    )
+    expect(request.googlePayMerchantId).toBe('google-pay-merchant-id')
+  })
+
+  it('omits undefined optional fields from created payment requests', () => {
+    const request = createPaymentRequest({
+      amount: 10,
+      label: 'Order',
+      merchantName: undefined,
+      googlePayMerchantId: undefined,
+      googlePayGateway: 'stripe',
+    })
+
+    expect(request).not.toHaveProperty('merchantName')
+    expect(request).not.toHaveProperty('googlePayMerchantId')
+    expect(request.googlePayGateway).toBe('stripe')
+  })
+
+  it('sanitizes payment requests before native bridging', () => {
+    const request = sanitizePaymentRequest({
+      countryCode: 'PL',
+      currencyCode: 'PLN',
+      paymentItems: [{ label: 'Order', amount: 10, type: 'final' }],
+      supportedNetworks: ['visa'],
+      merchantCapabilities: ['3DS'],
+      merchantName: undefined,
+      googlePayGateway: 'przelewy24',
+      googlePayGatewayMerchantId: undefined,
+    } as any)
+
+    expect(request).not.toHaveProperty('merchantName')
+    expect(request).not.toHaveProperty('googlePayGatewayMerchantId')
+    expect(request.googlePayGateway).toBe('przelewy24')
+  })
+
+  it('formats and parses amount values', () => {
+    expect(formatAmount(29.9)).toBe('29.90')
+    expect(parseAmount('29.90')).toBeCloseTo(29.9)
+  })
+
+  it('checks network support using case-insensitive matching', () => {
+    expect(isNetworkSupported('AMEX', ['visa', 'amex'])).toBe(true)
+    expect(isNetworkSupported('discover', ['visa', 'mastercard'])).toBe(false)
+  })
+
+  it('formats known payment networks for display', () => {
+    expect(formatNetworkName('visa')).toBe('Visa')
+    expect(formatNetworkName('amex')).toBe('American Express')
+    expect(formatNetworkName('privateLabel')).toBe('Private Label')
+  })
+})

package/src/utils/paymentHelpers.ts

@@ -11,7 +11,6 @@
  * import { createPaymentRequest, calculateTotal } from 'react-native-pay'
  *
  * const request = createPaymentRequest({
- *   merchantIdentifier: 'merchant.com.example',
  *   amount: 29.99,
  *   label: 'Coffee Subscription'
  * })
@@ -30,6 +29,31 @@ export const CommonNetworks = {
   DISCOVER: 'discover',
 } as const
 
+const DEFAULT_SUPPORTED_NETWORKS: PaymentRequest['supportedNetworks'] = [
+  CommonNetworks.VISA,
+  CommonNetworks.MASTERCARD,
+  CommonNetworks.AMEX,
+  CommonNetworks.DISCOVER,
+]
+
+const DEFAULT_MERCHANT_CAPABILITIES: PaymentRequest['merchantCapabilities'] = [
+  '3DS',
+]
+
+function omitUndefinedProperties<T extends object>(value: T): T {
+  return Object.fromEntries(
+    Object.entries(value as Record<string, unknown>).filter(
+      ([, entryValue]) => entryValue !== undefined
+    )
+  ) as T
+}
+
+export function sanitizePaymentRequest(
+  request: PaymentRequest
+): PaymentRequest {
+  return omitUndefinedProperties(request)
+}
+
 /**
  * Creates a payment item with the specified label, amount, and type.
  *
@@ -80,13 +104,12 @@ export function calculateTotal(items: PaymentItem[]): number {
  * - supportedNetworks: ['visa', 'mastercard', 'amex', 'discover']
  * - merchantCapabilities: ['3DS']
  *
- * @param options - Payment request options (merchantIdentifier, amount, label required)
+ * @param options - Payment request options (amount and label required)
  * @returns Complete PaymentRequest object
  *
  * @example
  * ```typescript
  * const request = createPaymentRequest({
- *   merchantIdentifier: 'merchant.com.example',
  *   amount: 29.99,
  *   label: 'Coffee Subscription',
  *   countryCode: 'CA', // override default
@@ -96,36 +119,28 @@ export function calculateTotal(items: PaymentItem[]): number {
  */
 export function createPaymentRequest(
   options: Partial<PaymentRequest> & {
-    merchantIdentifier: string
     amount: number
     label: string
   }
 ): PaymentRequest {
   const {
-    merchantIdentifier,
     amount,
     label,
     countryCode = 'US',
     currencyCode = 'USD',
-    supportedNetworks = [
-      CommonNetworks.VISA,
-      CommonNetworks.MASTERCARD,
-      CommonNetworks.AMEX,
-      CommonNetworks.DISCOVER,
-    ],
-    merchantCapabilities = ['3DS'],
+    supportedNetworks = DEFAULT_SUPPORTED_NETWORKS,
+    merchantCapabilities = DEFAULT_MERCHANT_CAPABILITIES,
     ...rest
   } = options
 
-  return {
-    merchantIdentifier,
+  return sanitizePaymentRequest({
     countryCode,
     currencyCode,
     paymentItems: [createPaymentItem(label, amount, 'final')],
     supportedNetworks,
     merchantCapabilities,
     ...rest,
-  }
+  } as PaymentRequest)
 }
 
 /**