@gmickel/gno 1.16.0 → 1.18.0

package/src/store/sqlite/adapter.ts

@@ -10,6 +10,8 @@
 // CRITICAL: Import setup FIRST to configure custom SQLite before any Database use
 import "./setup";
 import { Database } from "bun:sqlite";
+// node:async_hooks binds nested transactions to one async request; Bun has no separate native equivalent.
+import { AsyncLocalStorage } from "node:async_hooks";
 // node:path basename: no Bun path utilities.
 import { basename } from "node:path";
 
@@ -86,12 +88,17 @@ const WHITESPACE_REGEX = /\s+/;
 const SINGLE_LINE_QUERY_PATTERN = /[\r\n]/;
 const DOUBLE_QUOTE_PATTERN = /"/g;
 const DOC_EDGE_TYPE_PATTERN = /^[a-z][a-z0-9_]*$/;
+const SQLITE_SAFE_PARAMETER_BATCH_SIZE = 900;
 const FTS5_FIELD_WEIGHTS = {
   filepath: 1.5,
   title: 4.0,
   body: 1.0,
 } as const;
 
+const uniqueNonEmptyValues = (values: readonly string[]): string[] => [
+  ...new Set(values.filter((value) => value.trim().length > 0)),
+];
+
 /** Content-free activation snapshot query; kept exported for contract tests. */
 export const ACTIVATION_INDEX_SNAPSHOT_SQL = `SELECT
   d.id,
@@ -307,8 +314,9 @@ export class SqliteAdapter implements StorePort, SqliteDbProvider {
   private dbPath = "";
   private ftsTokenizer: FtsTokenizer = "unicode61";
   private configPath = ""; // Set by CLI layer for status output
-  private txDepth = 0; // Transaction nesting depth
   private txCounter = 0; // Savepoint counter for unique names
+  private readonly txContext = new AsyncLocalStorage<{ depth: number }>();
+  private txTail: Promise<void> = Promise.resolve();
   private contextGeneration = 0;
 
   // ─────────────────────────────────────────────────────────────────────────
@@ -402,9 +410,12 @@ export class SqliteAdapter implements StorePort, SqliteDbProvider {
    */
   async withTransaction<T>(fn: () => Promise<T>): Promise<StoreResult<T>> {
     const db = this.ensureOpen();
-
-    const isOuter = this.txDepth === 0;
+    const parent = this.txContext.getStore();
+    const isOuter = parent === undefined;
     const savepoint = `sp_${++this.txCounter}`;
+    const releaseWriter = isOuter
+      ? await this.acquireTransactionWriter()
+      : null;
 
     try {
       if (isOuter) {
@@ -414,9 +425,10 @@ export class SqliteAdapter implements StorePort, SqliteDbProvider {
         db.exec(`SAVEPOINT ${savepoint}`);
       }
 
-      this.txDepth += 1;
-      const value = await fn();
-      this.txDepth -= 1;
+      const value = await this.txContext.run(
+        { depth: (parent?.depth ?? 0) + 1 },
+        fn
+      );
 
       if (isOuter) {
         db.exec("COMMIT");
@@ -426,8 +438,6 @@ export class SqliteAdapter implements StorePort, SqliteDbProvider {
 
       return ok(value);
     } catch (cause) {
-      this.txDepth = Math.max(0, this.txDepth - 1);
-
       try {
         if (isOuter) {
           db.exec("ROLLBACK");
@@ -442,9 +452,21 @@ export class SqliteAdapter implements StorePort, SqliteDbProvider {
       const message =
         cause instanceof Error ? cause.message : "Transaction failed";
       return err("TRANSACTION_FAILED", message, cause);
+    } finally {
+      releaseWriter?.();
     }
   }
 
+  private async acquireTransactionWriter(): Promise<() => void> {
+    const previous = this.txTail;
+    let release!: () => void;
+    this.txTail = new Promise<void>((resolve) => {
+      release = resolve;
+    });
+    await previous;
+    return release;
+  }
+
   /**
    * Set config path for status output (called by CLI layer).
    */
@@ -1384,28 +1406,38 @@ export class SqliteAdapter implements StorePort, SqliteDbProvider {
     mirrorHashes: string[]
   ): Promise<StoreResult<Map<string, string>>> {
     try {
-      const db = this.ensureOpen();
-
-      if (mirrorHashes.length === 0) {
+      const uniqueHashes = uniqueNonEmptyValues(mirrorHashes);
+      if (uniqueHashes.length === 0) {
         return ok(new Map());
       }
+      const db = this.ensureOpen();
 
       interface DbContentRow {
         mirror_hash: string;
         markdown: string;
       }
 
-      const placeholders = mirrorHashes.map(() => "?").join(", ");
-      const rows = db
-        .query<DbContentRow, string[]>(
-          `SELECT mirror_hash, markdown FROM content
-           WHERE mirror_hash IN (${placeholders})`
-        )
-        .all(...mirrorHashes);
+      const result = new Map<string, string>();
+      for (
+        let offset = 0;
+        offset < uniqueHashes.length;
+        offset += SQLITE_SAFE_PARAMETER_BATCH_SIZE
+      ) {
+        const batch = uniqueHashes.slice(
+          offset,
+          offset + SQLITE_SAFE_PARAMETER_BATCH_SIZE
+        );
+        const placeholders = batch.map(() => "?").join(", ");
+        const rows = db
+          .query<DbContentRow, string[]>(
+            `SELECT mirror_hash, markdown FROM content
+             WHERE mirror_hash IN (${placeholders})`
+          )
+          .all(...batch);
+        for (const row of rows) result.set(row.mirror_hash, row.markdown);
+      }
 
-      return ok(
-        new Map(rows.map((row) => [row.mirror_hash, row.markdown] as const))
-      );
+      return ok(result);
     } catch (cause) {
       return err(
         "QUERY_FAILED",
@@ -1493,9 +1525,7 @@ export class SqliteAdapter implements StorePort, SqliteDbProvider {
       }
 
       // Dedupe and filter empty strings
-      const uniqueHashes = [
-        ...new Set(mirrorHashes.filter((h) => h.trim().length > 0)),
-      ];
+      const uniqueHashes = uniqueNonEmptyValues(mirrorHashes);
       if (uniqueHashes.length === 0) {
         return ok(new Map());
       }
@@ -1505,11 +1535,16 @@ export class SqliteAdapter implements StorePort, SqliteDbProvider {
 
       // SQLite SQLITE_LIMIT_VARIABLE_NUMBER defaults to 999
       // Reserve 99 for potential future filter params (collection, language, etc.)
-      const SQLITE_MAX_PARAMS = 900;
-
       // Batch queries to respect SQLite parameter limit
-      for (let i = 0; i < uniqueHashes.length; i += SQLITE_MAX_PARAMS) {
-        const batch = uniqueHashes.slice(i, i + SQLITE_MAX_PARAMS);
+      for (
+        let i = 0;
+        i < uniqueHashes.length;
+        i += SQLITE_SAFE_PARAMETER_BATCH_SIZE
+      ) {
+        const batch = uniqueHashes.slice(
+          i,
+          i + SQLITE_SAFE_PARAMETER_BATCH_SIZE
+        );
         const placeholders = batch.map(() => "?").join(",");
         const sql = `SELECT * FROM content_chunks
                      WHERE mirror_hash IN (${placeholders})
@@ -4214,7 +4249,7 @@ export class SqliteAdapter implements StorePort, SqliteDbProvider {
       // Last updated (max updated_at from documents)
       const lastUpdatedRow = db
         .query<{ last_updated: string | null }, []>(
-          "SELECT MAX(updated_at) as last_updated FROM documents"
+          "SELECT strftime('%Y-%m-%dT%H:%M:%fZ', MAX(updated_at)) as last_updated FROM documents"
         )
         .get();