@gmickel/gno 1.0.5 → 1.2.0

package/src/cli/run.ts

@@ -169,7 +169,10 @@ Run '${CLI_NAME} --help' for full command list.
  * No process.exit() - caller sets process.exitCode.
  */
 export async function runCli(argv: string[]): Promise<number> {
-  // Reset global state for clean invocation (important for testing)
+  // Reset global state for clean invocation (important for testing).
+  // The detach paths (runServeDetach / runDaemonDetach) read argv from
+  // Commander's per-invocation `Command.rawArgs` via `resolveCliArgv()`,
+  // so no separate process-global capture is needed here.
   resetGlobals();
 
   const isJson = argvWantsJson(argv);
@@ -204,8 +207,13 @@ export async function runCli(argv: string[]): Promise<number> {
   } catch (err) {
     // Handle CliError with proper JSON formatting
     if (err instanceof CliError) {
-      const output = formatErrorForOutput(err, { json: isJson });
-      process.stderr.write(`${output}\n`);
+      // `silent` is reserved for codes whose exit value carries the meaning
+      // (e.g. NOT_RUNNING from `--stop` per spec/cli.md). Skip stderr but
+      // still propagate the code.
+      if (!err.silent) {
+        const output = formatErrorForOutput(err, { json: isJson });
+        process.stderr.write(`${output}\n`);
+      }
       return exitCodeFor(err);
     }
 

package/src/core/user-dirs.ts

@@ -0,0 +1,86 @@
+// node:os homedir: no Bun equivalent.
+import { homedir } from "node:os";
+// node:path join/normalize: no Bun path utilities.
+import { join, normalize } from "node:path";
+
+interface ResolveDownloadsDirDeps {
+  env?: Record<string, string | undefined>;
+  homeDir?: string;
+  platform?: NodeJS.Platform;
+  readTextFile?: (path: string) => Promise<string | null>;
+}
+
+const XDG_DOWNLOAD_DIR_REGEX = /^XDG_DOWNLOAD_DIR=(?:"([^"]+)"|([^\r\n#]+))$/mu;
+
+function expandEnvPath(
+  value: string,
+  env: Record<string, string | undefined>,
+  homeDir: string
+): string {
+  return normalize(
+    value
+      .trim()
+      .replaceAll(/\$HOME|\$\{HOME\}/gu, homeDir)
+      .replace(/^~(?=$|[\\/])/u, homeDir)
+      .replaceAll(
+        /%([^%]+)%/gu,
+        (_match, key: string) => env[key] ?? env[key.toUpperCase()] ?? ""
+      )
+  );
+}
+
+function parseXdgDownloadsDir(
+  fileContents: string,
+  env: Record<string, string | undefined>,
+  homeDir: string
+): string | null {
+  const match = fileContents.match(XDG_DOWNLOAD_DIR_REGEX);
+  const rawValue = match?.[1] ?? match?.[2];
+  if (!rawValue) {
+    return null;
+  }
+  return expandEnvPath(rawValue, env, homeDir);
+}
+
+async function defaultReadTextFile(path: string): Promise<string | null> {
+  const file = Bun.file(path);
+  if (!(await file.exists())) {
+    return null;
+  }
+  return file.text();
+}
+
+export async function resolveDownloadsDir(
+  deps: ResolveDownloadsDirDeps = {}
+): Promise<string> {
+  const env = deps.env ?? process.env;
+  const platform = deps.platform ?? process.platform;
+  const homeDir = deps.homeDir ?? homedir();
+  const readTextFile = deps.readTextFile ?? defaultReadTextFile;
+
+  if (platform === "linux") {
+    const explicit = env.XDG_DOWNLOAD_DIR?.trim();
+    if (explicit) {
+      return expandEnvPath(explicit, env, homeDir);
+    }
+
+    const xdgConfigHome =
+      env.XDG_CONFIG_HOME?.trim() || join(homeDir, ".config");
+    const userDirs = await readTextFile(join(xdgConfigHome, "user-dirs.dirs"));
+    if (userDirs) {
+      const parsed = parseXdgDownloadsDir(userDirs, env, homeDir);
+      if (parsed) {
+        return parsed;
+      }
+    }
+  }
+
+  if (platform === "win32") {
+    const userProfile = env.USERPROFILE?.trim();
+    if (userProfile) {
+      return join(userProfile, "Downloads");
+    }
+  }
+
+  return join(homeDir, "Downloads");
+}