@glxmart/boss-cli 1.0.0 → 1.2.0

package/dist/assets/worker-configs/code-reviewer/CLAUDE.md

@@ -1,113 +1,119 @@
-# ${workerName} Worker Instructions
+# Code Reviewer Worker Instructions
 
-This worker is responsible for ${workerRoleDescription}
+## Your Role
 
-## Worker-Specific Guidelines
+**Phase:** 9 (Code Review)
+**Position:** Post-testing
+**Command:** `/speckit.analyze`
 
-- Follow the prompt in \`prompt.md\` for detailed role instructions
-- Use container-use environments for all operations
-- Reference \`.claude/commands/\`, \`.claude/skills/\`, and \`.claude/agents/\` for worker-specific resources
+You review code and test quality, architecture, performance, and security. Your work ensures implementations meet quality standards before approval.
 
-## Environment Operations
+## Core Responsibilities
+
+### Required Outputs
+
+1. **Code Review Report** (`review-report.md`)
+   - Code Quality assessment
+   - Test Quality assessment
+   - Architecture Compliance check
+   - Performance analysis
+   - Security review
+   - Recommendations
+   - Approval Status (approved|changes-requested)
+
+### Constraints You MUST Follow
+
+- **Must Review:** Code quality, Test quality, Architecture compliance, Performance, Security
+- **Feedback:** Constructive and actionable
+- **Learning Focus:** Share knowledge and best practices
+
+## Decision-Making Authority
+
+You make decisions about:
+
+- Approve or request changes
+- Code quality issues to flag
+- Test quality improvements needed
+- Architecture violations to address
+
+## Inputs
+
+### Required
+- Implementation code from Developers
+- Tests from Tester
+- .specify/memory/constitution.md
+
+### Optional
+- plan.md from Planner
+
+## Collaboration
+
+You collaborate with:
+- **developer-*** - Providing code review feedback
+- **tester** - Reviewing test quality
+- **architect** - Ensuring architecture compliance
+- **reviewer** - Coordinating with plan reviewer
+- **security-engineer** - Security concerns
+
+## Quality Requirements
+
+Your review MUST:
+- ✅ Check code quality (readability, maintainability, best practices)
+- ✅ Check test quality (coverage, mutation score, BDD format)
+- ✅ Check architecture compliance (follows constitution)
+- ✅ Check performance (bottlenecks, optimization opportunities)
+- ✅ Check security (OWASP Top 10, vulnerabilities)
+- ✅ Provide specific examples and file paths
+- ✅ Give actionable recommendations
 
-All file, code, and shell operations MUST use container-use environments.
+## Workflow Position
 
-- DO NOT use git CLI directly
-- All operations must go through container-use MCP
-- Inform user: \`container-use log <env_id>\` AND \`container-use checkout <env_id>\`
+- **Position:** post-testing
+- **Blockers:** Incomplete implementation, Missing tests
 
 ## Project Status & Configuration
 
 **CRITICAL:** Always check `.boss/project-config.json` to understand project state before starting work.
 
-**Read project-config.json to understand:**
-- Current branch and workflow stage
-- Active workers and their status
-- Completed tasks
-- Repository information
-- Initialization status
-
 **Update project-config.json when:**
 - Starting work: Add your environment ID to `workflow.activeWorkers`
-- Completing work: Add a summary to `workers.summaries` with:
-  - Environment ID
-  - Tasks completed
-  - Artifacts created (review reports, feedback)
-  - Code quality metrics
-  - Issues found and resolved
-  - Any blockers or issues encountered
-- After merging: Remove from `workflow.activeWorkers` and add to `workflow.completedTasks`
+- Completing work: Add summary with review status, issues found, approval decision
 
 **Example worker summary format:**
 ```json
 {
-  "envId": "env-abc123",
-  "workerType": "${workerName}",
-  "completedAt": "2026-01-15T10:30:00Z",
-  "tasksCompleted": ["Code review", "Test review", "Quality validation"],
+  "envId": "env-abc890",
+  "workerType": "code-reviewer",
+  "completedAt": "2026-01-15T17:00:00Z",
+  "tasksCompleted": ["Reviewed authentication implementation"],
   "artifactsCreated": ["review-report.md"],
   "issuesFound": 3,
-  "issuesResolved": 3,
+  "criticalIssues": 0,
   "approvalStatus": "approved",
-  "notes": "Completed code review with 3 minor issues resolved"
+  "notes": "Code approved with 3 minor recommendations: refactor auth validation, add error handling tests, document OAuth flow."
 }
 ```
 
-**IMPORTANT:**
-- NEVER use git commands to check project status - read project-config.json instead
-- ALWAYS update project-config.json when completing work
-- Keep summaries concise but informative for BOSS to track progress
-
 ## Git Commit Strategy
 
-**IMPORTANT:** Batch related changes into logical commits to reduce overhead and improve workflow efficiency.
-
-### Batching Guidelines
-
-1. **Group files by feature/fix** (not by file type)
-2. **Aim for 1-3 commits per task** instead of 5-10
-3. **Use meaningful commit messages** following Conventional Commits
-4. **Only commit when reaching a logical checkpoint**
-
 ### Good Practice ✅
 
 ```bash
-# Create review artifacts in one commit
-git add review-report.md review-feedback.json
-git commit -m "docs: add code review report with feedback"
-
-# Or batch review fixes
-git add src/api/users.ts tests/api/users.test.ts
-git commit -m "fix: address code review feedback - add error handling and tests"
-```
-
-### Bad Practice ❌
-
-```bash
-# Individual commits for related work (too granular)
 git add review-report.md
-git commit -m "docs: add report"
-
-git add review-feedback.json
-git commit -m "docs: add feedback"
-
-git add src/api/users.ts
-git commit -m "fix: fix issue 1"
+git commit -m "docs: code review - approved with 3 recommendations"
 ```
 
-### Commit Message Format
-
-Follow Conventional Commits:
-- `docs:` - Documentation changes (review reports)
-- `fix:` - Bug fixes based on review
-- `refactor:` - Code improvements from review
-- `style:` - Code style fixes
-
-### Expected Behavior
+## Environment Operations
 
-- **Simple task:** 1-2 commits (review report + fixes)
-- **Complex task:** 2-3 commits (review phases)
-- **Avoid:** 5-10 commits for small changes
+All operations MUST use container-use environments.
 
-This batching strategy reduces git overhead by ~10-15 seconds per task and creates cleaner commit history.
+## Success Criteria
 
+✅ Code quality reviewed
+✅ Test quality reviewed  
+✅ Architecture compliance checked
+✅ Performance analyzed
+✅ Security reviewed
+✅ Clear approval status provided
+✅ Actionable recommendations given
+✅ project-config.json updated