@glossarist/concept-browser 0.7.92 → 0.7.93

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@glossarist/concept-browser",
-  "version": "0.7.92",
+  "version": "0.7.93",
   "description": "Vue SPA for browsing Glossarist terminology datasets with cross-reference resolution, graph visualization, and multi-language support",
   "type": "module",
   "bin": {
@@ -37,7 +37,7 @@
     "astro": "^7.0.7",
     "d3": "^7.9.0",
     "favicons": "^7.2.0",
-    "glossarist": "^0.4.33",
+    "glossarist": "^0.4.34",
     "js-yaml": "^4.1.0",
     "jszip": "^3.10.1",
     "pinia": "^2.3.1",

package/src/__tests__/components/GenericRelationList.test.ts

@@ -58,8 +58,8 @@ function makeRelation(overrides: Partial<GenericRelationWire> = {}): GenericRela
     source: 'https://example.org/test/concept/5-1',
     comprehensive: 'https://example.org/test/concept/5-1',
     members: [
-      { uri: 'https://example.org/test/concept/5-4', presence: 'required', count: 'exactly_one', isDelimiting: false },
-      { uri: 'https://example.org/test/concept/5-5', presence: 'required', count: 'exactly_one', isDelimiting: false },
+      { uri: 'https://example.org/test/concept/5-4', presence: 'required', count: 'exactly_one', delimitingCharacteristic: { eng: "test characteristic" } },
+      { uri: 'https://example.org/test/concept/5-5', presence: 'required', count: 'exactly_one', delimitingCharacteristic: { eng: "test characteristic" } },
     ],
     completeness: 'complete',
     register: 'test',
@@ -120,8 +120,8 @@ describe('GenericRelationList — wire-type contract mount test', () => {
       props: {
         relations: [makeRelation({
           members: [
-            { uri: 'https://example.org/test/concept/5-4', presence: 'optional', count: 'multiple', isDelimiting: true },
-            { uri: 'https://example.org/test/concept/5-5', presence: 'required', count: 'exactly_one', isDelimiting: false },
+            { uri: 'https://example.org/test/concept/5-4', presence: 'optional', count: 'multiple', delimitingCharacteristic: { eng: "delimiting by light sensors" } },
+            { uri: 'https://example.org/test/concept/5-5', presence: 'required', count: 'exactly_one', delimitingCharacteristic: { eng: "test characteristic" } },
           ],
         })],
         manifest,

package/src/__tests__/components/GenericRelationList.test.ts.bak

@@ -0,0 +1,147 @@
+/**
+ * GenericRelationList mount test — pins the wire-type contract so
+ * the 5 type bugs found in audit (entry.titles, member.ref,
+ * is_delimiting casing, comprehensive.source, missing props)
+ * can't regress.
+ */
+import { describe, it, expect, vi } from 'vitest';
+import { mount } from '@vue/test-utils';
+import GenericRelationList from '../../components/GenericRelationList.vue';
+import type { GenericRelationWire } from '../../adapters/types';
+
+// Stub the composables the component depends on
+vi.mock('../../stores/vocabulary', () => ({
+  useVocabularyStore: () => ({
+    graph: { getNode: () => null },
+    datasets: new Map(),
+  }),
+}));
+
+vi.mock('../../adapters/factory', () => ({
+  getFactory: () => ({
+    resolve: (uri: string) => ({ type: 'unresolved' as const, uri }),
+  }),
+}));
+
+vi.mock('../../i18n', () => ({
+  useI18n: () => ({ t: (key: string) => key }),
+  locale: { value: 'eng' },
+}));
+
+vi.mock('vue-router', () => ({
+  useRouter: () => ({ push: vi.fn() }),
+}));
+
+const manifest = {
+  id: 'test',
+  datasetUri: 'https://example.org/test',
+  title: 'Test',
+  description: '',
+  owner: '',
+  baseUrl: '',
+  languages: ['eng'],
+  conceptCount: 0,
+  conceptUrlTemplate: '',
+  indexUrl: '',
+  contextUrl: '',
+  uriBase: 'https://example.org',
+  status: 'valid',
+  schemaVersion: '3',
+  tags: [],
+  lastUpdated: '',
+  sourceRepo: '',
+  chunkSize: 100,
+} as any;
+
+function makeRelation(overrides: Partial<GenericRelationWire> = {}): GenericRelationWire {
+  return {
+    source: 'https://example.org/test/concept/5-1',
+    comprehensive: 'https://example.org/test/concept/5-1',
+    members: [
+      { uri: 'https://example.org/test/concept/5-4', presence: 'required', count: 'exactly_one', isDelimiting: false },
+      { uri: 'https://example.org/test/concept/5-5', presence: 'required', count: 'exactly_one', isDelimiting: false },
+    ],
+    completeness: 'complete',
+    register: 'test',
+    ...overrides,
+  };
+}
+
+describe('GenericRelationList — wire-type contract mount test', () => {
+  it('mounts without errors for a well-formed relation', () => {
+    const w = mount(GenericRelationList, {
+      props: {
+        relations: [makeRelation()],
+        manifest,
+        registerId: 'test',
+      },
+    });
+    expect(w.html()).toContain('generic-relation-card');
+  });
+
+  it('renders completeness badge', () => {
+    const w = mount(GenericRelationList, {
+      props: {
+        relations: [makeRelation({ completeness: 'partial' })],
+        manifest,
+        registerId: 'test',
+      },
+    });
+    expect(w.html()).toContain('completeness-partial');
+  });
+
+  it('renders multiple relations', () => {
+    const w = mount(GenericRelationList, {
+      props: {
+        relations: [
+          makeRelation({ comprehensive: 'https://example.org/test/concept/5-1' }),
+          makeRelation({ comprehensive: 'https://example.org/test/concept/5-2' }),
+        ],
+        manifest,
+        registerId: 'test',
+      },
+    });
+    expect(w.findAll('.generic-relation-card')).toHaveLength(2);
+  });
+
+  it('renders criterion when present', () => {
+    const w = mount(GenericRelationList, {
+      props: {
+        relations: [makeRelation({ criterion: { eng: 'by realization medium' } })],
+        manifest,
+        registerId: 'test',
+      },
+    });
+    expect(w.html()).toContain('by realization medium');
+  });
+
+  it('renders member presence/count badges for non-default values', () => {
+    const w = mount(GenericRelationList, {
+      props: {
+        relations: [makeRelation({
+          members: [
+            { uri: 'https://example.org/test/concept/5-4', presence: 'optional', count: 'multiple', isDelimiting: true },
+            { uri: 'https://example.org/test/concept/5-5', presence: 'required', count: 'exactly_one', isDelimiting: false },
+          ],
+        })],
+        manifest,
+        registerId: 'test',
+      },
+    });
+    const html = w.html();
+    expect(html).toContain('Optional');
+    expect(html).toContain('Multiple');
+  });
+
+  it('renders empty section when relations array is empty', () => {
+    const w = mount(GenericRelationList, {
+      props: {
+        relations: [],
+        manifest,
+        registerId: 'test',
+      },
+    });
+    expect(w.find('section.generic-relations').exists()).toBe(true);
+    expect(w.findAll('.generic-relation-card')).toHaveLength(0);
+  });
+});

package/src/__tests__/composables/use-concept-edges-v2.test.ts

@@ -39,7 +39,7 @@ function makePartitive(
   if (fields.presence) data.presence = fields.presence;
   if (fields.count) data.count = fields.count;
   if (fields.isDelimiting) data.is_delimiting = fields.isDelimiting;
-  return PartitiveMemberModel.fromJSON(data as unknown as Record<string, unknown>) as PartitiveMember;
+  return new PartitiveMemberModel(data as any) as PartitiveMember;
 }
 
 function makeRelation(opts: {
@@ -48,7 +48,7 @@ function makeRelation(opts: {
   completeness?: 'complete' | 'partial';
   criterion?: Record<string, string>;
 }): PartitiveHyperedge {
-  return PartitiveHyperedgeModel.fromJSON(opts as unknown as Record<string, unknown>) as PartitiveHyperedge;
+  return new PartitiveHyperedgeModel(opts as any) as PartitiveHyperedge;
 }
 
 describe('useConceptEdges — MECE PartitiveRelation (glossarist 0.4.26)', () => {
@@ -84,14 +84,14 @@ describe('useConceptEdges — MECE PartitiveRelation (glossarist 0.4.26)', () =>
 
     it('is_delimiting defaults to false', () => {
       const m = makePartitive('test', '1.1');
-      expect(m.is_delimiting).toBe(false);
-      expect(m.is_delimiting).toBe(false);
+      expect((m as any).is_delimiting).toBe(false);
+      expect((m as any).is_delimiting).toBe(false);
     });
 
     it('is_delimiting is preserved when set to true', () => {
       const m = makePartitive('test', '1.1', { isDelimiting: true });
-      expect(m.is_delimiting).toBe(true);
-      expect(m.is_delimiting).toBe(true);
+      expect((m as any).is_delimiting).toBe(true);
+      expect((m as any).is_delimiting).toBe(true);
     });
 
     it('rejects the vacuous (presence=optional, count=at_least_one)', () => {

package/src/__tests__/composables/use-concept-edges-v2.test.ts.bak

@@ -84,14 +84,14 @@ describe('useConceptEdges — MECE PartitiveRelation (glossarist 0.4.26)', () =>
 
     it('is_delimiting defaults to false', () => {
       const m = makePartitive('test', '1.1');
-      expect(m.is_delimiting).toBe(false);
-      expect(m.is_delimiting).toBe(false);
+      expect((m as any).is_delimiting).toBe(false);
+      expect((m as any).is_delimiting).toBe(false);
     });
 
     it('is_delimiting is preserved when set to true', () => {
       const m = makePartitive('test', '1.1', { isDelimiting: true });
-      expect(m.is_delimiting).toBe(true);
-      expect(m.is_delimiting).toBe(true);
+      expect((m as any).is_delimiting).toBe(true);
+      expect((m as any).is_delimiting).toBe(true);
     });
 
     it('rejects the vacuous (presence=optional, count=at_least_one)', () => {
@@ -107,7 +107,7 @@ describe('useConceptEdges — MECE PartitiveRelation (glossarist 0.4.26)', () =>
         comprehensive: makeRef('test', '1.3'),
         partitives: [makePartitive('test', '1.4'), makePartitive('test', '1.5')],
       });
-      expect(r.members).toHaveLength(2);
+      expect((r as any).members).toHaveLength(2);
       expect((r as any).completeness).toBe('complete');
       expect((r as any).isComplete).toBe(true);
       expect((r as any).isPartial).toBe(false);

package/src/__tests__/wire-keys.test.ts

@@ -60,6 +60,6 @@ describe('GL wire-key SSOT', () => {
     // The point of this test: when adding a key, you remember to update
     // the count; when removing, you notice the test fails. Catches
     // accidental drift in either direction.
-    expect(Object.keys(GL).length).toBe(90);
+    expect(Object.keys(GL).length).toBe(91);
   });
 });

package/src/__tests__/wire-keys.test.ts.bak

@@ -0,0 +1,65 @@
+/**
+ * Wire-key SSOT contract.
+ *
+ * Audit-driven (AUDIT-2026-07-29 P1-3).
+ *
+ * The GL record is the single source of truth for the JSON-LD wire-format
+ * keys used across src/adapters/. This spec pins:
+ *
+ *   - Every entry is a string starting with 'gl:' (or '@' for JSON-LD core)
+ *   - No two entries share the same value (injectivity — one key, one name)
+ *   - The set of values matches what's declared in jsonld-types.ts
+ *     (catches drift if someone adds a key to one but not the other)
+ */
+import { describe, it, expect } from 'vitest';
+import { GL } from '../adapters/wire-keys';
+
+describe('GL wire-key SSOT', () => {
+  it('every value is a non-empty string', () => {
+    for (const value of Object.values(GL)) {
+      expect(typeof value).toBe('string');
+      expect(value.length).toBeGreaterThan(0);
+    }
+  });
+
+  it('every value starts with gl: or @ (JSON-LD namespace)', () => {
+    for (const value of Object.values(GL)) {
+      expect(value.startsWith('gl:') || value.startsWith('@')).toBe(true);
+    }
+  });
+
+  it('no two entries share the same value (injectivity)', () => {
+    const values = Object.values(GL);
+    expect(new Set(values).size).toBe(values.length);
+  });
+
+  it('MECE keys are present (presence, count, isDelimiting, multiplicity, certainty)', () => {
+    expect(GL.PRESENCE).toBe('gl:presence');
+    expect(GL.COUNT).toBe('gl:count');
+    expect(GL.IS_DELIMITING).toBe('gl:isDelimiting');
+    expect(GL.MULTIPLICITY).toBe('gl:multiplicity');
+    expect(GL.CERTAINTY).toBe('gl:certainty');
+  });
+
+  it('JSON-LD core keys are present', () => {
+    expect(GL.ID).toBe('@id');
+    expect(GL.TYPE).toBe('@type');
+  });
+
+  it('LOCAL_ID is distinct from ID (one is gl:id, the other @id)', () => {
+    // Both represent "id" but in different namespaces:
+    //   GL.ID (@id)        — JSON-LD IRI for the concept
+    //   GL.LOCAL_ID (gl:id) — source-local id within ConceptSource/Origin/Ref
+    expect(GL.ID).toBe('@id');
+    expect(GL.LOCAL_ID).toBe('gl:id');
+    expect(GL.ID).not.toBe(GL.LOCAL_ID);
+  });
+
+  it('count matches documented set (no drift)', () => {
+    // Update this number when adding a new key.
+    // The point of this test: when adding a key, you remember to update
+    // the count; when removing, you notice the test fails. Catches
+    // accidental drift in either direction.
+    expect(Object.keys(GL).length).toBe(90);
+  });
+});

package/src/adapters/model-bridge/hyperedge.ts

@@ -53,6 +53,15 @@ export function mapHyperedgeFromJsonLd(
         }
       }
       if (m[GL.IS_DELIMITING] === true) out.is_delimiting = true;
+      // ISO 704:2022 §5.5.4.2.1 — GenericMember carries a required
+      // delimitingCharacteristic (the intension difference between
+      // this specific concept and its coordinate concepts).
+      const dc = m[GL.DELIMITING_CHARACTERISTIC];
+      if (dc) {
+        out.delimitingCharacteristic = typeof dc === 'string'
+          ? { default: dc }
+          : dc;
+      }
       return out;
     })
     .filter((m): m is Record<string, unknown> => m !== null);

package/src/adapters/non-verbal/glossarist-augment.d.ts

@@ -182,22 +182,37 @@ declare module 'glossarist' {
       ref?: ConceptRef;
       presence?: PartitivePresence;
       count?: PartitiveCount;
-      is_delimiting?: boolean;
     });
     readonly ref: ConceptRef;
     readonly presence: PartitivePresence;
     readonly count: PartitiveCount;
-    readonly is_delimiting: boolean;
-    readonly isRequired: boolean;
-    readonly isOptional: boolean;
-    get isDelimiting(): boolean;
+    required(): boolean;
+    optional(): boolean;
     toJSON(): Record<string, unknown>;
     static fromJSON(data: Record<string, unknown>): HyperedgeMember;
     static identityOf(value: unknown): string;
   }
 
-  export class PartitiveMember extends HyperedgeMember {}
-  export class GenericMember extends HyperedgeMember {}
+  export class PartitiveMember extends HyperedgeMember {
+    constructor(data?: {
+      ref?: ConceptRef;
+      presence?: PartitivePresence;
+      count?: PartitiveCount;
+      is_delimiting?: boolean;
+    });
+    readonly is_delimiting: boolean;
+    get isDelimiting(): boolean;
+  }
+
+  export class GenericMember extends HyperedgeMember {
+    constructor(data?: {
+      ref?: ConceptRef;
+      presence?: PartitivePresence;
+      count?: PartitiveCount;
+      delimitingCharacteristic?: Record<string, string> | string;
+    });
+    readonly delimitingCharacteristic: Record<string, string>;
+  }
 
   export class AbstractHyperedge extends GlossaristModel {
     readonly comprehensive: ConceptRef;

package/src/adapters/types.ts

@@ -200,7 +200,10 @@ export interface GenericMemberWire {
   uri: string;
   presence: 'required' | 'optional';
   count: 'exactly_one' | 'at_least_one' | 'multiple';
-  isDelimiting: boolean;
+  /** ISO 704:2022 §5.5.4.2.1 — the delimiting characteristic that
+   * distinguishes this specific concept from its coordinate concepts.
+   * Required on every GenericMember. LocalizedString shape. */
+  delimitingCharacteristic: Record<string, string>;
 }
 
 export interface GraphNode {

package/src/adapters/wire-keys.ts

@@ -134,6 +134,7 @@ export const GL = {
   PRESENCE: 'gl:presence',
   COUNT: 'gl:count',
   IS_DELIMITING: 'gl:isDelimiting',
+  DELIMITING_CHARACTERISTIC: 'gl:delimitingCharacteristic',
   MULTIPLICITY: 'gl:multiplicity',
   CERTAINTY: 'gl:certainty',
 

package/src/components/GenericRelationList.vue

@@ -42,12 +42,17 @@ function designationFor(uri: string): string {
   return resolveDesignation(uri, store, factory, locale.value);
 }
 
+/** Resolve a LocalizedString delimitingCharacteristic to the current locale. */
+function characteristicText(dc: Record<string, string>): string {
+  return dc[locale.value] ?? dc.default ?? dc.eng ?? Object.values(dc)[0] ?? '';
+}
+
 function memberLabel(member: GenericRelationWire['members'][number]): PartitiveMemberLabeled {
   return {
     uri: member.uri,
     presence: member.presence,
     count: member.count,
-    isDelimiting: member.isDelimiting,
+    isDelimiting: false,
     label: designationFor(member.uri),
   };
 }
@@ -78,12 +83,15 @@ function memberLabel(member: GenericRelationWire['members'][number]): PartitiveM
         :completeness="rel.completeness"
       />
 
-      <ul class="member-presence-list" aria-label="Member presence and count">
+      <ul class="member-presence-list" aria-label="Member delimiting characteristics">
         <li v-for="(m, j) in rel.members" :key="j">
           <span class="member-label">{{ designationFor(m.uri) }}</span>
+          <span
+            v-if="m.delimitingCharacteristic"
+            class="member-delimiting-characteristic"
+          >{{ characteristicText(m.delimitingCharacteristic) }}</span>
           <span v-if="m.presence && m.presence !== 'required'" class="member-presence">{{ presenceLabel(m.presence) }}</span>
           <span v-if="m.count && m.count !== 'exactly_one'" class="member-count">{{ countLabel(m.count) }}</span>
-          <span v-if="m.isDelimiting" class="member-delimiting">{{ t('relations.delimiting') }}</span>
         </li>
       </ul>
     </div>

package/src/composables/use-concept-edges.ts

@@ -171,18 +171,24 @@ export function useConceptEdges(
     const source = conceptUriValue.value;
     const comprehensive = resolveConceptRefUri(rel.comprehensive);
     if (!comprehensive) return null;
-    const members: PartitiveMemberWire[] = (rel.members ?? rel.partitives ?? [])
-      .map((m: any): PartitiveMemberWire | null => {
+    const isGeneric = rel instanceof GenericHyperedge;
+    const members: any[] = (rel.members ?? rel.partitives ?? [])
+      .map((m: any): any | null => {
         const uri = resolveConceptRefUri(m.ref);
         if (!uri || uri === source) return null;
-        return {
+        const base: any = {
           uri,
           presence: readPresence(m),
           count: readCount(m),
-          isDelimiting: readIsDelimiting(m),
         };
+        if (isGeneric) {
+          base.delimitingCharacteristic = m.delimitingCharacteristic;
+        } else {
+          base.isDelimiting = readIsDelimiting(m);
+        }
+        return base;
       })
-      .filter((m: PartitiveMemberWire | null): m is PartitiveMemberWire => m !== null);
+      .filter((m: any | null): m is any => m !== null);
     if (members.length === 0) return null;
     return {
       source,

package/src/views/ConceptView.vue

@@ -89,7 +89,7 @@ const partitiveRelationsForSphere = computed<PartitiveRelationWire[]>(() => {
         if (uri === sourceUri) return null;
         const presence: PartitivePresence = member.presence;
         const count: PartitiveCount = member.count;
-        const isDelimiting = member.isDelimiting;
+        const isDelimiting = (member as any).is_delimiting === true;
         return { uri, presence, count, isDelimiting };
       })
       .filter((x): x is PartitiveMemberWire => x !== null);