@glossarist/concept-browser 0.7.105 → 0.7.107
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +59 -1
- package/cli/index.mjs +133 -36
- package/cli/index.ts +137 -37
- package/package.json +3 -1
- package/scripts/generate-data.mjs +6 -0
- package/scripts/smoke.mjs +269 -0
- package/src/__tests__/cli/favicon-config.test.ts +61 -0
- package/src/__tests__/composables/use-concept-edges-defensive.test.ts +164 -0
- package/src/__tests__/concept-detail-hydration.test.ts +199 -0
- package/src/components/ConceptDetail.vue +45 -38
- package/src/composables/use-concept-edges.ts +59 -43
- package/src/config/types.ts +17 -1
- package/src/layouts/Default.astro +41 -16
- package/src/pages/[...path].astro +6 -0
|
@@ -0,0 +1,269 @@
|
|
|
1
|
+
#!/usr/bin/env node
|
|
2
|
+
/**
|
|
3
|
+
* Post-build smoke test — deploy gate that catches runtime errors the
|
|
4
|
+
* type-checker and unit tests can't see.
|
|
5
|
+
*
|
|
6
|
+
* WHAT THIS CATCHES
|
|
7
|
+
* - Hydration TypeError (#171: `r.conceptGenericRelations.length`).
|
|
8
|
+
* - Dynamic-import resolution failures (the tsx devDep bug).
|
|
9
|
+
* - Failed resource requests the build itself caused (#174:
|
|
10
|
+
* bibliography.json / /learn / favicon 404s).
|
|
11
|
+
* - Config-not-honored regressions (#162/#166: branding.fonts).
|
|
12
|
+
*
|
|
13
|
+
* WHAT THIS DOES NOT DO
|
|
14
|
+
* - Functional UI testing (use Vitest + @vue/test-utils for that).
|
|
15
|
+
* - Cross-browser coverage (Chromium only — WebKit/Safari differences
|
|
16
|
+
* are caught by manual pre-release validation).
|
|
17
|
+
*
|
|
18
|
+
* USAGE
|
|
19
|
+
* npm run smoke # assumes dist/ already built
|
|
20
|
+
* npm run build:full # build:full pipeline now includes smoke
|
|
21
|
+
*
|
|
22
|
+
* The test serves dist/ on a random localhost port, loads each URL in a
|
|
23
|
+
* headless Chromium, and asserts zero `pageerror` events plus zero 404s
|
|
24
|
+
* on same-origin resources. Any failure exits non-zero so CI/deploy
|
|
25
|
+
* gates fail loudly.
|
|
26
|
+
*/
|
|
27
|
+
import { chromium } from 'playwright';
|
|
28
|
+
import { createServer } from 'http';
|
|
29
|
+
import { statSync, createReadStream } from 'fs';
|
|
30
|
+
import { extname, join, normalize, resolve as pathResolve } from 'path';
|
|
31
|
+
import { fileURLToPath } from 'url';
|
|
32
|
+
|
|
33
|
+
const __dirname = fileURLToPath(new URL('.', import.meta.url));
|
|
34
|
+
const DIST = pathResolve(__dirname, '..', 'dist');
|
|
35
|
+
|
|
36
|
+
const MIME = {
|
|
37
|
+
'.html': 'text/html; charset=utf-8',
|
|
38
|
+
'.js': 'application/javascript; charset=utf-8',
|
|
39
|
+
'.mjs': 'application/javascript; charset=utf-8',
|
|
40
|
+
'.css': 'text/css; charset=utf-8',
|
|
41
|
+
'.json': 'application/json; charset=utf-8',
|
|
42
|
+
'.svg': 'image/svg+xml',
|
|
43
|
+
'.png': 'image/png',
|
|
44
|
+
'.jpg': 'image/jpeg',
|
|
45
|
+
'.ico': 'image/x-icon',
|
|
46
|
+
'.webp': 'image/webp',
|
|
47
|
+
'.woff': 'font/woff',
|
|
48
|
+
'.woff2':'font/woff2',
|
|
49
|
+
'.ttf': 'font/ttf',
|
|
50
|
+
'.map': 'application/json; charset=utf-8',
|
|
51
|
+
'.xml': 'application/xml; charset=utf-8',
|
|
52
|
+
'.txt': 'text/plain; charset=utf-8',
|
|
53
|
+
'.webmanifest': 'application/manifest+json; charset=utf-8',
|
|
54
|
+
};
|
|
55
|
+
|
|
56
|
+
function serveDist(root) {
|
|
57
|
+
return new Promise((resolve) => {
|
|
58
|
+
const server = createServer((req, res) => {
|
|
59
|
+
try {
|
|
60
|
+
const urlPath = decodeURIComponent((req.url ?? '/').split('?')[0]);
|
|
61
|
+
let filePath = join(root, urlPath);
|
|
62
|
+
// SPA fallback: if no extension and the file doesn't exist as a
|
|
63
|
+
// directory, try .html, then fall back to 200.html / index.html.
|
|
64
|
+
if (!extname(filePath)) {
|
|
65
|
+
if (statSafe(filePath)?.isFile()) {
|
|
66
|
+
return sendFile(res, filePath);
|
|
67
|
+
}
|
|
68
|
+
const candidates = [
|
|
69
|
+
filePath + '.html',
|
|
70
|
+
join(filePath, 'index.html'),
|
|
71
|
+
join(root, '200.html'),
|
|
72
|
+
join(root, 'index.html'),
|
|
73
|
+
];
|
|
74
|
+
for (const c of candidates) {
|
|
75
|
+
if (statSafe(c)?.isFile()) {
|
|
76
|
+
return sendFile(res, c);
|
|
77
|
+
}
|
|
78
|
+
}
|
|
79
|
+
res.writeHead(404);
|
|
80
|
+
return res.end('Not found');
|
|
81
|
+
}
|
|
82
|
+
if (statSafe(filePath)?.isFile()) {
|
|
83
|
+
return sendFile(res, filePath);
|
|
84
|
+
}
|
|
85
|
+
res.writeHead(404);
|
|
86
|
+
return res.end('Not found');
|
|
87
|
+
} catch (e) {
|
|
88
|
+
res.writeHead(500);
|
|
89
|
+
res.end(String(e ?? 'server error'));
|
|
90
|
+
}
|
|
91
|
+
});
|
|
92
|
+
// Use port 0 to let the OS pick a free port; retrieve it after listen.
|
|
93
|
+
server.listen(0, '127.0.0.1', () => {
|
|
94
|
+
const { port } = server.address();
|
|
95
|
+
resolve({ server, origin: `http://127.0.0.1:${port}` });
|
|
96
|
+
});
|
|
97
|
+
});
|
|
98
|
+
}
|
|
99
|
+
|
|
100
|
+
function statSafe(p) {
|
|
101
|
+
try { return statSync(p); } catch { return null; }
|
|
102
|
+
}
|
|
103
|
+
|
|
104
|
+
function sendFile(res, filePath) {
|
|
105
|
+
const safe = normalize(filePath);
|
|
106
|
+
const ct = MIME[extname(safe)] ?? 'application/octet-stream';
|
|
107
|
+
res.writeHead(200, { 'Content-Type': ct });
|
|
108
|
+
createReadStream(safe).pipe(res);
|
|
109
|
+
}
|
|
110
|
+
|
|
111
|
+
/**
|
|
112
|
+
* Pages to probe. Use relative paths from the served origin. The smoke
|
|
113
|
+
* test runs AFTER the build, so anything present in dist/ is fair game.
|
|
114
|
+
* The home page always exists; the rest are best-effort (404 → skip).
|
|
115
|
+
*/
|
|
116
|
+
const PAGE_PATHS = [
|
|
117
|
+
'/',
|
|
118
|
+
'/learn/',
|
|
119
|
+
'/learn/relationships/',
|
|
120
|
+
'/learn/designations/',
|
|
121
|
+
'/learn/statuses/',
|
|
122
|
+
];
|
|
123
|
+
|
|
124
|
+
/**
|
|
125
|
+
* Consumer-provided files that concept-browser's build does NOT emit.
|
|
126
|
+
* The smoke test runs against concept-browser's own dist (no datasets
|
|
127
|
+
* configured), so these will 404. That's not a regression — it's a
|
|
128
|
+
* "consumer hasn't provided data" condition. Listed here so we can
|
|
129
|
+
* filter them out of the failure signal.
|
|
130
|
+
*/
|
|
131
|
+
const CONSUMER_DATA_FILES = [
|
|
132
|
+
'/datasets.json',
|
|
133
|
+
'/site-config.json',
|
|
134
|
+
'/data/cross-ref-index.json',
|
|
135
|
+
];
|
|
136
|
+
|
|
137
|
+
function isConsumerDataFile(url) {
|
|
138
|
+
try {
|
|
139
|
+
const u = new URL(url);
|
|
140
|
+
return CONSUMER_DATA_FILES.some(f => u.pathname === f || u.pathname.startsWith('/data/'));
|
|
141
|
+
} catch {
|
|
142
|
+
return false;
|
|
143
|
+
}
|
|
144
|
+
}
|
|
145
|
+
|
|
146
|
+
async function probePage(browser, origin, path) {
|
|
147
|
+
const url = new URL(path, origin).toString();
|
|
148
|
+
const page = await browser.newPage();
|
|
149
|
+
const errors = [];
|
|
150
|
+
const failedRequests = [];
|
|
151
|
+
|
|
152
|
+
page.on('pageerror', (e) => {
|
|
153
|
+
errors.push({ kind: 'pageerror', message: e.message, stack: e.stack ?? '' });
|
|
154
|
+
});
|
|
155
|
+
page.on('console', (msg) => {
|
|
156
|
+
if (msg.type() !== 'error') return;
|
|
157
|
+
const text = msg.text();
|
|
158
|
+
// Browser consoles emit a generic "Failed to load resource: ... 404"
|
|
159
|
+
// message for every network 404 — the URL is NOT in the text, so we
|
|
160
|
+
// can't filter by file here. We track real 404s via the response
|
|
161
|
+
// event below and discard the generic console message to avoid
|
|
162
|
+
// double-counting noise.
|
|
163
|
+
if (/Failed to load resource/i.test(text)) return;
|
|
164
|
+
// Cross-origin font CDN warnings are out of our control.
|
|
165
|
+
if (/fonts\.g(oogle|static)\.com/.test(text)) return;
|
|
166
|
+
errors.push({ kind: 'console.error', message: text });
|
|
167
|
+
});
|
|
168
|
+
page.on('requestfailed', (req) => {
|
|
169
|
+
const u = req.url();
|
|
170
|
+
if (u.startsWith(origin) && !isConsumerDataFile(u)) {
|
|
171
|
+
failedRequests.push({ url: u, failure: req.failure()?.errorText ?? 'failed' });
|
|
172
|
+
}
|
|
173
|
+
});
|
|
174
|
+
page.on('response', (resp) => {
|
|
175
|
+
const u = resp.url();
|
|
176
|
+
if (u.startsWith(origin) && resp.status() >= 400 && !isConsumerDataFile(u)) {
|
|
177
|
+
failedRequests.push({ url: u, status: resp.status() });
|
|
178
|
+
}
|
|
179
|
+
});
|
|
180
|
+
|
|
181
|
+
try {
|
|
182
|
+
const resp = await page.goto(url, { waitUntil: 'networkidle', timeout: 15_000 });
|
|
183
|
+
if (resp && resp.status() >= 400) {
|
|
184
|
+
// 404 on a non-home page = the build didn't emit it. Treat as
|
|
185
|
+
// skip, not fail (the home page is the load-bearing probe).
|
|
186
|
+
return { path, url, status: resp.status(), bodyLen: 0, errors, failedRequests, skipped: path !== '/' };
|
|
187
|
+
}
|
|
188
|
+
// Wait a beat for any deferred hydration effect to fire.
|
|
189
|
+
await page.waitForTimeout(500);
|
|
190
|
+
const bodyLen = await page.evaluate(() => document.body?.innerText?.length ?? 0);
|
|
191
|
+
return { path, url, status: resp?.status() ?? 0, bodyLen, errors, failedRequests, skipped: false };
|
|
192
|
+
} catch (e) {
|
|
193
|
+
errors.push({ kind: 'navigation', message: String(e) });
|
|
194
|
+
return { path, url, status: 0, bodyLen: 0, errors, failedRequests, skipped: false };
|
|
195
|
+
} finally {
|
|
196
|
+
await page.close();
|
|
197
|
+
}
|
|
198
|
+
}
|
|
199
|
+
|
|
200
|
+
function formatFindings(results) {
|
|
201
|
+
const lines = [];
|
|
202
|
+
for (const r of results) {
|
|
203
|
+
if (r.skipped) {
|
|
204
|
+
lines.push(`\n ${r.path} (HTTP ${r.status} — skipped, not in this build)`);
|
|
205
|
+
continue;
|
|
206
|
+
}
|
|
207
|
+
if (r.errors.length === 0 && r.failedRequests.length === 0 && r.bodyLen > 0) continue;
|
|
208
|
+
lines.push(`\n ${r.path} (HTTP ${r.status}, body ${r.bodyLen} chars)`);
|
|
209
|
+
for (const e of r.errors) {
|
|
210
|
+
lines.push(` [${e.kind}] ${e.message}`);
|
|
211
|
+
}
|
|
212
|
+
for (const f of r.failedRequests) {
|
|
213
|
+
lines.push(` [request] ${f.status ?? f.failure} ${f.url}`);
|
|
214
|
+
}
|
|
215
|
+
}
|
|
216
|
+
return lines.join('\n');
|
|
217
|
+
}
|
|
218
|
+
|
|
219
|
+
async function ensureDist() {
|
|
220
|
+
if (!statSafe(DIST)?.isDirectory()) {
|
|
221
|
+
console.error(`smoke: dist/ not found at ${DIST}`);
|
|
222
|
+
console.error(` run \`npm run build\` first, or use \`npm run build:full\`.`);
|
|
223
|
+
process.exit(2);
|
|
224
|
+
}
|
|
225
|
+
if (!statSafe(join(DIST, 'index.html'))?.isFile()) {
|
|
226
|
+
console.error(`smoke: dist/index.html missing — build did not complete.`);
|
|
227
|
+
process.exit(2);
|
|
228
|
+
}
|
|
229
|
+
}
|
|
230
|
+
|
|
231
|
+
async function main() {
|
|
232
|
+
await ensureDist();
|
|
233
|
+
const { server, origin } = await serveDist(DIST);
|
|
234
|
+
|
|
235
|
+
let exitCode = 0;
|
|
236
|
+
const browser = await chromium.launch({ headless: true });
|
|
237
|
+
try {
|
|
238
|
+
const results = [];
|
|
239
|
+
for (const path of PAGE_PATHS) {
|
|
240
|
+
// Skip paths the build didn't emit (e.g. /learn/* if page-types
|
|
241
|
+
// config doesn't synthesize them). 404 on the navigation itself
|
|
242
|
+
// is recorded; the probe still runs to catch prefetch 404s.
|
|
243
|
+
const r = await probePage(browser, origin, path);
|
|
244
|
+
results.push(r);
|
|
245
|
+
}
|
|
246
|
+
|
|
247
|
+
const anyFail = results.some(r =>
|
|
248
|
+
!r.skipped && (r.errors.length > 0 || r.failedRequests.length > 0 || r.bodyLen === 0)
|
|
249
|
+
);
|
|
250
|
+
const findings = formatFindings(results);
|
|
251
|
+
|
|
252
|
+
if (anyFail) {
|
|
253
|
+
exitCode = 1;
|
|
254
|
+
console.error(`\n FAIL smoke test found problems:${findings}\n`);
|
|
255
|
+
} else {
|
|
256
|
+
const skipped = results.filter(r => r.skipped).length;
|
|
257
|
+
console.log(`\n OK smoke test passed (${results.length - skipped} pages, ${skipped} skipped, 0 errors).`);
|
|
258
|
+
}
|
|
259
|
+
} finally {
|
|
260
|
+
await browser.close();
|
|
261
|
+
server.close();
|
|
262
|
+
}
|
|
263
|
+
process.exit(exitCode);
|
|
264
|
+
}
|
|
265
|
+
|
|
266
|
+
main().catch((e) => {
|
|
267
|
+
console.error('smoke: fatal error', e);
|
|
268
|
+
process.exit(1);
|
|
269
|
+
});
|
|
@@ -0,0 +1,61 @@
|
|
|
1
|
+
import { describe, it, expect } from 'vitest';
|
|
2
|
+
import { resolve } from 'path';
|
|
3
|
+
|
|
4
|
+
/**
|
|
5
|
+
* Regression test for issue #177 — `branding.favicon` object form crashes
|
|
6
|
+
* the CLI with ERR_INVALID_ARG_TYPE.
|
|
7
|
+
*
|
|
8
|
+
* The 0.7.106 fix for #173 shipped `branding.favicon` as an object
|
|
9
|
+
* (`{ source_dir, links_html, skip_default_links, base_path }`) in the
|
|
10
|
+
* TypeScript types and in `src/layouts/Default.astro`, but `cli/index.mjs`
|
|
11
|
+
* still called `resolve(process.cwd(), branding.favicon)` — which throws
|
|
12
|
+
* `ERR_INVALID_ARG_TYPE` when `branding.favicon` is an object.
|
|
13
|
+
*
|
|
14
|
+
* Importing `cli/index.mjs` directly runs the full build pipeline, which
|
|
15
|
+
* is too heavy for a unit test. Instead, this spec pins the type-narrowing
|
|
16
|
+
* contract that the CLI's favicon resolution MUST honor: a string is a
|
|
17
|
+
* path, an object is a config, and the two must never be conflated. The
|
|
18
|
+
* integration smoke test (scripts/smoke.mjs) covers the end-to-end path.
|
|
19
|
+
*/
|
|
20
|
+
|
|
21
|
+
describe('CLI favicon config (issue #177)', () => {
|
|
22
|
+
it('resolve() throws ERR_INVALID_ARG_TYPE when branding.favicon is an object — proves the bug class', async () => {
|
|
23
|
+
// This is the bug: the legacy code did `resolve(cwd, branding.favicon)`
|
|
24
|
+
// unconditionally. When branding.favicon is an object, Node throws.
|
|
25
|
+
const faviconCfg = { skip_default_links: true, links_html: '<link>' };
|
|
26
|
+
expect(() => resolve(process.cwd(), faviconCfg as any)).toThrow(/paths\[1\].*string|ERR_INVALID_ARG_TYPE/);
|
|
27
|
+
});
|
|
28
|
+
|
|
29
|
+
it('typeof-string guard prevents the crash', () => {
|
|
30
|
+
const faviconCfg = { skip_default_links: true, links_html: '<link>' };
|
|
31
|
+
const safeResolve = () =>
|
|
32
|
+
typeof faviconCfg === 'string' && faviconCfg
|
|
33
|
+
? resolve(process.cwd(), faviconCfg)
|
|
34
|
+
: null;
|
|
35
|
+
expect(safeResolve).not.toThrow();
|
|
36
|
+
expect(safeResolve()).toBe(null);
|
|
37
|
+
});
|
|
38
|
+
|
|
39
|
+
it('accepts string form (legacy) — single source path', () => {
|
|
40
|
+
const faviconCfg = 'assets/my-brand.svg';
|
|
41
|
+
const resolved =
|
|
42
|
+
typeof faviconCfg === 'string' && faviconCfg
|
|
43
|
+
? resolve(process.cwd(), faviconCfg)
|
|
44
|
+
: null;
|
|
45
|
+
expect(resolved).toBe(resolve(process.cwd(), 'assets/my-brand.svg'));
|
|
46
|
+
});
|
|
47
|
+
|
|
48
|
+
it('accepts object form — no path resolution attempted on the object itself', () => {
|
|
49
|
+
const faviconCfg = {
|
|
50
|
+
source_dir: 'assets/favicons',
|
|
51
|
+
links_html: '<link rel="icon" href="/favicon.svg" />',
|
|
52
|
+
skip_default_links: true,
|
|
53
|
+
base_path: '/',
|
|
54
|
+
};
|
|
55
|
+
expect(typeof faviconCfg).toBe('object');
|
|
56
|
+
// The object form must be inspected for fields, not passed to resolve().
|
|
57
|
+
expect((faviconCfg as any).source_dir).toBe('assets/favicons');
|
|
58
|
+
expect((faviconCfg as any).links_html).toContain('<link');
|
|
59
|
+
expect((faviconCfg as any).skip_default_links).toBe(true);
|
|
60
|
+
});
|
|
61
|
+
});
|
|
@@ -0,0 +1,164 @@
|
|
|
1
|
+
import { describe, it, expect, beforeEach, vi } from 'vitest';
|
|
2
|
+
import { computed, ref } from 'vue';
|
|
3
|
+
import type { Router } from 'vue-router';
|
|
4
|
+
import { useConceptEdges } from '../../composables/use-concept-edges';
|
|
5
|
+
import { useVocabularyStore } from '../../stores/vocabulary';
|
|
6
|
+
import type { Manifest, GraphEdge } from '../../adapters/types';
|
|
7
|
+
import { makeManifest, setupPinia } from '../test-helpers';
|
|
8
|
+
import { getFactory, resetFactory } from '../../adapters/factory';
|
|
9
|
+
|
|
10
|
+
/**
|
|
11
|
+
* Regression test for issue #171 — `TypeError: r.conceptGenericRelations.length
|
|
12
|
+
* at hydration`.
|
|
13
|
+
*
|
|
14
|
+
* Bug (2026-08-01): on the live `glossarist/cie-eilv` deployment, every concept
|
|
15
|
+
* page threw `TypeError: undefined is not an object (evaluating
|
|
16
|
+
* 'r.conceptGenericRelations.length')` at hydration time. The concept detail
|
|
17
|
+
* view failed to render. No unit test caught this because every existing test
|
|
18
|
+
* passes a well-formed Concept instance.
|
|
19
|
+
*
|
|
20
|
+
* Root cause: any code path that made the `conceptGenericRelations` computed
|
|
21
|
+
* throw (or made the destructured value undefined at hydration) crashed the
|
|
22
|
+
* template's `v-if="conceptGenericRelations.length"` access. The fix has two
|
|
23
|
+
* arms:
|
|
24
|
+
*
|
|
25
|
+
* 1. The composable wraps its computed getters in try/catch so a malformed
|
|
26
|
+
* concept never propagates an exception into the render path.
|
|
27
|
+
* 2. The template uses `v-if="conceptGenericRelations?.length"` so an
|
|
28
|
+
* undefined destructured value is treated as "no relations" instead of
|
|
29
|
+
* throwing.
|
|
30
|
+
*
|
|
31
|
+
* This spec exercises the composable's defensive layer directly: malformed
|
|
32
|
+
* concepts, partially-formed relations, and the null/undefined concept value
|
|
33
|
+
* must all produce `[]` — never throw, never return `undefined`.
|
|
34
|
+
*/
|
|
35
|
+
describe('useConceptEdges — defensive projection (regression for #171)', () => {
|
|
36
|
+
const URN_SOURCE = 'urn:glossarist:fixtures';
|
|
37
|
+
const manifest: Manifest = makeManifest({
|
|
38
|
+
id: 'fixtures',
|
|
39
|
+
datasetUri: URN_SOURCE,
|
|
40
|
+
uriBase: 'https://glossarist.org',
|
|
41
|
+
});
|
|
42
|
+
const noEdges: GraphEdge[] = [];
|
|
43
|
+
const noopRouter = { push() {} } as unknown as Router;
|
|
44
|
+
|
|
45
|
+
let store: ReturnType<typeof useVocabularyStore>;
|
|
46
|
+
|
|
47
|
+
beforeEach(() => {
|
|
48
|
+
setupPinia();
|
|
49
|
+
resetFactory();
|
|
50
|
+
store = useVocabularyStore();
|
|
51
|
+
store.manifests.set(manifest.id, manifest);
|
|
52
|
+
|
|
53
|
+
const factory = getFactory();
|
|
54
|
+
factory.resolveRelatedRef = vi.fn((ref: { source: string | null; id: string | null } | null) =>
|
|
55
|
+
ref?.source === URN_SOURCE && ref.id
|
|
56
|
+
? { registerId: manifest.id, conceptId: ref.id }
|
|
57
|
+
: null,
|
|
58
|
+
);
|
|
59
|
+
});
|
|
60
|
+
|
|
61
|
+
/**
|
|
62
|
+
* The core regression: any malformed concept input must NOT propagate an
|
|
63
|
+
* exception through the composable. The computed must always resolve to an
|
|
64
|
+
* array (possibly empty). This is what the template's `?.length` defensive
|
|
65
|
+
* access relies on — and what the prior crash violated.
|
|
66
|
+
*/
|
|
67
|
+
it('never throws when concept.relations is malformed (issue #171)', () => {
|
|
68
|
+
const malformedConcepts = [
|
|
69
|
+
/* relations is undefined */
|
|
70
|
+
{ id: 'a', localization: () => null, languages: [], relatedConcepts: [] },
|
|
71
|
+
/* relations is null */
|
|
72
|
+
{ id: 'b', relations: null, localization: () => null, languages: [], relatedConcepts: [] },
|
|
73
|
+
/* relations contains a non-hyperedge object */
|
|
74
|
+
{ id: 'c', relations: [{ not: 'a relation' }], localization: () => null, languages: [], relatedConcepts: [] },
|
|
75
|
+
/* relations contains a hyperedge whose comprehensive is missing */
|
|
76
|
+
{ id: 'd', relations: [{ members: [] }], localization: () => null, languages: [], relatedConcepts: [] },
|
|
77
|
+
/* relations contains a hyperedge with null members */
|
|
78
|
+
{ id: 'e', relations: [{ comprehensive: { source: URN_SOURCE, id: '1.1' }, members: null }], localization: () => null, languages: [], relatedConcepts: [] },
|
|
79
|
+
/* the concept itself is an empty object */
|
|
80
|
+
{} as any,
|
|
81
|
+
];
|
|
82
|
+
|
|
83
|
+
for (const concept of malformedConcepts) {
|
|
84
|
+
const { conceptPartitiveRelations, conceptGenericRelations, conceptRelated } = useConceptEdges(
|
|
85
|
+
computed(() => concept),
|
|
86
|
+
computed(() => 'fixtures'),
|
|
87
|
+
computed(() => manifest),
|
|
88
|
+
computed(() => noEdges),
|
|
89
|
+
noopRouter,
|
|
90
|
+
);
|
|
91
|
+
/* Each computed must resolve without throwing. */
|
|
92
|
+
expect(() => conceptPartitiveRelations.value).not.toThrow();
|
|
93
|
+
expect(() => conceptGenericRelations.value).not.toThrow();
|
|
94
|
+
expect(() => conceptRelated.value).not.toThrow();
|
|
95
|
+
/* And must produce an array (never undefined). */
|
|
96
|
+
expect(Array.isArray(conceptPartitiveRelations.value)).toBe(true);
|
|
97
|
+
expect(Array.isArray(conceptGenericRelations.value)).toBe(true);
|
|
98
|
+
expect(Array.isArray(conceptRelated.value)).toBe(true);
|
|
99
|
+
}
|
|
100
|
+
});
|
|
101
|
+
|
|
102
|
+
it('returns a complete return shape — every key always present', () => {
|
|
103
|
+
/* The original issue text hypothesized an early-return path that omitted
|
|
104
|
+
`conceptGenericRelations`. Pin the contract: every documented key is
|
|
105
|
+
present in the return object, regardless of input. */
|
|
106
|
+
const result = useConceptEdges(
|
|
107
|
+
ref(null) as any,
|
|
108
|
+
computed(() => 'fixtures'),
|
|
109
|
+
computed(() => manifest),
|
|
110
|
+
computed(() => noEdges),
|
|
111
|
+
noopRouter,
|
|
112
|
+
);
|
|
113
|
+
const requiredKeys = [
|
|
114
|
+
'conceptUriValue',
|
|
115
|
+
'outgoingEdges',
|
|
116
|
+
'incomingEdges',
|
|
117
|
+
'edgeDisplayCache',
|
|
118
|
+
'getEdgeDisplay',
|
|
119
|
+
'designationFor',
|
|
120
|
+
'edgeBadgeColor',
|
|
121
|
+
'inverseEdgeType',
|
|
122
|
+
'conceptRelated',
|
|
123
|
+
'conceptPartitiveRelations',
|
|
124
|
+
'conceptGenericRelations',
|
|
125
|
+
'resolveRelatedRef',
|
|
126
|
+
'getResolvedRef',
|
|
127
|
+
'relatedLabel',
|
|
128
|
+
'navigateEdge',
|
|
129
|
+
'navigateRelated',
|
|
130
|
+
] as const;
|
|
131
|
+
for (const key of requiredKeys) {
|
|
132
|
+
expect(result, `missing key: ${key}`).toHaveProperty(key);
|
|
133
|
+
expect(result[key as keyof typeof result], `undefined value for key: ${key}`).toBeDefined();
|
|
134
|
+
}
|
|
135
|
+
});
|
|
136
|
+
|
|
137
|
+
it('returns [] (not undefined) when concept.relations entries throw on instanceof check', () => {
|
|
138
|
+
/* Simulate the failure mode where a bundled class import ends up undefined
|
|
139
|
+
at hydration — `r instanceof undefined` throws. The composable's try/catch
|
|
140
|
+
must swallow it and yield []. */
|
|
141
|
+
const Bomb = function () {} as any;
|
|
142
|
+
Object.defineProperty(Bomb.prototype, Symbol.hasInstance, {
|
|
143
|
+
value: () => { throw new Error('simulated instanceof failure'); },
|
|
144
|
+
});
|
|
145
|
+
const concept = {
|
|
146
|
+
id: 'bomb',
|
|
147
|
+
relations: [new Bomb()],
|
|
148
|
+
localization: () => null,
|
|
149
|
+
languages: [],
|
|
150
|
+
relatedConcepts: [],
|
|
151
|
+
};
|
|
152
|
+
const { conceptGenericRelations, conceptPartitiveRelations } = useConceptEdges(
|
|
153
|
+
computed(() => concept),
|
|
154
|
+
computed(() => 'fixtures'),
|
|
155
|
+
computed(() => manifest),
|
|
156
|
+
computed(() => noEdges),
|
|
157
|
+
noopRouter,
|
|
158
|
+
);
|
|
159
|
+
expect(() => conceptGenericRelations.value).not.toThrow();
|
|
160
|
+
expect(() => conceptPartitiveRelations.value).not.toThrow();
|
|
161
|
+
expect(conceptGenericRelations.value).toEqual([]);
|
|
162
|
+
expect(conceptPartitiveRelations.value).toEqual([]);
|
|
163
|
+
});
|
|
164
|
+
});
|
|
@@ -0,0 +1,199 @@
|
|
|
1
|
+
import { describe, it, expect, beforeEach, vi } from 'vitest';
|
|
2
|
+
import { mount, flushPromises } from '@vue/test-utils';
|
|
3
|
+
import { createPinia, setActivePinia } from 'pinia';
|
|
4
|
+
import { createRouter, createMemoryHistory } from 'vue-router';
|
|
5
|
+
import ConceptDetail from '../components/ConceptDetail.vue';
|
|
6
|
+
import { useVocabularyStore } from '../stores/vocabulary';
|
|
7
|
+
import type { Manifest } from '../adapters/types';
|
|
8
|
+
import { conceptFromJson } from '../adapters/model-bridge';
|
|
9
|
+
|
|
10
|
+
/**
|
|
11
|
+
* Regression test for issue #171 — `TypeError: r.conceptGenericRelations.length
|
|
12
|
+
* at hydration`. Concept pages on the live cie-eilv deployment crashed at
|
|
13
|
+
* hydration because the template accessed `.length` on a composable value
|
|
14
|
+
* that evaluated to undefined under specific data conditions.
|
|
15
|
+
*
|
|
16
|
+
* Strategy: mount ConceptDetail with a wide range of concept shapes —
|
|
17
|
+
* well-formed, minimal, missing optional fields, and actively malformed —
|
|
18
|
+
* and assert the mount never throws + the rendered output contains the
|
|
19
|
+
* primary term. If any access path raises during render, this test fails
|
|
20
|
+
* LOUDLY before the build ships.
|
|
21
|
+
*/
|
|
22
|
+
|
|
23
|
+
// Prevent the 2.7MB Opal runtime from loading in tests
|
|
24
|
+
vi.mock('../utils/plurimath', () => ({
|
|
25
|
+
loadPlurimath: () => new Promise(() => {}),
|
|
26
|
+
mathToHtml: () => '<code class="math-fallback">x</code>',
|
|
27
|
+
renderToMathML: () => null,
|
|
28
|
+
}));
|
|
29
|
+
|
|
30
|
+
import { vMath } from '../directives/v-math';
|
|
31
|
+
|
|
32
|
+
function makeManifest(): Manifest {
|
|
33
|
+
return {
|
|
34
|
+
id: 'test',
|
|
35
|
+
datasetUri: 'https://glossarist.org/test/concept',
|
|
36
|
+
title: 'Test Dataset',
|
|
37
|
+
description: 'A test dataset',
|
|
38
|
+
owner: 'ISO',
|
|
39
|
+
baseUrl: '/data/test',
|
|
40
|
+
languages: ['eng'],
|
|
41
|
+
conceptCount: 1,
|
|
42
|
+
conceptUrlTemplate: '/data/test/concepts/{id}.json',
|
|
43
|
+
indexUrl: '/data/test/index.json',
|
|
44
|
+
contextUrl: '/data/test/context.json',
|
|
45
|
+
uriBase: 'https://glossarist.org',
|
|
46
|
+
status: 'published',
|
|
47
|
+
schemaVersion: '1.0',
|
|
48
|
+
tags: [],
|
|
49
|
+
lastUpdated: '2025-01-01',
|
|
50
|
+
sourceRepo: 'https://example.com/repo',
|
|
51
|
+
chunkSize: 1000,
|
|
52
|
+
color: '#3366ff',
|
|
53
|
+
};
|
|
54
|
+
}
|
|
55
|
+
|
|
56
|
+
function makeMinimalJson(overrides: Record<string, any> = {}): Record<string, any> {
|
|
57
|
+
return {
|
|
58
|
+
'@context': 'https://glossarist.org/context',
|
|
59
|
+
'@id': 'https://glossarist.org/test/concept/1',
|
|
60
|
+
'@type': 'gl:Concept',
|
|
61
|
+
'gl:identifier': '1',
|
|
62
|
+
'gl:localizedConcept': {
|
|
63
|
+
eng: {
|
|
64
|
+
'@id': 'https://glossarist.org/test/concept/1/eng',
|
|
65
|
+
'@type': 'gl:LocalizedConcept',
|
|
66
|
+
'gl:languageCode': 'eng',
|
|
67
|
+
'gl:entryStatus': 'valid',
|
|
68
|
+
'gl:designation': [
|
|
69
|
+
{ '@type': 'gl:Expression', 'gl:normativeStatus': 'preferred', 'gl:term': 'test term' },
|
|
70
|
+
],
|
|
71
|
+
'gl:definition': [
|
|
72
|
+
{ '@type': 'gl:DetailedDefinition', 'gl:content': 'a definition' },
|
|
73
|
+
],
|
|
74
|
+
},
|
|
75
|
+
},
|
|
76
|
+
...overrides,
|
|
77
|
+
};
|
|
78
|
+
}
|
|
79
|
+
|
|
80
|
+
async function makeRouter() {
|
|
81
|
+
const router = createRouter({
|
|
82
|
+
history: createMemoryHistory(),
|
|
83
|
+
routes: [
|
|
84
|
+
{ path: '/', name: 'home', component: { template: '<div/>' } },
|
|
85
|
+
{ path: '/dataset/:registerId', name: 'dataset', component: { template: '<div/>' } },
|
|
86
|
+
{ path: '/dataset/:registerId/concept/:conceptId', name: 'concept', component: { template: '<div/>' } },
|
|
87
|
+
],
|
|
88
|
+
});
|
|
89
|
+
router.push('/');
|
|
90
|
+
await router.isReady();
|
|
91
|
+
return router;
|
|
92
|
+
}
|
|
93
|
+
|
|
94
|
+
describe('ConceptDetail hydration regression (issue #171)', () => {
|
|
95
|
+
let pinia: ReturnType<typeof createPinia>;
|
|
96
|
+
let router: Awaited<ReturnType<typeof makeRouter>>;
|
|
97
|
+
let store: ReturnType<typeof useVocabularyStore>;
|
|
98
|
+
|
|
99
|
+
beforeEach(async () => {
|
|
100
|
+
pinia = createPinia();
|
|
101
|
+
setActivePinia(pinia);
|
|
102
|
+
router = await makeRouter();
|
|
103
|
+
store = useVocabularyStore();
|
|
104
|
+
store.manifests.set('test', makeManifest());
|
|
105
|
+
store.datasets.set('test', {
|
|
106
|
+
index: [],
|
|
107
|
+
getConceptCount: () => 0,
|
|
108
|
+
getConcepts: () => [],
|
|
109
|
+
getConceptPosition: () => -1,
|
|
110
|
+
getIndexEntry: () => undefined,
|
|
111
|
+
} as any);
|
|
112
|
+
});
|
|
113
|
+
|
|
114
|
+
function mountDetail(json: Record<string, any>) {
|
|
115
|
+
const concept = conceptFromJson(json);
|
|
116
|
+
return mount(ConceptDetail, {
|
|
117
|
+
global: {
|
|
118
|
+
plugins: [pinia, router],
|
|
119
|
+
directives: { math: vMath },
|
|
120
|
+
},
|
|
121
|
+
props: {
|
|
122
|
+
concept,
|
|
123
|
+
manifest: makeManifest(),
|
|
124
|
+
edges: [],
|
|
125
|
+
registerId: 'test',
|
|
126
|
+
adjacent: { prev: null, next: null },
|
|
127
|
+
},
|
|
128
|
+
});
|
|
129
|
+
}
|
|
130
|
+
|
|
131
|
+
it('mounts cleanly with a minimal concept (no relations)', async () => {
|
|
132
|
+
const wrapper = mountDetail(makeMinimalJson());
|
|
133
|
+
await flushPromises();
|
|
134
|
+
expect(wrapper.find('h1').html()).toContain('test term');
|
|
135
|
+
});
|
|
136
|
+
|
|
137
|
+
it('mounts cleanly with a partitive hyperedge', async () => {
|
|
138
|
+
const json = makeMinimalJson({
|
|
139
|
+
'gl:partitiveRelations': [
|
|
140
|
+
{
|
|
141
|
+
'@type': 'gl:PartitiveRelation',
|
|
142
|
+
'gl:comprehensive': { '@id': 'https://glossarist.org/test/concept/1' },
|
|
143
|
+
'gl:hasPart': [
|
|
144
|
+
{ '@id': 'https://glossarist.org/test/concept/2', 'gl:presence': 'required', 'gl:count': 'exactly_one' },
|
|
145
|
+
],
|
|
146
|
+
},
|
|
147
|
+
],
|
|
148
|
+
});
|
|
149
|
+
const wrapper = mountDetail(json);
|
|
150
|
+
await flushPromises();
|
|
151
|
+
expect(wrapper.find('h1').html()).toContain('test term');
|
|
152
|
+
});
|
|
153
|
+
|
|
154
|
+
it('mounts cleanly with a generic hyperedge', async () => {
|
|
155
|
+
const json = makeMinimalJson({
|
|
156
|
+
'gl:genericRelations': [
|
|
157
|
+
{
|
|
158
|
+
'@type': 'gl:GenericRelation',
|
|
159
|
+
'gl:comprehensive': { '@id': 'https://glossarist.org/test/concept/1' },
|
|
160
|
+
'gl:hasMember': [
|
|
161
|
+
{ '@id': 'https://glossarist.org/test/concept/2', 'gl:delimitingCharacteristic': { eng: 'characteristic A' } },
|
|
162
|
+
],
|
|
163
|
+
},
|
|
164
|
+
],
|
|
165
|
+
});
|
|
166
|
+
const wrapper = mountDetail(json);
|
|
167
|
+
await flushPromises();
|
|
168
|
+
expect(wrapper.find('h1').html()).toContain('test term');
|
|
169
|
+
});
|
|
170
|
+
|
|
171
|
+
it('mounts cleanly with empty relations array — no Partitive/Generic sections rendered', async () => {
|
|
172
|
+
/* This is the closest reproduction of the #171 condition: the live
|
|
173
|
+
deployment had concept data that didn't trigger any error in unit
|
|
174
|
+
tests but failed at hydration. Pin: an empty relations array MUST
|
|
175
|
+
produce a rendered page, not a thrown TypeError. */
|
|
176
|
+
const json = makeMinimalJson({ 'gl:relations': [] });
|
|
177
|
+
const wrapper = mountDetail(json);
|
|
178
|
+
await flushPromises();
|
|
179
|
+
expect(wrapper.find('h1').html()).toContain('test term');
|
|
180
|
+
/* The PartitiveRelationList + GenericRelationList blocks must NOT
|
|
181
|
+
render when their data is empty — the v-if check should evaluate
|
|
182
|
+
to 0 (falsy), not crash. */
|
|
183
|
+
expect(wrapper.findComponent({ name: 'PartitiveRelationList' }).exists()).toBe(false);
|
|
184
|
+
expect(wrapper.findComponent({ name: 'GenericRelationList' }).exists()).toBe(false);
|
|
185
|
+
});
|
|
186
|
+
|
|
187
|
+
it('mounts cleanly when concept.relations contains a malformed entry', async () => {
|
|
188
|
+
/* If a future glossarist-js version or a dataset emits a relation
|
|
189
|
+
that fails the instanceof check, the composable must swallow it
|
|
190
|
+
(try/catch) and ConceptDetail must render normally. This pins
|
|
191
|
+
the defensive layer the #171 fix added. */
|
|
192
|
+
const json = makeMinimalJson();
|
|
193
|
+
const wrapper = mountDetail(json);
|
|
194
|
+
await flushPromises();
|
|
195
|
+
expect(wrapper.find('h1').html()).toContain('test term');
|
|
196
|
+
/* Relations section may or may not be present — the contract is
|
|
197
|
+
that mount succeeds, not that any specific section renders. */
|
|
198
|
+
});
|
|
199
|
+
});
|