@globisnv/cypress-core 1.1.1 → 1.1.3

package/README.md

@@ -2,7 +2,7 @@
 
 Core building blocks for Globis Cypress E2E tests.
 
-This package holds everything that is *not* customer-specific: the shared Cypress config factory, the custom command library for the Servoy-based Globis solutions, the WebSocket-aware loading detector, the reusable data-entry blueprints, and the lint scripts. Customer repos install it, call `defineGlobisConfig()` in their `cypress.config.ts`, import `@globisnv/cypress-core/register` in their support file, and only keep their own specs and customer-specific commands locally.
+This package holds everything that is *not* customer-specific: the shared Cypress config factory, the custom command library for the Servoy-based Globis solutions, the WebSocket-aware loading detector, the reusable data-entry blueprints, and the lint plugins. Customer repos install it, call `defineGlobisConfig()` in their `cypress.config.ts`, import `@globisnv/cypress-core/register` in their support file, and only keep their own specs and customer-specific commands locally.
 
 ---
 
@@ -164,7 +164,7 @@ src/
 ├── commands/             # 6 generic command files (~128 custom commands)
 ├── apiMethods/           # IGS REST request/response helpers
 └── plugins/              # prometheusWriter — SigV4-signed remote write to AWS AMP
-scripts/                  # standalone lint rules (shipped to consumers)
+biome-plugins/            # GritQL lint rules (shipped to consumers)
 ```
 
 ### Command families
@@ -241,23 +241,22 @@ npm run lint           # biome check .
 npm run lint:fix       # biome check . --write
 ```
 
-Formatting is Biome ([biome.json](biome.json)): 4-space indent, single quotes, semicolons, no trailing commas, 180-column lines, LF endings. `src/types.ts` has `noUnusedVariables` disabled since it is declaration-only.
+Formatting is Biome ([biome.json](biome.json)): 4-space indent, single quotes, semicolons, no trailing commas, 180-column lines, LF endings. [src/biome.json](src/biome.json) extends it for `src/` only: it enables `noUnnecessaryWaiting` there and disables `noUnusedVariables` for `types.ts`, which is declaration-only. It lives in `src/` because consumers `extends` the root `biome.json`, and a plugin path in there would resolve against their repo.
 
-### Shipped lint scripts
+### Shipped lint plugins
 
-`scripts/` is published with the package so consumer repos can run the same rule over their specs. It's a standalone Node script (no ESLint) that reads the invoking repo's `tsconfig.json` from `process.cwd()`, using the TypeScript 7 `typescript/unstable/*` preview API — the classic in-process Compiler API that `typescript-eslint` and `ts-morph` depend on was removed in TS7, which is why those tools cap their peer range below it.
+`biome-plugins/` is published with the package so consumer repos run the same rules over their specs as Biome [GritQL plugins](https://biomejs.dev/linter/plugins/). Their diagnostics show up in `biome check`, the editor and the CI linter like any built-in rule.
 
-| Script | What it does |
+| Plugin | What it does |
 | --- | --- |
-| [check-unnecessary-waiting.mjs](scripts/check-unnecessary-waiting.mjs) | Fails on `cy.wait(<number>)`, including numeric constants/default params aliased in the enclosing scope. Exempt a call with a `// biome-ignore plugin: <reason>` comment on the line directly above — Biome's GritQL plugins have no suppression mechanism, hence the standalone script. |
+| [noUnnecessaryWaiting.grit](biome-plugins/noUnnecessaryWaiting.grit) | Fails on `cy.wait(<number>)`, including numeric constants/default params declared in an enclosing scope. Exempt a call with `// biome-ignore lint/plugin/noUnnecessaryWaiting: <reason>` on the line above. |
 
-Wire it into the consumer repo:
+Wire it into the consumer repo's `biome.json` (the template already does). Biome resolves plugin paths from the consumer's root, not from an `extends`-ed config, so the path can't live in this package's `biome.json`:
 
 ```json
 {
-    "scripts": {
-        "lint:waiting": "node node_modules/@globisnv/cypress-core/scripts/check-unnecessary-waiting.mjs"
-    }
+    "extends": ["./node_modules/@globisnv/cypress-core/biome.json"],
+    "plugins": ["./node_modules/@globisnv/cypress-core/biome-plugins/noUnnecessaryWaiting.grit"]
 }
 ```
 

package/biome-plugins/noUnnecessaryWaiting.grit

@@ -0,0 +1,32 @@
+language js
+
+// A numeric `const`/`let`/`var` declared directly in this list of statements.
+pattern numeric_decl($name) {
+    some JsVariableStatement(declaration=JsVariableDeclaration(declarators=some JsVariableDeclarator(id=$name, initializer=JsInitializerClause(expression=JsNumberLiteralExpression()))))
+}
+
+// A parameter with a numeric default in this parameter list.
+pattern numeric_param($name) { JsParameters(items=some JsFormalParameter(binding=$name, initializer=JsInitializerClause(expression=JsNumberLiteralExpression()))) }
+
+// Only a scope's own statements/parameters count, so a same-named local in another function doesn't match.
+`cy.wait($ms, $...)` as $call where {
+    or {
+        $ms <: JsNumberLiteralExpression(),
+        and {
+            $ms <: JsIdentifierExpression(),
+            $ms <: r"(.*)"($name),
+            $call <: within or {
+                JsFunctionBody(statements=numeric_decl($name)),
+                JsBlockStatement(statements=numeric_decl($name)),
+                JsModule(items=numeric_decl($name)),
+                JsScript(statements=numeric_decl($name)),
+                JsFunctionDeclaration(parameters=numeric_param($name)),
+                JsFunctionExpression(parameters=numeric_param($name)),
+                JsArrowFunctionExpression(parameters=numeric_param($name)),
+                JsMethodClassMember(parameters=numeric_param($name)),
+                JsMethodObjectMember(parameters=numeric_param($name))
+            }
+        }
+    },
+    register_diagnostic(span=$call, message="Avoid arbitrary cy.wait(ms); prefer cy.intercept()/should() polling instead.")
+}

package/biome.json

@@ -1,5 +1,5 @@
 {
-    "$schema": "https://biomejs.dev/schemas/2.5.7/schema.json",
+    "$schema": "https://biomejs.dev/schemas/2.5.14/schema.json",
     "vcs": {
         "enabled": true,
         "clientKind": "git",
@@ -44,17 +44,5 @@
                 "noDoubleEquals": "error"
             }
         }
-    },
-    "overrides": [
-        {
-            "includes": ["src/types.ts"],
-            "linter": {
-                "rules": {
-                    "correctness": {
-                        "noUnusedVariables": "off"
-                    }
-                }
-            }
-        }
-    ]
+    }
 }

package/dist/blueprints/GLO_priceRequestLine.js

@@ -12,6 +12,8 @@ export const GLO_enterPriceRequestLine$Terminal = (obj) => {
         cy.GLO_addInput([qtFormName, 'gross_price'], obj.grossPriceTwo);
         cy.GLO_addInput([qtFormName, 'purchase_costs_euro'], obj.purchaseCostTwo);
         cy.GLO_addInput([qtFormName, 'discount_amount'], obj.discountTwoValue);
+        if (obj.discountTwoValue)
+            cy.GLO_checkLoadingIndicator();
         cy.GLO_addInput([qtFormName, 'discount_percentage'], obj.discountTwoPercentage);
     });
 };

package/dist/commands/FOB_commands.js

@@ -70,7 +70,7 @@ Cypress.Commands.add('FOB_oktaLogin', (company, formBuilderStandalone) => {
     // Change the Url if necessary
     const url = Cypress.expose('formBuilderUrl');
     cy.visit(url);
-    // biome-ignore plugin: wait for okta redirect page load
+    // biome-ignore lint/plugin/noUnnecessaryWaiting: wait for okta redirect page load
     cy.wait(2000);
     cy.task('log', 'Redirect to okta url');
     cy.origin(Cypress.expose('oktaUrl'), () => {
@@ -133,7 +133,7 @@ Cypress.Commands.add('FOB_deleteCustomViewItem', (name) => {
 });
 Cypress.Commands.add('FOB_dragComponentItem', (dragLocation, dropLocation) => {
     cy.get(`[title="${dragLocation}"]`).realMouseDown({ button: 'left', position: 'center' }).realMouseMove(0, 10, { position: 'center' });
-    // biome-ignore plugin: wait for drag animation to settle before drop
+    // biome-ignore lint/plugin/noUnnecessaryWaiting: wait for drag animation to settle before drop
     cy.wait(200);
     cy.get(span).contains(dropLocation).realMouseMove(0, 0, { position: 'center' }).realMouseUp();
     cy.GLO_checkLoadingIndicator();

package/dist/commands/GLO_commands.js

@@ -116,7 +116,7 @@ Cypress.Commands.add('GLO_defaultlogin', (company, usernameENV = 'username', pas
     cy.GLO_checkLoadingIndicator();
     cy.get('body').then(($body) => {
         if ($body.find('.svy-message-dialog.active .window-title').text() === 'Locked record') {
-            // biome-ignore plugin: wait for locked record dialog choice to register
+            // biome-ignore lint/plugin/noUnnecessaryWaiting: wait for locked record dialog choice to register
             cy.wait(15000);
             cy.GLO_dialogChoice('!globis.label.yes!');
         }
@@ -220,7 +220,7 @@ Cypress.Commands.add('GLO_oktaLogin', (company, urlType, skipvNavCheck) => {
     }
     else {
         // This is in case the check is instable
-        // biome-ignore plugin: wait in case the check is instable
+        // biome-ignore lint/plugin/noUnnecessaryWaiting: wait in case the check is instable
         cy.wait(5000);
         cy.GLO_checkLoadingIndicator();
     }
@@ -398,7 +398,7 @@ const waitForProgressBar = () => {
                 reject(new Error(`Timed out after ${Math.round((maxAttempts * pollInterval) / 1000)}s waiting for the progress bar to disappear`));
                 return;
             }
-            // biome-ignore plugin: wait for next poll interval before checking again
+            // biome-ignore lint/plugin/noUnnecessaryWaiting: wait for next poll interval before checking again
             cy.wait(pollInterval, { log: false }).then(() => {
                 log.set({ message: `Still waiting for the progress bar ${attempts}/${maxAttempts}` });
                 checkStatus(resolve, reject);
@@ -415,7 +415,7 @@ Cypress.Commands.add('GLO_checkLoadingIndicator', () => {
         cy.WS_loadingCheck();
     }
     else {
-        // biome-ignore plugin: wait before checking loading indicator
+        // biome-ignore lint/plugin/noUnnecessaryWaiting: wait before checking loading indicator
         cy.wait(1000);
         cy.get('loading-indicator', { timeout: loadingCheckTimeout }).should('not.exist');
         waitForProgressBar();
@@ -776,7 +776,7 @@ Cypress.Commands.add('GLO_closeProgram', (topBottom, programName, tabNumber) =>
     cy.GLO_log(` - Closed program tab ${programName}`);
 });
 Cypress.Commands.add('GLO_dialogChoice', (confirmation) => {
-    // biome-ignore plugin: wait for dialog choice body to render
+    // biome-ignore lint/plugin/noUnnecessaryWaiting: wait for dialog choice body to render
     cy.wait(500);
     cy.get('body').then(($body) => {
         let CSSSearchStr;
@@ -966,21 +966,44 @@ Cypress.Commands.add('GLO_filterGrid', (colId, selector, text, exactMatch = noEq
         }
     });
     if (filterType) {
+        // The typed value needs to sync into the grid's filter model before the operator
+        // menu opens, or the menu's own value field still reads empty and the operator
+        // picker starts from a stale/default state (reproduced manually: opening the menu
+        // too soon after typing shows the filter value field blank).
+        cy.GLO_checkLoadingIndicator();
         cy.get('@filterHeaderCell').find('button').click();
-        cy.get('.ag-filter-menu .ag-filter-select .ag-picker-field-display').click();
-        // biome-ignore plugin: special dropdown for filter, doesn't work without small wait
-        cy.wait(250); // Special dropdown for filter, doesn't work without small wait..
-        cy.get('.ag-filter-menu .ag-picker-expanded')
-            .invoke('attr', 'aria-controls')
-            .then((dropDownId) => {
-            cy.get(`[id="${dropDownId}"]`)
-                .should('be.visible')
-                .within(() => {
-                cy.get('.ag-list-item').contains(filterType).should('be.visible').parent().click();
+        // Selecting the operator in this popup is occasionally flaky in Cypress (the click
+        // registers but the picker display doesn't update to the new operator - reproduced
+        // manually in the live app and ruled out as a wrong-popup/stale-aria-controls issue;
+        // the open+select sequence itself is correct). Self-heal by reopening and reselecting
+        // instead of guessing at the exact cause of the dropped click.
+        // A compound AND/OR filter always has a second condition row scaffolded in (even
+        // when unused), each with its own operator picker - scope to .first() throughout so
+        // this always targets the primary condition's picker instead of matching 2 elements.
+        const selectFilterType = (attemptsLeft) => {
+            cy.get('.ag-filter-menu .ag-filter-select .ag-picker-field-display').first().click();
+            // biome-ignore lint/plugin/noUnnecessaryWaiting: special dropdown for filter, doesn't work without small wait
+            cy.wait(250);
+            cy.get('.ag-filter-menu .ag-picker-expanded')
+                .invoke('attr', 'aria-controls')
+                .then((dropDownId) => {
+                cy.get(`[id="${dropDownId}"]`)
+                    .should('be.visible')
+                    .within(() => {
+                    cy.get('.ag-list-item').contains(filterType).should('be.visible').parent().click();
+                });
             });
-        });
-        cy.GLO_checkAGLoader();
-        cy.get('.ag-filter-menu .ag-filter-select .ag-picker-field-display').should('contain.text', filterType);
+            cy.GLO_checkAGLoader();
+            cy.get('.ag-filter-menu .ag-filter-select .ag-picker-field-display')
+                .first()
+                .then(($el) => {
+                if ($el.text().trim() !== filterType && attemptsLeft > 0) {
+                    selectFilterType(attemptsLeft - 1);
+                }
+            });
+        };
+        selectFilterType(2);
+        cy.get('.ag-filter-menu .ag-filter-select .ag-picker-field-display').first().should('contain.text', filterType);
         cy.press(Cypress.Keyboard.Keys.ESC); // Close the filter menu
     }
     cy.GLO_checkLoadingIndicator();
@@ -1029,13 +1052,13 @@ const selectYear = (targetYear) => {
         const currentYear = Number(currentDate.split(' ')[1]);
         if (currentYear < targetYear) {
             cy.GLO_getVisible('i.dx-icon.dx-icon-chevronright').last().click();
-            // biome-ignore plugin: wait for year navigation click to register
+            // biome-ignore lint/plugin/noUnnecessaryWaiting: wait for year navigation click to register
             cy.wait(500);
             selectYear(targetYear);
         }
         else if (currentYear > targetYear) {
             cy.GLO_getVisible('i.dx-icon.dx-icon-chevronleft').last().click();
-            // biome-ignore plugin: wait for year navigation click to register
+            // biome-ignore lint/plugin/noUnnecessaryWaiting: wait for year navigation click to register
             cy.wait(500);
             selectYear(targetYear);
         }
@@ -1055,13 +1078,13 @@ const selectMonth = (targetMonth) => {
             throw new Error('Given month is invalid');
         if (currenMonthNumber < targetMonth) {
             cy.GLO_getVisible('i.dx-icon.dx-icon-chevronright').last().click();
-            // biome-ignore plugin: wait for month navigation click to register
+            // biome-ignore lint/plugin/noUnnecessaryWaiting: wait for month navigation click to register
             cy.wait(500);
             selectMonth(targetMonth);
         }
         else if (currenMonthNumber > targetMonth) {
             cy.GLO_getVisible('i.dx-icon.dx-icon-chevronleft').last().click();
-            // biome-ignore plugin: wait for month navigation click to register
+            // biome-ignore lint/plugin/noUnnecessaryWaiting: wait for month navigation click to register
             cy.wait(500);
             selectMonth(targetMonth);
         }
@@ -1429,8 +1452,8 @@ Cypress.Commands.add('GLO_validateCheckbox', (selector, value) => {
  * It ensures that the AG Grid has finished loading.
  */
 Cypress.Commands.add('GLO_checkAGLoader', () => {
-    // biome-ignore plugin: wait because AGLoader is not instant
-    cy.wait(1000); // Wait because AGLoader is not instant
+    // biome-ignore lint/plugin/noUnnecessaryWaiting: wait because AGLoader is not instant
+    cy.wait(1000);
     cy.get('.ag-loading', { timeout: 600000 }).should('not.exist');
 });
 Cypress.Commands.add('GLO_log', (logValue) => {
@@ -1604,7 +1627,7 @@ Cypress.Commands.add('GLO_checkNumberOfRowsInGrid', (selector, numberToValidate,
                     reject(new Error(`Timed out after ${Math.round((maxAttempts * pollInterval) / 100) / 10}s: row count was ${actual}, expected "${lengthCondition} ${numberToValidate}"`));
                     return;
                 }
-                // biome-ignore plugin: wait for next poll interval before checking again
+                // biome-ignore lint/plugin/noUnnecessaryWaiting: wait for next poll interval before checking again
                 cy.wait(pollInterval, { log: false }).then(() => {
                     log.set({ message: `Still polling ${actual} to ${lengthCondition} ${numberToValidate} ${attempts}/${maxAttempts}` });
                     checkStatus(resolve, reject);
@@ -1800,7 +1823,8 @@ Cypress.Commands.add('GLO_fillInfieldInGrid', (selector, rowFilter, columnId, va
             .some((cell) => cell.textContent?.trim() === rowFilter))
             .find(`[col-id="${columnId}"]`)
             .click();
-        cy.wait(500); // Else both click and dblclick fire too fast
+        // biome-ignore lint/plugin/noUnnecessaryWaiting: else both click and dblclick fire too fast
+        cy.wait(500);
         cy.GLO_getAllRowsInGrid()
             .filter((_, el) => Cypress.$(el)
             .find('[role="gridcell"]')
@@ -1813,7 +1837,11 @@ Cypress.Commands.add('GLO_fillInfieldInGrid', (selector, rowFilter, columnId, va
         cy.GLO_getElement(selector).within(() => {
             cy.GLO_clickRowInGrid(rowFilter, columnId);
         });
-        cy.wait(500); // Else both click and dblclick fire too fast
+        // Re-check outside the .within(): loading-indicator renders at page level, so the check
+        // inside GLO_clickRowInGrid (scoped to the grid element above) can't see it and resolves early.
+        cy.GLO_checkLoadingIndicator();
+        // biome-ignore lint/plugin/noUnnecessaryWaiting: else both click and dblclick fire too fast
+        cy.wait(500);
         cy.GLO_dblClickRowInGrid(row, selector, rowFilter, columnId, skipCheck);
     }
     cy.get(gridInputType === 'aggrid-texteditor-without-enter' ? gridInput : gridInputType, { timeout: 1000 }).should('exist');
@@ -1910,8 +1938,8 @@ Cypress.Commands.add('GLO_clickButtonInGrid', { prevSubject: ['optional', 'eleme
 });
 Cypress.Commands.add('GLO_oktaAlternativeLogin', (altUser, company) => {
     cy.GLO_logout();
-    // biome-ignore plugin: wait for Okta to process logout
-    cy.wait(10000); // Wait for Okta to process logout
+    // biome-ignore lint/plugin/noUnnecessaryWaiting: wait for Okta to process logout
+    cy.wait(10000);
     if (cypressWebsocketLoader) {
         cy.on('window:before:load', (win) => {
             attachWebSocketSpy(win);
@@ -2077,21 +2105,14 @@ const validateGridValue = (value, failValue, rowFilter, columnId, timeOut = 1000
         cy.then(() => promise);
     }
 };
-Cypress.Commands.add('GLO_getCurrentRecordCount', () => {
-    return cy
-        .GLO_getElement(['ng$datacontrol', 'datacontrol'])
-        .find('#txtCount')
-        .invoke('text')
-        .then((records) => {
-        const [currentStr, totalStr] = records.split('/');
-        if (!currentStr || !totalStr) {
-            throw new Error(`Could not parse record count from "${records}"`);
-        }
+Cypress.Commands.addQuery('GLO_getCurrentRecordCount', () => {
+    return () => {
+        const records = Cypress.$('div[formslist]:not([hidden]) [data-cy$="ng$datacontrol.datacontrol"] #txtCount').text().split('/');
         return {
-            currentRecord: parseInt(currentStr.trim(), 10),
-            totalRecords: parseInt(totalStr.trim(), 10)
+            currentRecord: Number.parseInt(records[0]?.trim() ?? '', 10),
+            totalRecords: Number.parseInt(records[1]?.trim() ?? '', 10)
         };
-    });
+    };
 });
 Cypress.Commands.add('GLO_storeObject', (formName, elementNames, index, log = hideInCommandLog) => {
     const keys = (Array.isArray(elementNames) ? elementNames : [elementNames]);

package/dist/commands/POR_commands.js

@@ -12,7 +12,7 @@ Cypress.Commands.add('POR_checkPortalSideMenuCorrect', (menuItems) => {
 });
 Cypress.Commands.add('POR_portalLogin', () => {
     cy.visit(Cypress.expose('portalUrl'));
-    // biome-ignore plugin: wait for portal login redirect
+    // biome-ignore lint/plugin/noUnnecessaryWaiting: wait for portal login redirect
     cy.wait(2000);
     cy.origin(Cypress.expose('oktaUrl'), () => {
         cy.get('.o-form-input')

package/dist/websocketDetector.js

@@ -492,7 +492,7 @@ Cypress.Commands.add('WS_loadingCheck', (options) => {
         }
         win.lockedRecordRetries = retries + 1;
         debugLog(`🔍 Locked record dialog detected (attempt ${win.lockedRecordRetries}/3), waiting 60s before handling`);
-        // biome-ignore plugin: <internal> Cypress wait for locked record dialog handling
+        // biome-ignore lint/plugin/noUnnecessaryWaiting: <internal> Cypress wait for locked record dialog handling
         cy.wait(LOCKED_RECORD_WAIT_MS).then(() => {
             if (!lockedRecordDialogHandled) {
                 lockedRecordDialogHandled = true;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@globisnv/cypress-core",
-    "version": "1.1.1",
+    "version": "1.1.3",
     "description": "Core building blocks for Globis Cypress E2E tests",
     "license": "UNLICENSED",
     "type": "module",
@@ -12,7 +12,8 @@
         "url": "git+https://github.com/globisnv/globis-cypress-core.git"
     },
     "publishConfig": {
-        "access": "public"
+        "access": "public",
+        "tag": "release-1.x"
     },
     "globisOnline": {
         "minVersion": "11.0.2"
@@ -33,7 +34,7 @@
     },
     "files": [
         "dist",
-        "scripts",
+        "biome-plugins",
         "bin",
         "template",
         "biome.json"
@@ -57,9 +58,9 @@
         "uuid": "^14.0.1"
     },
     "devDependencies": {
-        "@biomejs/biome": "^2.5.7",
+        "@biomejs/biome": "^2.5.14",
         "@types/node": "^26.1.2",
-        "cypress": "^16.1.0",
+        "cypress": "^16.1.1",
         "cypress-real-events": "^1.15.1",
         "typescript": "^7.0.2"
     },

package/template/biome.json

@@ -1,6 +1,7 @@
 {
-    "$schema": "https://biomejs.dev/schemas/2.5.7/schema.json",
+    "$schema": "https://biomejs.dev/schemas/2.5.14/schema.json",
     "extends": ["./node_modules/@globisnv/cypress-core/biome.json"],
+    "plugins": ["./node_modules/@globisnv/cypress-core/biome-plugins/noUnnecessaryWaiting.grit"],
     "files": {
         "includes": ["!cypress/screenshots", "!cypress/videos", "!cypress/downloads", "!cypress/reports", "!cypress.env*.json"]
     }

package/template/package.json

@@ -9,13 +9,13 @@
         "typescript": "^7.0.2"
     },
     "devDependencies": {
-        "@biomejs/biome": "^2.5.7",
+        "@biomejs/biome": "^2.5.14",
         "@types/node": "^26.1.2",
         "cypress": "^16.0.0"
     },
     "scripts": {
-        "lint": "biome check . && node node_modules/@globisnv/cypress-core/scripts/check-unnecessary-waiting.mjs",
-        "lint:fix": "biome check . --write && node node_modules/@globisnv/cypress-core/scripts/check-unnecessary-waiting.mjs",
+        "lint": "biome check .",
+        "lint:fix": "biome check . --write",
         "typescript": "tsc --noEmit --skipLibCheck",
         "open": "cypress open --e2e --browser chrome",
         "record": "node ./cypress/support/record.mjs"

package/scripts/check-unnecessary-waiting.mjs

@@ -1,119 +0,0 @@
-#!/usr/bin/env node
-// Standalone replacement for the biome-plugins/no-unnecessary-waiting.grit plugin.
-//
-// Biome's GritQL plugins (2.5.7) have no suppression mechanism - a
-// register_diagnostic() call either fires or it doesn't, with no per-line
-// ignore comment support (confirmed: `biome lint --suppress` writes nothing
-// for plugin-sourced diagnostics). Blocking on cy.wait(<number>) while still
-// allowing a documented exception needs code that can check for a preceding
-// comment itself, so this is a plain AST walk instead of a Grit plugin.
-//
-// Flags cy.wait(<number literal>[, options]) unless the line directly above
-// the call has a `// biome-ignore plugin: <reason>` comment.
-
-import path from 'node:path';
-import * as ts from 'typescript/unstable/ast';
-import { API } from 'typescript/unstable/sync';
-
-const ROOT = process.cwd(); // invoking repo's root, not this script's install location
-const TSCONFIG = 'tsconfig.json';
-const IGNORE_COMMENT = /^\s*\/\/\s*biome-ignore\s+plugin:/;
-
-function walkAll(node, visit) {
-    visit(node);
-    node.forEachChild((child) => walkAll(child, visit));
-}
-
-function isIgnored(sourceFile, node) {
-    const line = sourceFile.getLineAndCharacterOfPosition(node.getStart()).line;
-    if (line === 0) return false;
-    const lineStarts = sourceFile.getLineStarts();
-    const prevLineText = sourceFile.text.slice(lineStarts[line - 1], lineStarts[line]);
-    return IGNORE_COMMENT.test(prevLineText);
-}
-
-// A cy.wait(x) call is just as arbitrary when x is a const/default-param alias for a
-// numeric literal (e.g. `const serverTimeout = 5000`) as when it's inlined. Resolve by
-// walking up to the nearest enclosing block/function and looking for a declaration of
-// that name among its statements/parameters - not a file-wide name search, since two
-// unrelated functions can each declare their own same-named local (e.g. `pollInterval`).
-function resolveNumericAlias(identifier) {
-    const name = identifier.text;
-    for (let scope = identifier.parent; scope; scope = scope.parent) {
-        if (ts.isFunctionLikeDeclaration(scope)) {
-            for (const param of scope.parameters) {
-                if (ts.isIdentifier(param.name) && param.name.text === name && param.initializer && ts.isNumericLiteral(param.initializer)) {
-                    return param.initializer.text;
-                }
-            }
-        }
-        if (ts.isBlock(scope) || ts.isSourceFile(scope)) {
-            const statements = scope.statements;
-            for (const statement of statements) {
-                if (!ts.isVariableStatement(statement)) continue;
-                for (const decl of statement.declarationList.declarations) {
-                    if (ts.isIdentifier(decl.name) && decl.name.text === name && decl.initializer && ts.isNumericLiteral(decl.initializer)) {
-                        return decl.initializer.text;
-                    }
-                }
-            }
-        }
-    }
-    return undefined;
-}
-
-function checkSourceFile(sourceFile) {
-    const violations = [];
-    walkAll(sourceFile, (node) => {
-        if (!ts.isCallExpression(node)) return;
-        const callee = node.expression;
-        if (!ts.isPropertyAccessExpression(callee) || !ts.isIdentifier(callee.expression) || callee.expression.text !== 'cy') return;
-        if (callee.name.text !== 'wait') return;
-
-        const msArg = node.arguments[0];
-        if (!msArg) return;
-        const isDirectLiteral = ts.isNumericLiteral(msArg);
-        const isNumericAlias = ts.isIdentifier(msArg) && resolveNumericAlias(msArg) !== undefined;
-        if (!isDirectLiteral && !isNumericAlias) return;
-        if (isIgnored(sourceFile, node)) return;
-
-        violations.push({
-            file: sourceFile.fileName,
-            line: sourceFile.getLineAndCharacterOfPosition(node.getStart()).line + 1
-        });
-    });
-    return violations;
-}
-
-function main() {
-    const api = new API({ cwd: ROOT });
-    try {
-        const snapshot = api.updateSnapshot({ openProjects: [TSCONFIG] });
-        const project = snapshot.getProject(TSCONFIG);
-
-        const cypressRoot = path.join(ROOT, 'cypress') + path.sep;
-        const fileNames = project.rootFiles.filter((f) => f.startsWith(cypressRoot) && f.endsWith('.ts') && !f.endsWith('.d.ts'));
-
-        const allViolations = [];
-        for (const fileName of fileNames) {
-            const sourceFile = project.program.getSourceFile(fileName);
-            if (!sourceFile) continue;
-            allViolations.push(...checkSourceFile(sourceFile));
-        }
-
-        for (const v of allViolations) {
-            console.log(
-                `${path.relative(ROOT, v.file)}:${v.line} Avoid arbitrary cy.wait(ms); prefer cy.intercept()/should() polling instead. (add "// biome-ignore plugin: <reason>" above the line if intentional)`
-            );
-        }
-
-        if (allViolations.length > 0) {
-            console.log(`\n${allViolations.length} unguarded cy.wait(ms) call(s) found.`);
-            process.exit(1);
-        }
-    } finally {
-        api.close();
-    }
-}
-
-main();