@globisnv/cypress-core 0.0.8 → 0.0.9

package/README.md

@@ -43,7 +43,9 @@ The floor is recorded in `package.json` under `globisOnline.minVersion` (machine
 A release is two phases, because the `develop` ruleset requires a reviewed PR — so the version bump takes the same route as every other change instead of CI trying to push past the ruleset.
 
 1. **Actions → [Prepare Release](.github/workflows/release-pr.yml) → Run workflow**, pick `patch` / `minor` / `major`. It bumps `package.json`, renames the `## Unreleased` heading in `CHANGELOG.md` to `## X.Y.Z` and opens a fresh empty `## Unreleased` above it, and opens a `chore(release): vX.Y.Z` PR. Nothing is published yet.
-2. **Check the changelog section on that PR** (it becomes the GitHub Release notes) and merge it. [Publish](.github/workflows/publish.yml) then builds, lints, publishes to npm, and creates the tag and GitHub Release.
+2. **Check the changelog section on that PR** (it becomes the GitHub Release notes) and **merge it yourself**. [Publish](.github/workflows/publish.yml) then builds, lints, publishes to npm, and creates the tag and GitHub Release.
+
+Release PRs are deliberately left out of the auto-merge that every other PR gets. A merge performed by `GITHUB_TOKEN` creates no workflow run, so an auto-merged release PR would land the version in git and never publish it. If that ever happens anyway, run **Actions → Publish → Run workflow** and give it the release PR's number to finish the release. It publishes that PR's merge commit — not whatever the run was started from — so a recovery still ships exactly the tree that was reviewed, and it refuses a PR that is not a merged `release/*` into `develop`.
 
 Write changelog entries under the `## Unreleased` heading as you merge work, rather than at release time — the release just renames that heading and opens a new one, so there is always a section at the top to write into and the file never needs reorganising by hand. If there is no `## Unreleased` section when you cut a release, the workflow adds an empty `## X.Y.Z` stub and warns, and you fill it in on the PR.
 

package/dist/blueprints/GLO_relations.js

@@ -131,10 +131,7 @@ const enterCustomerTab = (obj, formName = 'ng$relations_dtl') => {
     cy.GLO_checkbox([formNameCustomer, 'flag_ready_for_invoicing'], obj.flagReadyForInvoicing);
     cy.GLO_addInput([formNameCustomer, 'responsible_user_id'], obj.responsible);
     cy.GLO_addInput([formNameCustomer, 'vat_regime_id'], obj.vatRegimeCustomerTab);
-    if (obj.invoiceCustomerCode) {
-        cy.GLO_addInput([formNameCustomer, 'invoice_customer_code'], obj.invoiceCustomerCode);
-        cy.GLO_checkLoadingIndicator();
-    }
+    cy.GLO_popupWindow([formNameCustomer, 'invoice_customer_code'], obj.invoiceCustomerCode);
     cy.GLO_addInput([formNameCustomer, 'debtorcode_accountancy'], obj.debtorCode);
     cy.GLO_addInput([formNameCustomer, 'office'], obj.office);
     cy.GLO_addInput([formNameCustomer, 'new_service_level'], obj.newServiceLevel);

package/dist/commands/GLO_commands.js

@@ -527,10 +527,11 @@ const GLO_inputValuelist = (selector, rawValue) => {
             if (newId)
                 dropDownId = newId;
             const query = dropdownSelector ? `[id="${dropDownId}"] ${dropdownSelector}` : `[id="${dropDownId}"]`;
+            // The timeout has to go on the find(), the retrying query. Cypress does not inherit it from cy.document().
             return cy
-                .document({ timeout: timeout ?? defaultTimeout, log: false })
+                .document({ log: false })
                 .its('body', { log: false })
-                .find(query, { log: false });
+                .find(query, { timeout: timeout ?? defaultTimeout, log: false });
         });
     };
     cy.GLO_getElement(vlEffectiveSelector).find('.dx-texteditor-input:enabled', { log: false }).eq(vlEffectiveIndex).click();
@@ -623,7 +624,9 @@ const GLO_inputValuelist = (selector, rawValue) => {
                             const currentTexts = [...$current].map((el) => el.innerText.trim());
                             const hasChanged = !Cypress._.isEqual(currentTexts, initialTexts);
                             const anyIncludes = currentTexts.every((text) => text.includes(dropdownValue));
-                            return expect(hasChanged || anyIncludes, `Dropdown updated or contains "${dropdownValue}" already`).to.be.true;
+                            // An empty list is the transitional state while the filtered valuelist is still loading, never a valid result.
+                            // Without this guard an emptied list counts as 'changed' (and every() is vacuously true), so we stop waiting too soon.
+                            return expect(currentTexts.length > 0 && (hasChanged || anyIncludes), `Dropdown updated or contains "${dropdownValue}" already`).to.be.true;
                         });
                     })
                         .then(() => {

package/dist/commands/GLS_commands.d.ts

@@ -56,7 +56,7 @@ declare global {
              * @param {string} elementName - Name of the element within the form
              * @param {string} label - The label text to search for (e.g. 'TO location:')
              */
-            GLS_getLabelValue(formName: string, elementName: string, label: string): Cypress.Chainable<JQuery>;
+            GLS_getLabelValue(formName: string, elementName: string, label: string): Cypress.Chainable<string>;
         }
     }
 }

package/dist/commands/GLS_commands.js

@@ -99,5 +99,7 @@ Cypress.Commands.add('GLS_navigation', (position, formName, value) => {
     cy.GLO_checkLoadingIndicator();
 });
 Cypress.Commands.add('GLS_getLabelValue', (formName, elementName, label) => {
-    return getLabelValue(formName, elementName, label);
+    return getLabelValue(formName, elementName, label)
+        .invoke('text')
+        .then((text) => text.trim());
 });

package/dist/commands/POR_commands.js

@@ -88,17 +88,9 @@ Cypress.Commands.add('POR_logout', (company) => {
     else {
         cy.GLO_getElement(['ep$main', 'sidemenu']).find('.footer').find('.clickable').click();
     }
-    cy.get('.window-footer').then(($dialog) => {
-        if ($dialog.find('.svy-btn-primary:contains("Yes")').length > 0) {
-            cy.wrap($dialog).contains('Yes').click();
-        }
-        else if ($dialog.find('.svy-btn-primary:contains("Ja")').length > 0) {
-            cy.wrap($dialog).contains('Ja').click();
-        }
-        else {
-            throw new Error('Neither "Yes" nor "Ja" options found in the dialog box.');
-        }
-    });
+    cy.GLO_getVisible('.window-footer button.svy-btn-primary', 30000)
+        .contains(/^(Yes|Ja)$/)
+        .click();
     cy.GLO_checkLoadingIndicator();
 });
 Cypress.Commands.add('POR_checklistCData', (formName, elementName, checkboxName) => {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@globisnv/cypress-core",
-    "version": "0.0.8",
+    "version": "0.0.9",
     "description": "Core building blocks for Globis Cypress E2E tests",
     "license": "UNLICENSED",
     "type": "module",