@globisnv/cypress-core 0.0.7 → 0.0.9

package/README.md

@@ -30,7 +30,7 @@ What each part of the version bump means:
 | minor | A new command / blueprint / API surface, backwards compatible |
 | patch | Bugfixes only |
 
-Releases are cut via the [Create Release](.github/workflows/release.yml) GitHub Action (Actions → Create Release → Run workflow), which bumps the version, tags, publishes to npm, and creates the GitHub Release.
+See [Cutting a release](#cutting-a-release) for how a bump actually gets published.
 
 | Core version | Minimum globis-online version |
 | --- | --- |
@@ -38,6 +38,21 @@ Releases are cut via the [Create Release](.github/workflows/release.yml) GitHub
 
 The floor is recorded in `package.json` under `globisOnline.minVersion` (machine-readable, in case tooling wants to check it later) and here in this table (human-readable, updated on every release alongside `CHANGELOG.md`). `globis-cypress` stays pinned to the latest core version — since it's Globis's own suite, it's the first thing to catch a globis-online release breaking something, before any customer repo would.
 
+## Cutting a release
+
+A release is two phases, because the `develop` ruleset requires a reviewed PR — so the version bump takes the same route as every other change instead of CI trying to push past the ruleset.
+
+1. **Actions → [Prepare Release](.github/workflows/release-pr.yml) → Run workflow**, pick `patch` / `minor` / `major`. It bumps `package.json`, renames the `## Unreleased` heading in `CHANGELOG.md` to `## X.Y.Z` and opens a fresh empty `## Unreleased` above it, and opens a `chore(release): vX.Y.Z` PR. Nothing is published yet.
+2. **Check the changelog section on that PR** (it becomes the GitHub Release notes) and **merge it yourself**. [Publish](.github/workflows/publish.yml) then builds, lints, publishes to npm, and creates the tag and GitHub Release.
+
+Release PRs are deliberately left out of the auto-merge that every other PR gets. A merge performed by `GITHUB_TOKEN` creates no workflow run, so an auto-merged release PR would land the version in git and never publish it. If that ever happens anyway, run **Actions → Publish → Run workflow** and give it the release PR's number to finish the release. It publishes that PR's merge commit — not whatever the run was started from — so a recovery still ships exactly the tree that was reviewed, and it refuses a PR that is not a merged `release/*` into `develop`.
+
+Write changelog entries under the `## Unreleased` heading as you merge work, rather than at release time — the release just renames that heading and opens a new one, so there is always a section at the top to write into and the file never needs reorganising by hand. If there is no `## Unreleased` section when you cut a release, the workflow adds an empty `## X.Y.Z` stub and warns, and you fill it in on the PR.
+
+Publishing uses [npm trusted publishing](https://docs.npmjs.com/trusted-publishers/) over OIDC, so there is no `NPM_TOKEN` and no PAT anywhere in the release path — the publish job's only write scope is the tag and release it creates. The trusted publisher on npm must name **`publish.yml`** as the workflow. npm provenance stays off: it isn't supported from a private repository.
+
+Because the bump lands in git *before* anything reaches npm, a failed publish never leaves the registry ahead of the repository — re-running the workflow after a fix picks up where it left off, and a version already on npm is skipped rather than retried.
+
 ---
 
 ## Setting up a new customer repo

package/dist/blueprints/GLO_logisticContractVolumeConstraint.d.ts

@@ -3,7 +3,7 @@ export type objLogisticContractVolumeConstraint = {
     fromCountry?: string;
     toCountry?: string;
     period?: string;
-    limit?: string;
+    maxOrders?: string;
     flagActive?: CheckState;
 };
 export declare const GLO_enterLogisticContractVolumeConstraint: (obj: objLogisticContractVolumeConstraint) => void;

package/dist/blueprints/GLO_logisticContractVolumeConstraint.js

@@ -3,6 +3,6 @@ export const GLO_enterLogisticContractVolumeConstraint = (obj) => {
     cy.GLO_popupWindow([formName, 'from_country_id'], obj.fromCountry);
     cy.GLO_popupWindow([formName, 'to_country_id'], obj.toCountry);
     cy.GLO_addInput([formName, 'period'], obj.period);
-    cy.GLO_addInput([formName, 'limit'], obj.limit);
+    cy.GLO_addInput([formName, 'max_orders'], obj.maxOrders);
     cy.GLO_checkbox([formName, 'flag_active'], obj.flagActive);
 };

package/dist/blueprints/GLO_relations.js

@@ -131,10 +131,7 @@ const enterCustomerTab = (obj, formName = 'ng$relations_dtl') => {
     cy.GLO_checkbox([formNameCustomer, 'flag_ready_for_invoicing'], obj.flagReadyForInvoicing);
     cy.GLO_addInput([formNameCustomer, 'responsible_user_id'], obj.responsible);
     cy.GLO_addInput([formNameCustomer, 'vat_regime_id'], obj.vatRegimeCustomerTab);
-    if (obj.invoiceCustomerCode) {
-        cy.GLO_addInput([formNameCustomer, 'invoice_customer_code'], obj.invoiceCustomerCode);
-        cy.GLO_checkLoadingIndicator();
-    }
+    cy.GLO_popupWindow([formNameCustomer, 'invoice_customer_code'], obj.invoiceCustomerCode);
     cy.GLO_addInput([formNameCustomer, 'debtorcode_accountancy'], obj.debtorCode);
     cy.GLO_addInput([formNameCustomer, 'office'], obj.office);
     cy.GLO_addInput([formNameCustomer, 'new_service_level'], obj.newServiceLevel);

package/dist/commands/GLO_commands.js

@@ -527,10 +527,11 @@ const GLO_inputValuelist = (selector, rawValue) => {
             if (newId)
                 dropDownId = newId;
             const query = dropdownSelector ? `[id="${dropDownId}"] ${dropdownSelector}` : `[id="${dropDownId}"]`;
+            // The timeout has to go on the find(), the retrying query. Cypress does not inherit it from cy.document().
             return cy
-                .document({ timeout: timeout ?? defaultTimeout, log: false })
+                .document({ log: false })
                 .its('body', { log: false })
-                .find(query, { log: false });
+                .find(query, { timeout: timeout ?? defaultTimeout, log: false });
         });
     };
     cy.GLO_getElement(vlEffectiveSelector).find('.dx-texteditor-input:enabled', { log: false }).eq(vlEffectiveIndex).click();
@@ -623,7 +624,9 @@ const GLO_inputValuelist = (selector, rawValue) => {
                             const currentTexts = [...$current].map((el) => el.innerText.trim());
                             const hasChanged = !Cypress._.isEqual(currentTexts, initialTexts);
                             const anyIncludes = currentTexts.every((text) => text.includes(dropdownValue));
-                            return expect(hasChanged || anyIncludes, `Dropdown updated or contains "${dropdownValue}" already`).to.be.true;
+                            // An empty list is the transitional state while the filtered valuelist is still loading, never a valid result.
+                            // Without this guard an emptied list counts as 'changed' (and every() is vacuously true), so we stop waiting too soon.
+                            return expect(currentTexts.length > 0 && (hasChanged || anyIncludes), `Dropdown updated or contains "${dropdownValue}" already`).to.be.true;
                         });
                     })
                         .then(() => {
@@ -1768,12 +1771,14 @@ Cypress.Commands.add('GLO_fillInfieldInGrid', (selector, rowFilter, columnId, va
         return;
     if (typeof rowFilter === 'string') {
         cy.GLO_getAllRowsInGrid().filter(`:contains("${rowFilter}")`).find(`[col-id="${columnId}"]`).click();
+        cy.wait(500); // Else both click and dblclick fire too fast
         cy.GLO_getAllRowsInGrid().filter(`:contains("${rowFilter}")`).find(`[col-id="${columnId}"]`).dblclick();
     }
     else {
         cy.GLO_getElement(selector).within(() => {
             cy.GLO_clickRowInGrid(rowFilter, columnId);
         });
+        cy.wait(500); // Else both click and dblclick fire too fast
         cy.GLO_dblClickRowInGrid(row, selector, rowFilter, columnId, skipCheck);
     }
     cy.get(gridInputType === 'aggrid-texteditor-without-enter' ? gridInput : gridInputType, { timeout: 1000 }).should('exist');

package/dist/commands/GLS_commands.d.ts

@@ -56,7 +56,7 @@ declare global {
              * @param {string} elementName - Name of the element within the form
              * @param {string} label - The label text to search for (e.g. 'TO location:')
              */
-            GLS_getLabelValue(formName: string, elementName: string, label: string): Cypress.Chainable<JQuery>;
+            GLS_getLabelValue(formName: string, elementName: string, label: string): Cypress.Chainable<string>;
         }
     }
 }

package/dist/commands/GLS_commands.js

@@ -99,5 +99,7 @@ Cypress.Commands.add('GLS_navigation', (position, formName, value) => {
     cy.GLO_checkLoadingIndicator();
 });
 Cypress.Commands.add('GLS_getLabelValue', (formName, elementName, label) => {
-    return getLabelValue(formName, elementName, label);
+    return getLabelValue(formName, elementName, label)
+        .invoke('text')
+        .then((text) => text.trim());
 });

package/dist/commands/POR_commands.js

@@ -88,17 +88,9 @@ Cypress.Commands.add('POR_logout', (company) => {
     else {
         cy.GLO_getElement(['ep$main', 'sidemenu']).find('.footer').find('.clickable').click();
     }
-    cy.get('.window-footer').then(($dialog) => {
-        if ($dialog.find('.svy-btn-primary:contains("Yes")').length > 0) {
-            cy.wrap($dialog).contains('Yes').click();
-        }
-        else if ($dialog.find('.svy-btn-primary:contains("Ja")').length > 0) {
-            cy.wrap($dialog).contains('Ja').click();
-        }
-        else {
-            throw new Error('Neither "Yes" nor "Ja" options found in the dialog box.');
-        }
-    });
+    cy.GLO_getVisible('.window-footer button.svy-btn-primary', 30000)
+        .contains(/^(Yes|Ja)$/)
+        .click();
     cy.GLO_checkLoadingIndicator();
 });
 Cypress.Commands.add('POR_checklistCData', (formName, elementName, checkboxName) => {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@globisnv/cypress-core",
-    "version": "0.0.7",
+    "version": "0.0.9",
     "description": "Core building blocks for Globis Cypress E2E tests",
     "license": "UNLICENSED",
     "type": "module",