@globisnv/cypress-core 0.0.6 → 0.0.8

package/README.md

@@ -30,7 +30,7 @@ What each part of the version bump means:
 | minor | A new command / blueprint / API surface, backwards compatible |
 | patch | Bugfixes only |
 
-Releases are cut via the [Create Release](.github/workflows/release.yml) GitHub Action (Actions → Create Release → Run workflow), which bumps the version, tags, publishes to npm, and creates the GitHub Release.
+See [Cutting a release](#cutting-a-release) for how a bump actually gets published.
 
 | Core version | Minimum globis-online version |
 | --- | --- |
@@ -38,6 +38,19 @@ Releases are cut via the [Create Release](.github/workflows/release.yml) GitHub
 
 The floor is recorded in `package.json` under `globisOnline.minVersion` (machine-readable, in case tooling wants to check it later) and here in this table (human-readable, updated on every release alongside `CHANGELOG.md`). `globis-cypress` stays pinned to the latest core version — since it's Globis's own suite, it's the first thing to catch a globis-online release breaking something, before any customer repo would.
 
+## Cutting a release
+
+A release is two phases, because the `develop` ruleset requires a reviewed PR — so the version bump takes the same route as every other change instead of CI trying to push past the ruleset.
+
+1. **Actions → [Prepare Release](.github/workflows/release-pr.yml) → Run workflow**, pick `patch` / `minor` / `major`. It bumps `package.json`, renames the `## Unreleased` heading in `CHANGELOG.md` to `## X.Y.Z` and opens a fresh empty `## Unreleased` above it, and opens a `chore(release): vX.Y.Z` PR. Nothing is published yet.
+2. **Check the changelog section on that PR** (it becomes the GitHub Release notes) and merge it. [Publish](.github/workflows/publish.yml) then builds, lints, publishes to npm, and creates the tag and GitHub Release.
+
+Write changelog entries under the `## Unreleased` heading as you merge work, rather than at release time — the release just renames that heading and opens a new one, so there is always a section at the top to write into and the file never needs reorganising by hand. If there is no `## Unreleased` section when you cut a release, the workflow adds an empty `## X.Y.Z` stub and warns, and you fill it in on the PR.
+
+Publishing uses [npm trusted publishing](https://docs.npmjs.com/trusted-publishers/) over OIDC, so there is no `NPM_TOKEN` and no PAT anywhere in the release path — the publish job's only write scope is the tag and release it creates. The trusted publisher on npm must name **`publish.yml`** as the workflow. npm provenance stays off: it isn't supported from a private repository.
+
+Because the bump lands in git *before* anything reaches npm, a failed publish never leaves the registry ahead of the repository — re-running the workflow after a fix picks up where it left off, and a version already on npm is skipped rather than retried.
+
 ---
 
 ## Setting up a new customer repo

package/dist/blueprints/GLO_logisticContractVolumeConstraint.d.ts

@@ -3,7 +3,7 @@ export type objLogisticContractVolumeConstraint = {
     fromCountry?: string;
     toCountry?: string;
     period?: string;
-    limit?: string;
+    maxOrders?: string;
     flagActive?: CheckState;
 };
 export declare const GLO_enterLogisticContractVolumeConstraint: (obj: objLogisticContractVolumeConstraint) => void;

package/dist/blueprints/GLO_logisticContractVolumeConstraint.js

@@ -3,6 +3,6 @@ export const GLO_enterLogisticContractVolumeConstraint = (obj) => {
     cy.GLO_popupWindow([formName, 'from_country_id'], obj.fromCountry);
     cy.GLO_popupWindow([formName, 'to_country_id'], obj.toCountry);
     cy.GLO_addInput([formName, 'period'], obj.period);
-    cy.GLO_addInput([formName, 'limit'], obj.limit);
+    cy.GLO_addInput([formName, 'max_orders'], obj.maxOrders);
     cy.GLO_checkbox([formName, 'flag_active'], obj.flagActive);
 };

package/dist/commands/GLO_commands.js

@@ -366,7 +366,10 @@ const waitForProgressBar = () => {
     let attempts = 0;
     const log = Cypress.log({ name: 'checkLoadingIndicator', message: 'Waiting for the progress bar…', autoEnd: false, timeout: 0 });
     const checkStatus = (resolve, reject) => {
-        cy.get('body', { log: false }).then(($body) => {
+        // cy.document(), not cy.get('body'): commands called from inside a .within() block - such as
+        // GLO_clickRowInGrid - would scope that query to the within subject and never find the body.
+        cy.document({ log: false }).then((doc) => {
+            const $body = Cypress.$(doc.body);
             if (!$body.find(progressBarSelector).length) {
                 log.end();
                 resolve();
@@ -1765,12 +1768,14 @@ Cypress.Commands.add('GLO_fillInfieldInGrid', (selector, rowFilter, columnId, va
         return;
     if (typeof rowFilter === 'string') {
         cy.GLO_getAllRowsInGrid().filter(`:contains("${rowFilter}")`).find(`[col-id="${columnId}"]`).click();
+        cy.wait(500); // Else both click and dblclick fire too fast
         cy.GLO_getAllRowsInGrid().filter(`:contains("${rowFilter}")`).find(`[col-id="${columnId}"]`).dblclick();
     }
     else {
         cy.GLO_getElement(selector).within(() => {
             cy.GLO_clickRowInGrid(rowFilter, columnId);
         });
+        cy.wait(500); // Else both click and dblclick fire too fast
         cy.GLO_dblClickRowInGrid(row, selector, rowFilter, columnId, skipCheck);
     }
     cy.get(gridInputType === 'aggrid-texteditor-without-enter' ? gridInput : gridInputType, { timeout: 1000 }).should('exist');

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@globisnv/cypress-core",
-    "version": "0.0.6",
+    "version": "0.0.8",
     "description": "Core building blocks for Globis Cypress E2E tests",
     "license": "UNLICENSED",
     "type": "module",