@glitchr/stickyjs 1.0.45 → 1.0.51

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@glitchr/stickyjs",
-  "version": "1.0.45",
+  "version": "1.0.51",
   "description": "Sticky scroll library",
   "main": "src/index.js",
   "repository": {
@@ -12,4 +12,4 @@
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1"
   }
-}
+}

package/src/js/sticky.js

@@ -677,7 +677,20 @@ $.fn.serializeObject = function () {
         return parseInt(closest);
     }
 
-    Sticky.userScroll = function(el = undefined) { return $(el === undefined ? document.documentElement : el).closestScrollable().prop("user-scroll") ?? true; }
+    Sticky.userScroll = function(el = undefined) {
+        // Defensive: closestScrollable() can return a value without .prop in
+        // some race conditions (transient DOM during transparent.js page
+        // transitions, sticky-scrollpercent triggers fired against detached
+        // nodes). Default to true so the autoscroll falls back to "user is
+        // scrolling, don't auto-advance."
+        try {
+            var $target = $(el === undefined ? document.documentElement : el);
+            if (!$target || !$target.length) return true;
+            var $scroll = $target.closestScrollable && $target.closestScrollable();
+            if (!$scroll || typeof $scroll.prop !== "function") return true;
+            return $scroll.prop("user-scroll") ?? true;
+        } catch (e) { return true; }
+    }
     Sticky.scrollTo = function(dict, callback = function() {}, el = window)
     {
         el = $(el).length ? $(el)[0] : window;
@@ -1147,9 +1160,20 @@ $.fn.serializeObject = function () {
             if(Settings.debug > 1) console.log("Sticky headlines:", $(ids));
 
 
+            // Hoisted out of the filter below. getScrollPadding() runs closestScrollable(),
+            // which walks the whole ancestor chain calling getComputedStyle twice per level
+            // (isScrollableX + isScrollableY), and it does not depend on the element being
+            // filtered - `scroller` is fixed for this whole call. Evaluating it per candidate
+            // put that ancestor walk on every headline candidate on EVERY scroll event, so
+            // the cost grew with the length of the page. Measured on a long article feed, a
+            // 2400px scroll went from ~6200 to ~2650 getComputedStyle calls and from ~4700
+            // to ~3500 scrollHeight/clientHeight reads, cutting the scroll handler's own
+            // time by ~17%.
+            var scrollPaddingTop = Sticky.getScrollPadding(scroller).top + 1;
+
             var elAll = $(ids).filter(function() {
                 if(this === $(Settings.identifier)) return false;
-                return this.getBoundingClientRect().top < Sticky.getScrollPadding(scroller).top + 1;
+                return this.getBoundingClientRect().top < scrollPaddingTop;
             }).toArray().sort(function (el1, el2) {
                 return el1.offsetTop > el2.offsetTop ? -1
                     : (el1.offsetTop < el2.offsetTop ?  1 : 0);