@glissade/cli 0.59.0 → 0.60.0-pre.1

package/dist/cli.js

@@ -82,6 +82,7 @@ function parseCaptionsModeOrFail(raw) {
 const USAGE = `usage:
   gs render <scene-module> [options]
   gs diff <scene-module> --at <t> --against <baseline.dl.json|.png>
+  gs critique <scene-module> [--json]   machine-readable RENDERED diagnostics (OFF_CANVAS/TEXT_OVERFLOW/OCCLUSION) from the DisplayList — the rendered-geometric half of validateScene; samples an integer-frame grid, prints the flat canonically-sorted diagnostics (--json for the raw result)
   gs verify-determinism <scene-module> [--shards <n>] [--against <frames.manifest>] [--range a..b] [--bisect] [--emit <p>]
   gs dev <scene-module> [--record] [--port <n>]
   gs import <lottie.json|asset.svg> [--out <dir>] [--allow-degraded]
@@ -212,7 +213,7 @@ async function main() {
 		process.stdout.write(`${describe().version}\n`);
 		return;
 	}
-	if (command !== "render" && command !== "diff" && command !== "verify-determinism" && command !== "dev" && command !== "import" && command !== "export" && command !== "narrate" && command !== "narration-lint" && command !== "sfx" && command !== "prepare" && command !== "measure-loudness" && command !== "fonts" && command !== "cache" && command !== "mcp" && command !== "build" && command !== "describe" && command !== "migrate" && command !== "repin" && command !== "parity" && command !== "master" && command !== "localize" && command !== "types") {
+	if (command !== "render" && command !== "diff" && command !== "critique" && command !== "verify-determinism" && command !== "dev" && command !== "import" && command !== "export" && command !== "narrate" && command !== "narration-lint" && command !== "sfx" && command !== "prepare" && command !== "measure-loudness" && command !== "fonts" && command !== "cache" && command !== "mcp" && command !== "build" && command !== "describe" && command !== "migrate" && command !== "repin" && command !== "parity" && command !== "master" && command !== "localize" && command !== "types") {
 		console.error(USAGE);
 		process.exit(command === void 0 || command === "help" || command === "--help" ? 0 : 1);
 	}
@@ -653,6 +654,20 @@ async function main() {
 		}
 		return;
 	}
+	if (command === "critique") {
+		const { critiqueCommand } = await import("./critique.js");
+		try {
+			const out = await critiqueCommand({
+				modulePath,
+				json: flags.has("json")
+			});
+			process.stdout.write(`${out.report}\n`);
+			if (out.hasErrors) process.exit(1);
+		} catch (err) {
+			fail(err instanceof Error ? err.message : String(err));
+		}
+		return;
+	}
 	if (command === "verify-determinism") {
 		let frameRange;
 		const rangeFlag = flags.get("range");

package/dist/critique.js

@@ -0,0 +1,53 @@
+import { o as loadSceneModule } from "./render.js";
+import { critique } from "@glissade/scene/diagnostics";
+//#region src/critique.ts
+/**
+* `gs critique <scene-module>` (0.60): machine-readable RENDERED diagnostics from
+* the DisplayList — the rendered-geometric half of `gs describe --lint` /
+* validateScene. Loads the scene, injects the Skia measurer (so TEXT_OVERFLOW
+* measures with the same metrics `gs render` lays out with), runs `critique`, and
+* prints the flat, canonically-sorted diagnostics. `--json` emits the raw result
+* for a machine consumer; exits non-zero iff any diagnostic is `error` severity
+* (only static errors are — the rendered pass emits warnings/info).
+*/
+async function critiqueCommand(opts) {
+	try {
+		const { loadYogaLayoutEngine } = await import("@glissade/scene/layout");
+		await loadYogaLayoutEngine();
+	} catch {}
+	const mod = await loadSceneModule(opts.modulePath);
+	const scene = mod.createScene();
+	const { SkiaBackend } = await import("@glissade/backend-skia");
+	scene.setTextMeasurer(new SkiaBackend(scene.size.w, scene.size.h));
+	const result = critique(scene, mod.timeline);
+	if (opts.json) return {
+		result,
+		report: JSON.stringify(result, null, 2),
+		hasErrors: result.hasErrors
+	};
+	return {
+		result,
+		report: formatCritique(result),
+		hasErrors: result.hasErrors
+	};
+}
+function formatCritique(r) {
+	const lines = [];
+	if (r.renderedSkipped) lines.push(`rendered pass SKIPPED: ${r.renderedSkipReason ?? ""}`);
+	else lines.push(`sampled ${r.sampledFrames} integer-frame grid sample(s).`);
+	if (r.diagnostics.length === 0) {
+		lines.push("ok — no diagnostics (clean scene).");
+		return lines.join("\n");
+	}
+	for (const d of r.diagnostics) {
+		const where = d.node ? ` [${d.node}]` : d.track ? ` [${d.track}]` : "";
+		lines.push(`${d.severity.toUpperCase()} ${d.code}${where} (${d.source ?? "?"}): ${d.message}`);
+	}
+	const errs = r.diagnostics.filter((d) => d.severity === "error").length;
+	const warns = r.diagnostics.filter((d) => d.severity === "warning").length;
+	const infos = r.diagnostics.filter((d) => d.severity === "info").length;
+	lines.push(`\n${errs} error(s), ${warns} warning(s), ${infos} info.`);
+	return lines.join("\n");
+}
+//#endregion
+export { critiqueCommand };

package/dist/describeLint.js

@@ -156,10 +156,20 @@ const EXEMPT_INTERNALS = new Set([
 	"vec2Equals",
 	"vec2Signal",
 	"velocityAt",
-	"validateScene",
-	"resolveAt",
-	"instanceProps",
-	"DIAGNOSTIC_SCHEMA_VERSION"
+	"DIAGNOSTIC_SCHEMA_VERSION",
+	"emitWithIds",
+	"diffDisplayLists",
+	"formatDisplayDiff",
+	"serializeDisplayList",
+	"parseDisplaySnapshot",
+	"DL_SNAPSHOT_VERSION",
+	"auditCacheCold",
+	"collectTextUsages",
+	"collectLocalizedTextUsages",
+	"validateSceneFonts",
+	"nearestId",
+	"levenshtein",
+	"sortDiagnostics"
 ]);
 /**
 * PATTERN-exempt runtime exports (no per-name entry needed): error classes
@@ -208,7 +218,7 @@ function describeLint(manifest, surface, opts = {}) {
 	const callables = /* @__PURE__ */ new Set();
 	for (const name of Object.keys(manifest.nodes)) callables.add(name);
 	for (const h of manifest.helpers) callables.add(h.name);
-	for (const e of manifest.surface ?? []) if (e.kind === "value" && (e.form === "constructor" || e.form === "function")) callables.add(e.name);
+	for (const e of manifest.surface ?? []) if ((e.kind === "value" || e.kind === "diagnostic") && (e.form === "constructor" || e.form === "function")) callables.add(e.name);
 	for (const name of [...callables].sort()) {
 		if (exempt.has(name) || isFn(name)) continue;
 		out.push(present(name) ? {
@@ -269,6 +279,7 @@ async function collectRuntimeSurface(manifest) {
 		"@glissade/core/clips",
 		"@glissade/scene",
 		"@glissade/scene/describe",
+		"@glissade/scene/diagnostics",
 		"@glissade/scene/layout-ctors",
 		"@glissade/scene/path"
 	]);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@glissade/cli",
-  "version": "0.59.0",
+  "version": "0.60.0-pre.1",
   "description": "glissade CLI: headless rendering via backend-skia (+ FFmpeg mux).",
   "license": "Apache-2.0",
   "engines": {
@@ -28,15 +28,15 @@
     "@napi-rs/canvas": "^0.1.65",
     "esbuild": "0.28.0",
     "jiti": "^2.4.2",
-    "@glissade/backend-skia": "0.59.0",
-    "@glissade/core": "0.59.0",
-    "@glissade/interact": "0.59.0",
-    "@glissade/lottie": "0.59.0",
-    "@glissade/narrate": "0.59.0",
-    "@glissade/player": "0.59.0",
-    "@glissade/scene": "0.59.0",
-    "@glissade/sfx": "0.59.0",
-    "@glissade/svg": "0.59.0"
+    "@glissade/backend-skia": "0.60.0-pre.1",
+    "@glissade/core": "0.60.0-pre.1",
+    "@glissade/interact": "0.60.0-pre.1",
+    "@glissade/lottie": "0.60.0-pre.1",
+    "@glissade/narrate": "0.60.0-pre.1",
+    "@glissade/player": "0.60.0-pre.1",
+    "@glissade/scene": "0.60.0-pre.1",
+    "@glissade/sfx": "0.60.0-pre.1",
+    "@glissade/svg": "0.60.0-pre.1"
   },
   "repository": {
     "type": "git",