@gjsify/rolldown-plugin-gjsify 0.22.0 → 0.24.1

package/lib/plugins/process-stub.js

@@ -1,7 +1,18 @@
 import { BUNDLE_URL_BANNER } from './bundle-url-banner.js';
 import { GJS_WELLKNOWN_SYMBOLS_STUB } from './wellknown-symbols-banner.js';
+// Every GJS ambient global is reached through `globalThis.` — NEVER as a bare
+// identifier. The banner shares the module's top-level scope with the bundled
+// code, so a bare `imports` binds to any top-level `const imports` a bundled
+// module declares — and since the banner runs at byte 1, that binding is still
+// in its temporal dead zone: `ReferenceError: can't access lexical declaration
+// 'imports' before initialization`, thrown at load, before a single line of
+// program code runs. `@girs/gjs`'s `gjs.js` declares exactly that
+// (`const imports = globalThis.imports || {}`), so the failure is real and
+// arrives whenever tree-shaking happens to retain that module. It was found
+// via `@gjsify/web-streams`, whose GJS test leg died the moment `@gjsify/utils`
+// became more shakeable — but nothing about it is specific to either package.
 export const GJS_PROCESS_STUB = 'if(typeof globalThis.process==="undefined"){' +
-    'const _s=imports.system,_G=imports.gi.GLib;' +
+    'const _s=globalThis.imports.system,_G=globalThis.imports.gi.GLib;' +
     // process.hrtime needs a `.bigint` property attached to the function
     // itself (Node API shape: `process.hrtime.bigint()` — used by execa,
     // perf-tracking libs, …). Build it as a named local so we can
@@ -21,7 +32,7 @@ export const GJS_PROCESS_STUB = 'if(typeof globalThis.process==="undefined"){' +
     'versions:{},config:{},' +
     'cwd(){return _G.get_current_dir()||"/"},' +
     'exit(c){_s.exit(c??0)},' +
-    'stderr:{write(s){printerr(s)}},stdout:{write(s){print(s)}},stdin:null,' +
+    'stderr:{write(s){globalThis.printerr(s)}},stdout:{write(s){globalThis.print(s)}},stdin:null,' +
     'exitCode:undefined,' +
     'nextTick(fn,...a){Promise.resolve().then(()=>fn(...a))},' +
     'hrtime:_h,' +

package/lib/utils/auto-globals.js

@@ -319,7 +319,12 @@ export async function detectAutoGlobals(analysisOptions, pluginOptions, gjsifyPl
                     ?.GJSIFY_DEBUG_AUTO_GLOBALS) {
                     const path = `/tmp/gjsify-auto-globals-failed-chunk-${i}.mjs`;
                     try {
-                        // eslint-disable-next-line @typescript-eslint/no-require-imports
+                        // Dynamic `import()` on purpose: this is a debug-only
+                        // branch and the module graph should not carry
+                        // `node:fs` for it. (It is NOT a `require` — it never
+                        // was; the rule-disable comment that used to sit here
+                        // named a rule that cannot apply to an import
+                        // expression.)
                         const fs = await import('node:fs');
                         fs.writeFileSync(path, code);
                         console.error(`[gjsify-auto-globals] parse failed on chunk #${i} — wrote ${path} for inspection`);

package/lib/utils/entry-wrapper.js

@@ -7,6 +7,7 @@
 // first, then re-exports the real entry. `\0`-prefixed ids are Rollup's
 // convention for synthetic modules — Rolldown treats them as not-from-disk and
 // skips the default loader.
+import { GJSIFY_VIRTUAL_PREFIX } from './virtual-module-id.js';
 /**
  * If there are side-effect imports to land alongside the user's entry, wrap each
  * entry in a virtual module that imports them first then re-exports the entry.
@@ -22,7 +23,7 @@ export function wrapInputWithSideEffects(input, sideEffects, opts = {}) {
         return { input, plugin: null };
     }
     const userEntries = new Map(); // virtualId → realPath
-    const PREFIX = '\0gjsify-entry:';
+    const PREFIX = `${GJSIFY_VIRTUAL_PREFIX}entry:`;
     function wrap(realPath) {
         const id = PREFIX + realPath;
         userEntries.set(id, realPath);

package/lib/utils/index.d.ts

@@ -6,3 +6,4 @@ export * from './merge.js';
 export { detectFreeGlobals } from './detect-free-globals.js';
 export { resolveGlobalsList, writeRegisterInjectFile } from './scan-globals.js';
 export { inlineStaticReads } from './inline-static-reads.js';
+export { GJSIFY_VIRTUAL_PREFIX, isGjsifyVirtualModuleId } from './virtual-module-id.js';

package/lib/utils/index.js

@@ -6,3 +6,4 @@ export * from './merge.js';
 export { detectFreeGlobals } from './detect-free-globals.js';
 export { resolveGlobalsList, writeRegisterInjectFile } from './scan-globals.js';
 export { inlineStaticReads } from './inline-static-reads.js';
+export { GJSIFY_VIRTUAL_PREFIX, isGjsifyVirtualModuleId } from './virtual-module-id.js';

package/lib/utils/virtual-module-id.d.ts

@@ -0,0 +1,14 @@
+/** Shared prefix of every gjsify-generated (synthetic) module id. */
+export declare const GJSIFY_VIRTUAL_PREFIX = "\0gjsify-";
+/**
+ * Is `id` a module gjsify's own plugins generated (as opposed to a user/npm
+ * source file)?
+ *
+ * Used by `aliasPlugin` to scope the alias tables to REAL source: generated
+ * module bodies name the runtime module they need explicitly and must not be
+ * re-pointed by a user alias or a slot-routing entry.
+ *
+ * @param id A Rolldown module id — typically a `resolveId` `importer`, which is
+ *   `undefined` for entry modules.
+ */
+export declare function isGjsifyVirtualModuleId(id: string | undefined | null): boolean;

package/lib/utils/virtual-module-id.js

@@ -0,0 +1,36 @@
+// The ONE prefix every synthetic module id emitted by a gjsify plugin carries.
+//
+// Rollup/Rolldown convention is that a `\0`-prefixed id is not-from-disk; every
+// gjsify plugin that emits one additionally namespaces it with `gjsify-`
+// (`\0gjsify-entry:`, `\0gjsify-gi-node:`, `\0gjsify-napi-addon:`,
+// `\0gjsify-empty-gjs-import`). Deriving those ids from THIS constant turns that
+// naming habit into an enforced invariant, which matters because the alias layer
+// keys off it: a module whose SOURCE we generated must bind to the RUNTIME's real
+// modules, never to whatever a user `--alias` retargets a specifier onto.
+//
+// Concretely (the bug that motivated this): `gjsGiNodePlugin`'s virtual module
+// emits `import { createRequire } from 'node:module'`. Under the node-gi consumer
+// harness — which builds `--alias node:module=@gjsify/module` to put the polyfill
+// UNDER TEST behind the specifier — that import was rewritten onto the polyfill
+// itself, so the bundle called `@gjsify/module`'s `createRequire` at top level
+// before its lazy GLib namespace proxy existed (`TypeError: Cannot read
+// properties of undefined (reading 'filename_from_uri')`), and past that hit a
+// genuine cycle: the polyfill's Gio-backed CJS loader needs GLib, and GLib is
+// reached through `@gjsify/node-gi/gi` — which is what the virtual module was
+// loading in the first place.
+/** Shared prefix of every gjsify-generated (synthetic) module id. */
+export const GJSIFY_VIRTUAL_PREFIX = '\0gjsify-';
+/**
+ * Is `id` a module gjsify's own plugins generated (as opposed to a user/npm
+ * source file)?
+ *
+ * Used by `aliasPlugin` to scope the alias tables to REAL source: generated
+ * module bodies name the runtime module they need explicitly and must not be
+ * re-pointed by a user alias or a slot-routing entry.
+ *
+ * @param id A Rolldown module id — typically a `resolveId` `importer`, which is
+ *   `undefined` for entry modules.
+ */
+export function isGjsifyVirtualModuleId(id) {
+    return typeof id === 'string' && id.startsWith(GJSIFY_VIRTUAL_PREFIX);
+}

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@gjsify/rolldown-plugin-gjsify",
-    "version": "0.22.0",
+    "version": "0.24.1",
     "description": "Rolldown / Rollup / Vite plugin orchestrator for GJS, Node, and Browser targets",
     "type": "module",
     "main": "lib/index.js",
@@ -55,11 +55,11 @@
     ],
     "license": "MIT",
     "dependencies": {
-        "@gjsify/console": "^0.22.0",
-        "@gjsify/resolve-npm": "^0.22.0",
-        "@gjsify/rolldown-plugin-deepkit": "^0.22.0",
-        "@gjsify/rolldown-plugin-pnp": "^0.22.0",
-        "@gjsify/vite-plugin-blueprint": "^0.22.0",
+        "@gjsify/console": "^0.24.1",
+        "@gjsify/resolve-npm": "^0.24.1",
+        "@gjsify/rolldown-plugin-deepkit": "^0.24.1",
+        "@gjsify/rolldown-plugin-pnp": "^0.24.1",
+        "@gjsify/vite-plugin-blueprint": "^0.24.1",
         "@rollup/pluginutils": "^5.4.0",
         "acorn": "^8.17.0",
         "acorn-walk": "^8.3.5",
@@ -68,7 +68,7 @@
         "sass": "^1.101.0"
     },
     "peerDependencies": {
-        "@gjsify/lightningcss-native": "^0.22.0",
+        "@gjsify/lightningcss-native": "^0.24.1",
         "rolldown": "^1.1.4"
     },
     "peerDependenciesMeta": {