@gjsify/resolve-npm 0.44.0 → 0.45.0

package/lib/runtime-aliases.mjs

@@ -64,8 +64,45 @@ import { existsSync, readdirSync, readFileSync } from 'node:fs';
 import { join, dirname, resolve } from 'node:path';
 import { fileURLToPath } from 'node:url';
 
+/**
+ * The slot values a declaration may use, and the runtimes it may name.
+ *
+ * EXPORTED because they are the CANONICAL lists and every hand-retyped copy of the TARGETS
+ * has drifted: `lib/index.d.ts` denied `nativescript` for the whole life of the 4th slot,
+ * and `scripts/audit-runtimes.mjs` — the gate that would have caught that — carried two
+ * more copies of its own (`REACH_TARGETS`, `diffDeclared`'s `slots`). The SLOT VALUES had
+ * the opposite problem: nothing outside this file listed them, so nothing outside this file
+ * rejected `"Polyfill"` either. Import these; do not retype them. What cannot import them
+ * (the `.d.ts` unions, which are types) is held against them by
+ * `tests/e2e/runtime-slot-declarations`.
+ */
 const VALID_SLOTS = new Set(['polyfill', 'native', 'partial', 'none']);
-const VALID_TARGETS = new Set(['gjs', 'node', 'browser', 'nativescript']);
+// `react-native` is the 5th target and the only one with no `--app` of its own. Not the
+// second: gjsify DOES bundle NativeScript (`--app nativescript`, `app/nativescript.ts`)
+// even though `@nativescript/vite` owns the APPLICATION build there. Metro owns a React
+// Native application's build the same way, and gjsify has no target under it at all, so
+// this slot feeds the ALIAS layer only and `build.ts`'s `choices` stays at four.
+// `gjsify build --dialect react-native` is a DIFFERENT axis: it says what the SOURCE is
+// written in, not what the PACKAGE runs on, so it is not this slot's sibling and the two
+// are never equal.
+const VALID_TARGETS = new Set(['gjs', 'node', 'browser', 'nativescript', 'react-native']);
+
+export { VALID_SLOTS, VALID_TARGETS };
+
+/**
+ * A runtime a package can declare a slot for. The union for JS callers, referenced from
+ * `index.mjs` and from this file's own `@param`s via
+ * `import('./runtime-aliases.mjs').Target`. It absorbs four of the six hand-written copies
+ * this package carried; the other two, in `index.d.ts`, became a second union
+ * (`RuntimeTarget`) on purpose. A `.d.ts` pointing at
+ * `import('./runtime-aliases.mjs').Target` hands every consumer without `allowJs` a TS7016
+ * against our own shipped `lib/` — measured — so one union there costs a compiler flag in
+ * somebody else's tsconfig. `tests/e2e/runtime-slot-declarations` holds `RuntimeTarget`
+ * against `VALID_TARGETS` instead. Six copies are how `index.mjs` still named four targets
+ * one commit after `VALID_TARGETS` gained the fifth.
+ *
+ * @typedef {'gjs'|'node'|'browser'|'nativescript'|'react-native'} Target
+ */
 
 /**
  * Collect the target names for which `exports` declares a `./<target>`
@@ -91,12 +128,13 @@ function collectPlatformEntries(exportsField) {
 
 /** @typedef {'polyfill'|'native'|'partial'|'none'} Slot */
 /**
- * Per-package runtime slot declaration. Quadruplet (gjs / node / browser /
- * nativescript). The legacy "triplet" name is kept on the typedef for
- * minimal churn while NativeScript is being landed; the type is canonically
- * a quadruplet from VALID_TARGETS' perspective.
+ * Per-package runtime slot declaration. Quintuplet (gjs / node / browser /
+ * nativescript / react-native). The legacy "triplet" name is kept on the typedef
+ * for minimal churn; the type is canonically a quintuplet from VALID_TARGETS'
+ * perspective.
  *
- * @typedef {{gjs?:Slot, node?:Slot, browser?:Slot, nativescript?:Slot}} RuntimeTriplet
+ * @typedef {{gjs?:Slot, node?:Slot, browser?:Slot, nativescript?:Slot,
+ *            'react-native'?:Slot}} RuntimeTriplet
  */
 /**
  * @typedef {{name:string, dir:string, runtimes:RuntimeTriplet, hasGlobals:boolean,
@@ -182,13 +220,7 @@ async function ingestPackageDir(dir, out) {
         const json = JSON.parse(raw);
         const name = typeof json.name === 'string' ? json.name : null;
         const runtimes = json?.gjsify?.runtimes;
-        if (
-            name &&
-            name.startsWith('@gjsify/') &&
-            !out.has(name) &&
-            runtimes &&
-            typeof runtimes === 'object'
-        ) {
+        if (name && name.startsWith('@gjsify/') && !out.has(name) && runtimes && typeof runtimes === 'object') {
             /** @type {RuntimeTriplet} */
             const triplet = {};
             for (const t of VALID_TARGETS) {
@@ -218,13 +250,7 @@ function ingestPackageDirSync(dir, out) {
         const json = JSON.parse(raw);
         const name = typeof json.name === 'string' ? json.name : null;
         const runtimes = json?.gjsify?.runtimes;
-        if (
-            name &&
-            name.startsWith('@gjsify/') &&
-            !out.has(name) &&
-            runtimes &&
-            typeof runtimes === 'object'
-        ) {
+        if (name && name.startsWith('@gjsify/') && !out.has(name) && runtimes && typeof runtimes === 'object') {
             /** @type {RuntimeTriplet} */
             const triplet = {};
             for (const t of VALID_TARGETS) {
@@ -367,7 +393,6 @@ function getCacheSync() {
 function warnOnce(key, message) {
     if (_warned.has(key)) return;
     _warned.add(key);
-    // eslint-disable-next-line no-console
     console.warn(`[@gjsify/resolve-npm] ${message}`);
 }
 
@@ -375,7 +400,7 @@ function warnOnce(key, message) {
  * Given a package record + target runtime, resolve the alias target.
  *
  * @param {PackageRecord} rec
- * @param {'gjs'|'node'|'browser'|'nativescript'} target
+ * @param {Target} target
  * @returns {string|null} The alias target specifier, or null if no rewrite applies.
  */
 function resolveSlot(rec, target) {
@@ -447,7 +472,7 @@ function resolveSlot(rec, target) {
  * (callers should `{ ...derived, ...hardcoded }` to preserve current behavior
  * for packages opted out of the triplet model).
  *
- * @param {'gjs'|'node'|'browser'|'nativescript'} target
+ * @param {Target} target
  * @returns {Record<string,string>}
  */
 export function getDerivedAliasesSync(target) {
@@ -468,7 +493,7 @@ export function getDerivedAliasesSync(target) {
  * Async variant of {@link getDerivedAliasesSync} — preferred when callable from
  * an async config hook.
  *
- * @param {'gjs'|'node'|'browser'|'nativescript'} target
+ * @param {Target} target
  * @returns {Promise<Record<string,string>>}
  */
 export async function getDerivedAliases(target) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@gjsify/resolve-npm",
-    "version": "0.44.0",
+    "version": "0.45.0",
     "description": "Resolve NPM package aliases",
     "type": "module",
     "main": "lib/index.mjs",