@gjsify/cli 0.64.5 → 0.64.6
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/cli.gjs.mjs +263 -263
- package/lib/utils/bin-shim.d.ts +16 -5
- package/lib/utils/bin-shim.js +20 -6
- package/lib/utils/install-backend-native.js +39 -1
- package/lib/utils/install-extraneous.d.ts +25 -0
- package/lib/utils/install-extraneous.js +41 -0
- package/lib/utils/ship/app-runtime.d.ts +6 -3
- package/lib/utils/ship/app-runtime.js +28 -13
- package/lib/utils/ship/launcher.js +20 -7
- package/lib/utils/ship/layout.d.ts +23 -0
- package/lib/utils/ship/layout.js +32 -1
- package/lib/utils/ship/node-runtime.js +8 -6
- package/package.json +20 -20
package/lib/utils/bin-shim.d.ts
CHANGED
|
@@ -173,12 +173,23 @@ export declare function buildNativeEnvPreamble(scanRoot: string, bakedDirs?: rea
|
|
|
173
173
|
* cannot go stale the way baking `systemGiLibraryDirs()` in would (a launcher is
|
|
174
174
|
* routinely written before `brew install gtk4`), and it re-derives nothing —
|
|
175
175
|
* four literals from `dyld(1)`, shared with {@link dyldDefaultFallbackDirs}.
|
|
176
|
-
* An inherited value stays AHEAD of it
|
|
177
|
-
* would have searched on its own.
|
|
176
|
+
* An inherited value stays AHEAD of it.
|
|
178
177
|
*
|
|
179
|
-
* NOT the
|
|
180
|
-
*
|
|
181
|
-
* `
|
|
178
|
+
* NOT SUFFICIENT ON ITS OWN, so the `lib/` beside the `gjs` this shim execs is
|
|
179
|
+
* appended: "set to the documented default" is NOT "unset". Measured on macOS 27 / arm64 with Homebrew
|
|
180
|
+
* gjs 1.88.1 and a fresh glib keg: `gjs -c "imports.gi.Gio"` loads with the
|
|
181
|
+
* variable unset and dies with the documented default exported —
|
|
182
|
+
* `Failed to load shared library 'libgjs.0.dylib' referenced by the typelib`,
|
|
183
|
+
* then `Unsupported type void` from Gio's override `_init`. `GjsPrivate-1.0`
|
|
184
|
+
* names GJS's own library by bare leaf, and once the variable is SET dyld only
|
|
185
|
+
* finds it in a listed directory; `gjs`'s rpath names GLib's keg, not its own.
|
|
186
|
+
* That broke every `gjsify` command on an Apple-silicon Mac, `--version`
|
|
187
|
+
* included, until a symlink was planted in GLib's keg by hand (the CI step
|
|
188
|
+
* `Make libgjs resolvable without a DYLD_ variable`) — and a `brew upgrade glib`
|
|
189
|
+
* silently removes it again. `<dir of gjs>/../lib` is where every prefix
|
|
190
|
+
* (Homebrew on either arch, MacPorts) links `libgjs`, resolved at LAUNCH from
|
|
191
|
+
* the same `PATH` lookup the `exec` uses, so it cannot go stale either. It goes
|
|
192
|
+
* LAST: it only has to catch what the defaults miss.
|
|
182
193
|
*/
|
|
183
194
|
export declare function dyldFallbackPreamble(platform: string): string;
|
|
184
195
|
/** POSIX `sh` single-quoting for a launcher's target path. */
|
package/lib/utils/bin-shim.js
CHANGED
|
@@ -444,12 +444,23 @@ export function buildNativeEnvPreamble(scanRoot, bakedDirs = [], target = {}) {
|
|
|
444
444
|
* cannot go stale the way baking `systemGiLibraryDirs()` in would (a launcher is
|
|
445
445
|
* routinely written before `brew install gtk4`), and it re-derives nothing —
|
|
446
446
|
* four literals from `dyld(1)`, shared with {@link dyldDefaultFallbackDirs}.
|
|
447
|
-
* An inherited value stays AHEAD of it
|
|
448
|
-
* would have searched on its own.
|
|
447
|
+
* An inherited value stays AHEAD of it.
|
|
449
448
|
*
|
|
450
|
-
* NOT the
|
|
451
|
-
*
|
|
452
|
-
* `
|
|
449
|
+
* NOT SUFFICIENT ON ITS OWN, so the `lib/` beside the `gjs` this shim execs is
|
|
450
|
+
* appended: "set to the documented default" is NOT "unset". Measured on macOS 27 / arm64 with Homebrew
|
|
451
|
+
* gjs 1.88.1 and a fresh glib keg: `gjs -c "imports.gi.Gio"` loads with the
|
|
452
|
+
* variable unset and dies with the documented default exported —
|
|
453
|
+
* `Failed to load shared library 'libgjs.0.dylib' referenced by the typelib`,
|
|
454
|
+
* then `Unsupported type void` from Gio's override `_init`. `GjsPrivate-1.0`
|
|
455
|
+
* names GJS's own library by bare leaf, and once the variable is SET dyld only
|
|
456
|
+
* finds it in a listed directory; `gjs`'s rpath names GLib's keg, not its own.
|
|
457
|
+
* That broke every `gjsify` command on an Apple-silicon Mac, `--version`
|
|
458
|
+
* included, until a symlink was planted in GLib's keg by hand (the CI step
|
|
459
|
+
* `Make libgjs resolvable without a DYLD_ variable`) — and a `brew upgrade glib`
|
|
460
|
+
* silently removes it again. `<dir of gjs>/../lib` is where every prefix
|
|
461
|
+
* (Homebrew on either arch, MacPorts) links `libgjs`, resolved at LAUNCH from
|
|
462
|
+
* the same `PATH` lookup the `exec` uses, so it cannot go stale either. It goes
|
|
463
|
+
* LAST: it only has to catch what the defaults miss.
|
|
453
464
|
*/
|
|
454
465
|
export function dyldFallbackPreamble(platform) {
|
|
455
466
|
if (platform !== 'darwin')
|
|
@@ -457,7 +468,10 @@ export function dyldFallbackPreamble(platform) {
|
|
|
457
468
|
// `HOME: '$HOME'` on purpose — the shim must expand it at LAUNCH, not bake
|
|
458
469
|
// the writing machine's home directory into every launcher.
|
|
459
470
|
const dirs = dyldDefaultFallbackDirs({ HOME: '$HOME' }).join(':');
|
|
460
|
-
return (`
|
|
471
|
+
return (`gjsify_gjs=$(command -v gjs 2>/dev/null)\n` +
|
|
472
|
+
`DYLD_FALLBACK_LIBRARY_PATH="\${DYLD_FALLBACK_LIBRARY_PATH:+$DYLD_FALLBACK_LIBRARY_PATH:}${dirs}` +
|
|
473
|
+
`\${gjsify_gjs:+:\${gjsify_gjs%/*}/../lib}"\n` +
|
|
474
|
+
`unset gjsify_gjs\n` +
|
|
461
475
|
`export DYLD_FALLBACK_LIBRARY_PATH\n`);
|
|
462
476
|
}
|
|
463
477
|
/** POSIX `sh` single-quoting for a launcher's target path. */
|
|
@@ -72,7 +72,7 @@ import { getCachedPackument, putCachedPackument } from './install-packument-cach
|
|
|
72
72
|
import { assertNativeBackendNodeVersion } from './node-version.js';
|
|
73
73
|
import { buildCmdShim, buildLauncherShims, buildNativeEnvPreamble, buildShLauncher, isGjsBundlePath, parseShebang, pickBinMap, } from './bin-shim.js';
|
|
74
74
|
import { detectNativePackages } from './detect-native-packages.js';
|
|
75
|
-
import { findExtraneous, formatExtraneousError } from './install-extraneous.js';
|
|
75
|
+
import { droppedInstallPaths, findExtraneous, formatExtraneousError } from './install-extraneous.js';
|
|
76
76
|
import { devLinkPath, devLinkRoot } from './dev-link.js';
|
|
77
77
|
import { scanPrefix } from './prune-prefix.js';
|
|
78
78
|
import { badPlatformError, checkPlatform, declaresPlatform, describePlatformTarget, readPlatformForce, resolveHostPlatform, } from './platform-check.js';
|
|
@@ -293,6 +293,12 @@ async function installPackagesNativeLocked(opts, npmrc, log) {
|
|
|
293
293
|
await downloadAndExtractAll(installable, opts.prefix, npmrc, log, opts.signal, progress);
|
|
294
294
|
await linkBins(installable, opts.prefix, log);
|
|
295
295
|
warnMissingNativeBuilds(installable, opts.prefix, log);
|
|
296
|
+
// Only after a resolve that rewrote the lockfile: that is when a placement can
|
|
297
|
+
// be dropped, and the previous lockfile is the record of what this installer
|
|
298
|
+
// put there. After the extract, so a failed download leaves the tree as it was.
|
|
299
|
+
if (resolved && opts.lockfile && existingLock) {
|
|
300
|
+
removeDroppedPackages(opts.prefix, droppedInstallPaths(Object.keys(existingLock.packages), nodes), new Set([...(opts.workspaceNames ?? []), ...(opts.linkedNames ?? [])]), log);
|
|
301
|
+
}
|
|
296
302
|
log('install: done');
|
|
297
303
|
// Top-level requested packages only, so callers can write the resolved version
|
|
298
304
|
// back into package.json (`npm install --save`). From `nodes`, NEVER from
|
|
@@ -300,6 +306,38 @@ async function installPackagesNativeLocked(opts, npmrc, log) {
|
|
|
300
306
|
// downloaded", and a provided package is installed.
|
|
301
307
|
return topLevelResolutions(opts.specs, nodes);
|
|
302
308
|
}
|
|
309
|
+
/**
|
|
310
|
+
* Remove what {@link droppedInstallPaths} planned, and say so in one line.
|
|
311
|
+
*
|
|
312
|
+
* A symlink is never removed (a workspace or `gjsify link` checkout, i.e. the user's
|
|
313
|
+
* sources), and neither is a name a workspace or a dev link provides, whatever its
|
|
314
|
+
* path: the same two guards `extractOne` applies before it overwrites anything.
|
|
315
|
+
*/
|
|
316
|
+
function removeDroppedPackages(prefix, installPaths, providedNames, log) {
|
|
317
|
+
const removed = [];
|
|
318
|
+
for (const installPath of installPaths) {
|
|
319
|
+
if (providedNames.has(nameFromInstallPath(installPath)))
|
|
320
|
+
continue;
|
|
321
|
+
const dir = path.join(prefix, installPath);
|
|
322
|
+
let stat;
|
|
323
|
+
try {
|
|
324
|
+
stat = fs.lstatSync(dir);
|
|
325
|
+
}
|
|
326
|
+
catch {
|
|
327
|
+
continue;
|
|
328
|
+
}
|
|
329
|
+
if (!stat.isDirectory())
|
|
330
|
+
continue;
|
|
331
|
+
fs.rmSync(dir, { recursive: true, force: true });
|
|
332
|
+
removed.push(installPath);
|
|
333
|
+
}
|
|
334
|
+
if (removed.length === 0)
|
|
335
|
+
return;
|
|
336
|
+
log('install: removed %d dropped placement(s): %s', removed.length, removed.join(', '));
|
|
337
|
+
const names = removed.map(nameFromInstallPath);
|
|
338
|
+
const shown = names.slice(0, 5).join(', ') + (names.length > 5 ? `, … ${names.length - 5} more` : '');
|
|
339
|
+
console.log(`gjsify: removed ${removed.length} package(s) the lockfile no longer names (${shown})`);
|
|
340
|
+
}
|
|
303
341
|
/**
|
|
304
342
|
* `--immutable` only: refuse a `node_modules` holding packages the lockfile does not
|
|
305
343
|
* describe, naming every one of them.
|
|
@@ -91,3 +91,28 @@ export declare const EXTRANEOUS_REPORT_LIMIT = 20;
|
|
|
91
91
|
* hand them a command that changes nothing and a refusal that repeats verbatim.
|
|
92
92
|
*/
|
|
93
93
|
export declare function formatExtraneousError(entries: readonly ExtraneousPackage[], prefix: string): string;
|
|
94
|
+
/**
|
|
95
|
+
* Install paths the PREVIOUS lockfile placed and a fresh resolve no longer does —
|
|
96
|
+
* what a plain install DROPPED, and the only thing it removes.
|
|
97
|
+
*
|
|
98
|
+
* THE INCIDENT (2026-10-22). A project removed `@gjsify/gtk-runtime-darwin-*` from its
|
|
99
|
+
* `optionalDependencies`; `gjsify install` rewrote the lockfile without them and left
|
|
100
|
+
* the 0.64.2 copies in `node_modules`. On a Mac every darwin prebuild's rpath prefers
|
|
101
|
+
* that bundle's GLib over Homebrew's, so every build kept dying with `No signal
|
|
102
|
+
* 'context_response' on object 'GVolumeMonitor'` — after the fix, from a dependency
|
|
103
|
+
* the project no longer declared. npm removes such a package; this installer only
|
|
104
|
+
* ever added.
|
|
105
|
+
*
|
|
106
|
+
* WHY THE LOCKFILE DIFF, and not "everything {@link findExtraneous} reports". The tree
|
|
107
|
+
* legitimately holds packages no lockfile names: `ensureProjectGjsEngine` lays the GJS
|
|
108
|
+
* bundler engine down after the install and on purpose keeps it out of the lockfile.
|
|
109
|
+
* Sweeping the undescribed set would delete that engine on every install and fetch it
|
|
110
|
+
* again. A path some earlier lockfile of THIS project placed is this installer's own
|
|
111
|
+
* output, so removing it cannot take anything another writer put there.
|
|
112
|
+
*
|
|
113
|
+
* Nested placements under a dropped root collapse into the root, like
|
|
114
|
+
* {@link findExtraneous}, so the caller removes each directory once.
|
|
115
|
+
*/
|
|
116
|
+
export declare function droppedInstallPaths(previous: Iterable<string>, next: readonly {
|
|
117
|
+
installPath: string;
|
|
118
|
+
}[]): string[];
|
|
@@ -129,3 +129,44 @@ export function formatExtraneousError(entries, prefix) {
|
|
|
129
129
|
'In CI this usually means a cache entry was restored from a DIFFERENT lockfile.',
|
|
130
130
|
].join('\n');
|
|
131
131
|
}
|
|
132
|
+
/**
|
|
133
|
+
* Install paths the PREVIOUS lockfile placed and a fresh resolve no longer does —
|
|
134
|
+
* what a plain install DROPPED, and the only thing it removes.
|
|
135
|
+
*
|
|
136
|
+
* THE INCIDENT (2026-10-22). A project removed `@gjsify/gtk-runtime-darwin-*` from its
|
|
137
|
+
* `optionalDependencies`; `gjsify install` rewrote the lockfile without them and left
|
|
138
|
+
* the 0.64.2 copies in `node_modules`. On a Mac every darwin prebuild's rpath prefers
|
|
139
|
+
* that bundle's GLib over Homebrew's, so every build kept dying with `No signal
|
|
140
|
+
* 'context_response' on object 'GVolumeMonitor'` — after the fix, from a dependency
|
|
141
|
+
* the project no longer declared. npm removes such a package; this installer only
|
|
142
|
+
* ever added.
|
|
143
|
+
*
|
|
144
|
+
* WHY THE LOCKFILE DIFF, and not "everything {@link findExtraneous} reports". The tree
|
|
145
|
+
* legitimately holds packages no lockfile names: `ensureProjectGjsEngine` lays the GJS
|
|
146
|
+
* bundler engine down after the install and on purpose keeps it out of the lockfile.
|
|
147
|
+
* Sweeping the undescribed set would delete that engine on every install and fetch it
|
|
148
|
+
* again. A path some earlier lockfile of THIS project placed is this installer's own
|
|
149
|
+
* output, so removing it cannot take anything another writer put there.
|
|
150
|
+
*
|
|
151
|
+
* Nested placements under a dropped root collapse into the root, like
|
|
152
|
+
* {@link findExtraneous}, so the caller removes each directory once.
|
|
153
|
+
*/
|
|
154
|
+
export function droppedInstallPaths(previous, next) {
|
|
155
|
+
const kept = new Set(next.map((n) => normalizePath(n.installPath)));
|
|
156
|
+
const dropped = [...new Set([...previous].map(normalizePath))]
|
|
157
|
+
.filter((p) => p.startsWith('node_modules/') && !kept.has(p))
|
|
158
|
+
.sort((a, b) => (a < b ? -1 : a > b ? 1 : 0));
|
|
159
|
+
const keptList = [...kept];
|
|
160
|
+
const roots = [];
|
|
161
|
+
for (const p of dropped) {
|
|
162
|
+
const parent = roots[roots.length - 1];
|
|
163
|
+
if (parent && p.startsWith(`${parent}/`))
|
|
164
|
+
continue;
|
|
165
|
+
// A directory still holding a kept placement is not removed whole; its own
|
|
166
|
+
// dropped descendants are still listed, one by one.
|
|
167
|
+
if (keptList.some((k) => k.startsWith(`${p}/`)))
|
|
168
|
+
continue;
|
|
169
|
+
roots.push(p);
|
|
170
|
+
}
|
|
171
|
+
return roots;
|
|
172
|
+
}
|
|
@@ -1,4 +1,4 @@
|
|
|
1
|
-
import type
|
|
1
|
+
import { type Layout, type LayoutIdentity } from './layout.js';
|
|
2
2
|
import { type ResolveInstalledPackageOptions } from '../resolve-npm-package.js';
|
|
3
3
|
import type { StagedFile } from './types.js';
|
|
4
4
|
/**
|
|
@@ -161,8 +161,11 @@ export interface AppRuntimePaths {
|
|
|
161
161
|
/** `<prebuildDir>/node_gi.node` — what `NODE_GI_NATIVE` pins. */
|
|
162
162
|
addonPath: string;
|
|
163
163
|
/**
|
|
164
|
-
* `<App>.app/Contents/
|
|
165
|
-
* launcher
|
|
164
|
+
* `<App>.app/Contents/Helpers/<display name>`, or `<program dir>/node.exe`
|
|
165
|
+
* beside the launcher — darwin names it after the app (`layout.ts`'s
|
|
166
|
+
* `dirs.helpers`) so Activity Monitor and System Events show the app
|
|
167
|
+
* instead of `node`; Windows keeps the interpreter's own release name
|
|
168
|
+
* beside the `.cmd`, where nothing reads a process list by file name.
|
|
166
169
|
*/
|
|
167
170
|
interpreterPath: string;
|
|
168
171
|
/** Node's own LICENSE, under `Contents/Resources` (macOS) or `share/` (Windows). */
|
|
@@ -80,6 +80,7 @@
|
|
|
80
80
|
import { existsSync, readdirSync, statSync } from 'node:fs';
|
|
81
81
|
import { dirname, join, posix, sep } from 'node:path';
|
|
82
82
|
import { listFilesRecursive } from './discover.js';
|
|
83
|
+
import { assertUsableAsHelperName } from './layout.js';
|
|
83
84
|
import { nodeRuntimeBinaryName } from './node-runtime.js';
|
|
84
85
|
import { isExecutableAsset } from './plan.js';
|
|
85
86
|
import { resolveInstalledPackage } from '../resolve-npm-package.js';
|
|
@@ -264,20 +265,34 @@ export function appRuntimePaths(layout, identity, target) {
|
|
|
264
265
|
prebuildDir,
|
|
265
266
|
gtkDir: posix.join(prebuildDir, 'gtk'),
|
|
266
267
|
addonPath: posix.join(prebuildDir, NODE_GI_ADDON_FILENAME),
|
|
267
|
-
// `Contents/
|
|
268
|
-
// because
|
|
269
|
-
//
|
|
270
|
-
//
|
|
271
|
-
//
|
|
272
|
-
//
|
|
268
|
+
// ON DARWIN, `Contents/Helpers/<display name>` — NEVER `Contents/MacOS`,
|
|
269
|
+
// because that directory already holds the launcher at `binaryName`, and
|
|
270
|
+
// APFS is case-insensitive by default: `stamped` and `Stamped` are the
|
|
271
|
+
// same file there, so no capitalisation of `binaryName` can share the
|
|
272
|
+
// directory with it. `Contents/Helpers` is one of Apple's own
|
|
273
|
+
// nested-code locations (`codesign(1)`'s bundle format, beside
|
|
274
|
+
// `Frameworks`, `PlugIns`, `XPCServices`), and naming the leaf after
|
|
275
|
+
// `identity.name` rather than `binaryName` is the whole point: Activity
|
|
276
|
+
// Monitor and System Events read a Mach-O process's name off its own
|
|
277
|
+
// FILE NAME, not off `exec -a` or any argv — measured by hand-editing a
|
|
278
|
+
// released `.app`, moving its interpreter to `Contents/Helpers/<App>`
|
|
279
|
+
// and rewriting the launcher's `exec` line, after which `ps -o comm` and
|
|
280
|
+
// System Events both read the app's name instead of `node`.
|
|
273
281
|
//
|
|
274
|
-
//
|
|
275
|
-
//
|
|
276
|
-
//
|
|
277
|
-
//
|
|
278
|
-
//
|
|
279
|
-
// launcher
|
|
280
|
-
|
|
282
|
+
// Derived from the LAYOUT (`dirs.helpers !== ''`) rather than from
|
|
283
|
+
// `layout.name === 'darwin'`: only the darwin row sets `helpers` to a
|
|
284
|
+
// real directory (`layout.ts`), so this branch is "does this layout have
|
|
285
|
+
// a helpers seam", not a second darwin-specific fact typed out here.
|
|
286
|
+
//
|
|
287
|
+
// ON WINDOWS AND LINUX, unchanged: `dirs.launcher` and the leaf
|
|
288
|
+
// `node-runtime.ts` already decided for the SOURCE file — `node.exe` on
|
|
289
|
+
// win32, read off the TARGET and never `process.platform` (assembling a
|
|
290
|
+
// Windows program directory on Linux is the supported path). A Windows
|
|
291
|
+
// program directory has no launcher-collision to dodge in the first
|
|
292
|
+
// place, so its interpreter stays beside the `.cmd`.
|
|
293
|
+
interpreterPath: dirs.helpers === ''
|
|
294
|
+
? posix.join(dirs.launcher, nodeRuntimeBinaryName(target))
|
|
295
|
+
: posix.join(dirs.helpers, assertUsableAsHelperName(identity.name)),
|
|
281
296
|
// rpm's `share/licenses/<name>/LICENSE` shape, which the `macos-app` row
|
|
282
297
|
// already uses for the app's own licence — one layout for a reader to learn,
|
|
283
298
|
// and `node` is a name no `binaryName` can collide with silently: `placeStage`
|
|
@@ -181,7 +181,16 @@ function renderPrefixLauncher(settings, bundleRelPath, layout) {
|
|
|
181
181
|
* IT EXECS WHAT THE BUNDLE CARRIES. `runtime` comes from
|
|
182
182
|
* `utils/ship/app-runtime.ts` and names the interpreter, the relocated GTK
|
|
183
183
|
* closure and the node-gi addon staged inside `Contents/` — so the exec line is
|
|
184
|
-
* `"$here
|
|
184
|
+
* `"$here/../Helpers/<display name>"` and the two locators below point into
|
|
185
|
+
* `dirs.native`. The interpreter is staged under `Contents/Helpers`, not
|
|
186
|
+
* `Contents/MacOS` beside this very script, and named after `identity.name`
|
|
187
|
+
* rather than kept as `node`: Activity Monitor and System Events read a
|
|
188
|
+
* process's name off the FILE NAME of the Mach-O that is running, not off argv
|
|
189
|
+
* or any `exec -a`, so a bundle whose carried interpreter is still called `node`
|
|
190
|
+
* shows up as `node` everywhere a user looks for it (`layout.ts`'s `dirs.helpers`,
|
|
191
|
+
* `app-runtime.ts`'s `appRuntimePaths`). `beside()` computes the relative hop
|
|
192
|
+
* from the actual two directories rather than assuming a sibling, so this
|
|
193
|
+
* function needs no special case for the rename.
|
|
185
194
|
* When the stage carries none of them every line here is byte-identical to what
|
|
186
195
|
* M2a wrote, which is what keeps a bundle assembled without the runtime packages
|
|
187
196
|
* exactly as (un)usable as it was rather than differently broken.
|
|
@@ -308,10 +317,14 @@ function renderAppBundleLauncher(settings, bundleRelPath, layout, runtime) {
|
|
|
308
317
|
if (settings.fontFiles.length > 0) {
|
|
309
318
|
lines.push(`GJSIFY_FONT_DIR="$contents/${stagedFontDir(under(dirs.data), settings.appId)}"`, 'export GJSIFY_FONT_DIR');
|
|
310
319
|
}
|
|
311
|
-
// `"$here
|
|
312
|
-
// and false of a `.app` a stranger downloads,
|
|
313
|
-
// degraded experience: macOS ships no Node at
|
|
314
|
-
// would be `exec: node: not found`.
|
|
320
|
+
// `"$here/../Helpers/<display name>"`, not a bare `node`. The bare name is
|
|
321
|
+
// true of a developer's machine and false of a `.app` a stranger downloads,
|
|
322
|
+
// and the difference is not a degraded experience: macOS ships no Node at
|
|
323
|
+
// all, so the launcher's first act would be `exec: node: not found`. The path
|
|
324
|
+
// is relative rather than the literal `../Helpers/…` written out, because
|
|
325
|
+
// `beside()` already carries the relation between `dirs.launcher` and
|
|
326
|
+
// wherever `appRuntimePaths` staged the interpreter — this function does not
|
|
327
|
+
// need to know that the leaf changed from `node` to `identity.name`.
|
|
315
328
|
const interpreter = runtime.interpreter === undefined ? undefined : `"$here/${beside(runtime.interpreter)}"`;
|
|
316
329
|
lines.push(`exec ${execLine(layout, `"$contents/${under(dirs.bundle)}/${bundleRelPath}"`, settings, interpreter)} "$@"`, '');
|
|
317
330
|
return lines.join('\n');
|
|
@@ -462,8 +475,8 @@ function windowsPath(rel) {
|
|
|
462
475
|
* `@gjsify/node-runtime-<target>` exists for; this comment used to say "the day a
|
|
463
476
|
* stage carries one, THIS is the line that names it by a layout-relative path
|
|
464
477
|
* instead", and #1354 M2b is that day — `utils/ship/app-runtime.ts` stages the
|
|
465
|
-
* interpreter into `Contents/
|
|
466
|
-
* `"$here
|
|
478
|
+
* interpreter into `Contents/Helpers/<display name>` and the `.app` launcher
|
|
479
|
+
* execs `"$here/../Helpers/<display name>"`.
|
|
467
480
|
*
|
|
468
481
|
* #1354 M3 is the same day one OS over: the Windows layout stages `node.exe` into
|
|
469
482
|
* the program directory and its `.cmd` runs `"%HERE%node.exe"`.
|
|
@@ -128,6 +128,15 @@ export interface LayoutDirs {
|
|
|
128
128
|
* bundle can address it and `codesign` later refuses the bundle.
|
|
129
129
|
*/
|
|
130
130
|
other: string;
|
|
131
|
+
/**
|
|
132
|
+
* macOS only: where a carried interpreter lives when it must NOT be named
|
|
133
|
+
* `binaryName` inside {@link LayoutDirs.launcher} — see
|
|
134
|
+
* `utils/ship/app-runtime.ts`'s `appRuntimePaths`. `''` on linux and windows,
|
|
135
|
+
* where nothing reads it: Linux takes its interpreter from the distribution,
|
|
136
|
+
* and a Windows program directory has no launcher-collision to dodge in the
|
|
137
|
+
* first place, so its interpreter stays beside the `.cmd`.
|
|
138
|
+
*/
|
|
139
|
+
helpers: string;
|
|
131
140
|
}
|
|
132
141
|
/**
|
|
133
142
|
* One operating system's layout.
|
|
@@ -290,6 +299,20 @@ export interface LayoutArches {
|
|
|
290
299
|
* {@link LAYOUTS.linux.icon} for what asked for each of the three.
|
|
291
300
|
*/
|
|
292
301
|
export declare const HICOLOR_RASTER_SIZES: readonly [64, 128, 256];
|
|
302
|
+
/**
|
|
303
|
+
* Refuse an `identity.name` that cannot be the carried interpreter's own file
|
|
304
|
+
* name under `Contents/Helpers` (`dirs.helpers`) — `appRuntimePaths` in
|
|
305
|
+
* `utils/ship/app-runtime.ts` is the only caller.
|
|
306
|
+
*
|
|
307
|
+
* A SUPERSET of {@link BUNDLE_NAME_FORBIDDEN}, not a restatement: the bundle
|
|
308
|
+
* directory wraps the same string in `.app`, so a name of "." or ".." becomes
|
|
309
|
+
* "..app" or "....app" — both ordinary directory names — while this leaf is
|
|
310
|
+
* `identity.name` taken LITERALLY, where "." and ".." name the directory
|
|
311
|
+
* itself and its parent. An empty name and a NUL byte are refused for the same
|
|
312
|
+
* reason `windowsProgramDirName` refuses them one OS over: neither is a name a
|
|
313
|
+
* filesystem can hold.
|
|
314
|
+
*/
|
|
315
|
+
export declare function assertUsableAsHelperName(name: string): string;
|
|
293
316
|
export declare const LAYOUTS: Record<LayoutName, Layout>;
|
|
294
317
|
/** Every layout name, derived from the table so a new row cannot be missed. */
|
|
295
318
|
export declare const LAYOUT_NAMES: LayoutName[];
|
package/lib/utils/ship/layout.js
CHANGED
|
@@ -75,6 +75,28 @@ function appBundleDir(identity) {
|
|
|
75
75
|
}
|
|
76
76
|
return `${identity.name}.app`;
|
|
77
77
|
}
|
|
78
|
+
/**
|
|
79
|
+
* Refuse an `identity.name` that cannot be the carried interpreter's own file
|
|
80
|
+
* name under `Contents/Helpers` (`dirs.helpers`) — `appRuntimePaths` in
|
|
81
|
+
* `utils/ship/app-runtime.ts` is the only caller.
|
|
82
|
+
*
|
|
83
|
+
* A SUPERSET of {@link BUNDLE_NAME_FORBIDDEN}, not a restatement: the bundle
|
|
84
|
+
* directory wraps the same string in `.app`, so a name of "." or ".." becomes
|
|
85
|
+
* "..app" or "....app" — both ordinary directory names — while this leaf is
|
|
86
|
+
* `identity.name` taken LITERALLY, where "." and ".." name the directory
|
|
87
|
+
* itself and its parent. An empty name and a NUL byte are refused for the same
|
|
88
|
+
* reason `windowsProgramDirName` refuses them one OS over: neither is a name a
|
|
89
|
+
* filesystem can hold.
|
|
90
|
+
*/
|
|
91
|
+
export function assertUsableAsHelperName(name) {
|
|
92
|
+
if (name === '' || name === '.' || name === '..' || BUNDLE_NAME_FORBIDDEN.test(name) || name.includes('\u0000')) {
|
|
93
|
+
throw new Error(`gjsify ship: the macOS layout would name the carried interpreter "${name}" under ` +
|
|
94
|
+
'`Contents/Helpers`, and that is not usable as a file name — empty, ".", ".." and anything ' +
|
|
95
|
+
'containing "/", ":", "\\" or a NUL byte are refused. Set `gjsify.ship.name` to the display ' +
|
|
96
|
+
'name you want.');
|
|
97
|
+
}
|
|
98
|
+
return name;
|
|
99
|
+
}
|
|
78
100
|
/**
|
|
79
101
|
* The rasters a row writes its icon from, or nothing for a CLI — and a refusal
|
|
80
102
|
* for an application that arrives without them.
|
|
@@ -117,6 +139,7 @@ export const LAYOUTS = {
|
|
|
117
139
|
native: `lib/${identity.binaryName}/gi`,
|
|
118
140
|
data: 'share',
|
|
119
141
|
other: '',
|
|
142
|
+
helpers: '',
|
|
120
143
|
}),
|
|
121
144
|
// THE RASTERS THE BUILD-TIME READERS OF THE THEME NEED, and the one row
|
|
122
145
|
// whose icon is written as ordinary payload files rather than into a
|
|
@@ -280,6 +303,14 @@ export const LAYOUTS = {
|
|
|
280
303
|
native: `${app}/Contents/Resources/native`,
|
|
281
304
|
data: `${app}/Contents/Resources/share`,
|
|
282
305
|
other: `${app}/Contents/Resources`,
|
|
306
|
+
// Apple's own nested-code location (alongside `Frameworks`,
|
|
307
|
+
// `PlugIns`, `XPCServices` — `codesign(1)`'s bundle format), and the
|
|
308
|
+
// one place `appRuntimePaths` can put the interpreter under a name
|
|
309
|
+
// that is not `binaryName`: `Contents/MacOS` already holds the
|
|
310
|
+
// launcher, and APFS is case-insensitive by default, so a second
|
|
311
|
+
// file there named `<BinaryName>` collides with it bytewise even
|
|
312
|
+
// when the casing differs.
|
|
313
|
+
helpers: `${app}/Contents/Helpers`,
|
|
283
314
|
};
|
|
284
315
|
},
|
|
285
316
|
// The two files that make the directory a BUNDLE. Without `Info.plist`
|
|
@@ -411,7 +442,7 @@ export const LAYOUTS = {
|
|
|
411
442
|
// LOADER: `lib/` is what the launcher prepends to `PATH`, because Windows
|
|
412
443
|
// has no rpath — a DLL is found on `PATH`, in the directory of the image
|
|
413
444
|
// that loaded it, or not at all.
|
|
414
|
-
dirs: () => ({ launcher: '', bundle: 'app', native: 'lib', data: 'share', other: '' }),
|
|
445
|
+
dirs: () => ({ launcher: '', bundle: 'app', native: 'lib', data: 'share', other: '', helpers: '' }),
|
|
415
446
|
// NO METADATA, and one PROGRAM. A Windows installer's metadata lives in the
|
|
416
447
|
// `.msi`'s own tables, not in a file inside the program directory —
|
|
417
448
|
// `msi.ts` puts every such fact in the `Product`/`Package` attributes of the
|
|
@@ -28,12 +28,14 @@
|
|
|
28
28
|
// THE CALLER IS `utils/ship/app-runtime.ts` (#1354 M2b), and this paragraph used
|
|
29
29
|
// to say there was none — "⚠️ NOTHING CALLS THIS YET, outside its own spec … a
|
|
30
30
|
// promise to a caller that does not exist yet". It exists: the macOS layout stages
|
|
31
|
-
// `nodePath` into `Contents/
|
|
32
|
-
// `null`-not-throw contract is what lets that caller
|
|
33
|
-
// find while naming the interpreter package it did
|
|
34
|
-
// caller — the Windows program directory stages
|
|
35
|
-
// both non-Linux rows of the table above are now
|
|
36
|
-
// longer has a "still has none" half to record.
|
|
31
|
+
// `nodePath` into `Contents/Helpers/<display name>` and `licensePath` beside it in
|
|
32
|
+
// `Contents/Resources`, and the `null`-not-throw contract is what lets that caller
|
|
33
|
+
// stage the GTK closure it DID find while naming the interpreter package it did
|
|
34
|
+
// not. #1354 M3 adds the second caller — the Windows program directory stages
|
|
35
|
+
// `node.exe` beside its `.cmd` — so both non-Linux rows of the table above are now
|
|
36
|
+
// used, and this paragraph no longer has a "still has none" half to record.
|
|
37
|
+
// `node.exe` keeps that name verbatim: nothing collides with it on Windows, and
|
|
38
|
+
// only the darwin leaf changed — see `layout.ts`'s `dirs.helpers`.
|
|
37
39
|
//
|
|
38
40
|
// The tests keep the by-name claim honest independently of any caller: they
|
|
39
41
|
// resolve a real installed package out of a throwaway consumer tree holding
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@gjsify/cli",
|
|
3
|
-
"version": "0.64.
|
|
3
|
+
"version": "0.64.6",
|
|
4
4
|
"description": "CLI for Gjsify",
|
|
5
5
|
"type": "module",
|
|
6
6
|
"main": "lib/index.js",
|
|
@@ -142,22 +142,22 @@
|
|
|
142
142
|
"cli"
|
|
143
143
|
],
|
|
144
144
|
"dependencies": {
|
|
145
|
-
"@gjsify/blueprint": "^0.64.
|
|
146
|
-
"@gjsify/buffer": "^0.64.
|
|
147
|
-
"@gjsify/create-app": "^0.64.
|
|
148
|
-
"@gjsify/node-globals": "^0.64.
|
|
149
|
-
"@gjsify/node-polyfills": "^0.64.
|
|
150
|
-
"@gjsify/npm-registry": "^0.64.
|
|
151
|
-
"@gjsify/resolve-npm": "^0.64.
|
|
152
|
-
"@gjsify/rolldown-plugin-gjsify": "^0.64.
|
|
153
|
-
"@gjsify/vite-plugin-blueprint": "^0.64.
|
|
154
|
-
"@gjsify/rolldown-plugin-pnp": "^0.64.
|
|
155
|
-
"@gjsify/semver": "^0.64.
|
|
156
|
-
"@gjsify/tar": "^0.64.
|
|
157
|
-
"@gjsify/tsc": "^0.64.
|
|
158
|
-
"@gjsify/utils": "^0.64.
|
|
159
|
-
"@gjsify/web-polyfills": "^0.64.
|
|
160
|
-
"@gjsify/workspace": "^0.64.
|
|
145
|
+
"@gjsify/blueprint": "^0.64.6",
|
|
146
|
+
"@gjsify/buffer": "^0.64.6",
|
|
147
|
+
"@gjsify/create-app": "^0.64.6",
|
|
148
|
+
"@gjsify/node-globals": "^0.64.6",
|
|
149
|
+
"@gjsify/node-polyfills": "^0.64.6",
|
|
150
|
+
"@gjsify/npm-registry": "^0.64.6",
|
|
151
|
+
"@gjsify/resolve-npm": "^0.64.6",
|
|
152
|
+
"@gjsify/rolldown-plugin-gjsify": "^0.64.6",
|
|
153
|
+
"@gjsify/vite-plugin-blueprint": "^0.64.6",
|
|
154
|
+
"@gjsify/rolldown-plugin-pnp": "^0.64.6",
|
|
155
|
+
"@gjsify/semver": "^0.64.6",
|
|
156
|
+
"@gjsify/tar": "^0.64.6",
|
|
157
|
+
"@gjsify/tsc": "^0.64.6",
|
|
158
|
+
"@gjsify/utils": "^0.64.6",
|
|
159
|
+
"@gjsify/web-polyfills": "^0.64.6",
|
|
160
|
+
"@gjsify/workspace": "^0.64.6",
|
|
161
161
|
"acorn": "^8.17.0",
|
|
162
162
|
"cosmiconfig": "^9.0.2",
|
|
163
163
|
"get-tsconfig": "^4.14.0",
|
|
@@ -166,13 +166,13 @@
|
|
|
166
166
|
"yargs": "^18.0.0"
|
|
167
167
|
},
|
|
168
168
|
"devDependencies": {
|
|
169
|
-
"@gjsify/unit": "^0.64.
|
|
169
|
+
"@gjsify/unit": "^0.64.6",
|
|
170
170
|
"@types/yargs": "^17.0.35",
|
|
171
171
|
"typescript": "^6.0.3"
|
|
172
172
|
},
|
|
173
173
|
"peerDependencies": {
|
|
174
|
-
"@gjsify/oxfmt-native": "^0.64.
|
|
175
|
-
"@gjsify/rolldown-native": "^0.64.
|
|
174
|
+
"@gjsify/oxfmt-native": "^0.64.6",
|
|
175
|
+
"@gjsify/rolldown-native": "^0.64.6"
|
|
176
176
|
},
|
|
177
177
|
"peerDependenciesMeta": {
|
|
178
178
|
"@gjsify/oxfmt-native": {
|