@gjsify/cli 0.51.1 → 0.52.0

package/lib/utils/ship/plist.d.ts

@@ -2,6 +2,8 @@ import type { LayoutMetadataInput } from './layout.js';
 /** Where the two files live inside a bundle. Apple's names, not ours. */
 export declare const BUNDLE_INFO_PLIST = "Contents/Info.plist";
 export declare const BUNDLE_PKGINFO = "Contents/PkgInfo";
+/** Where `CFBundleIconFile` is resolved: the bundle's resources directory, and nowhere else. */
+export declare const BUNDLE_RESOURCES = "Contents/Resources";
 /**
  * Render `Contents/Info.plist`.
  *
@@ -30,19 +32,12 @@ export declare const BUNDLE_PKGINFO = "Contents/PkgInfo";
  * release). Emitting `version` twice would throw the distinction away on the one
  * OS that has a field for it.
  *
- * KEYS DELIBERATELY ABSENT are listed in this module's header. `CFBundleIconFile`
- * is the one a reader will reach for first, and it is absent for a reason that
- * outlives the key: M2a ships NO icon. `png2icns`, `icnsutil` and `iconutil` are
- * all absent from this workstation and from the CI image, so an `.icns` written
- * here could only be read back by a reader written here — `selfReading: true`,
- * which `flatpak.spec.ts` reds. The unblocker is an independent Linux ICNS reader
- * entering the CI image; until one does, the hicolor PNG/SVG the payload already
- * carries stays the only icon, unread on macOS.
+ * KEYS DELIBERATELY ABSENT are listed in this module's header.
  *
  * A TWELFTH KEY, `ATSApplicationFontsPath`, is emitted when the bundle carries
  * faces, and it is the first one here NOT cited to `refs/` — so the exception is
  * stated rather than left to be noticed (ADR 0038). The rule this module opens
- * with exists against DECORATION: the five absent keys are cosmetic, nothing a
+ * with exists against DECORATION: the four absent keys are cosmetic, nothing a
  * reader here can open contains them, and emitting one would be a guess with no
  * observable behind it. This key is a MECHANISM, and its citation is Apple's own
  * *Information Property List Key Reference*, which states the scope in the terms
@@ -51,6 +46,21 @@ export declare const BUNDLE_PKGINFO = "Contents/PkgInfo";
  * app and not for the system as a whole."* The value is a path relative to
  * `Contents/Resources`.
  *
+ * A THIRTEENTH, `CFBundleIconFile`, is the same shape of exception and closes the
+ * gap the previous version of this comment recorded: M2a shipped NO icon because
+ * nothing on Linux could read an `.icns` back. Two things changed. `icns.ts` now
+ * writes the container from rasters `icons.ts` renders through librsvg, and the
+ * readers were measured rather than assumed: CPython `struct` walks the element
+ * table in `verify-app-plist.py` (in CI), Pillow 12.3 opens all ten elements (on
+ * the workstation), `icns2png` reads three of ten and is NOT relied on, and
+ * `iconutil` on macOS is the reader with authority — a VM run, recorded with the
+ * change that lands this key. The citation is the same key reference: *"The name
+ * of the bundle's icon file, located in the Resources folder"*, and the
+ * measurement that motivates it is the released 0.8.0 bundle of one app on macOS
+ * 15.7 with no key, no `.icns` and the generic Finder icon. `CFBundleIconName` is
+ * NOT emitted: it names an asset-catalog entry (`Assets.car`), which this tree
+ * does not produce, and a name with no catalog is a dangling reference.
+ *
  * It is also the only route there is. Pango on macOS is CoreText-backed, GTK is
  * not built against fontconfig on that platform, and
  * `pango_font_map_add_font_file()` answers `G_IO_ERROR_NOT_SUPPORTED` on the
@@ -63,7 +73,7 @@ export declare const BUNDLE_PKGINFO = "Contents/PkgInfo";
  * Pango's CoreText map then holds the family, is unverified here — which is what
  * `Layout.fontGap` says out loud rather than letting a green stage imply.
  */
-export declare function renderInfoPlist(input: LayoutMetadataInput, fontsPath?: string): string;
+export declare function renderInfoPlist(input: LayoutMetadataInput, fontsPath?: string, iconFile?: string): string;
 /**
  * Render `Contents/PkgInfo`: the package type and the signature, eight bytes, no
  * newline.

package/lib/utils/ship/plist.js

@@ -14,8 +14,10 @@
 // (`.github/ship-oracle/verify-modes.py`), and it parses the XML form.
 //
 // EVERY KEY BELOW IS CITED to a file in `refs/` that a real macOS toolchain
-// produced or consumes. Keys that are merely plausible — `CFBundleIconFile`,
-// `LSMinimumSystemVersion`, `NSHighResolutionCapable`, `LSApplicationCategoryType`,
+// produced or consumes, or — for the two MECHANISM keys, `ATSApplicationFontsPath`
+// and `CFBundleIconFile` — to Apple's own key reference plus a measurement on a
+// Mac. Keys that are merely plausible — `LSMinimumSystemVersion`,
+// `NSHighResolutionCapable`, `LSApplicationCategoryType`,
 // `NSHumanReadableCopyright` — are not emitted, because nothing a reader here can
 // open contains them.
 //
@@ -32,6 +34,8 @@
 /** Where the two files live inside a bundle. Apple's names, not ours. */
 export const BUNDLE_INFO_PLIST = 'Contents/Info.plist';
 export const BUNDLE_PKGINFO = 'Contents/PkgInfo';
+/** Where `CFBundleIconFile` is resolved: the bundle's resources directory, and nowhere else. */
+export const BUNDLE_RESOURCES = 'Contents/Resources';
 /**
  * The four-character bundle type of an application, and the signature that says
  * "none".
@@ -139,19 +143,12 @@ function arrayEntry(key, values) {
  * release). Emitting `version` twice would throw the distinction away on the one
  * OS that has a field for it.
  *
- * KEYS DELIBERATELY ABSENT are listed in this module's header. `CFBundleIconFile`
- * is the one a reader will reach for first, and it is absent for a reason that
- * outlives the key: M2a ships NO icon. `png2icns`, `icnsutil` and `iconutil` are
- * all absent from this workstation and from the CI image, so an `.icns` written
- * here could only be read back by a reader written here — `selfReading: true`,
- * which `flatpak.spec.ts` reds. The unblocker is an independent Linux ICNS reader
- * entering the CI image; until one does, the hicolor PNG/SVG the payload already
- * carries stays the only icon, unread on macOS.
+ * KEYS DELIBERATELY ABSENT are listed in this module's header.
  *
  * A TWELFTH KEY, `ATSApplicationFontsPath`, is emitted when the bundle carries
  * faces, and it is the first one here NOT cited to `refs/` — so the exception is
  * stated rather than left to be noticed (ADR 0038). The rule this module opens
- * with exists against DECORATION: the five absent keys are cosmetic, nothing a
+ * with exists against DECORATION: the four absent keys are cosmetic, nothing a
  * reader here can open contains them, and emitting one would be a guess with no
  * observable behind it. This key is a MECHANISM, and its citation is Apple's own
  * *Information Property List Key Reference*, which states the scope in the terms
@@ -160,6 +157,21 @@ function arrayEntry(key, values) {
  * app and not for the system as a whole."* The value is a path relative to
  * `Contents/Resources`.
  *
+ * A THIRTEENTH, `CFBundleIconFile`, is the same shape of exception and closes the
+ * gap the previous version of this comment recorded: M2a shipped NO icon because
+ * nothing on Linux could read an `.icns` back. Two things changed. `icns.ts` now
+ * writes the container from rasters `icons.ts` renders through librsvg, and the
+ * readers were measured rather than assumed: CPython `struct` walks the element
+ * table in `verify-app-plist.py` (in CI), Pillow 12.3 opens all ten elements (on
+ * the workstation), `icns2png` reads three of ten and is NOT relied on, and
+ * `iconutil` on macOS is the reader with authority — a VM run, recorded with the
+ * change that lands this key. The citation is the same key reference: *"The name
+ * of the bundle's icon file, located in the Resources folder"*, and the
+ * measurement that motivates it is the released 0.8.0 bundle of one app on macOS
+ * 15.7 with no key, no `.icns` and the generic Finder icon. `CFBundleIconName` is
+ * NOT emitted: it names an asset-catalog entry (`Assets.car`), which this tree
+ * does not produce, and a name with no catalog is a dangling reference.
+ *
  * It is also the only route there is. Pango on macOS is CoreText-backed, GTK is
  * not built against fontconfig on that platform, and
  * `pango_font_map_add_font_file()` answers `G_IO_ERROR_NOT_SUPPORTED` on the
@@ -172,7 +184,7 @@ function arrayEntry(key, values) {
  * Pango's CoreText map then holds the family, is unverified here — which is what
  * `Layout.fontGap` says out loud rather than letting a green stage imply.
  */
-export function renderInfoPlist(input, fontsPath) {
+export function renderInfoPlist(input, fontsPath, iconFile) {
     const name = assertPlistText(input.name, 'CFBundleName', 'gjsify.ship.name');
     const executable = assertPlistText(input.binaryName, 'CFBundleExecutable', 'gjsify.ship.binaryName');
     const appId = assertPlistText(input.appId, 'CFBundleIdentifier', 'gjsify.ship.appId');
@@ -195,6 +207,11 @@ export function renderInfoPlist(input, fontsPath) {
         stringEntry('CFBundleDevelopmentRegion', 'en'),
         stringEntry('CFBundleDisplayName', name),
         stringEntry('CFBundleExecutable', executable),
+        // Between Executable and Identifier is where the alphabet puts it. Absent,
+        // not empty, for a bundle that carries no icon (`kind: 'cli'`): an empty
+        // name is a file lookup that fails, which macOS answers with the same
+        // generic icon and no diagnostic.
+        ...(iconFile === undefined ? [] : [stringEntry('CFBundleIconFile', iconFile)]),
         stringEntry('CFBundleIdentifier', appId),
         stringEntry('CFBundleInfoDictionaryVersion', '6.0'),
         stringEntry('CFBundleName', name),

package/lib/utils/ship/settings.js

@@ -175,8 +175,9 @@ export function resolveShipSettings(input) {
     const description = descriptionParagraphs(metadata.description) ?? [summary];
     const sections = sectionsFor(metadata.categories);
     if (kind === 'app' && discovered.iconFiles.length === 0) {
-        warnings.push(`gjsify ship: no icon found — the installed app will show a placeholder in menus and app stores. ` +
-            'Point `gjsify.ship.icon` at an SVG (or a directory of sized PNGs).');
+        warnings.push(`gjsify ship: no icon found — the installed app will show a placeholder in menus and app stores ` +
+            'on Linux, and the darwin and windows layouts refuse to stage without one. Point ' +
+            '`gjsify.ship.icon` at an SVG (or a directory of sized PNGs).');
     }
     // Resolved here rather than in the packer, because the packer may run on a
     // host with no `package.json` at all (ADR 0024 § A2) — and because the

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@gjsify/cli",
-    "version": "0.51.1",
+    "version": "0.52.0",
     "description": "CLI for Gjsify",
     "type": "module",
     "main": "lib/index.js",
@@ -131,7 +131,7 @@
         "build:test:node": "node lib/index.js build src/test.mts --app node --outfile dist/test.node.mjs",
         "test:node": "node dist/test.node.mjs",
         "test:bun": "bun dist/test.node.mjs",
-        "test:deno": "deno run -A --no-lock --node-modules-dir=none dist/test.node.mjs",
+        "test:deno": "deno run -A --no-lock --node-modules-dir=none --min-dep-age=0 dist/test.node.mjs",
         "test:cross-runtime": "gjsify run build:test:node && gjsify run test:node && gjsify run test:bun && gjsify run test:deno",
         "test": "gjsify run build:test:node && gjsify run test:node"
     },
@@ -142,21 +142,21 @@
         "cli"
     ],
     "dependencies": {
-        "@gjsify/buffer": "^0.51.1",
-        "@gjsify/create-app": "^0.51.1",
-        "@gjsify/node-globals": "^0.51.1",
-        "@gjsify/node-polyfills": "^0.51.1",
-        "@gjsify/npm-registry": "^0.51.1",
-        "@gjsify/resolve-npm": "^0.51.1",
-        "@gjsify/rolldown-plugin-gjsify": "^0.51.1",
-        "@gjsify/vite-plugin-blueprint": "^0.51.1",
-        "@gjsify/rolldown-plugin-pnp": "^0.51.1",
-        "@gjsify/semver": "^0.51.1",
-        "@gjsify/tar": "^0.51.1",
-        "@gjsify/tsc": "^0.51.1",
-        "@gjsify/utils": "^0.51.1",
-        "@gjsify/web-polyfills": "^0.51.1",
-        "@gjsify/workspace": "^0.51.1",
+        "@gjsify/buffer": "^0.52.0",
+        "@gjsify/create-app": "^0.52.0",
+        "@gjsify/node-globals": "^0.52.0",
+        "@gjsify/node-polyfills": "^0.52.0",
+        "@gjsify/npm-registry": "^0.52.0",
+        "@gjsify/resolve-npm": "^0.52.0",
+        "@gjsify/rolldown-plugin-gjsify": "^0.52.0",
+        "@gjsify/vite-plugin-blueprint": "^0.52.0",
+        "@gjsify/rolldown-plugin-pnp": "^0.52.0",
+        "@gjsify/semver": "^0.52.0",
+        "@gjsify/tar": "^0.52.0",
+        "@gjsify/tsc": "^0.52.0",
+        "@gjsify/utils": "^0.52.0",
+        "@gjsify/web-polyfills": "^0.52.0",
+        "@gjsify/workspace": "^0.52.0",
         "acorn": "^8.17.0",
         "cosmiconfig": "^9.0.2",
         "get-tsconfig": "^4.14.0",
@@ -165,13 +165,13 @@
         "yargs": "^18.0.0"
     },
     "devDependencies": {
-        "@gjsify/unit": "^0.51.1",
+        "@gjsify/unit": "^0.52.0",
         "@types/yargs": "^17.0.35",
         "typescript": "^6.0.3"
     },
     "peerDependencies": {
-        "@gjsify/oxfmt-native": "^0.51.1",
-        "@gjsify/rolldown-native": "^0.51.1"
+        "@gjsify/oxfmt-native": "^0.52.0",
+        "@gjsify/rolldown-native": "^0.52.0"
     },
     "peerDependenciesMeta": {
         "@gjsify/oxfmt-native": {