@gjsify/cli 0.27.0 → 0.28.0

package/lib/bundler-pick.js

@@ -93,13 +93,21 @@ function diagnoseNativeEngine() {
     const facade = path.join(pkgDir, 'lib', 'esm', 'index.js');
     if (!existsSync(facade)) {
         return (`The engine's JS facade is NOT BUILT: ${facade} does not exist.\n` +
-            'It is a BUILD OUTPUT, not something `gjsify install` produces — so a freshly cloned or freshly ' +
-            'installed tree never has it, and every `gjsify build` under GJS fails here until it is built once. ' +
+            'It is a BUILD OUTPUT, so this is almost certainly a clone of the gjsify REPOSITORY rather than a ' +
+            'consumer install: in a clone, node_modules/@gjsify/rolldown-native is a symlink to the workspace ' +
+            'package, whose `lib/` no `gjsify install` produces. An installed package from npm is NOT affected — ' +
+            'the published tarball does contain `lib/esm/index.js` (verified against 0.26.1), so a consumer that ' +
+            'hit this message should report it.\n' +
             'Building it needs a bundler, which is why it cannot bootstrap itself under GJS; the Node CLI entry ' +
-            'does it instead. From the gjsify repo root:\n' +
+            'does it instead. From the gjsify repo root — NOTE both of these REQUIRE Node:\n' +
             '  gjsify run build:infra                          # the full cold-tree chain (recommended)\n' +
             '  node scripts/bootstrap-native-facades.mjs       # just the facades, if the rest is already built\n' +
-            'Both are idempotent and skip already-built facades in seconds.');
+            'Both are idempotent and skip already-built facades in seconds.\n' +
+            'ON A NODE-LESS GJS HOST there is currently no in-repo way out, and saying so is the point — this ' +
+            'message used to recommend those two commands unconditionally, and on such a host BOTH fail (the ' +
+            "second directly, the first at `@gjsify/create-app`'s `node scripts/process-template.mjs`). Until " +
+            'that is closed, seed `lib/` from the published package — which ships it — or from a host that has ' +
+            'Node. Tracked in `status/open-todos.md` ("A Node-less host cannot bootstrap a fresh CLONE").');
     }
     return ('The JS facade is built, so this is the typelib/prebuild lookup failing. Most likely the CLI bundle was ' +
         'invoked DIRECTLY (`gjs -m …/cli.gjs.mjs`, or by executing dist/cli.gjs.mjs), which bypasses the `gjsify` ' +

package/lib/commands/debug.d.ts

@@ -1,6 +1,7 @@
 import type { Command } from '../types/index.js';
 interface DebugCliOptions {
     busName?: string;
+    address?: string;
     profile?: string;
     globals?: string;
     out?: string;

package/lib/commands/debug.js

@@ -43,26 +43,32 @@ function deriveBrowserAppId(name) {
 function hasDep(pkg, name) {
     return Boolean(pkg.dependencies?.[name] || pkg.devDependencies?.[name]);
 }
-function generateEntry(profile, busNameBase, name, version) {
+function generateEntry(profile, busNameBase, name, version, address) {
+    const base = JSON.stringify(busNameBase);
+    // Only emit the option when an address was actually given: an `address:
+    // undefined` in the generated entry would read like a decision, when the
+    // bridge's own precedence (env var → published address file → session bus)
+    // is what should apply.
+    const options = address ? `, { address: ${JSON.stringify(address)} }` : '';
     if (profile === 'storybook') {
         return `// Auto-generated by \`gjsify debug\` — do not edit by hand.
 import { runDevtoolsMcp, storybookProfile } from '@gjsify/devtools-mcp';
 
-await runDevtoolsMcp(storybookProfile(${JSON.stringify(busNameBase)}));
+await runDevtoolsMcp(storybookProfile(${base}${options}));
 `;
     }
     if (profile === 'browser') {
         return `// Auto-generated by \`gjsify debug\` — do not edit by hand.
 import { runDevtoolsMcp, browserProfile } from '@gjsify/devtools-mcp';
 
-await runDevtoolsMcp(browserProfile(${JSON.stringify(busNameBase)}));
+await runDevtoolsMcp(browserProfile(${base}${options}));
 `;
     }
     if (profile === 'cdp') {
         return `// Auto-generated by \`gjsify debug\` — do not edit by hand.
 import { runDevtoolsMcp, cdpProfile } from '@gjsify/devtools-mcp';
 
-await runDevtoolsMcp(cdpProfile(${JSON.stringify(busNameBase)}));
+await runDevtoolsMcp(cdpProfile(${base}${options}));
 `;
     }
     return `// Auto-generated by \`gjsify debug\` — do not edit by hand.
@@ -71,7 +77,7 @@ import { runDevtoolsMcp } from '@gjsify/devtools-mcp';
 await runDevtoolsMcp({
     name: ${JSON.stringify(name)},
     version: ${JSON.stringify(version)},
-    busNameBase: ${JSON.stringify(busNameBase)},
+    busNameBase: ${base},${address ? `\n    address: ${JSON.stringify(address)},` : ''}
 });
 `;
 }
@@ -82,6 +88,12 @@ export const debugCommand = {
         .option('bus-name', {
         description: 'App DBus base name (default: gjsify.devtools.busNameBase, or the storybook app-id)',
         type: 'string',
+    })
+        .option('address', {
+        description: 'Peer D-Bus address of the app (unix:path=… / nonce-tcp:…) instead of the session bus — for ' +
+            'macOS/Windows, which have no session bus. Default: GJSIFY_DEVTOOLS_ADDRESS, then the address ' +
+            'file the app publishes, then the session bus',
+        type: 'string',
     })
         .option('profile', {
         description: 'Tool profile: generic | storybook | browser | cdp (default: auto — storybook if @gjsify/storybook is a dep, browser if @gjsify/devtools-browser is, cdp if @gjsify/devtools-cdp is, else generic)',
@@ -133,9 +145,10 @@ export const debugCommand = {
         mkdirSync(cacheDir, { recursive: true });
         const entryPath = join(cacheDir, 'entry.ts');
         const outPath = args.out ? resolve(cwd, args.out) : join(cacheDir, 'bridge.gjs.mjs');
-        writeFileSync(entryPath, generateEntry(profile, busNameBase, name, version));
+        const address = args.address ?? config.address;
+        writeFileSync(entryPath, generateEntry(profile, busNameBase, name, version, address));
         // stderr only — stdout is the MCP JSON-RPC channel.
-        console.error(`[gjsify debug] profile=${profile} bus=${busNameBase}`);
+        console.error(`[gjsify debug] profile=${profile} bus=${busNameBase}${address ? ` address=${address}` : ''}`);
         // In-process build (runtime-agnostic), then launch with stdio inherited
         // so the bridge's JSON-RPC stdin/stdout are the client's pipes.
         const { runCli } = await import('../cli-app.js');

package/lib/commands/pack.d.ts

@@ -61,6 +61,38 @@ export interface PackWorkspaceOptions {
  * `wsDir` to an absolute path.
  */
 export declare function packWorkspace(wsDir: string, opts?: PackWorkspaceOptions): Promise<PackResult>;
+/**
+ * Walk the workspace and return the list of files to include in the tarball,
+ * relative to `wsDir`. Mirrors npm pack's selection rules:
+ *
+ *   - If pkg.files exists: the array is an ALLOWLIST that overrides
+ *     .gitignore / .npmignore entirely. Every file under an allowlisted
+ *     path/dir ships from disk; only the hardcoded implicit-exclusion set
+ *     (node_modules, .git, lockfiles, … — applied by `walkAll` /
+ *     `expandFilesPatterns`) and npm's always-ignore names are dropped.
+ *     This matches `npm pack`: a `files` entry re-includes a path even when
+ *     .gitignore/.npmignore would drop it (verified against `npm pack
+ *     --dry-run`). Trimming `files`-allowlisted content by .gitignore
+ *     silently dropped build-generated-but-allowlisted files like
+ *     adwaita-web's `src/styles.generated.ts` (gitignored, allowlisted via
+ *     `files: ["src"]`) — shipping a broken tarball whose `src/index.ts`
+ *     imported a file the tarball didn't contain.
+ *   - Otherwise: walk everything, apply .npmignore + .gitignore, drop the
+ *     implicit-exclusion set (node_modules, .git, …)
+ *
+ * package.json, README*, LICENSE*, NOTICE* and the `bin`/`main` files are
+ * always force-included regardless of the rules above.
+ *
+ * EXPORTED because `scripts/verify-tarball-outputs.mjs` — the repo-wide
+ * "is every declared entry point actually in the tarball" post-condition —
+ * must ask THIS function and no other. The packer-glob incident is precisely
+ * what a second oracle costs: `npm pack` expanded `lib/lib*.d.ts` while
+ * `gjsify publish` did not, so a check written against `npm pack --dry-run`
+ * would have been green for the whole v0.4.37–0.7.2 window in which the
+ * published `@gjsify/tsc` shipped an empty `lib/`. The tarballs are produced
+ * here, so the check has to be answered here.
+ */
+export declare function collectPackedFiles(wsDir: string, pkg: Record<string, unknown>): string[];
 /**
  * Collect every `types`/`typings` path a consumer's TypeScript would resolve for
  * this package: the top-level `types`/`typings` fields plus every value under a

package/lib/commands/pack.js

@@ -124,7 +124,7 @@ export async function packWorkspace(wsDir, opts = {}) {
     // default set). The package.json itself is always included with the
     // rewritten contents. We use the post-script `pkgAfterScripts` here so
     // that any `files` array modified by a prepack script is honored.
-    const filesToPack = collectFiles(wsDir, pkgAfterScripts);
+    const filesToPack = collectPackedFiles(wsDir, pkgAfterScripts);
     // Guard against the #655 class of bug: a `types`/`typings` declaration that
     // physically exists in the workspace but is excluded from the tarball by the
     // `files` allowlist. A mass-added `files: ["lib"]` (Phase D.7d, #179) silently
@@ -198,8 +198,17 @@ export async function packWorkspace(wsDir, opts = {}) {
  *
  * package.json, README*, LICENSE*, NOTICE* and the `bin`/`main` files are
  * always force-included regardless of the rules above.
+ *
+ * EXPORTED because `scripts/verify-tarball-outputs.mjs` — the repo-wide
+ * "is every declared entry point actually in the tarball" post-condition —
+ * must ask THIS function and no other. The packer-glob incident is precisely
+ * what a second oracle costs: `npm pack` expanded `lib/lib*.d.ts` while
+ * `gjsify publish` did not, so a check written against `npm pack --dry-run`
+ * would have been green for the whole v0.4.37–0.7.2 window in which the
+ * published `@gjsify/tsc` shipped an empty `lib/`. The tarballs are produced
+ * here, so the check has to be answered here.
  */
-function collectFiles(wsDir, pkg) {
+export function collectPackedFiles(wsDir, pkg) {
     const always = forceIncluded(pkg);
     const filesField = Array.isArray(pkg.files)
         ? pkg.files.filter((f) => typeof f === 'string')

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@gjsify/cli",
-    "version": "0.27.0",
+    "version": "0.28.0",
     "description": "CLI for Gjsify",
     "type": "module",
     "main": "lib/index.js",
@@ -112,7 +112,7 @@
         "clear": "gjsify clear lib dist tsconfig.tsbuildinfo",
         "check": "gjsify tsc --noEmit",
         "start": "node lib/index.js",
-        "build": "tsc && node scripts/build-assets.mjs",
+        "build": "gjsify tsc && node scripts/build-assets.mjs",
         "build:gjs-bundle": "node lib/index.js build src/index.ts --app gjs --outfile dist/cli.gjs.mjs --shebang",
         "build:affected-bundle": "node lib/index.js build src/affected-entry.ts --app gjs --outfile dist/affected.gjs.mjs",
         "build:test:node": "node lib/index.js build src/test.mts --app node --outfile dist/test.node.mjs",
@@ -129,19 +129,19 @@
         "cli"
     ],
     "dependencies": {
-        "@gjsify/buffer": "^0.27.0",
-        "@gjsify/create-app": "^0.27.0",
-        "@gjsify/node-globals": "^0.27.0",
-        "@gjsify/node-polyfills": "^0.27.0",
-        "@gjsify/npm-registry": "^0.27.0",
-        "@gjsify/resolve-npm": "^0.27.0",
-        "@gjsify/rolldown-plugin-gjsify": "^0.27.0",
-        "@gjsify/rolldown-plugin-pnp": "^0.27.0",
-        "@gjsify/semver": "^0.27.0",
-        "@gjsify/tar": "^0.27.0",
-        "@gjsify/tsc": "^0.27.0",
-        "@gjsify/web-polyfills": "^0.27.0",
-        "@gjsify/workspace": "^0.27.0",
+        "@gjsify/buffer": "^0.28.0",
+        "@gjsify/create-app": "^0.28.0",
+        "@gjsify/node-globals": "^0.28.0",
+        "@gjsify/node-polyfills": "^0.28.0",
+        "@gjsify/npm-registry": "^0.28.0",
+        "@gjsify/resolve-npm": "^0.28.0",
+        "@gjsify/rolldown-plugin-gjsify": "^0.28.0",
+        "@gjsify/rolldown-plugin-pnp": "^0.28.0",
+        "@gjsify/semver": "^0.28.0",
+        "@gjsify/tar": "^0.28.0",
+        "@gjsify/tsc": "^0.28.0",
+        "@gjsify/web-polyfills": "^0.28.0",
+        "@gjsify/workspace": "^0.28.0",
         "cosmiconfig": "^9.0.2",
         "get-tsconfig": "^4.14.0",
         "pkg-types": "^2.3.1",
@@ -149,13 +149,13 @@
         "yargs": "^18.0.0"
     },
     "devDependencies": {
-        "@gjsify/unit": "^0.27.0",
+        "@gjsify/unit": "^0.28.0",
         "@types/yargs": "^17.0.35",
         "typescript": "^6.0.3"
     },
     "peerDependencies": {
-        "@gjsify/oxfmt-native": "^0.27.0",
-        "@gjsify/rolldown-native": "^0.27.0"
+        "@gjsify/oxfmt-native": "^0.28.0",
+        "@gjsify/rolldown-native": "^0.28.0"
     },
     "peerDependenciesMeta": {
         "@gjsify/oxfmt-native": {