@gjsify/adwaita-web 0.64.3-next.260 → 0.64.3-next.262

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@gjsify/adwaita-web",
-    "version": "0.64.3-next.260",
+    "version": "0.64.3-next.262",
     "description": "Adwaita/Libadwaita web components for browser targets",
     "type": "module",
     "main": "./src/index.ts",
@@ -58,14 +58,14 @@
         "@codemirror/language": "^6.12.4",
         "@codemirror/state": "^6.7.0",
         "@codemirror/view": "^6.43.4",
-        "@gjsify/adwaita-core": "0.64.3-next.260",
-        "@gjsify/adwaita-fonts": "0.64.3-next.260",
-        "@gjsify/adwaita-icons": "0.64.3-next.260",
-        "@gjsify/gtksource-core": "0.64.3-next.260",
+        "@gjsify/adwaita-core": "0.64.3-next.262",
+        "@gjsify/adwaita-fonts": "0.64.3-next.262",
+        "@gjsify/adwaita-icons": "0.64.3-next.262",
+        "@gjsify/gtksource-core": "0.64.3-next.262",
         "@lezer/highlight": "^1.2.3"
     },
     "peerDependencies": {
-        "@gjsify/app-settings": "0.64.3-next.260"
+        "@gjsify/app-settings": "0.64.3-next.262"
     },
     "peerDependenciesMeta": {
         "@gjsify/app-settings": {
@@ -73,11 +73,11 @@
         }
     },
     "devDependencies": {
-        "@gjsify/app-settings": "0.64.3-next.260",
-        "@gjsify/blueprint": "0.64.3-next.260",
-        "@gjsify/cli": "0.64.3-next.260",
-        "@gjsify/unit": "0.64.3-next.260",
-        "@gjsify/vite-plugin-blueprint": "0.64.3-next.260",
+        "@gjsify/app-settings": "0.64.3-next.262",
+        "@gjsify/blueprint": "0.64.3-next.262",
+        "@gjsify/cli": "0.64.3-next.262",
+        "@gjsify/unit": "0.64.3-next.262",
+        "@gjsify/vite-plugin-blueprint": "0.64.3-next.262",
         "sass": "^1.101.0",
         "typescript": "^6.0.3"
     },
@@ -115,5 +115,5 @@
         "url": "https://github.com/gjsify/gjsify/issues"
     },
     "homepage": "https://github.com/gjsify/gjsify/tree/main/packages/web/adwaita-web#readme",
-    "gitHead": "886de21be840429ce043cdbf8195172530e230d4"
+    "gitHead": "0f5ca82aab25bf9df8d1e790d28483b1f90fe3a9"
 }

package/scss/_link.scss

@@ -1,9 +1,12 @@
 // _link.scss — `link` and `button.link`, libadwaita's link treatment.
 //
-// UNSCOPED, because upstream's rule is on the node and the class together
-// (`_links.scss:1-2`) and both spellings have a reader: a `Gtk.Label` that is a link is
-// the `link` node, and a `Gtk.LinkButton` is `button.link`. `<gtk-link-button>` renders an
-// inner `<button class="adw-button link">`, so the class is what the selector needs.
+// ONLY `button.link`, not a bare `.link`. Upstream's rule names the `link` NODE and
+// `button.link` (`_links.scss:1-2`); the `link` node is the inner node of a `Gtk.Label`'s
+// `<a>` markup, which no element here renders. The `.link` style CLASS on anything but a
+// button is unstyled upstream: `AdwLinkRow` adds it to its row (adw-link-row.c:377), and
+// no rule matches `row.link`, so its title stays in the row's own colour. A bare `.link`
+// here painted the About dialog's link rows blue and underlined. `<gtk-link-button>`
+// renders an inner `<button class="adw-button link">`, which the selector below reads.
 //
 // THE TWO COLOURS ARE THE PALETTE'S, not new tokens: `$link_color: var(--accent-color)`
 // and `$link_visited_color: color-mix(in srgb, var(--accent-color) 80%, var(--view-fg-color))`
@@ -23,6 +26,7 @@
 //
 // Reference: refs/libadwaita/src/stylesheet/widgets/_links.scss:1-49
 // Reference: refs/libadwaita/src/stylesheet/_colors.scss:265-266
+// Reference: refs/libadwaita/src/adw-link-row.c:377 (the row's `.link` class)
 // Reference: refs/gtk/gtk/gtklinkbutton.c:380 (the `.link` style class), :646-672 (the
 //   URI tooltip), :742-749 (the VISITED state flag)
 // Copyright (c) GNOME contributors (libadwaita). LGPLv2.1+.
@@ -33,7 +37,6 @@ $link-color: var(--accent-color);
 $link-visited-color: color-mix(in srgb, var(--accent-color) 80%, var(--view-fg-color));
 $osd-link-color: color-mix(in srgb, var(--accent-bg-color) 50%, white);
 
-.link,
 .adw-button.link {
   color: $link-color;
   text-decoration: underline;

package/src/gtk-link-button.spec.ts

@@ -105,6 +105,20 @@ export const GtkLinkButtonTest = async () => {
             host.remove();
         });
 
+        await it('the link treatment is button.link only — a row with the .link class stays plain', () => {
+            // AdwLinkRow adds `.link` to its row (adw-link-row.c:377) and no upstream rule
+            // matches `row.link`; only the `link` node and `button.link` are styled.
+            const { el, host } = mount({ uri: 'https://example.org/a', label: 'Example' });
+            const row = document.createElement('div');
+            row.classList.add('link');
+            row.textContent = 'Row';
+            host.appendChild(row);
+            expect(getComputedStyle(el.button).textDecorationLine).toBe('underline');
+            expect(getComputedStyle(row).textDecorationLine).toBe('none');
+            expect(getComputedStyle(row).color).toBe(getComputedStyle(host).color);
+            host.remove();
+        });
+
         await it('keeps the link treatment through a re-render of the label', () => {
             const { el, host } = mount({ uri: 'https://example.org/a', label: 'Example', visited: '' });
             el.setAttribute('label', 'Other');