@gjsify/adwaita-web 0.64.1-next.243 → 0.64.1-next.244

package/lib/types/elements/adw-action-row.d.ts

@@ -30,6 +30,7 @@ export declare class AdwActionRow extends HTMLElement {
     set activatableWidget(widget: HTMLElement | null);
     /** Whether a click activates this row — `GtkListBoxRow:activatable`. */
     get activatable(): boolean;
+    constructor();
     connectedCallback(): void;
     /** Copy the declarative attributes into the headless state. */
     private _adoptAttributes;

package/lib/types/elements/adw-bottom-sheet.d.ts

@@ -71,6 +71,7 @@ export declare class AdwBottomSheet extends HTMLElement {
      * a swipe, and the drag handle never closes anything (`resolveBottomSheetClose`).
      */
     requestClose(source: BottomSheetCloseSource): BottomSheetCloseOutcome;
+    constructor();
     connectedCallback(): void;
     attributeChangedCallback(name: string, oldValue: string | null, newValue: string | null): void;
     /** The programmatic open/close — `AdwBottomSheet:open`, ungated by `can-close`. */

package/lib/types/elements/adw-navigation-view.d.ts

@@ -41,6 +41,7 @@ export declare class AdwNavigationView extends HTMLElement {
     get canGoBack(): boolean;
     /** The back button's tooltip — the previous page's title, or null when there is no button. */
     get backButtonTooltip(): string | null;
+    constructor();
     connectedCallback(): void;
     attributeChangedCallback(name: string): void;
     /**

package/lib/types/elements/adw-switch-row.d.ts

@@ -17,6 +17,7 @@ export declare class AdwSwitchRow extends HTMLElement {
     get prefixSection(): HTMLDivElement;
     get active(): boolean;
     set active(value: boolean);
+    constructor();
     connectedCallback(): void;
     attributeChangedCallback(name: string): void;
     /**

package/lib/types/namespace/gtk.d.ts

@@ -72,6 +72,7 @@ export { GtkToggleButton as ToggleButton } from '../elements/gtk-toggle-button.j
 export { GtkTreeExpander as TreeExpander } from '../elements/gtk-tree-expander.js';
 export { GtkVideo as Video } from '../elements/gtk-video.js';
 export { GtkWindow as Window } from '../elements/gtk-window.js';
+export type { WindowCommon } from '@gjsify/adwaita-core';
 export { GtkWindowControls as WindowControls } from '../elements/gtk-window-controls.js';
 export { GtkViewport as Viewport } from '../elements/gtk-viewport.js';
 export { GtkWindowHandle as WindowHandle } from '../elements/gtk-window-handle.js';

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@gjsify/adwaita-web",
-    "version": "0.64.1-next.243",
+    "version": "0.64.1-next.244",
     "description": "Adwaita/Libadwaita web components for browser targets",
     "type": "module",
     "main": "./src/index.ts",
@@ -58,14 +58,14 @@
         "@codemirror/language": "^6.12.4",
         "@codemirror/state": "^6.7.0",
         "@codemirror/view": "^6.43.4",
-        "@gjsify/adwaita-core": "0.64.1-next.243",
-        "@gjsify/adwaita-fonts": "0.64.1-next.243",
-        "@gjsify/adwaita-icons": "0.64.1-next.243",
-        "@gjsify/gtksource-core": "0.64.1-next.243",
+        "@gjsify/adwaita-core": "0.64.1-next.244",
+        "@gjsify/adwaita-fonts": "0.64.1-next.244",
+        "@gjsify/adwaita-icons": "0.64.1-next.244",
+        "@gjsify/gtksource-core": "0.64.1-next.244",
         "@lezer/highlight": "^1.2.3"
     },
     "peerDependencies": {
-        "@gjsify/app-settings": "0.64.1-next.243"
+        "@gjsify/app-settings": "0.64.1-next.244"
     },
     "peerDependenciesMeta": {
         "@gjsify/app-settings": {
@@ -73,11 +73,11 @@
         }
     },
     "devDependencies": {
-        "@gjsify/app-settings": "0.64.1-next.243",
-        "@gjsify/blueprint": "0.64.1-next.243",
-        "@gjsify/cli": "0.64.1-next.243",
-        "@gjsify/unit": "0.64.1-next.243",
-        "@gjsify/vite-plugin-blueprint": "0.64.1-next.243",
+        "@gjsify/app-settings": "0.64.1-next.244",
+        "@gjsify/blueprint": "0.64.1-next.244",
+        "@gjsify/cli": "0.64.1-next.244",
+        "@gjsify/unit": "0.64.1-next.244",
+        "@gjsify/vite-plugin-blueprint": "0.64.1-next.244",
         "sass": "^1.101.0",
         "typescript": "^6.0.3"
     },
@@ -115,5 +115,5 @@
         "url": "https://github.com/gjsify/gjsify/issues"
     },
     "homepage": "https://github.com/gjsify/gjsify/tree/main/packages/web/adwaita-web#readme",
-    "gitHead": "f88c7b1074d454e211094963a9f4dc7d0982bf32"
+    "gitHead": "9a6ca179c1a74477f23791c5b8f6d5a7bffaee61"
 }

package/src/adw-window.spec.ts

@@ -54,6 +54,10 @@ export const AdwWindowTest = async () => {
         });
 
         await it('keeps 360×200 as a minimum and fills the viewport without an authored size', async () => {
+            // The window fills its containing block, which is the viewport only once the
+            // browser's default 8px body margin is gone (an app resets it, the test page does not).
+            const margin = document.body.style.margin;
+            document.body.style.margin = '0';
             const win = makeWindow();
             expect(win.style.minWidth).toBe('360px');
             expect(win.style.minHeight).toBe('200px');
@@ -62,6 +66,7 @@ export const AdwWindowTest = async () => {
             expect(Math.round(win.getBoundingClientRect().width)).toBe(document.documentElement.clientWidth);
             expect(Math.round(win.getBoundingClientRect().height)).toBe(window.innerHeight);
             win.remove();
+            document.body.style.margin = margin;
         });
 
         await it('width-request/height-request override the minimum; gtk-window has none', async () => {
@@ -117,6 +122,8 @@ export const AdwWindowTest = async () => {
 
             win.remove();
             document.body.appendChild(win);
+            // 360 is a MINIMUM, so a 200px box needs the request lowered as well.
+            win.setAttribute('width-request', '100');
             win.setAttribute('width', '200');
             await settle();
 

package/src/application.spec.ts

@@ -53,8 +53,6 @@ const subject: ApplicationSubject = {
 
 export const ApplicationTest = async () => {
     await driveApplicationVectors(subject, { describe, it, expect });
-    // The page is shared with every other suite: a window left in it moves their layout.
-    for (const element of made.splice(0)) element.remove();
 
     await describe('adwaita-web: Application (ADR 0098 § 3)', async () => {
         await it('has a vector for every unlocked vfunc', () => {
@@ -102,7 +100,9 @@ export const ApplicationTest = async () => {
             app.connect('activate', () => app.quit());
             await app.runAsync([]);
             expect(window.isConnected).toBe(false);
-            made.length = 0;
+            made.splice(made.indexOf(window), 1);
         });
     });
+    // The page is shared with every other suite: a window left in it moves their layout.
+    for (const element of made.splice(0)) element.remove();
 };

package/src/elements/adw-action-row.ts

@@ -27,6 +27,7 @@ import { ActionRowState } from '@gjsify/adwaita-core';
 import { bindEmptySections } from '../empty-sections.js';
 import { applyRowTooltip } from '../row-tooltip.js';
 import { bindSlottedChildren } from '../slotted-children.js';
+import { installElementApi } from '../gobject-elements.js';
 import type { DispatchedSignals } from '../signals.js';
 import { type AdwRowActivation, attachRowActivation } from './row-activation.js';
 import { applyRowLineClamp, parseRowLinesAttribute } from '../row-line-clamp.js';
@@ -97,6 +98,11 @@ export class AdwActionRow extends HTMLElement {
         return this._state.activatable;
     }
 
+    constructor() {
+        super();
+        installElementApi(this);
+    }
+
     connectedCallback() {
         if (this._initialized) {
             // Re-entering a document: `disconnectedCallback` dropped the sensitivity

package/src/elements/adw-bottom-sheet.ts

@@ -64,6 +64,7 @@ import type {
 } from '@gjsify/adwaita-core';
 
 import { bindSlottedChildren, type AdwSlot } from '../slotted-children.js';
+import { installElementApi } from '../gobject-elements.js';
 import type { DispatchedSignals } from '../signals.js';
 
 /** The persistent content. Child of <adw-bottom-sheet>; consumed at connect time. */
@@ -209,6 +210,11 @@ export class AdwBottomSheet extends HTMLElement {
         return outcome;
     }
 
+    constructor() {
+        super();
+        installElementApi(this);
+    }
+
     connectedCallback() {
         if (this._initialized) return;
         this._initialized = true;

package/src/elements/adw-navigation-view.ts

@@ -55,6 +55,7 @@ import { BACK_BUTTON_FALLBACK_TOOLTIP, NavigationViewState, describeNavigationDi
 import type { AdwNavigationPageProps, NavigationDiagnostic, NavigationStackChange } from '@gjsify/adwaita-core';
 
 import { bindSlottedChildren } from '../slotted-children.js';
+import { installElementApi } from '../gobject-elements.js';
 import type { DispatchedSignals } from '../signals.js';
 
 /** The page properties the core owns, read off the element's attributes. */
@@ -215,6 +216,11 @@ export class AdwNavigationView extends HTMLElement {
         return this._state.backButtonTooltip();
     }
 
+    constructor() {
+        super();
+        installElementApi(this);
+    }
+
     connectedCallback() {
         if (this._initialized) return;
         this._initialized = true;

package/src/elements/adw-switch-row.ts

@@ -29,6 +29,7 @@ import { SwitchRowState, deriveRowLabels } from '@gjsify/adwaita-core';
 import { bindEmptySections } from '../empty-sections.js';
 import { applyRowTooltip } from '../row-tooltip.js';
 import { bindSlottedChildren } from '../slotted-children.js';
+import { installElementApi } from '../gobject-elements.js';
 import type { DispatchedSignals } from '../signals.js';
 import { applyRowLineClamp, parseRowLinesAttribute } from '../row-line-clamp.js';
 
@@ -75,6 +76,11 @@ export class AdwSwitchRow extends HTMLElement {
         this.toggleAttribute('active', !!value);
     }
 
+    constructor() {
+        super();
+        installElementApi(this);
+    }
+
     connectedCallback() {
         if (this._initialized) return;
         this._initialized = true;

package/src/elements/gtk-window-controls.ts

@@ -280,7 +280,7 @@ export class GtkWindowControls extends HTMLElement {
         if (token === 'maximize') {
             if (!sovereign || !this._windowFlag(window, 'resizable')) return null;
             // :347-350 — the glyph and the label follow the window's state, not the token.
-            const maximized = window.hasAttribute('maximized');
+            const maximized = window.hasAttribute('maximized') && window.getAttribute('maximized') !== 'false';
             return this._controlButton(
                 maximized
                     ? { ...TOKEN_BUTTONS.maximize, icon: RESTORE_ICON_NAME, label: RESTORE_LABEL }

package/src/elements/gtk-window.ts

@@ -281,7 +281,7 @@ export class GtkWindow extends HTMLElement {
     }
 
     private _offByDefault(name: string): boolean {
-        return this.hasAttribute(name);
+        return this.hasAttribute(name) && this.getAttribute(name) !== 'false';
     }
 
     connectedCallback() {

package/src/file-chooser-host.ts

@@ -22,6 +22,7 @@ import {
     dialogFailedError,
     dismissedError,
     fileFilterAccepts,
+    GLibError,
     registerFileChooserDriver,
     type FileChooserDriver,
     type FileChooserHandle,
@@ -207,6 +208,7 @@ function isAbort(error: unknown): boolean {
 
 /** The `Gtk.DialogError` a platform rejection becomes: `AbortError` is the user closing the picker. */
 function dialogRejection(error: unknown) {
+    if (error instanceof GLibError) return error;
     if (isAbort(error)) return dismissedError();
     const e = error as { name?: string; message?: string } | null;
     if (e && typeof e.message === 'string') return dialogFailedError(`${e.name ?? 'Error'}: ${e.message}`);

package/src/file-chooser.spec.ts

@@ -316,11 +316,9 @@ export const FileChooserTest = async () => {
                 const { env, subject } = opfsSubject(dir);
                 subject.script({ basename: 'd.txt' });
                 await withEnv(env, async () => {
-                    const save = new Gtk.FileDialog({ initial_name: 'd.txt' }).save as unknown as (
-                        p: unknown,
-                        c: unknown,
-                    ) => Promise<{ replace_contents_async: unknown }>;
-                    await save(null, null);
+                    const dialog = new Gtk.FileDialog({ initial_name: 'd.txt' });
+                    // Called on the dialog: a detached `save` has no `this`, which is not what is under test.
+                    await (dialog.save as unknown as (p: unknown, c: unknown) => Promise<unknown>)(null, null);
                 });
             } finally {
                 document.createElement = original;

package/src/gtk-font-dialog-button.spec.ts

@@ -124,7 +124,9 @@ export const GtkFontDialogButtonTest = async () => {
             expect(label.style.fontFamily).toBe('');
             el.useFont = true;
             expect(label.style.fontWeight).toBe('700');
-            expect(label.style.fontFamily).toBe('"Cantarell"');
+            // Engines differ on serializing a quoted single-identifier family: Firefox keeps
+            // the quotes, Chromium drops them. The family name is what matters.
+            expect(label.style.fontFamily.replace(/"/g, '')).toBe('Cantarell');
             // `use-size` is false, so `PANGO_FONT_MASK_SIZE` was cleared and there is no size.
             expect(label.style.fontSize).toBe('');
             el.useSize = true;

package/src/gtk-scrolled-window.spec.ts

@@ -185,6 +185,9 @@ export const GtkScrolledWindowTest = async () => {
             // An unknown nick is the pspec's `automatic`, not a silent never.
             el.setAttribute('vscrollbar-policy', 'sideways');
             expect(el.vscrollbarPolicy).toBe('automatic');
+            // AUTOMATIC decides from the adjustment, and the viewport was just held at its
+            // minimum by NEVER: the re-measure that lifts it is a ResizeObserver delivery.
+            await settle();
             expect(bars(el).vertical.hidden).toBe(false);
             host.remove();
         });

package/src/namespace/gtk.ts

@@ -96,6 +96,8 @@ export { GtkToggleButton as ToggleButton } from '../elements/gtk-toggle-button.j
 export { GtkTreeExpander as TreeExpander } from '../elements/gtk-tree-expander.js';
 export { GtkVideo as Video } from '../elements/gtk-video.js';
 export { GtkWindow as Window } from '../elements/gtk-window.js';
+// ADR 0098 Amendment 4: the `Gtk.Window` subset both ports and GJS share, for code that runs on all three.
+export type { WindowCommon } from '@gjsify/adwaita-core';
 export { GtkWindowControls as WindowControls } from '../elements/gtk-window-controls.js';
 export { GtkViewport as Viewport } from '../elements/gtk-viewport.js';
 export { GtkWindowHandle as WindowHandle } from '../elements/gtk-window-handle.js';

package/src/navigation-view.spec.ts

@@ -433,8 +433,8 @@ export const AdwNavigationViewTest = async () => {
     await describe('<adw-navigation-view> GJS-spelled API and declared signals', async () => {
         await it('push_by_tag and get_visible_page_tag follow the camelCase members', () => {
             const { adapter, view, host, page } = mountView();
-            adapter.add(page('root'));
-            adapter.add(page('detail'));
+            adapter.add(page('root'), { tag: 'root' });
+            adapter.add(page('detail'), { tag: 'detail' });
             expect(view.push_by_tag('detail')).toBe(true);
             expect(view.get_visible_page_tag()).toBe('detail');
             host.remove();
@@ -442,8 +442,8 @@ export const AdwNavigationViewTest = async () => {
 
         await it('connects `pushed` and `notify::visible-page`', () => {
             const { adapter, view, host, page } = mountView();
-            adapter.add(page('root'));
-            adapter.add(page('detail'));
+            adapter.add(page('root'), { tag: 'root' });
+            adapter.add(page('detail'), { tag: 'detail' });
             const api = view as unknown as { connect(s: string, h: () => void): number };
             let pushed = 0;
             let visible = 0;