@gjsify/adwaita-web 0.41.0 → 0.42.0

package/src/source-view/theme.ts

@@ -15,9 +15,21 @@ import { EditorView } from '@codemirror/view';
 import { HighlightStyle } from '@codemirror/language';
 import { tags } from '@lezer/highlight';
 
-/** Monospace stack — Adwaita Mono when present, else a portable code font. */
-const MONO_FONT =
-    "'Adwaita Mono', 'Cascadia Code', 'JetBrains Mono', 'Source Code Pro', ui-monospace, 'SF Mono', Menlo, Consolas, monospace";
+/**
+ * Monospace stack — the `--monospace-font-family` token, with its own value
+ * repeated as the `var()` fallback for a page that loads `@gjsify/adwaita-web`'s
+ * stylesheet without the theme tokens.
+ *
+ * It USED to be a second stack, written out here and longer (Cascadia Code,
+ * JetBrains Mono, Source Code Pro, Consolas). Two consequences, both real: the
+ * `stylesheet-font-families` conformance rule reads `.css`/`.scss` only, so a
+ * stack living in a TS string literal was outside every check the repo has; and
+ * on a host with, say, JetBrains Mono but no Adwaita Mono, an `<adw-source-view>`
+ * and a `.monospace` label on the SAME page rendered in DIFFERENT typefaces.
+ * `_variables.scss` is where that stack is argued about (it explains why
+ * 'Cantarell' is dropped from it), so it is where it lives.
+ */
+const MONO_FONT = "var(--monospace-font-family, 'Adwaita Mono', ui-monospace, 'SF Mono', 'Menlo', monospace)";
 
 /** The CodeMirror EditorView theme mapping `.cm-*` chrome to Adwaita tokens. */
 export const adwaitaEditorTheme = EditorView.theme({

package/src/split-button.spec.ts

@@ -19,6 +19,7 @@ import {
 } from '@gjsify/adwaita-core/conformance';
 import type { SplitButtonProperty } from '@gjsify/adwaita-core';
 import type { AdwSplitButton } from './elements/adw-split-button.js';
+import { fallbackMask, maskOf } from './icon-registry.spec.js';
 
 /** The GObject properties the element re-emits as `notify::*` CustomEvents. */
 const NOTIFY_PROPERTIES: readonly SplitButtonProperty[] = [
@@ -160,12 +161,15 @@ export const AdwSplitButtonTest = async () => {
             host.remove();
         });
 
-        await it('keeps a stray icon name out of the class list', () => {
+        await it('turns a stray icon name into the broken glyph, not a stray class', () => {
             const { el, host } = mount({ 'icon-name': 'a b' });
             const icon = actionHalf(el).querySelector('.adw-icon') as HTMLElement;
             // `adw-icon--a b` would have added a second, unrelated `b` class.
             expect(icon.classList.contains('b')).toBe(false);
-            expect(icon.className).toBe('adw-icon');
+            expect(icon.className).toBe('adw-icon adw-icon--image-missing');
+            // The name was GIVEN, so the slot shows what GTK's failed lookup shows —
+            // dropping the class left a visible 16px hole instead.
+            expect(maskOf(icon)).toBe(fallbackMask());
             host.remove();
         });
 

package/src/style-classes.spec.ts

@@ -83,6 +83,12 @@ export const DOCUMENTED_STYLE_CLASSES: Record<string, { shipped: boolean; reason
     monospace: SHIPPED,
     numeric: SHIPPED,
     // Colors
+    // `accent` was missing from this list for as long as it has existed, and not by
+    // judgement: the gate that keeps the list honest read only the doc's BACKTICK
+    // spelling, and `.accent` is the one class upstream writes as `<tt>.accent</tt>`
+    // (style-classes.md:368). It has always been implemented (`scss/_labels.scss:53`);
+    // what was missing was anything that would notice if it stopped being.
+    accent: SHIPPED,
     error: SHIPPED,
     warning: SHIPPED,
     success: SHIPPED,