@gjsify/adwaita-web 0.40.0 → 0.42.0

package/src/elements/adw-about-dialog.ts

@@ -68,6 +68,7 @@ import {
 } from '@gjsify/adwaita-core';
 
 import { createAdwIcon } from './adw-icon.js';
+import { AdwModalSurface } from './modal-surface.js';
 
 /** A template label with its mnemonic marker removed — this renderer has no accelerator layer. */
 function rowLabel(key: keyof typeof ADW_ABOUT_DIALOG_LABELS): string {
@@ -80,6 +81,7 @@ export class AdwAboutDialog extends HTMLElement {
     // Layout nodes (rebuilt from attributes on each render).
     private _scrimEl!: HTMLDivElement;
     private _sheetEl!: HTMLDivElement;
+    private _modal!: AdwModalSurface;
     private _navView!: HTMLElement;
     private _scrollEl!: HTMLDivElement;
     private _mainToolbarEl!: HTMLDivElement;
@@ -260,8 +262,6 @@ export class AdwAboutDialog extends HTMLElement {
 
         this._sheetEl = document.createElement('div');
         this._sheetEl.className = 'adw-about-dialog-sheet';
-        this._sheetEl.setAttribute('role', 'dialog');
-        this._sheetEl.setAttribute('aria-modal', 'true');
         // AdwDialog:title, whose template default is the bare word. The application
         // name is announced by the title-1 label inside, exactly as the header
         // revealer shows it separately in GTK.
@@ -269,12 +269,15 @@ export class AdwAboutDialog extends HTMLElement {
 
         this.replaceChildren(this._scrimEl, this._sheetEl);
 
-        // Escape dismisses while open (mirrors AdwDialog's close shortcut).
-        this.addEventListener('keydown', (event) => {
-            if (event.key === 'Escape' && this.open) {
-                event.stopPropagation();
-                this.close();
-            }
+        // The role, `aria-modal`, Escape, the Tab trap and the return-focus. No
+        // `initialFocus`: the sheet itself is the fallback, which is what this element
+        // used to focus by hand, and the navigation view's first control is better.
+        this._modal = new AdwModalSurface({
+            host: this,
+            surface: this._sheetEl,
+            role: 'dialog',
+            isOpen: () => this.open,
+            onEscape: () => this.close(),
         });
 
         this._render();
@@ -301,8 +304,9 @@ export class AdwAboutDialog extends HTMLElement {
             nav.replace?.(['main']);
             this._scrollEl.scrollTop = 0;
             this._updateHeaderTitle();
-            // Move focus into the sheet for keyboard dismissal.
-            requestAnimationFrame(() => this._sheetEl.focus());
+            this._modal.present();
+        } else {
+            this._modal.dismiss();
         }
     }
 
@@ -352,7 +356,6 @@ export class AdwAboutDialog extends HTMLElement {
         if (visibility.legalRow) this._navView.append(this._buildLegalPage());
 
         this._sheetEl.replaceChildren(this._navView);
-        this._sheetEl.tabIndex = -1;
 
         this.classList.toggle('open', this.open);
     }
@@ -382,10 +385,11 @@ export class AdwAboutDialog extends HTMLElement {
         header.setAttribute('title', headerTitle);
 
         if (showClose) {
-            // The close button — drawn with a CSS "×" glyph, the same approach as
-            // adw-tab-view's close affordance: `window-close` has no mask class,
-            // because it is not in the ICONS map in `scripts/build-scss.mjs` that
-            // generates them (`@gjsify/adwaita-icons` does export the SVG).
+            // The close button — drawn with a CSS "×" glyph, the same approach and the
+            // same reason as adw-tab-view's close affordance: `window-close` IS compiled
+            // and does have a mask class; what differs from upstream's
+            // `window-close-symbolic` (adw-sheet-controls.c:118) is the button size this
+            // header budgets for it.
             const close = document.createElement('button');
             close.type = 'button';
             close.className = 'adw-button flat circular adw-about-dialog-close';
@@ -430,9 +434,11 @@ export class AdwAboutDialog extends HTMLElement {
 
         // Only when one was given: GTK hides the image outright for an empty icon
         // name, and a generic glyph would show an icon for an application that asked
-        // for none. A reverse-DNS application id (`org.gnome.Builder`) is not one CSS
-        // token and resolves to no glyph rather than to three stray classes — see
-        // `normalizeIconName`.
+        // for none. A reverse-DNS application id (`org.gnome.Builder`) — what
+        // `adw_about_dialog_new_from_appdata` hands to `set_application_icon` in
+        // refs/libadwaita/src/adw-about-dialog.c — is not one CSS token, so it draws
+        // `image-missing` rather than three stray classes; that is also what GTK draws for
+        // it on a machine without the app installed.
         if (visibility.appIcon) {
             body.appendChild(createAdwIcon(this.applicationIcon, 'adw-about-dialog-icon'));
         }

package/src/elements/adw-action-row.ts

@@ -16,6 +16,9 @@
 
 import { ActionRowState } from '@gjsify/adwaita-core';
 
+import { bindEmptySections } from '../empty-sections.js';
+import { type AdwRowActivation, attachRowActivation } from './row-activation.js';
+
 /**
  * Attributes whose change means the activatable widget's sensitivity may have
  * changed. `disabled` is the DOM's `GtkWidget:sensitive` for form controls;
@@ -39,6 +42,8 @@ export class AdwActionRow extends HTMLElement {
     /** Watches the activatable widget's `disabled`/`aria-disabled` — the live binding. */
     private _sensitivityObserver: MutationObserver | null = null;
     private _initialized = false;
+    /** Tab stop + Enter/Space, re-derived whenever `activatable` moves. */
+    private _activation?: AdwRowActivation;
 
     static get observedAttributes() {
         return ['title', 'subtitle', 'activatable'];
@@ -105,12 +110,20 @@ export class AdwActionRow extends HTMLElement {
         for (const child of suffixChildren) this._suffixEl.appendChild(child);
 
         this.replaceChildren(this._prefixEl, textEl, this._suffixEl);
+        // `_render` runs from `attributeChangedCallback`, which a control appended into
+        // `suffixSection` never triggers — the section stayed `hidden` and the control
+        // measured 0x0. The observer is what keeps the two sections in step with what
+        // they actually hold.
+        bindEmptySections(this._prefixEl, this._suffixEl);
         // `attributeChangedCallback` was guarded until now, so a parsed row would
         // otherwise start with a stale state.
         this._adoptAttributes();
         this._render();
 
         this.addEventListener('click', (event) => this._onClick(event));
+        // Only while `activatable` — a plain action row is a label, and a label that
+        // takes Tab makes every static row in a group a stop.
+        this._activation = attachRowActivation({ row: this, activatable: () => this._state.activatable });
     }
 
     /** Copy the declarative attributes into the headless state. */
@@ -178,9 +191,8 @@ export class AdwActionRow extends HTMLElement {
         this._titleEl.hidden = !titleVisible;
         this._subtitleEl.textContent = subtitle;
         this._subtitleEl.hidden = !subtitleVisible;
-        this._prefixEl.hidden = this._prefixEl.childElementCount === 0;
-        this._suffixEl.hidden = this._suffixEl.childElementCount === 0;
         this.classList.toggle('activatable', this._state.activatable);
+        this._activation?.sync();
     }
 }
 

package/src/elements/adw-alert-dialog.ts

@@ -44,6 +44,9 @@
 import { AdwAlertResponses } from '@gjsify/adwaita-core';
 import type { AdwResponseAppearance } from '@gjsify/adwaita-core';
 
+import { bindEmptySections } from '../empty-sections.js';
+import { AdwModalSurface } from './modal-surface.js';
+
 /** Response button appearance — mirrors Adw.ResponseAppearance. */
 export type { AdwResponseAppearance } from '@gjsify/adwaita-core';
 
@@ -67,6 +70,7 @@ export class AdwAlertDialog extends HTMLElement {
     private _bodyEl!: HTMLParagraphElement;
     private _childEl!: HTMLDivElement;
     private _responseAreaEl!: HTMLDivElement;
+    private _modal!: AdwModalSurface;
 
     /** The headless response registry + default/close semantics + resolution (ADR 0004). */
     private _model = new AdwAlertResponses();
@@ -149,10 +153,17 @@ export class AdwAlertDialog extends HTMLElement {
 
         this._dialogEl = document.createElement('div');
         this._dialogEl.className = 'adw-alert-dialog-box';
-        this._dialogEl.setAttribute('role', 'alertdialog');
-        this._dialogEl.setAttribute('aria-modal', 'true');
         // Clicks inside the box must not bubble to the scrim's dismiss handler.
         this._dialogEl.addEventListener('click', (event) => event.stopPropagation());
+        // The role, `aria-modal`, Escape, the Tab trap and the return-focus.
+        this._modal = new AdwModalSurface({
+            host: this,
+            surface: this._dialogEl,
+            role: 'alertdialog',
+            isOpen: () => this.open,
+            onEscape: () => this._dismiss(),
+            initialFocus: (focusables) => this._initialFocusTarget(focusables),
+        });
 
         const messageArea = document.createElement('div');
         messageArea.className = 'adw-alert-dialog-message';
@@ -168,6 +179,9 @@ export class AdwAlertDialog extends HTMLElement {
         for (const child of extraChildren) this._childEl.appendChild(child);
 
         messageArea.append(this._headingEl, this._bodyEl, this._childEl);
+        // `_render` runs from `attributeChangedCallback` and from the response API, and
+        // an extra child appended after connect triggers neither.
+        bindEmptySections(this._childEl);
 
         this._responseAreaEl = document.createElement('div');
         this._responseAreaEl.className = 'adw-alert-dialog-responses';
@@ -175,15 +189,6 @@ export class AdwAlertDialog extends HTMLElement {
         this._dialogEl.append(messageArea, this._responseAreaEl);
         this.replaceChildren(this._scrimEl, this._dialogEl);
 
-        // Escape dismisses the dialog when open (the AdwDialog Escape shortcut →
-        // close-response).
-        this.addEventListener('keydown', (event) => {
-            if (event.key === 'Escape' && this.open) {
-                event.stopPropagation();
-                this._dismiss();
-            }
-        });
-
         for (const el of declared) {
             const id = el.getAttribute('id');
             if (!id) continue;
@@ -217,7 +222,8 @@ export class AdwAlertDialog extends HTMLElement {
             this.dispatchEvent(new CustomEvent('notify::body', { bubbles: true, detail: { body: this.body } }));
         } else if (name === 'open') {
             this.dispatchEvent(new CustomEvent('notify::open', { bubbles: true, detail: { open: this.open } }));
-            if (this.open) this._focusInitial();
+            if (this.open) this._modal.present();
+            else this._modal.dismiss();
         }
     }
 
@@ -351,14 +357,29 @@ export class AdwAlertDialog extends HTMLElement {
         this.dispatchEvent(new CustomEvent('response', { bubbles: true, detail: { response } }));
     }
 
-    /** Move focus to the default response button (or the first enabled one). */
-    private _focusInitial(): void {
+    /**
+     * Where a presented alert puts focus, in the three steps `adw_alert_dialog_grab_focus`
+     * takes (refs/libadwaita/src/adw-alert-dialog.c:382): the CONTENT first
+     * (`adw_widget_grab_focus_child (priv->scrolled_window)`, :397), then the default
+     * widget (:406), then the first response whose `enabled` is set (:413). The default
+     * response is rarely the first button — a destructive alert opens on Cancel — and
+     * content beats it: an alert carrying an entry is answered by typing into it.
+     *
+     * `focusables` is the surface's own list, so what "focusable" means is decided once.
+     */
+    private _initialFocusTarget(focusables: readonly HTMLElement[]): HTMLElement | undefined {
+        return focusables.find((el) => this._childEl.contains(el)) ?? this._defaultResponseButton();
+    }
+
+    /** The default response button, or the first enabled one. */
+    private _defaultResponseButton(): HTMLElement | undefined {
         const defaultId = this._model.defaultResponse;
         const firstEnabledId = this._model.responses.find((response) => response.enabled)?.id;
-        const target =
-            (defaultId ? this._buttons.get(defaultId) : undefined) ??
-            (firstEnabledId ? this._buttons.get(firstEnabledId) : undefined);
-        target?.focus();
+        // The enabled check covers the DEFAULT too: `focus()` on a disabled button is a
+        // no-op, so handing one back left the dialog open with focus outside itself.
+        const defaultButton =
+            defaultId !== null && this._model.getResponseEnabled(defaultId) ? this._buttons.get(defaultId) : undefined;
+        return defaultButton ?? (firstEnabledId ? this._buttons.get(firstEnabledId) : undefined);
     }
 
     private _render(): void {
@@ -372,8 +393,6 @@ export class AdwAlertDialog extends HTMLElement {
         this._bodyEl.textContent = body;
         this._bodyEl.hidden = body.length === 0;
 
-        this._childEl.hidden = this._childEl.childElementCount === 0;
-
         // Horizontal only when prefer-wide-layout is set AND there are at most two
         // responses — the AdwAlertDialog heuristic for keeping wide buttons readable.
         const horizontal = this.preferWideLayout && this._model.responses.length <= 2;

package/src/elements/adw-button-row.ts

@@ -22,6 +22,7 @@
 import { BUTTON_ROW_ACTIVATABLE, ButtonRowState } from '@gjsify/adwaita-core';
 
 import { type AdwIcon, createAdwIcon } from './adw-icon.js';
+import { attachRowActivation } from './row-activation.js';
 
 export class AdwButtonRow extends HTMLElement {
     private _contentsEl!: HTMLDivElement;
@@ -58,6 +59,8 @@ export class AdwButtonRow extends HTMLElement {
         this.addEventListener('click', () => {
             this.dispatchEvent(new CustomEvent('activated', { bubbles: true }));
         });
+        // `BUTTON_ROW_ACTIVATABLE`, not an attribute read: there is no opt-out to read.
+        attachRowActivation({ row: this, activatable: () => BUTTON_ROW_ACTIVATABLE });
     }
 
     attributeChangedCallback() {

package/src/elements/adw-carousel.ts

@@ -27,7 +27,7 @@
 // Copyright (c) GNOME contributors (libadwaita). LGPLv2.1+.
 // Modifications: Implemented as Web Components for @gjsify/adwaita-web.
 
-import { CarouselState } from '@gjsify/adwaita-core';
+import { CarouselState, carouselPageAllocation } from '@gjsify/adwaita-core';
 import type { CarouselScrollRequest, CarouselScrollSource, CarouselStateChange } from '@gjsify/adwaita-core';
 
 /** Common surface an indicator binds to. The concrete element is AdwCarousel. */
@@ -79,12 +79,21 @@ export class AdwCarousel extends HTMLElement implements CarouselHost {
     /** A declared `position` waiting for the track to have a width. */
     private _pendingPosition: number | null = null;
     private _pendingLayout: ResizeObserver | undefined;
+    /** Watches the carousel's own width, which caps the page size. */
+    private _layoutObserver: ResizeObserver | undefined;
     /**
      * `interactive` for the scroll now in flight: the flag of the request that
      * started it, or `null` for a scroll we did not start — which is a user drag,
      * and therefore interactive.
      */
     private _pendingInteractive: boolean | null = null;
+    /**
+     * The page an issued scroll is travelling TO, `null` once it has arrived:
+     * `self->animation_target_child`. Held as the page's ID and not its index, for the
+     * same reason C holds a widget, since an insert or a reorder in between moves the
+     * index while the target page stays the target.
+     */
+    private _scrollTargetId: string | null = null;
 
     static get observedAttributes() {
         return ['allow-scroll-wheel', 'allow-long-swipes', 'interactive', 'spacing', 'position'];
@@ -159,7 +168,13 @@ export class AdwCarousel extends HTMLElement implements CarouselHost {
     }
 
     connectedCallback() {
-        if (this._initialized) return;
+        if (!this._initialized) this._build();
+        // Re-armed on every connect, because `disconnectedCallback` drops it: a
+        // carousel moved into another parent has a new width to follow.
+        this._observeLayout();
+    }
+
+    private _build(): void {
         this._initialized = true;
 
         this._trackEl = document.createElement('div');
@@ -200,6 +215,28 @@ export class AdwCarousel extends HTMLElement implements CarouselHost {
         // A pending declared position watches the track for its first layout; a
         // carousel removed before that must not keep the observer alive.
         this._cancelPendingPosition();
+        this._layoutObserver?.disconnect();
+        this._layoutObserver = undefined;
+    }
+
+    /**
+     * Re-run the page allocation whenever the carousel's own width changes: the page
+     * size is capped by it, so a resize can turn a peek into a full-width page and back.
+     */
+    private _observeLayout(): void {
+        if (this._layoutObserver) return;
+        this._layoutObserver = new ResizeObserver(() => {
+            // Only when the PITCH changed. The scroll offset is `position * distance`,
+            // so a resize that leaves the page size alone leaves the offset meaning
+            // exactly what it meant. Re-applying it unconditionally rewound every scroll
+            // still in flight: the observer's first delivery lands in the same frame as
+            // the wheel or drag that started one, and the model only learns the new
+            // offset from the scroll event that has not arrived yet.
+            if (this._allocatePages()) this._applyScrollFromModel();
+        });
+        // The BORDER box: the inset is written as track padding, and observing the
+        // content box would report that write back to us as a resize.
+        this._layoutObserver.observe(this._trackEl, { box: 'border-box' });
     }
 
     private _applyAttribute(name: string, value: string | null): void {
@@ -378,9 +415,64 @@ export class AdwCarousel extends HTMLElement implements CarouselHost {
             }
         });
         this._applySnapStop();
+        this._allocatePages();
         this._applyScrollFromModel();
     }
 
+    /**
+     * Size the pages as `adw_carousel_size_allocate` does, and centre the strip in the
+     * carousel.
+     *
+     * A page is NOT the carousel's width. Every page is allocated the same size, the
+     * largest natural one capped at the carousel (adw-carousel.c:748-765), and the strip
+     * is drawn at an offset of `-(width - child_width) / 2` (:801), so whatever is left
+     * over shows the previous and next page at the two edges. The `flex: 0 0 100%` this
+     * replaces reproduced only the case where nothing is left over: the 440px pages of
+     * the Carousel story sat in a 480px carousel with both neighbours entirely off
+     * screen, where GTK shows 20px of each.
+     *
+     * The inset is track PADDING paired with `scroll-snap-align: center`, which is what
+     * keeps `scrollLeft = position * distance` true either way: page i then snaps at
+     * `inset + i * distance + pageSize / 2 - available / 2`, and the two insets cancel.
+     *
+     * Returns whether the page size, and with it the scroll pitch, actually moved.
+     */
+    private _allocatePages(): boolean {
+        const slots = [...this._slots.values()];
+        if (slots.length === 0) return false;
+
+        // What the pages are laid out at RIGHT NOW, read before the reset below. "Did
+        // the pitch change" has to be answered from the DOM rather than from a
+        // remembered write, or the first pass over an already-correct layout counts as
+        // a change and moves a scroll that had no reason to move.
+        const before = slots[0]!.getBoundingClientRect().width;
+
+        // Measure against the FULL-width allocation: a page whose content is
+        // `width: 100%` reports back whatever the slot currently is, so measuring it
+        // inside an already narrowed slot would shrink the pages again on every pass.
+        this._trackEl.style.removeProperty('padding-inline');
+        for (const slot of slots) slot.style.removeProperty('flex-basis');
+
+        const available = this._trackEl.clientWidth;
+        if (!(available > 0)) return false;
+
+        // `natural` only: CSS has already resolved a page's own `min-width` and every
+        // spelling of "fill the carousel" into the width it renders at, so there is no
+        // separate minimum or hexpand left for the renderer to pass.
+        const measurements = slots.map((slot) => ({
+            natural: (slot.firstElementChild as HTMLElement | null)?.getBoundingClientRect().width ?? 0,
+        }));
+        const { pageSize, leadingInset } = carouselPageAllocation(available, measurements);
+        // A page that measures nothing yet (an image still loading, a font not
+        // applied) would collapse the whole strip; the full-width fallback stands
+        // until the resize that gives it a size.
+        if (!(pageSize > 0)) return false;
+
+        for (const slot of slots) slot.style.flexBasis = `${pageSize}px`;
+        if (leadingInset > 0) this._trackEl.style.paddingInline = `${leadingInset}px`;
+        return Math.round(pageSize) !== Math.round(before);
+    }
+
     /**
      * Put the scroll offset back where the model says it is, instantly. A page revealed
      * at or before the current one moves the position with it (`shift_position`)
@@ -391,7 +483,29 @@ export class AdwCarousel extends HTMLElement implements CarouselHost {
     private _applyScrollFromModel(): void {
         const distance = this._distance();
         if (!(distance > 0)) return;
-        this._trackEl.scrollTo({ left: this._state.position * distance, behavior: 'instant' });
+        this._trackEl.scrollTo({ left: this._restorePosition() * distance, behavior: 'instant' });
+    }
+
+    /**
+     * Which position that write must aim at. Normally the model's, but a scroll still
+     * in flight has not reached the model yet: `scrollTo` only ASKS, and `position`
+     * catches up from the `scroll` event a frame later. Re-applying the stale position
+     * there parks the carousel back where it started and swallows the scroll, which is
+     * how `<adw-carousel position="2">` lost its page: the pending-position observer
+     * and the layout observer are delivered in ONE resize pass, so the very first
+     * allocation landed on a scroll it had just issued.
+     *
+     * `size_allocate` reaches the same moment and re-aims rather than rewinds: it
+     * pushes the recomputed snap point of `animation_target_child` into the running
+     * animation (adw-carousel.c:786-788).
+     */
+    private _restorePosition(): number {
+        if (this._scrollTargetId === null) return this._state.position;
+        const index = this._state.ids.indexOf(this._scrollTargetId);
+        // The target page was removed while the scroll ran; the model's position is
+        // then the only thing left that means anything.
+        if (index < 0) return this._state.position;
+        return this._state.snapPointOf(index) ?? this._state.position;
     }
 
     /**
@@ -416,6 +530,7 @@ export class AdwCarousel extends HTMLElement implements CarouselHost {
         const distance = this._distance();
         if (!(distance > 0)) return;
         this._pendingInteractive = request.interactive;
+        this._scrollTargetId = this._state.ids[request.index] ?? null;
         // `offset = distance * position`, NOT `slot.offsetLeft` — that is measured from
         // the nearest POSITIONED ancestor and coincides with the scroll offset only by
         // accident.
@@ -454,7 +569,9 @@ export class AdwCarousel extends HTMLElement implements CarouselHost {
         // `scroll_animation_done_cb` has an animation to tell it the scroll
         // finished; scroll-snap has only the offset, so the core stands ARRIVAL
         // at a snap point in for it.
-        if (this._state.settleIfArrived()) this._pendingInteractive = null;
+        if (!this._state.settleIfArrived()) return;
+        this._pendingInteractive = null;
+        this._scrollTargetId = null;
     }
 
     private _onStateChange(change: CarouselStateChange): void {

package/src/elements/adw-clamp.ts

@@ -40,8 +40,9 @@ export class AdwClamp extends HTMLElement {
         this._resize = new ResizeObserver(() => this._allocate());
         this._resize.observe(this);
         // Children appended AFTER connect are clamped too. Without this they
-        // would keep whatever width they came with — the same "evaluated once at
-        // connect time" bug the toolbar view's empty-bar handling still has.
+        // would keep whatever width they came with — the "evaluated once at
+        // connect time" bug that cost six container getters their layout;
+        // `src/empty-sections.ts` is the same technique for the `hidden` half.
         this._mutations = new MutationObserver(() => this._allocate());
         this._mutations.observe(this, { childList: true });
         this._allocate();

package/src/elements/adw-data-grid.ts

@@ -52,8 +52,11 @@
 // column tracks, the cell classes, the two normalisers, the cell text and the activation
 // rule. `@gjsify/adwaita-nativescript` renders the same widget over `GridLayout`
 // `ItemSpec`s — NativeScript has no subgrid — so the TRACK rule is a renderer-neutral
-// descriptor and only the mapping onto `grid-template-columns` stays here. Both ports
-// are held to `@gjsify/adwaita-core/conformance`'s `DATA_GRID_*_VECTORS`.
+// descriptor and only the mapping onto `grid-template-columns` stays here. The NativeScript
+// suite is held to DATA_GRID_TRACK_VECTORS, DATA_GRID_COLUMN_CLASS_VECTORS,
+// DATA_GRID_VARIANT_VECTORS, DATA_GRID_CELL_TEXT_VECTORS and DATA_GRID_INTERACTIVE_VECTORS.
+// This element is held to none of them — the browser half of the shared derivation is
+// asserted only against itself, which is the gap, not the arrangement.
 // Reference: Gtk.Grid usage in the Buchhaltung BWA view (native financial grid).
 // Reference: refs/libadwaita/src/stylesheet/_colors.scss (separator / card tokens).
 // Copyright (c) GNOME contributors (libadwaita). LGPLv2.1+.

package/src/elements/adw-dialog.ts

@@ -24,21 +24,14 @@
 // Copyright (c) 2023-2024 GNOME Foundation Inc. (libadwaita). LGPLv2.1+.
 // Modifications: Implemented as a Web Component for @gjsify/adwaita-web.
 
+import { AdwModalSurface } from './modal-surface.js';
+
 /** Adaptive presentation of the dialog — mirrors Adw.DialogPresentationMode. */
 export type AdwDialogPresentationMode = 'auto' | 'floating' | 'bottom-sheet';
 
 const DEFAULT_CONTENT_WIDTH = 360;
 const PRESENTATION_MODES: readonly AdwDialogPresentationMode[] = ['auto', 'floating', 'bottom-sheet'];
 
-const FOCUSABLE_SELECTOR = [
-    'a[href]',
-    'button:not([disabled])',
-    'input:not([disabled])',
-    'select:not([disabled])',
-    'textarea:not([disabled])',
-    '[tabindex]:not([tabindex="-1"])',
-].join(',');
-
 export class AdwDialog extends HTMLElement {
     private _initialized = false;
     private _scrimEl!: HTMLDivElement;
@@ -47,8 +40,7 @@ export class AdwDialog extends HTMLElement {
     private _titleEl!: HTMLSpanElement;
     private _closeBtn!: HTMLButtonElement;
     private _contentEl!: HTMLDivElement;
-    // The element focused before present(), restored on close (return-focus).
-    private _previouslyFocused: HTMLElement | null = null;
+    private _modal!: AdwModalSurface;
 
     static get observedAttributes() {
         return ['title', 'open', 'can-close', 'content-width', 'content-height', 'presentation-mode', 'show-header'];
@@ -157,15 +149,19 @@ export class AdwDialog extends HTMLElement {
         this._scrimEl.className = 'adw-dialog-scrim';
         this._scrimEl.addEventListener('click', () => this._attemptClose());
 
-        // Focusable so the box receives keys even when the content has none, and clicks
-        // inside must not reach the scrim's dismiss handler.
+        // Clicks inside must not reach the scrim's dismiss handler. The role, `aria-modal`
+        // and the -1 tabindex that lets the box hold focus when its content has none all
+        // come from the modal surface below.
         this._boxEl = document.createElement('div');
         this._boxEl.className = 'adw-dialog-box';
-        this._boxEl.setAttribute('role', 'dialog');
-        this._boxEl.setAttribute('aria-modal', 'true');
-        this._boxEl.tabIndex = -1;
         this._boxEl.addEventListener('click', (event) => event.stopPropagation());
-        this._boxEl.addEventListener('keydown', (event) => this._onBoxKeyDown(event));
+        this._modal = new AdwModalSurface({
+            host: this,
+            surface: this._boxEl,
+            role: 'dialog',
+            isOpen: () => this.open,
+            onEscape: () => this._attemptClose(),
+        });
 
         this._headerEl = document.createElement('div');
         this._headerEl.className = 'adw-dialog-header';
@@ -206,7 +202,7 @@ export class AdwDialog extends HTMLElement {
         this._render();
         if (name === 'open') {
             this.dispatchEvent(new CustomEvent('notify::open', { bubbles: true, detail: { open: this.open } }));
-            if (this.open) this._onPresented();
+            if (this.open) this._modal.present();
             else this._onClosed();
         }
     }
@@ -222,53 +218,10 @@ export class AdwDialog extends HTMLElement {
         this.open = false;
     }
 
-    /** Focus trap + Escape while the box has focus. */
-    private _onBoxKeyDown(event: KeyboardEvent): void {
-        if (event.key === 'Escape' && this.open) {
-            event.stopPropagation();
-            this._attemptClose();
-            return;
-        }
-        if (event.key !== 'Tab') return;
-        const focusables = this._focusables();
-        if (focusables.length === 0) {
-            // Nothing tabbable inside — keep focus on the box.
-            event.preventDefault();
-            this._boxEl.focus();
-            return;
-        }
-        const first = focusables[0];
-        const last = focusables[focusables.length - 1];
-        const active = document.activeElement;
-        if (event.shiftKey && (active === first || active === this._boxEl)) {
-            event.preventDefault();
-            last.focus();
-        } else if (!event.shiftKey && active === last) {
-            event.preventDefault();
-            first.focus();
-        }
-    }
-
-    private _focusables(): HTMLElement[] {
-        return Array.from(this._boxEl.querySelectorAll<HTMLElement>(FOCUSABLE_SELECTOR)).filter(
-            (el) => !el.hasAttribute('disabled') && !el.hidden,
-        );
-    }
-
-    /** On present: remember focus, then move it into the dialog. */
-    private _onPresented(): void {
-        const active = document.activeElement;
-        this._previouslyFocused = active instanceof HTMLElement && active !== this ? active : null;
-        const target = this._focusables()[0] ?? this._boxEl;
-        target.focus();
-    }
-
-    /** On close: emit `closed` and return focus to where it was before present. */
+    /** On close: emit `closed`, then let the surface return focus to where it was. */
     private _onClosed(): void {
         this.dispatchEvent(new CustomEvent('closed', { bubbles: true }));
-        const restore = this._previouslyFocused;
-        this._previouslyFocused = null;
-        if (restore && restore.isConnected) restore.focus();
+        this._modal.dismiss();
     }
 
     private _render(): void {