@gjsify/adwaita-web 0.30.0 → 0.32.0

package/src/elements/adw-split-button.ts

@@ -3,50 +3,142 @@
 // halves are separated by a thin divider; the .suggested-action /
 // .destructive-action / .flat style classes recolor the whole control like the
 // matching Adwaita button variants.
-// Attributes: label, icon-name (symbolic name, e.g. "document-save"; an icon
-//   without a label collapses the action half to icon-only), tooltip,
-//   dropdown-tooltip, disabled, and the boolean variant flags
-//   suggested / destructive / flat.
-//   Menu entries are provided as a JSON array on the `menu` attribute, each
-//   entry `{ "label": "Save as…", "action": "app.save-as" }`.
+//
+// Attributes:
+//   label            — the action label. MUTUALLY EXCLUSIVE with icon-name.
+//   icon-name        — symbolic name (with or without the `-symbolic` suffix).
+//   use-underline    — boolean; an underline in the label marks a mnemonic.
+//   tooltip          — tooltip/accessible name of the action half.
+//   dropdown-tooltip — tooltip of the dropdown half; empty restores "More Options".
+//   direction        — none | up | down | left | right (default down).
+//   menu             — JSON array of entries, each `{ "label", "action"? }`.
+//   disabled, flat, suggested, destructive — boolean flags.
 // Events (all CustomEvent, bubbles — mirror the Adw.SplitButton GObject signals):
-//   `clicked`            — the primary action half was activated.
-//   `notify::active`     — the dropdown menu was opened/closed (detail.active).
-//   `menu-activated`     — a menu entry was chosen (detail.action / detail.label).
+//   `clicked`         — the primary action half was activated.
+//   `notify::active`  — the dropdown menu was opened/closed (detail.active).
+//   `notify::<prop>`  — one per GObject property the state machine notified,
+//                       in libadwaita's emission order.
+//   `menu-activated`  — a menu entry was chosen (detail.label / .action / .index).
+//
+// All of the behavior above lives in `@gjsify/adwaita-core` (ADR 0004) as
+// {@link SplitButtonState}; this element only paints it and translates DOM
+// events into state calls. It used to carry its own copy, and that copy rendered
+// the label AND the icon together (libadwaita clears whichever slot it is not
+// using), could not clear the label at all, hardcoded "Menu" as the dropdown's
+// accessible name, and opened an empty popover when there was no menu. The
+// shared vectors in `@gjsify/adwaita-core/conformance` now pin this element to
+// the C source — see `src/split-button.spec.ts`.
+//
+// The last piece of that copy to go was the direction→arrow table, which
+// outlived the lift and drew the `open-menu` hamburger for `direction="none"`.
+// Only the glyph→mask-class mapping is a renderer concern; see ARROW_MASK_CLASSES.
+//
+// THE POPOVER WENT THE SAME WAY, and it was the worst of the three copies: a
+// 9px (`--button-radius`) surface where libadwaita's is 15px, under a two-layer
+// shadow nothing in the vendored stylesheet has, with NO Escape dismissal and NO
+// arrow-key navigation at all — a menu you could open with the keyboard and then
+// only leave with the mouse. It is now `<adw-popover>`, so those two behaviours
+// arrive with the surface rather than having to be written a third time; the
+// spec cases for exactly them are in `src/split-button.spec.ts`.
+//
 // Reference: refs/libadwaita/src/adw-split-button.c (AdwSplitButton)
 // Reference: refs/adwaita-web/adwaita-web/scss/_split_button.scss
 // Copyright (c) GNOME contributors (libadwaita). LGPLv2.1+.
 // Copyright (c) 2025 csm (adwaita-web). MIT License.
 // Modifications: Implemented as a Web Component for @gjsify/adwaita-web.
 
+import {
+    SplitButtonState,
+    isSplitButtonDirection,
+    parseMenuEntries,
+    resolveDropdownTooltip,
+    splitButtonArrowIcon,
+    splitButtonPopupDirection,
+    splitButtonRootState,
+} from '@gjsify/adwaita-core';
+import type { AdwArrowIcon, AdwMenuEntry, SplitButtonChange, SplitButtonDirection } from '@gjsify/adwaita-core';
+
+// SIDE-EFFECT import, deliberately separate from the type import below: it is
+// what guarantees `adw-popover` is defined before this module's own
+// `customElements.define` can upgrade a server-rendered `<adw-split-button>` and
+// build one. A combined `import { AdwPopover }` would NOT do it — the binding is
+// only ever used in type position here, and this package compiles without
+// `verbatimModuleSyntax`, so TypeScript would elide the whole statement and take
+// the registration with it.
+import './adw-popover.js';
+import type { AdwPopover } from './adw-popover.js';
+
+import { type AdwIcon, createAdwIcon } from './adw-icon.js';
+
 const VARIANT_CLASSES: Record<string, string> = {
     flat: 'flat',
     suggested: 'suggested-action',
     destructive: 'destructive-action',
 };
 
-interface MenuEntry {
-    label: string;
-    action?: string;
-}
+/**
+ * libadwaita's arrow GLYPH NAMES mapped onto the mask classes
+ * `_icons.generated.scss` actually ships. Renderer-specific by nature: the icon
+ * set here is the `go-*` family, so no `pan-*` mask exists to map onto.
+ *
+ * WHICH glyph a direction gets is NOT decided here — {@link splitButtonArrowIcon}
+ * owns that, and this table is keyed by its output rather than by direction. That
+ * split is the point: keying by direction is how this element came to draw the
+ * `open-menu` hamburger for `direction="none"`, where a split button draws the
+ * down caret (`splitbutton > menubutton > button > arrow.none`,
+ * _buttons.scss:621-623). The mask mapping is a fact about our asset set; the
+ * glyph choice is a fact about libadwaita, and only one of them lives here.
+ *
+ * `pan-up-symbolic` has no mask at all, so it reuses `go-down` flipped by the
+ * caller — the alternative is a blank arrow.
+ */
+const ARROW_MASK_CLASSES: Readonly<Record<AdwArrowIcon, string>> = {
+    'open-menu-symbolic': 'open-menu',
+    'pan-down-symbolic': 'go-down',
+    'pan-up-symbolic': 'go-down',
+    'pan-start-symbolic': 'go-previous',
+    'pan-end-symbolic': 'go-next',
+};
+
+// The `-symbolic` strip AND the token guard that used to live here — as
+// `iconClass`, the ONLY copy of the guard in the package — are
+// `normalizeIconName`'s now, applied by <adw-icon>. Five other places built the
+// same class without the guard; keeping the correct one private is what let
+// them stay wrong.
+
+/**
+ * Direction → the CSS axis `<adw-popover>` places the surface on. WHICH
+ * direction applies is not decided here — {@link splitButtonPopupDirection}
+ * folds `none` onto `down` (GtkMenuButton's rule, not the split button's), and
+ * this table is keyed by its output for the same reason ARROW_MASK_CLASSES is.
+ */
+const POPOVER_POSITIONS = {
+    down: 'bottom',
+    up: 'top',
+    left: 'start',
+    right: 'end',
+} as const;
 
 export class AdwSplitButton extends HTMLElement {
+    private readonly _state = new SplitButtonState();
     private _actionEl!: HTMLButtonElement;
     private _dropdownEl!: HTMLButtonElement;
-    private _menuEl!: HTMLDivElement;
-    private _label = '';
-    private _active = false;
+    private _arrowEl!: AdwIcon;
+    private _menuEl!: AdwPopover;
+    /** Inline text content, captured before we take over the subtree. */
+    private _inlineLabel = '';
+    /** Last `open` value reflected as `notify::active`, so the event fires once per flip. */
+    private _openReflected = false;
     private _initialized = false;
-    private _onDocumentPointerDown = (event: Event): void => {
-        if (!this.contains(event.target as Node)) this._setActive(false);
-    };
 
     static get observedAttributes() {
         return [
             'label',
             'icon-name',
+            'use-underline',
             'tooltip',
             'dropdown-tooltip',
+            'direction',
             'menu',
             'disabled',
             'flat',
@@ -57,15 +149,92 @@ export class AdwSplitButton extends HTMLElement {
 
     /** Whether the dropdown menu is currently open. */
     get active(): boolean {
-        return this._active;
+        return this._state.open;
+    }
+
+    /** Whether the dropdown half is live (there is a menu to show). */
+    get dropdownEnabled(): boolean {
+        return this._state.dropdownEnabled;
+    }
+
+    /** The action label, or `null` when the action half shows an icon or nothing. */
+    get label(): string | null {
+        return this._state.label;
+    }
+
+    set label(value: string) {
+        this.setAttribute('label', value ?? '');
+        // Setting the label clears the icon (adw-split-button.c:658-659); mirror
+        // that in the DOM so the attributes never contradict the state.
+        this.removeAttribute('icon-name');
+    }
+
+    /** The symbolic icon name, or `null` when the action half shows a label or nothing. */
+    get iconName(): string | null {
+        return this._state.iconName;
+    }
+
+    set iconName(value: string) {
+        this.setAttribute('icon-name', value ?? '');
+        this.removeAttribute('label');
+    }
+
+    /** The dropdown menu entries. */
+    get menuItems(): readonly AdwMenuEntry[] {
+        return this._state.menuModel ?? [];
+    }
+
+    set menuItems(value: readonly AdwMenuEntry[]) {
+        this._state.setMenuModel(Array.isArray(value) ? value.map((entry) => ({ ...entry })) : null);
+        if (this._initialized) this._render();
+    }
+
+    /** The dropdown tooltip as set — `''` while unset. */
+    get dropdownTooltip(): string {
+        return this._state.dropdownTooltip;
+    }
+
+    set dropdownTooltip(value: string) {
+        this.setAttribute('dropdown-tooltip', value ?? '');
+    }
+
+    /** The direction the popup opens in, and the arrow points. */
+    get direction(): SplitButtonDirection {
+        return this._state.direction;
+    }
+
+    set direction(value: SplitButtonDirection) {
+        this.setAttribute('direction', value);
+    }
+
+    /** Whether an underline in the label marks a mnemonic. */
+    get useUnderline(): boolean {
+        return this._state.useUnderline;
+    }
+
+    set useUnderline(value: boolean) {
+        if (value) this.setAttribute('use-underline', '');
+        else this.removeAttribute('use-underline');
+    }
+
+    /** Pop the menu up — `adw_split_button_popup()`. */
+    popup(): void {
+        this._state.openMenu();
+    }
+
+    /** Dismiss the menu — `adw_split_button_popdown()`. */
+    popdown(): void {
+        this._state.closeMenu();
     }
 
     connectedCallback() {
         if (this._initialized) return;
         this._initialized = true;
 
-        // Capture any inline text as the label before we take over the subtree.
-        this._label = (this.getAttribute('label') ?? this.textContent ?? '').trim();
+        // Inline text is the label when no `label` attribute is given. This seed
+        // IS trimmed — markup indentation is not part of the value — while an
+        // explicit attribute never is, because C keys `text-button` off label[0].
+        this._inlineLabel = (this.textContent ?? '').trim();
 
         this.classList.add('adw-split-button');
 
@@ -76,16 +245,31 @@ export class AdwSplitButton extends HTMLElement {
         this._dropdownEl = document.createElement('button');
         this._dropdownEl.type = 'button';
         this._dropdownEl.className = 'adw-split-button-dropdown';
-        const arrow = document.createElement('span');
-        arrow.className = 'adw-icon adw-icon--go-down';
-        arrow.setAttribute('aria-hidden', 'true');
-        this._dropdownEl.appendChild(arrow);
+        this._dropdownEl.setAttribute('aria-haspopup', 'menu');
+        this._arrowEl = createAdwIcon(null);
+        this._dropdownEl.appendChild(this._arrowEl);
 
-        this._menuEl = document.createElement('div');
-        this._menuEl.className = 'adw-split-button-menu';
-        this._menuEl.hidden = true;
+        this._menuEl = document.createElement('adw-popover') as AdwPopover;
+        this._menuEl.classList.add('adw-split-button-menu');
+        this._menuEl.setAttribute('role', 'menu');
+        // The dropdown half IS a GtkMenuButton (adw-split-button.c:997 passes
+        // straight through to it), so its popover is a `popover.menu`.
+        this._menuEl.setAttribute('menu', '');
+        this._menuEl.setAttribute('align', 'end');
 
         this.replaceChildren(this._actionEl, this._dropdownEl, this._menuEl);
+        // The DROPDOWN half is the anchor, not the whole control: the popover
+        // must not treat the half that toggles it as "outside" (it would close
+        // and immediately reopen), and Escape returns focus to the half that
+        // opened the menu.
+        this._menuEl.anchor = this._dropdownEl;
+        // The popover is a MIRROR of `SplitButtonState.open`, which stays the
+        // single source of truth (`dropdownEnabled`, the root `checked` fold and
+        // `notify::active` all read it). A dismissal the popover owns — outside
+        // click, Escape — is fed back in here rather than diverging.
+        this._menuEl.subscribe((open) => {
+            if (!open) this._state.closeMenu();
+        });
 
         this._actionEl.addEventListener('click', () => {
             if (this.hasAttribute('disabled')) return;
@@ -93,113 +277,208 @@ export class AdwSplitButton extends HTMLElement {
         });
         this._dropdownEl.addEventListener('click', () => {
             if (this.hasAttribute('disabled')) return;
-            this._setActive(!this._active);
+            this._state.toggleMenu();
         });
 
+        // Seed the state from the attributes BEFORE subscribing, so connecting an
+        // element does not fire a burst of notify::* for properties that were
+        // never "changed" from an author's point of view.
+        this._syncStateFromAttributes();
+        this._state.subscribe((change) => this._onStateChange(change));
         this._render();
     }
 
-    disconnectedCallback() {
-        document.removeEventListener('pointerdown', this._onDocumentPointerDown);
+    attributeChangedCallback(name: string, _previous: string | null, value: string | null) {
+        if (!this._initialized) return;
+        switch (name) {
+            case 'label':
+            case 'icon-name':
+                this._applyContentAttribute(name, value);
+                break;
+            case 'use-underline':
+                this._state.setUseUnderline(value !== null);
+                break;
+            case 'direction':
+                this._state.setDirection(isSplitButtonDirection(value) ? value : 'down');
+                break;
+            case 'dropdown-tooltip':
+                this._state.setDropdownTooltip(value ?? '');
+                break;
+            case 'menu':
+                this._state.setMenuModel(parseMenuEntries(value));
+                break;
+            default:
+                break;
+        }
+        // A change that the state machine swallowed as a no-op still has to reach
+        // the DOM (`tooltip`, `disabled`, the variant flags have no state).
+        this._render();
     }
 
-    attributeChangedCallback() {
-        if (this._initialized) this._render();
+    /** Seed label/icon/menu/direction/tooltip from the attributes present at connect time. */
+    private _syncStateFromAttributes(): void {
+        const label = this.getAttribute('label') ?? (this._inlineLabel.length > 0 ? this._inlineLabel : null);
+        const iconName = this.getAttribute('icon-name');
+        // With both present the icon wins — exactly where `set_label();
+        // set_icon_name();` leaves the widget (adw-split-button.c:749-771).
+        if (label !== null) this._state.setLabel(label);
+        if (iconName !== null) this._state.setIconName(iconName);
+
+        this._state.setUseUnderline(this.hasAttribute('use-underline'));
+        const direction = this.getAttribute('direction');
+        if (isSplitButtonDirection(direction)) this._state.setDirection(direction);
+        this._state.setDropdownTooltip(this.getAttribute('dropdown-tooltip') ?? '');
+        // The `menuItems` property may have been set before the element upgraded;
+        // the attribute only seeds an otherwise empty menu.
+        if (this._state.menuModel === null) this._state.setMenuModel(parseMenuEntries(this.getAttribute('menu')));
+    }
+
+    /**
+     * Route a `label` / `icon-name` attribute mutation into the content machine.
+     *
+     * C has no independent "unset" for either slot — clearing one is a side
+     * effect of setting another — so a REMOVED attribute falls back to whichever
+     * sibling is still present, and to the empty child otherwise. That fallback
+     * is what makes `removeAttribute('label')` actually drop the label; it used
+     * to be a silent no-op, so the storybook's icon-only mode rendered the icon
+     * next to a stale "Save".
+     */
+    private _applyContentAttribute(name: 'label' | 'icon-name', value: string | null): void {
+        if (value !== null) {
+            if (name === 'label') this._state.setLabel(value);
+            else this._state.setIconName(value);
+            return;
+        }
+        const sibling = this.getAttribute(name === 'label' ? 'icon-name' : 'label');
+        if (sibling === null) this._state.setChild(null);
+        else if (name === 'label') this._state.setIconName(sibling);
+        else this._state.setLabel(sibling);
     }
 
-    private _setActive(active: boolean): void {
-        if (this._active === active) return;
-        this._active = active;
-        this._menuEl.hidden = !active;
-        this.classList.toggle('active', active);
-        this._dropdownEl.setAttribute('aria-expanded', String(active));
-        if (active) {
-            document.addEventListener('pointerdown', this._onDocumentPointerDown);
-        } else {
-            document.removeEventListener('pointerdown', this._onDocumentPointerDown);
+    private _onStateChange(change: SplitButtonChange): void {
+        for (const property of change.notified) {
+            this.dispatchEvent(new CustomEvent(`notify::${property}`, { bubbles: true }));
         }
-        this.dispatchEvent(new CustomEvent('notify::active', { bubbles: true, detail: { active } }));
-    }
-
-    private _parseMenu(): MenuEntry[] {
-        const raw = this.getAttribute('menu');
-        if (!raw) return [];
-        try {
-            const parsed: unknown = JSON.parse(raw);
-            if (!Array.isArray(parsed)) return [];
-            return parsed
-                .filter((entry): entry is MenuEntry => typeof entry === 'object' && entry !== null && 'label' in entry)
-                .map((entry) => ({ label: String(entry.label), action: entry.action }));
-        } catch {
-            return [];
+        const opened = change.open && !this._openReflected;
+        if (change.open !== this._openReflected) {
+            this._openReflected = change.open;
+            this.dispatchEvent(new CustomEvent('notify::active', { bubbles: true, detail: { active: change.open } }));
         }
+        this._render();
+        // Focus lands in the menu on open, AFTER _render has built the rows —
+        // without it the arrow keys the popover now provides would have nothing
+        // to move from, which is half of why this element had none.
+        if (opened) this._menuEl.items[0]?.focus();
     }
 
-    private _render() {
+    private _render(): void {
         const disabled = this.hasAttribute('disabled');
         this.classList.toggle('disabled', disabled);
         this._actionEl.disabled = disabled;
-        this._dropdownEl.disabled = disabled;
+        // With neither a menu model nor a popover the dropdown is INSENSITIVE
+        // (adw-split-button.c:376-378, :394-396) — it must not open an empty
+        // popover, which is what the old unguarded click handler did.
+        this._dropdownEl.disabled = disabled || !this._state.dropdownEnabled;
 
         this.classList.remove('flat', 'suggested-action', 'destructive-action');
-        for (const [attr, cls] of Object.entries(VARIANT_CLASSES)) {
-            if (this.hasAttribute(attr)) this.classList.add(cls);
+        for (const [attribute, cls] of Object.entries(VARIANT_CLASSES)) {
+            if (this.hasAttribute(attribute)) this.classList.add(cls);
         }
 
-        // --- Primary action half ---
-        const icon = this.getAttribute('icon-name');
-        const label = (this.getAttribute('label') ?? this._label).trim();
-        this._actionEl.classList.toggle('icon-only', Boolean(icon) && !label);
+        this._renderContent();
+        this._renderDropdown();
+        this._renderMenu();
+    }
+
+    /** The action half + the root style classes libadwaita derives from it. */
+    private _renderContent(): void {
+        const { mode, label, iconName, styleClasses } = this._state;
+
+        // `splitbutton[.image-button][.text-button]` — the documented CSS node
+        // contract (adw-split-button.c:32-50, :145-165).
+        this.classList.toggle('image-button', styleClasses.includes('image-button'));
+        this.classList.toggle('text-button', styleClasses.includes('text-button'));
 
         this._actionEl.replaceChildren();
-        if (icon) {
-            const span = document.createElement('span');
-            span.className = `adw-icon adw-icon--${icon}`;
-            span.setAttribute('aria-hidden', 'true');
-            this._actionEl.appendChild(span);
+        this._actionEl.classList.toggle('icon-only', mode === 'icon');
+
+        if (mode === 'icon' && iconName !== null) {
+            this._actionEl.appendChild(createAdwIcon(iconName));
+        } else if (mode === 'label' && label !== null) {
+            // Never trimmed: two spaces are a valid label and render as one.
+            this._actionEl.appendChild(document.createTextNode(label));
         }
-        if (label) this._actionEl.appendChild(document.createTextNode(label));
 
         const tooltip = this.getAttribute('tooltip');
         this._actionEl.title = tooltip ?? '';
         // An icon-only action half has no text, so give it an accessible name —
         // prefer the tooltip, fall back to the symbolic icon name (WCAG 4.1.2).
-        if (icon && !label) {
-            this._actionEl.setAttribute('aria-label', tooltip ?? icon);
-        } else {
-            this._actionEl.removeAttribute('aria-label');
-        }
+        if (mode === 'icon') this._actionEl.setAttribute('aria-label', tooltip ?? (iconName || 'Action'));
+        else this._actionEl.removeAttribute('aria-label');
+    }
 
-        // --- Dropdown half ---
-        const dropdownTooltip = this.getAttribute('dropdown-tooltip');
-        this._dropdownEl.title = dropdownTooltip ?? '';
-        this._dropdownEl.setAttribute('aria-label', dropdownTooltip ?? 'Menu');
-        this._dropdownEl.setAttribute('aria-haspopup', 'menu');
-        this._dropdownEl.setAttribute('aria-expanded', String(this._active));
+    /** The dropdown half: arrow glyph, tooltip/accessible name, expanded state. */
+    private _renderDropdown(): void {
+        const { direction, open } = this._state;
+        const glyph = splitButtonArrowIcon(direction);
+        this._arrowEl.iconName = ARROW_MASK_CLASSES[glyph];
+        // No pan-up mask ships yet, so it is the down arrow turned over. Keyed off
+        // the GLYPH, not the direction: the flip belongs to the mask substitution.
+        this._arrowEl.style.transform = glyph === 'pan-up-symbolic' ? 'rotate(180deg)' : '';
+        // Where the popup goes is core's call (`none` → `down`); only the
+        // direction → CSS-axis mapping is ours.
+        this._menuEl.position = POPOVER_POSITIONS[splitButtonPopupDirection(direction)];
 
-        // --- Menu ---
-        const entries = this._parseMenu();
+        // An empty value RESTORES the translated default (adw-split-button.c:1044-1051)
+        // instead of leaving the button without an accessible name.
+        const { text } = resolveDropdownTooltip(this._state.dropdownTooltip);
+        this._dropdownEl.title = text;
+        this._dropdownEl.setAttribute('aria-label', text);
+        this._dropdownEl.setAttribute('aria-expanded', String(open));
+
+        // update_state folds both halves onto the root (adw-split-button.c:118-143).
+        // The browser gives the ACTIVE half of that fold for free — CSS `:active`
+        // matches the ancestors of the pressed element — so only CHECKED, which
+        // the arrow half carries while the menu is open, has to be applied here.
+        const { checked } = splitButtonRootState(
+            { active: false, checked: false, keyboardActivating: false },
+            { active: false, checked: open, keyboardActivating: false },
+        );
+        this.classList.toggle('checked', checked);
+        // `.active` predates the lift and stays the open-state hook; libadwaita
+        // spells the same state `checked`.
+        this.classList.toggle('active', open);
+    }
+
+    /** The popover contents, one button per menu entry, dispatched BY POSITION. */
+    private _renderMenu(): void {
         this._menuEl.replaceChildren();
-        this._menuEl.setAttribute('role', 'menu');
-        for (const entry of entries) {
+        this._menuEl.open = this._state.open;
+
+        for (const [index, entry] of (this._state.menuModel ?? []).entries()) {
             const item = document.createElement('button');
             item.type = 'button';
-            item.className = 'adw-split-button-menu-item';
+            // `.adw-popover-item` is what makes the row navigable: it is the
+            // selector `<adw-popover>` walks for arrow/Home/End/Enter, which this
+            // element never had.
+            item.className = 'adw-popover-item adw-split-button-menu-item';
             item.setAttribute('role', 'menuitem');
+            item.tabIndex = -1;
             item.textContent = entry.label;
             item.addEventListener('click', () => {
-                this._setActive(false);
+                // By position, never by label: two entries called "Copy" are
+                // legal and must dispatch their own action (c:385-388).
+                const activated = this._state.activateMenuEntry(index);
+                if (activated === null) return;
                 this.dispatchEvent(
                     new CustomEvent('menu-activated', {
                         bubbles: true,
-                        detail: { label: entry.label, action: entry.action },
+                        detail: { label: activated.label, action: activated.action, index },
                     }),
                 );
             });
             this._menuEl.appendChild(item);
         }
-        // A split button with no menu entries hides its (empty) popover entirely.
-        if (entries.length === 0) this._setActive(false);
     }
 }
 

package/src/elements/adw-status-page.ts

@@ -4,10 +4,13 @@
 // Reference: refs/adwaita-web/adwaita-web/scss/_status_page.scss
 // Reference: refs/libadwaita/src/stylesheet/widgets/_status-page.scss
 // Copyright (c) GNOME contributors (libadwaita). LGPLv2.1+.
-// Modifications: Implemented as a Web Component for @gjsify/adwaita-web.
+// Modifications: Implemented as a Web Component for @gjsify/adwaita-web; the
+// icon node is <adw-icon>.
+
+import { type AdwIcon, createAdwIcon } from './adw-icon.js';
 
 export class AdwStatusPage extends HTMLElement {
-    private _iconEl!: HTMLSpanElement;
+    private _iconEl!: AdwIcon;
     private _titleEl!: HTMLSpanElement;
     private _descEl!: HTMLSpanElement;
     private _childEl!: HTMLDivElement;
@@ -23,9 +26,7 @@ export class AdwStatusPage extends HTMLElement {
 
         const children = Array.from(this.childNodes);
 
-        this._iconEl = document.createElement('span');
-        this._iconEl.className = 'adw-status-page-icon adw-icon';
-        this._iconEl.setAttribute('aria-hidden', 'true');
+        this._iconEl = createAdwIcon(null, 'adw-status-page-icon');
 
         this._titleEl = document.createElement('span');
         this._titleEl.className = 'adw-status-page-title';
@@ -46,10 +47,9 @@ export class AdwStatusPage extends HTMLElement {
     }
 
     private _render() {
-        const icon = (this.getAttribute('icon') ?? '').replace(/-symbolic$/, '');
-        // Swap the icon mask class (keep the base + size class).
-        this._iconEl.className = `adw-status-page-icon adw-icon${icon ? ` adw-icon--${icon}` : ''}`;
-        this._iconEl.hidden = icon.length === 0;
+        // The element swaps the mask class and keeps the size class.
+        this._iconEl.iconName = this.getAttribute('icon');
+        this._iconEl.hidden = this._iconEl.resolvedIconName === '';
 
         const title = this.getAttribute('title') ?? '';
         this._titleEl.textContent = title;