@givolt/i3-composer-agent 2.3.1 → 2.3.2

package/scripts/ui-prototype-dependencies-test.js

@@ -0,0 +1,213 @@
+'use strict';
+const test = require('node:test');
+const assert = require('node:assert/strict');
+const fs = require('node:fs');
+const os = require('node:os');
+const path = require('node:path');
+const installation = path.join(__dirname, 'lib/installation.js');
+const skills = fs.existsSync(installation) ? require(installation).loadInstallation().skillsDirectory : path.resolve(__dirname, '../skills');
+const deps = require(path.join(skills, 'i3-ui-prototype/scripts/prototype-dependencies.cjs'));
+const installer = require(path.join(skills, 'i3-ui-prototype/scripts/optional-skill-install.cjs'));
+function workspace(t) {
+  const root = fs.realpathSync(fs.mkdtempSync(path.join(os.tmpdir(), 'i3-optional-deps-')));
+  t.after(() => fs.rmSync(root, { recursive: true, force: true }));
+  const project = path.join(root, 'business'), home = path.join(root, 'home');
+  fs.mkdirSync(project); fs.mkdirSync(home);
+  return { project, home, env: {
+    ...process.env,
+    HOME: home, USERPROFILE: home,
+    XDG_CONFIG_HOME: path.join(home, '.config'),
+    CODEBUDDY_CONFIG_DIR: path.join(home, '.codebuddy'),
+    WORKBUDDY_CONFIG_DIR: path.join(home, '.workbuddy'),
+    CLAUDE_CONFIG_DIR: path.join(home, '.claude'),
+    CODEX_HOME: path.join(home, '.codex'),
+  } };
+}
+test('missing optional Skills do not fail read-only inspection or write files', t => {
+  const options = workspace(t), before = fs.readdirSync(options.project);
+  const result = deps.check(options);
+  assert.equal(result.status, 'checked');
+  assert.equal(result.professionalReady, false);
+  assert.equal(result.antdv.skill.availability, 'missing');
+  assert.equal(result.antdv.tool.availability, 'missing');
+  assert.deepEqual(fs.readdirSync(options.project), before);
+});
+test('later installed antDv Skill is detected without reinstalling i3 or claiming the CLI ready', t => {
+  const options = workspace(t);
+  assert.equal(deps.check(options).antdv.skill.availability, 'missing');
+  const root = path.join(options.project, '.codebuddy/skills/antdv');
+  fs.mkdirSync(root, { recursive: true }); fs.writeFileSync(path.join(root, 'SKILL.md'), 'official Skill fixture');
+  const result = deps.check(options);
+  assert.equal(result.antdv.skill.root, root);
+  assert.equal(result.antdv.skill.availability, 'available');
+  assert.equal(result.antdv.skill.invocationVerified, false);
+  assert.equal(result.antdv.tool.availability, 'missing');
+});
+test('CodeBuddy global antDv is reusable and current project entry has precedence', t => {
+  const options = workspace(t);
+  options.env.CODEBUDDY_CONFIG_DIR = path.join(options.home, 'legacy CodeBuddy config');
+  const global = path.join(options.env.CODEBUDDY_CONFIG_DIR, 'skills/antdv');
+  fs.mkdirSync(global, { recursive: true }); fs.writeFileSync(path.join(global, 'SKILL.md'), 'global');
+  assert.equal(deps.skillAt(options.project, 'antdv', options).source, 'global-skill');
+  const local = path.join(options.project, '.codebuddy/skills/antdv');
+  fs.mkdirSync(local, { recursive: true }); fs.writeFileSync(path.join(local, 'SKILL.md'), 'local');
+  assert.equal(deps.skillAt(options.project, 'antdv', options).root, local);
+});
+test('global UIUX detection reuses enabled user plugins, preserves disabled status and excludes business plugins', t => {
+  const options = { ...workspace(t), host: 'codebuddy', scope: 'global' }, config = path.join(options.home, '.codebuddy');
+  const plugin = path.join(options.home, 'uiux-plugin'), root = path.join(plugin, 'skills/ui-ux-pro-max'), id = 'ui-ux-pro-max@fixture';
+  const write = (file, content) => { fs.mkdirSync(path.dirname(file), { recursive: true }); fs.writeFileSync(file, typeof content === 'string' ? content : JSON.stringify(content)); };
+  write(path.join(plugin, '.codebuddy-plugin/plugin.json'), { name: 'ui-ux-pro-max', version: '2.15.0' });
+  for (const file of ['SKILL.md', 'scripts/core.py', 'scripts/design_system.py', ...['ux-guidelines','styles','colors','typography','products','landing','ui-reasoning'].map(name => `data/${name}.csv`)]) write(path.join(root, file), 'synthetic fixture');
+  write(path.join(root, 'scripts/search.py'), 'import json\nprint(json.dumps({"domain":"ux","results":[{"id":"synthetic-probe-only"}]}))\n');
+  write(path.join(config, 'settings.json'), { enabledPlugins: { [id]: true } });
+  const record = { scope: 'user', installPath: plugin, version: '2.15.0' };
+  write(path.join(config, 'plugins/installed_plugins.json'), { version: 2, plugins: { [id]: [record] } });
+  const result = deps.check(options);
+  assert.equal(result.uiux.root, root);
+  assert.equal(result.uiux.availability, 'available');
+  assert.equal(result.uiux.source, 'codebuddy-plugin');
+  write(path.join(config, 'settings.json'), { enabledPlugins: { [id]: false } });
+  assert.equal(deps.check(options).uiux.availability, 'disabled');
+  write(path.join(config, 'settings.json'), { enabledPlugins: { [id]: true } });
+  write(path.join(config, 'plugins/installed_plugins.json'), { version: 2, plugins: { [id]: [{ ...record, scope: 'project', projectPath: options.project }] } });
+  assert.equal(deps.check(options).uiux.availability, 'missing');
+});
+test('dependency CLI rejects unintended writes and unrelated hosts', () => {
+  assert.throws(() => deps.parse(['check', '--force']), /Invalid option/);
+  assert.throws(() => deps.check({ host: 'not-a-host' }), /Unknown host/);
+  assert.throws(() => deps.parse(['update']), /check or install/);
+});
+function officialFixture(name, folder) {
+  const skill = path.join(folder, 'skill'), tool = path.join(folder, 'tool');
+  fs.mkdirSync(skill); fs.mkdirSync(tool);
+  fs.writeFileSync(path.join(skill, 'SKILL.md'), `---\nname: ${name === 'uiux' ? 'ui-ux-pro-max' : 'antdv'}\n---\nOfficial fixture; not host invocation evidence.\n`);
+  if (name === 'uiux') {
+    for (const file of ['scripts/search.py', 'scripts/core.py', 'scripts/design_system.py', 'data/ux-guidelines.csv']) {
+      fs.mkdirSync(path.dirname(path.join(skill, file)), { recursive: true }); fs.writeFileSync(path.join(skill, file), 'fixture');
+    }
+  } else {
+    const pkg = path.join(tool, 'node_modules/@antdv-next/cli'); fs.mkdirSync(pkg, { recursive: true });
+    fs.writeFileSync(path.join(pkg, 'package.json'), JSON.stringify({ name: '@antdv-next/cli', version: '0.0.0-beta.1', bin: { antdv: 'cli.cjs' } }));
+    fs.writeFileSync(path.join(pkg, 'cli.cjs'), 'process.stdout.write(JSON.stringify({name:"Table",props:[]}));');
+  }
+  return { skill, tool };
+}
+test('explicit skip never downloads, writes or permanently disables dependencies', async t => {
+  const options = workspace(t), before = fs.readdirSync(options.project);
+  const result = await installer.install({ ...options, skills: 'none' }, { prepare() { throw new Error('Unexpected download'); } });
+  assert.equal(result.status, 'skipped');
+  assert.deepEqual(fs.readdirSync(options.project), before);
+  assert.deepEqual(installer.selection('uiux,antdv'), ['uiux', 'antdv']);
+  assert.throws(() => installer.selection('none,uiux'), /Choose/);
+});
+test('optional antDv installation preserves user files and a later invocation reuses the Skill', async t => {
+  const options = workspace(t);
+  fs.writeFileSync(path.join(options.project, 'PRD.md'), 'human requirements');
+  const services = { prepare: officialFixture, progress() {} };
+  const result = await installer.install({ ...options, skills: 'antdv' }, services);
+  assert.equal(result.status, 'installed');
+  assert.equal(result.detection.antdv.skill.availability, 'available');
+  assert.equal(fs.readFileSync(path.join(options.project, 'PRD.md'), 'utf8'), 'human requirements');
+  const skillFile = path.join(options.project, '.codebuddy/skills/antdv/SKILL.md');
+  fs.appendFileSync(skillFile, 'user edit'); const before = fs.readFileSync(skillFile);
+  const again = await installer.install({ ...options, skills: 'antdv' }, { prepare() { throw new Error('Existing tool must not be replaced'); } });
+  assert.equal(again.status, 'reused');
+  assert.deepEqual(fs.readFileSync(skillFile), before);
+});
+test('a failed second preparation publishes neither selected Skill and removes temporary files', async t => {
+  const options = workspace(t);
+  await assert.rejects(installer.install({ ...options, skills: 'uiux,antdv' }, {
+    progress() {}, prepare(name, folder) { if (name === 'antdv') throw new Error('simulated network failure'); return officialFixture(name, folder); },
+  }), /simulated network failure/);
+  assert.deepEqual(fs.readdirSync(options.project), []);
+});
+test('antDv error text or error JSON with exit zero is not successful knowledge', async t => {
+  const options = workspace(t);
+  await installer.install({ ...options, skills: 'antdv' }, { prepare: officialFixture, progress() {} });
+  const file = path.join(resultTool(options), 'node_modules/@antdv-next/cli/cli.cjs');
+  for (const output of ['Error: Table knowledge missing', JSON.stringify({ error: 'Table knowledge missing' })]) {
+    fs.writeFileSync(file, `process.stdout.write(${JSON.stringify(output)});`);
+    assert.equal(deps.check(options).antdv.tool.availability, 'unusable');
+  }
+});
+function resultTool(options) { return path.join(deps.check(options).locations.toolsDirectory, 'antdv-cli'); }
+for (const host of ['codebuddy', 'workbuddy', 'codex', 'claude-code']) for (const scope of ['project', 'global']) {
+  test(`${host} ${scope} optional installation keeps all tools inside the selected host root`, async t => {
+    const options = { ...workspace(t), host, scope };
+    const result = await installer.install({ ...options, skills: 'antdv' }, { prepare: officialFixture, progress() {} });
+    assert.equal(result.detection.antdv.tool.source, `${scope}-tool`);
+    assert.ok(fs.existsSync(path.join(resultTool(options), 'node_modules/@antdv-next/cli/package.json')));
+    assert.equal(fs.existsSync(path.join(options.project, '.prototype-tools')), false);
+    assert.equal(fs.existsSync(path.join(options.project, 'package.json')), false);
+    if (scope === 'global') assert.deepEqual(fs.readdirSync(options.project), []);
+  });
+}
+test('an available global tool is reused by a later project without project writes', async t => {
+  const options = workspace(t);
+  await installer.install({ ...options, host: 'codex', scope: 'global', skills: 'antdv' }, { prepare: officialFixture, progress() {} });
+  const result = await installer.install({ ...options, host: 'codex', skills: 'antdv' }, { prepare() { throw new Error('No download expected'); } });
+  assert.equal(result.status, 'reused');
+  assert.equal(result.detection.antdv.tool.source, 'global-tool');
+  assert.deepEqual(fs.readdirSync(options.project), []);
+});
+test('legacy independent tools stay readable until an explicit owned migration', async t => {
+  const options = workspace(t), legacy = path.join(options.project, '.prototype-tools/antdv-cli');
+  const stage = path.join(options.project, 'fixture'); fs.mkdirSync(stage);
+  const prepared = officialFixture('antdv', stage);
+  fs.mkdirSync(path.dirname(legacy)); fs.renameSync(prepared.tool, legacy); fs.rmSync(stage, { recursive: true });
+  fs.writeFileSync(path.join(legacy, 'UPSTREAM-ORIGIN.json'), JSON.stringify({ ...require(path.join(skills, 'i3-ui-prototype/assets/optional-skills/sources.json')).antdv, installer: 'i3 optional dependency preparation; official Skill body unchanged' }));
+  assert.equal(deps.check(options).antdv.tool.source, 'legacy-project-tool');
+  await installer.install({ ...options, skills: 'antdv' }, { prepare: officialFixture, progress() {} });
+  assert.equal(fs.existsSync(legacy), true);
+  fs.writeFileSync(path.join(options.project, '.prototype-tools/user-note.txt'), 'keep this location');
+  await installer.install({ ...options, scope: 'global', skills: 'antdv' }, { prepare: officialFixture, progress() {} });
+  assert.equal(deps.check(options).antdv.tool.source, 'global-tool', 'normal lookup prefers a current global tool over legacy');
+  const result = await installer.install({ ...options, skills: 'antdv', migrateTools: true }, { prepare() { throw new Error('No download expected'); } });
+  assert.equal(result.status, 'migrated');
+  assert.equal(result.detection.antdv.tool.source, 'project-tool');
+  assert.equal(fs.existsSync(legacy), false);
+  assert.equal(fs.readFileSync(path.join(options.project, '.prototype-tools/user-note.txt'), 'utf8'), 'keep this location');
+});
+test('legacy mixed tools without i3 ownership remain untouched by migration', async t => {
+  const options = workspace(t), stage = path.join(options.project, 'fixture'); fs.mkdirSync(stage);
+  const prepared = officialFixture('antdv', stage), legacy = path.join(options.project, '.prototype-tools/antdv-cli');
+  fs.mkdirSync(path.dirname(legacy)); fs.renameSync(prepared.tool, legacy); fs.rmSync(stage, { recursive: true });
+  await assert.rejects(installer.install({ ...options, skills: 'antdv', migrateTools: true }, { prepare() { throw new Error('No download expected'); } }), /ownership|来源|归属/);
+  assert.equal(deps.check(options).antdv.tool.source, 'legacy-project-tool');
+});
+test('a broken project tool is reported instead of silently borrowing a healthy global tool', async t => {
+  const options = workspace(t);
+  await installer.install({ ...options, scope: 'global', skills: 'antdv' }, { prepare: officialFixture, progress() {} });
+  const local = path.join(options.project, '.codebuddy/tools/i3-prototype/antdv-cli/node_modules/@antdv-next/cli');
+  fs.mkdirSync(local, { recursive: true }); fs.writeFileSync(path.join(local, 'package.json'), '{broken');
+  assert.equal(deps.check(options).antdv.tool.availability, 'unusable');
+  assert.equal(deps.check({ ...options, scope: 'global' }).antdv.tool.availability, 'available');
+  await assert.rejects(installer.install({ ...options, skills: 'antdv' }), /Existing tool unusable/);
+  assert.equal(fs.readFileSync(path.join(local, 'package.json'), 'utf8'), '{broken');
+});
+test('failed post-migration execution restores the old location and removes newly created destinations', async t => {
+  const options = workspace(t), stage = path.join(options.project, 'fixture'); fs.mkdirSync(stage);
+  const prepared = officialFixture('antdv', stage), legacy = path.join(options.project, '.prototype-tools/antdv-cli');
+  fs.mkdirSync(path.dirname(legacy)); fs.renameSync(prepared.tool, legacy); fs.rmSync(stage, { recursive: true });
+  const file = path.join(legacy, 'node_modules/@antdv-next/cli/cli.cjs');
+  fs.writeFileSync(file, 'if(__dirname.includes("tools/i3-prototype"))process.exit(1);process.stdout.write(JSON.stringify({name:"Table",props:[]}));');
+  fs.writeFileSync(path.join(legacy, 'UPSTREAM-ORIGIN.json'), JSON.stringify({ ...require(path.join(skills, 'i3-ui-prototype/assets/optional-skills/sources.json')).antdv, installer: 'i3 optional dependency preparation; official Skill body unchanged' }));
+  await assert.rejects(installer.install({ ...options, skills: 'antdv', migrateTools: true }, { prepare: officialFixture, progress() {} }), /tool query failed/);
+  assert.equal(deps.check(options).antdv.tool.source, 'legacy-project-tool');
+  assert.equal(fs.existsSync(path.join(options.project, '.codebuddy')), false);
+  assert.ok(fs.existsSync(file));
+});
+test('unusable existing UIUX resources are preserved without attempting a download', async t => {
+  const options = workspace(t), target = path.join(options.project, '.codebuddy/skills/ui-ux-pro-max');
+  fs.mkdirSync(target, { recursive: true }); fs.writeFileSync(path.join(target, 'SKILL.md'), 'human-owned incomplete skill');
+  await assert.rejects(installer.install({ ...options, skills: 'uiux' }, { prepare() { throw new Error('must not download'); } }), /Existing Skill preserved/);
+  assert.equal(fs.readFileSync(path.join(target, 'SKILL.md'), 'utf8'), 'human-owned incomplete skill');
+});
+test('optional installer rejects symlink escapes, including dangling targets, and bad download bytes', async t => {
+  const options = workspace(t), outside = path.join(options.project, 'outside');
+  fs.symlinkSync(outside, path.join(options.project, '.codebuddy'), 'dir');
+  await assert.rejects(installer.install({ ...options, skills: 'antdv' }, { prepare: officialFixture }), /symlink/);
+  assert.equal(fs.existsSync(outside), false);
+  assert.throws(() => installer.verify(Buffer.from('altered'), '0'.repeat(64)), /integrity mismatch/);
+});

package/scripts/ui-prototype-devtools-test.js

@@ -0,0 +1,53 @@
+'use strict';
+const test=require('node:test'),assert=require('node:assert/strict'),fs=require('node:fs'),path=require('node:path'),os=require('node:os');
+const installationFile=path.join(__dirname,'lib/installation.js');
+const skills=fs.existsSync(installationFile)?require(installationFile).loadInstallation().skillsDirectory:path.resolve(__dirname,'../skills');
+const review=require(path.join(skills,'i3-ui-prototype/scripts/native-devtools.cjs'));
+// Synthetic contract fixtures only; none is browser or host invocation evidence.
+function fixture(t){
+ const directory=fs.mkdtempSync(path.join(os.tmpdir(),'devtools-review-'));t.after(()=>fs.rmSync(directory,{recursive:true,force:true}));
+ const write=(file,value)=>{const full=path.join(directory,file);fs.mkdirSync(path.dirname(full),{recursive:true});fs.writeFileSync(full,Buffer.isBuffer(value)||typeof value==='string'?value:JSON.stringify(value));};
+ const current={revision:'r001',digest:'a'.repeat(64)},build={buildId:'b-fixture',buildDigest:'b'.repeat(64)};
+ write('inputs/acceptance.json',{browserReview:review.policy()});
+ const png=Buffer.from('iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mP8/x8AAwMCAO+ip1sAAAAASUVORK5CYII=','base64');
+ const observations={};for(const kind of review.KINDS){const evidence=`qa/fixture/${kind}.${kind==='screenshot'?'png':kind==='performance'?'json':'txt'}`;write(evidence,kind==='screenshot'?png:kind==='performance'?{traceEvents:[{name:'synthetic-fixture',ts:1}]}:`Synthetic ${kind} fixture; not executed`);observations[kind]={status:'passed',summary:'Synthetic guard fixture, not executed',evidence};}
+ const report={schemaVersion:1,status:'passed',revision:current.revision,candidateDigest:current.digest,...build,executor:'synthetic-unit-fixture',startedAt:'2026-10-17T00:00:00.000Z',completedAt:'2026-10-17T00:00:01.000Z',previewBaseURL:'http://127.0.0.1:4173/',skill:{name:review.policy().skill,toolCallId:'fixture-skill',evidence:'synthetic-fixture only'},mcp:{name:'chrome-devtools-mcp',version:'1.11.0',evidence:'synthetic-fixture only',calls:['evaluate_script','take_screenshot','list_console_messages','list_network_requests','take_snapshot','performance_start_trace','performance_stop_trace'].map((name,index)=>({tool:`mcp__chrome-devtools__${name}`,toolCallId:`fixture-${index}`}))},observations,openItems:[]};
+ const lib={manifest:()=>current,verifyBuild:(_root,id)=>{assert.equal(id,build.buildId);return build;},claim:()=>{},release:()=>{}};
+ return {directory,write,current,build,report,lib};
+}
+test('new DevTools policy is explicit; old fixed inputs remain read-only and not required',t=>{
+ const f=fixture(t);assert.equal(review.check(f.directory,f.lib).status,'not-run');
+ f.write('inputs/acceptance.json',{});const before=fs.readdirSync(f.directory);assert.deepEqual(review.check(f.directory,f.lib),{status:'not-required',required:false});assert.deepEqual(fs.readdirSync(f.directory),before);
+});
+test('fixed framework inputs retain all six DevTools observations and reject policy removal',t=>{
+ const f=fixture(t);f.write('inputs/framework.json',{acceptance:{browserReview:review.policy()}});
+ for(const mutate of [value=>delete value.browserReview,value=>value.browserReview.required=false,value=>value.browserReview.observations.pop()]){
+  const input={browserReview:review.policy()};mutate(input);f.write('inputs/acceptance.json',input);
+  assert.equal(review.check(f.directory,f.lib).status,'failed');assert.throws(()=>review.record(f.directory,f.report,f.lib),/policy|observations|opt out/);
+ }
+});
+test('a review binds six actual-format evidence files to current candidate and build without attesting invocation',t=>{
+ const f=fixture(t),before=f.current.digest;const result=review.record(f.directory,f.report,f.lib);
+ assert.equal(result.status,'passed');assert.equal(result.invocationVerified,false);assert.equal(f.current.digest,before);
+ const checked=review.check(f.directory,f.lib);assert.equal(checked.status,'current');assert.equal(Object.keys(checked.evidenceDigests).length,6);
+ assert.match(checked.limitations,/host transcript/);
+});
+test('missing observation, stale identity and substituted evidence cannot pass the review gate',t=>{
+ const f=fixture(t);
+ for(const mutate of [r=>delete r.observations.network,r=>r.observations.console.status='not-run',r=>r.candidateDigest='c'.repeat(64),r=>r.buildDigest='c'.repeat(64),r=>r.skill.name='other-skill',r=>r.mcp.calls=r.mcp.calls.filter(c=>!c.tool.endsWith('performance_stop_trace')),r=>r.observations.network.evidence=r.observations.dom.evidence]){
+  const report=structuredClone(f.report);mutate(report);assert.throws(()=>review.record(f.directory,report,f.lib));assert.equal(fs.existsSync(path.join(f.directory,'qa/devtools-review.json')),false);
+ }
+ review.record(f.directory,f.report,f.lib);f.write(f.report.observations.network.evidence,'changed QA artifact');assert.equal(review.check(f.directory,f.lib).status,'failed');
+});
+test('Playwright ZIP and mislabeled screenshots do not become DevTools trace or PNG evidence',t=>{
+ const f=fixture(t);f.write(f.report.observations.performance.evidence,Buffer.from('PK\x03\x04fake-playwright-trace'));assert.throws(()=>review.record(f.directory,f.report,f.lib),/trace|JSON/);
+ f.write(f.report.observations.performance.evidence,{traceEvents:[{name:'fixture'}]});f.write(f.report.observations.screenshot.evidence,'not a PNG');assert.throws(()=>review.record(f.directory,f.report,f.lib),/PNG/);
+});
+test('a truncated PNG header is not a complete screenshot artifact',t=>{
+ const f=fixture(t),fake=Buffer.alloc(24);Buffer.from([137,80,78,71,13,10,26,10]).copy(fake);fake.write('IHDR',12);fake.writeUInt32BE(1,16);fake.writeUInt32BE(1,20);f.write(f.report.observations.screenshot.evidence,fake);
+ assert.throws(()=>review.record(f.directory,f.report,f.lib),/PNG/);
+});
+test('evidence paths cannot escape QA through traversal or symlinks',t=>{
+ const f=fixture(t),r=structuredClone(f.report);r.observations.dom.evidence='../outside.txt';assert.throws(()=>review.record(f.directory,r,f.lib),/QA|path/);
+ const link=path.join(f.directory,'qa/link.txt');fs.symlinkSync(path.join(f.directory,f.report.observations.dom.evidence),link);r.observations.dom.evidence='qa/link.txt';assert.throws(()=>review.record(f.directory,r,f.lib),/symlink/);
+});