@gitroll/tacitt-cli 0.6.9 → 0.6.10

package/skills/tacitt/scripts/journey.mjs

@@ -22,6 +22,7 @@ import {
   uncoveredPending,
 } from './journey-state.mjs'
 import { classificationTasks } from './journey-classification-tasks.mjs'
+import { validateLatePlacedWorks } from './journey-classification-validation.mjs'
 import { classificationEvidence, classificationFormat } from './journey-classification.mjs'
 import {
   consolidateClassification,
@@ -514,7 +515,7 @@ async function runPhaseCore(
         ? { expectedClassificationRevision: manifest.partial.revision }
         : {}),
       ...(stage === 'classification'
-        ? { [key]: await classificationSubmission(manifest, view) }
+        ? { [key]: await classificationItems(manifest, view) }
         : stage === 'cards'
           ? cards
           : { [key]: await answers(tasks, key) }),
@@ -549,6 +550,16 @@ async function runPhaseCore(
   return { stage, status: result.status, revision: result.state?.revision }
 }
 
+/**
+ * The complete proposal, checked before commit: after scope confirmation an item never joins
+ * placed Works with different visibility (ADR 0274), which CLI would refuse.
+ */
+async function classificationItems(manifest, view) {
+  const items = await classificationSubmission(manifest, view)
+  if (view.scope?.status === 'confirmed') validateLatePlacedWorks(items, view.works)
+  return items
+}
+
 /** Classification published known Works and is still grouping the remaining roots (E2). */
 const grouping = (view) => view.works.some((work) => work.placement === 'classifying')
 
@@ -591,6 +602,7 @@ async function ingestKnownWorks(directory, manifest, view, call, partial) {
 
 const terminalClassificationErrors = new Set([
   'INVALID_SELECTION',
+  'CLASSIFICATION_LATE_SEVERAL_WORKS',
   'CLASSIFICATION_PROJECT_NAME_CONFLICT',
   'CLASSIFICATION_ROOT_COVERAGE_INVALID',
   'CLASSIFICATION_THEME_TOO_SMALL',
@@ -665,13 +677,31 @@ export async function main(argv) {
     ),
   )
 }
+const safeId = /^[A-Za-z0-9._:-]{1,128}$/u
+/**
+ * Stderr for a failed command: the code, and for CLASSIFICATION_LATE_SEVERAL_WORKS one line per
+ * refused item with its index and the placed Work ids, never a title or path (ADR 0274).
+ */
+export function failureOutput(error) {
+  const message = error?.message ?? ''
+  const code = /^[A-Z_]{3,80}$/u.test(message) ? message : 'JOURNEY_HELPER_FAILED'
+  const lines = [code]
+  if (code === 'CLASSIFICATION_LATE_SEVERAL_WORKS')
+    for (const conflict of error.conflicts ?? [])
+      if (Number.isInteger(conflict.item))
+        lines.push(
+          `items[${conflict.item}] joins Works ${conflict.workIds
+            .map((id) => (safeId.test(id) ? id : '?'))
+            .join(', ')}`,
+        )
+  return lines.join('\n') + '\n'
+}
 const entry = process.argv[1]
 if (entry && (await realpath(entry)) === fileURLToPath(import.meta.url))
   main(process.argv.slice(2)).then(
     (result) => process.stdout.write(JSON.stringify({ ok: true, ...result }) + '\n'),
     (error) => {
-      const code = /^[A-Z_]{3,80}$/u.test(error.message) ? error.message : 'JOURNEY_HELPER_FAILED'
-      process.stderr.write(code + '\n')
+      process.stderr.write(failureOutput(error))
       process.exitCode = 1
     },
   )

package/skills/tacitt/scripts/privacy-validator.mjs

@@ -10131,7 +10131,8 @@ const journeyWorkSchema = object({
 		"default",
 		"model",
 		"explicit",
-		"delegate"
+		"delegate",
+		"account"
 	]),
 	placement: _enum([
 		"placed",
@@ -10148,6 +10149,15 @@ const journeyWorkSchema = object({
 	grouping: _enum(["workspace", "regrouped"]),
 	access: journeyAccessSchema,
 	accessConfirmed: boolean(),
+	accessChoice: object({
+		channel: _enum([
+			"conversation",
+			"panel",
+			"account"
+		]),
+		at: datetime()
+	}).strict().optional(),
+	accountAccessConflict: boolean().optional(),
 	reason: string().max(1e3),
 	revision: count$1,
 	inputRevision: count$1.min(1),

package/skills/tacitt/scripts/review.mjs

@@ -85,9 +85,21 @@ class HelperError extends Error {
     super(code)
     this.code = /^[A-Z_]{3,80}$/u.test(code) ? code : 'HELPER_FAILED'
     if (
-      code === 'INVALID_REVIEW_SPAN' &&
       typeof field === 'string' &&
-      /^terms\[\d+(?:,\d+){0,31}\]$/u.test(field)
+      ((code === 'INVALID_REVIEW_SPAN' && /^terms\[\d+(?:,\d+){0,31}\]$/u.test(field)) ||
+        (code === 'INVALID_SELECTION' &&
+          [
+            'cards.append.empty',
+            'cards.append.limit',
+            'cards.append.duplicate-card',
+            'cards.append.existing-card',
+            'cards.append.duplicate-extension',
+            'cards.append.unknown-card',
+            'cards.append.duplicate-term',
+            'cards.append.term-not-open',
+            'cards.append.own-identity-card',
+            'cards.append.other-person',
+          ].includes(field)))
     )
       this.field = field
   }