@gitlab/ui 66.31.0 → 66.31.1

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [66.31.1](https://gitlab.com/gitlab-org/gitlab-ui/compare/v66.31.0...v66.31.1) (2023-10-13)
+
+
+### Bug Fixes
+
+* **GlCollapsibleListbox:** Visibility of Reset button ([f71f767](https://gitlab.com/gitlab-org/gitlab-ui/commit/f71f767553a93237167c65772479e990c8913f93))
+
 # [66.31.0](https://gitlab.com/gitlab-org/gitlab-ui/compare/v66.30.0...v66.31.0) (2023-10-13)
 
 

package/dist/components/base/new_dropdowns/listbox/listbox.js

@@ -408,10 +408,9 @@ var script = {
       if (!this.selected || this.selected.length === 0) {
         return false;
       }
-      if (this.multiple) {
-        return this.selected.length === this.flattenedOptions.length;
-      }
-      return Boolean(this.selected);
+
+      // only show reset button if show all button is not there
+      return !this.showSelectAllButton;
     },
     showSelectAllButton() {
       if (!this.showSelectAllButtonLabel) {

package/dist/tokens/css/tokens.css

@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri, 13 Oct 2023 10:34:59 GMT
+ * Generated on Fri, 13 Oct 2023 20:03:52 GMT
  */
 
 :root {

package/dist/tokens/css/tokens.dark.css

@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri, 13 Oct 2023 10:34:59 GMT
+ * Generated on Fri, 13 Oct 2023 20:03:52 GMT
  */
 
 :root {

package/dist/tokens/js/tokens.dark.js

@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri, 13 Oct 2023 10:34:59 GMT
+ * Generated on Fri, 13 Oct 2023 20:03:52 GMT
  */
 
 export const BLACK = "#fff";

package/dist/tokens/js/tokens.js

@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Fri, 13 Oct 2023 10:34:59 GMT
+ * Generated on Fri, 13 Oct 2023 20:03:52 GMT
  */
 
 export const BLACK = "#000";

package/dist/tokens/scss/_tokens.dark.scss

@@ -1,6 +1,6 @@
 
 // Do not edit directly
-// Generated on Fri, 13 Oct 2023 10:34:59 GMT
+// Generated on Fri, 13 Oct 2023 20:03:52 GMT
 
 $red-950: #fff4f3;
 $red-900: #fcf1ef;

package/dist/tokens/scss/_tokens.scss

@@ -1,6 +1,6 @@
 
 // Do not edit directly
-// Generated on Fri, 13 Oct 2023 10:34:59 GMT
+// Generated on Fri, 13 Oct 2023 20:03:52 GMT
 
 $gl-line-height-52: 3.25rem;
 $gl-line-height-44: 2.75rem;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/ui",
-  "version": "66.31.0",
+  "version": "66.31.1",
   "description": "GitLab UI Components",
   "license": "MIT",
   "main": "dist/index.js",

package/src/components/base/new_dropdowns/listbox/listbox.spec.js

@@ -517,6 +517,18 @@ describe('GlCollapsibleListbox', () => {
       }
     );
 
+    it('shows the button if the label is provided and only one option is selected in multi select', () => {
+      buildWrapper({
+        headerText: 'Select assignee',
+        resetButtonLabel: 'Unassign',
+        items: mockOptions,
+        multiple: true,
+        selected: mockOptionsValues.slice(0, 1),
+      });
+
+      expect(findResetButton().exists()).toBe(true);
+    });
+
     it.each`
       description        | props
       ${'multi-select'}  | ${{ multiple: true, selected: [] }}
@@ -598,6 +610,7 @@ describe('GlCollapsibleListbox', () => {
     describe.each`
       multiple | resetVisible | selectAllVisible | selected
       ${false} | ${false}     | ${false}         | ${[]}
+      ${false} | ${false}     | ${false}         | ${undefined}
       ${true}  | ${false}     | ${true}          | ${[]}
     `(
       'when label is provided, selection is empty and multiple option is $multiple',
@@ -623,6 +636,20 @@ describe('GlCollapsibleListbox', () => {
       }
     );
 
+    it('when label is provided and one option is selected in multiselect', () => {
+      buildWrapper({
+        headerText: 'Select assignee',
+        resetButtonLabel: 'Unassign',
+        showSelectAllButtonLabel: 'Select All',
+        items: mockOptions,
+        selected: mockOptionsValues.slice(0, 1),
+        multiple: true,
+      });
+
+      expect(findSelectAllButton().exists()).toBe(true);
+      expect(findResetButton().exists()).toBe(false);
+    });
+
     it('hides select all button if dropdown has no items', () => {
       buildWrapper({
         headerText: 'Select assignee',

package/src/components/base/new_dropdowns/listbox/listbox.vue

@@ -419,10 +419,8 @@ export default {
         return false;
       }
 
-      if (this.multiple) {
-        return this.selected.length === this.flattenedOptions.length;
-      }
-      return Boolean(this.selected);
+      // only show reset button if show all button is not there
+      return !this.showSelectAllButton;
     },
     showSelectAllButton() {
       if (!this.showSelectAllButtonLabel) {

package/src/components/base/tabs/tabs/tabs.spec.js

@@ -1,6 +1,6 @@
 import { mount } from '@vue/test-utils';
 import { nextTick } from 'vue';
-import { GlButton } from '../../../../index';
+import GlButton from '../../button/button.vue';
 import { tabsButtonDefaults } from '../../../../utils/constants';
 import GlTab from '../tab/tab.vue';
 import GlTabs from './tabs.vue';

package/src/components/experimental/duo/chat/components/duo_chat_message/duo_chat_message.spec.js

@@ -1,6 +1,6 @@
 import { nextTick } from 'vue';
 import { shallowMount } from '@vue/test-utils';
-import { GlDuoUserFeedback } from '../../../../../../index';
+import GlDuoUserFeedback from '../../../user_feedback/user_feedback.vue';
 import {
   MOCK_USER_PROMPT_MESSAGE,
   MOCK_RESPONSE_MESSAGE,

package/src/components/experimental/duo/chat/components/duo_chat_message_sources/duo_chat_message_sources.spec.js

@@ -1,5 +1,6 @@
 import { shallowMount } from '@vue/test-utils';
-import { GlIcon, GlLink } from '../../../../../../index';
+import GlIcon from '../../../../../base/icon/icon.vue';
+import GlLink from '../../../../../base/link/link.vue';
 import { DOCUMENTATION_SOURCE_TYPES } from '../../constants';
 import GlDuoChatMessageSources from './duo_chat_message_sources.vue';
 

package/src/components/experimental/duo/chat/components/duo_chat_predefined_prompts/duo_chat_predefined_prompts.spec.js

@@ -1,5 +1,5 @@
 import { shallowMount } from '@vue/test-utils';
-import { GlButton } from '../../../../../../index';
+import GlButton from '../../../../../base/button/button.vue';
 import GlDuoChatPredefinedPrompts from './duo_chat_predefined_prompts.vue';
 
 describe('GlDuoChatPredefinedPrompts', () => {

package/src/components/experimental/duo/user_feedback/user_feedback.spec.js

@@ -1,6 +1,6 @@
 import { nextTick } from 'vue';
 import { shallowMount } from '@vue/test-utils';
-import { GlButton } from '../../../../index';
+import GlButton from '../../../base/button/button.vue';
 import FeedbackModal from './user_feedback_modal.vue';
 import UserFeedback, { i18n } from './user_feedback.vue';
 

package/src/components/experimental/duo/user_feedback/user_feedback.stories.js

@@ -1,4 +1,6 @@
-import { GlAlert, GlFormGroup, GlFormTextarea } from '../../../../index';
+import GlAlert from '../../../base/alert/alert.vue';
+import GlFormGroup from '../../../base/form/form_group/form_group.vue';
+import GlFormTextarea from '../../../base/form/form_textarea/form_textarea.vue';
 import GlDuoUserFeedback from './user_feedback.vue';
 import readme from './user_feedback.md';
 

package/src/components/experimental/duo/user_feedback/user_feedback_modal.spec.js

@@ -1,5 +1,8 @@
 import { shallowMount } from '@vue/test-utils';
-import { GlModal, GlFormCheckboxGroup, GlFormCheckbox, GlFormTextarea } from '../../../../index';
+import GlModal from '../../../base/modal/modal.vue';
+import GlFormCheckbox from '../../../base/form/form_checkbox/form_checkbox.vue';
+import GlFormCheckboxGroup from '../../../base/form/form_checkbox/form_checkbox_group.vue';
+import GlFormTextarea from '../../../base/form/form_textarea/form_textarea.vue';
 import FeedbackModal, { feedbackOptions } from './user_feedback_modal.vue';
 
 const DummyComponent = {