@gitlab/ui 64.6.0 → 64.6.1

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [64.6.1](https://gitlab.com/gitlab-org/gitlab-ui/compare/v64.6.0...v64.6.1) (2023-06-08)
+
+
+### Bug Fixes
+
+* **GlChart:** ResizeObserver loop limit exceeded on responsive charts ([7952ae8](https://gitlab.com/gitlab-org/gitlab-ui/commit/7952ae86a22e200ff2bc4f9f8cf172de8e30b6f2))
+
 # [64.6.0](https://gitlab.com/gitlab-org/gitlab-ui/compare/v64.5.0...v64.6.0) (2023-06-08)
 
 

package/dist/components/charts/chart/chart.js

@@ -2,6 +2,7 @@ import * as echarts from 'echarts';
 import { validRenderers, defaultWidth, defaultHeight, toolboxHeight } from '../../../utils/charts/config';
 import { themeName, createTheme } from '../../../utils/charts/theme';
 import { GlResizeObserverDirective } from '../../../directives/resize_observer/resize_observer';
+import { debounceByAnimationFrame } from '../../../utils/utils';
 import __vue_normalize__ from 'vue-runtime-helpers/dist/normalize-component.js';
 
 //
@@ -90,7 +91,8 @@ var script = {
   },
   data() {
     return {
-      chart: null
+      chart: null,
+      debouncedHandleResize: debounceByAnimationFrame(this.handleResize)
     };
   },
   computed: {
@@ -169,7 +171,7 @@ var script = {
       });
     },
     handleResize() {
-      if (this.responsive) this.chart.resize();
+      this.chart.resize();
     }
   }
 };
@@ -178,7 +180,7 @@ var script = {
 const __vue_script__ = script;
 
 /* template */
-var __vue_render__ = function () {var _vm=this;var _h=_vm.$createElement;var _c=_vm._self._c||_h;return _c('div',{directives:[{name:"resize-observer",rawName:"v-resize-observer",value:(_vm.handleResize),expression:"handleResize"}],ref:"chart"})};
+var __vue_render__ = function () {var _vm=this;var _h=_vm.$createElement;var _c=_vm._self._c||_h;return _c('div',{directives:[{name:"resize-observer",rawName:"v-resize-observer:[responsive]",value:(_vm.debouncedHandleResize),expression:"debouncedHandleResize",arg:_vm.responsive}],ref:"chart"})};
 var __vue_staticRenderFns__ = [];
 
   /* style */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/ui",
-  "version": "64.6.0",
+  "version": "64.6.1",
   "description": "GitLab UI Components",
   "license": "MIT",
   "main": "dist/index.js",

package/src/components/charts/chart/chart.spec.js

@@ -2,6 +2,7 @@ import { shallowMount } from '@vue/test-utils';
 import * as echarts from 'echarts';
 import { toolboxHeight } from '~/utils/charts/config';
 import { createTheme } from '~/utils/charts/theme';
+import { waitForAnimationFrame } from '~/utils/test_utils';
 import { useMockResizeObserver } from '~helpers/mock_dom_observer';
 import Chart from './chart.vue';
 
@@ -47,15 +48,19 @@ describe('chart component', () => {
     expect(wrapper.vm.chart.resize).toHaveBeenCalledTimes(1);
 
     triggerResize(wrapper.element);
+    await waitForAnimationFrame();
+
     expect(wrapper.vm.chart.resize).toHaveBeenCalledTimes(1);
   });
 
-  it('resizes the chart when responsive = true', async () => {
+  it('resizes the chart only once per animation frame when responsive = true', async () => {
     wrapper = shallowMount(Chart, { propsData: { options: {}, responsive: true } });
     await wrapper.vm.$nextTick();
     expect(wrapper.vm.chart.resize).toHaveBeenCalledTimes(1);
 
     triggerResize(wrapper.element);
+    triggerResize(wrapper.element);
+    await waitForAnimationFrame();
 
     expect(wrapper.vm.chart.resize).toHaveBeenCalledTimes(2);
   });

package/src/components/charts/chart/chart.vue

@@ -9,6 +9,7 @@ import {
 } from '../../../utils/charts/config';
 import { createTheme, themeName } from '../../../utils/charts/theme';
 import { GlResizeObserverDirective } from '../../../directives/resize_observer/resize_observer';
+import { debounceByAnimationFrame } from '../../../utils/utils';
 
 /**
  * Allowed values by eCharts
@@ -95,6 +96,7 @@ export default {
   data() {
     return {
       chart: null,
+      debouncedHandleResize: debounceByAnimationFrame(this.handleResize),
     };
   },
   computed: {
@@ -175,12 +177,12 @@ export default {
       this.$emit('chartItemClicked', { chart: this.chart, params });
     },
     handleResize() {
-      if (this.responsive) this.chart.resize();
+      this.chart.resize();
     },
   },
 };
 </script>
 
 <template>
-  <div ref="chart" v-resize-observer="handleResize"></div>
+  <div ref="chart" v-resize-observer:[responsive]="debouncedHandleResize"></div>
 </template>