@gitlab/ui 64.11.0 → 64.11.1

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [64.11.1](https://gitlab.com/gitlab-org/gitlab-ui/compare/v64.11.0...v64.11.1) (2023-06-19)
+
+
+### Bug Fixes
+
+* **GlCollapsibleListbox:** revert to previous clear all logic ([a9ef6d6](https://gitlab.com/gitlab-org/gitlab-ui/commit/a9ef6d6ce69b470be3d2f0c1471d164e0eea24bd))
+
 # [64.11.0](https://gitlab.com/gitlab-org/gitlab-ui/compare/v64.10.2...v64.11.0) (2023-06-16)
 
 

package/dist/components/base/new_dropdowns/listbox/listbox.js

@@ -399,7 +399,7 @@ var script = {
         return false;
       }
       if (this.multiple) {
-        return this.selected.length === this.items.length;
+        return this.selected.length > 0;
       }
       return Boolean(this.selected);
     },
@@ -418,7 +418,7 @@ var script = {
       if (!this.hasItems) {
         return false;
       }
-      return this.selected.length !== this.items.length;
+      return this.selected.length === 0;
     },
     showIntersectionObserver() {
       return this.infiniteScroll && !this.infiniteScrollLoading && !this.loading && !this.searching;

package/dist/components/base/new_dropdowns/listbox/mock_data.js

@@ -35,12 +35,6 @@ const mockOptions = [{
   value: 'sup',
   text: 'Support'
 }];
-const mockOptionsValues = mockOptions.map(_ref => {
-  let {
-    value
-  } = _ref;
-  return value;
-});
 const mockGroups = [{
   text: 'Branches',
   options: [{
@@ -109,4 +103,4 @@ const mockUsers = [{
   icon: 'bin'
 }];
 
-export { mockGroups, mockGroupsWithTextSrOnly, mockOptions, mockOptionsValues, mockUsers };
+export { mockGroups, mockGroupsWithTextSrOnly, mockOptions, mockUsers };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/ui",
-  "version": "64.11.0",
+  "version": "64.11.1",
   "description": "GitLab UI Components",
   "license": "MIT",
   "main": "dist/index.js",

package/src/components/base/new_dropdowns/listbox/listbox.spec.js

@@ -18,7 +18,7 @@ import GlIntersectionObserver from '../../../utilities/intersection_observer/int
 import GlCollapsibleListbox, { ITEM_SELECTOR } from './listbox.vue';
 import GlListboxItem from './listbox_item.vue';
 import GlListboxGroup from './listbox_group.vue';
-import { mockOptions, mockOptionsValues, mockGroups, mockGroupsWithTextSrOnly } from './mock_data';
+import { mockOptions, mockGroups, mockGroupsWithTextSrOnly } from './mock_data';
 
 jest.mock('@floating-ui/dom');
 autoUpdate.mockImplementation(() => {
@@ -485,16 +485,16 @@ describe('GlCollapsibleListbox', () => {
     });
 
     it.each`
-      title      | multiple | selected
-      ${'shows'} | ${true}  | ${mockOptionsValues}
-      ${'hides'} | ${false} | ${mockOptions[1].value}
+      multiple
+      ${true}
+      ${false}
     `(
-      '$title the reset button if the label is provided and the selection is complete and mode if multiple mode is $multiple',
-      ({ multiple, selected }) => {
+      'shows the reset button if the label is provided and the selection is not empty and mode if multiple mode is $multiple',
+      ({ multiple }) => {
         buildWrapper({
           headerText: 'Select assignee',
           resetButtonLabel: 'Unassign',
-          selected,
+          selected: mockOptions[1].value,
           items: mockOptions,
           multiple,
         });
@@ -503,7 +503,7 @@ describe('GlCollapsibleListbox', () => {
       }
     );
 
-    it('hides reset button if the label is provided and the selection is not complete', () => {
+    it('shows the reset button if the label is provided and the selection is not empty', () => {
       buildWrapper({
         headerText: 'Select assignee',
         resetButtonLabel: 'Unassign',
@@ -512,7 +512,7 @@ describe('GlCollapsibleListbox', () => {
         multiple: true,
       });
 
-      expect(findResetButton().exists()).toBe(false);
+      expect(findResetButton().text()).toBe('Unassign');
     });
 
     it('hides reset button if dropdown has no items', () => {
@@ -546,7 +546,7 @@ describe('GlCollapsibleListbox', () => {
       buildWrapper({
         headerText: 'Select assignee',
         resetButtonLabel: 'Unassign',
-        selected: mockOptionsValues,
+        selected: mockOptions[1].value,
         items: mockOptions,
         multiple: true,
       });
@@ -605,32 +605,6 @@ describe('GlCollapsibleListbox', () => {
       expect(findSelectAllButton().exists()).toBe(false);
     });
 
-    it('hides select all button if all items are selected', () => {
-      buildWrapper({
-        headerText: 'Select assignee',
-        resetButtonLabel: 'Unassign',
-        showSelectAllButtonLabel: 'Select All',
-        selected: mockOptionsValues,
-        items: mockOptions,
-        multiple: true,
-      });
-
-      expect(findSelectAllButton().exists()).toBe(false);
-    });
-
-    it('has the label text "Select All" if the label is provided and some items are selected', () => {
-      buildWrapper({
-        headerText: 'Select assignee',
-        resetButtonLabel: 'Unassign',
-        showSelectAllButtonLabel: 'Select All',
-        selected: [mockOptions[1].value],
-        items: mockOptions,
-        multiple: true,
-      });
-
-      expect(findSelectAllButton().text()).toBe('Select All');
-    });
-
     it('has the label text "Select All" if the label is provided and the selection is empty', () => {
       buildWrapper({
         headerText: 'Select assignee',

package/src/components/base/new_dropdowns/listbox/listbox.vue

@@ -411,7 +411,7 @@ export default {
       }
 
       if (this.multiple) {
-        return this.selected.length === this.items.length;
+        return this.selected.length > 0;
       }
       return Boolean(this.selected);
     },
@@ -432,7 +432,7 @@ export default {
         return false;
       }
 
-      return this.selected.length !== this.items.length;
+      return this.selected.length === 0;
     },
     showIntersectionObserver() {
       return this.infiniteScroll && !this.infiniteScrollLoading && !this.loading && !this.searching;

package/src/components/base/new_dropdowns/listbox/mock_data.js

@@ -49,8 +49,6 @@ export const mockOptions = [
   },
 ];
 
-export const mockOptionsValues = mockOptions.map(({ value }) => value);
-
 export const mockGroups = [
   {
     text: 'Branches',