@gitlab/ui 62.11.0 → 62.12.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/ui",
-  "version": "62.11.0",
+  "version": "62.12.1",
   "description": "GitLab UI Components",
   "license": "MIT",
   "main": "dist/index.js",
@@ -89,22 +89,22 @@
     "@gitlab/eslint-plugin": "19.0.0",
     "@gitlab/fonts": "^1.2.0",
     "@gitlab/stylelint-config": "4.1.0",
-    "@gitlab/svgs": "3.45.0",
+    "@gitlab/svgs": "3.46.0",
     "@rollup/plugin-commonjs": "^11.1.0",
     "@rollup/plugin-node-resolve": "^7.1.3",
     "@rollup/plugin-replace": "^2.3.2",
-    "@storybook/addon-a11y": "7.0.9",
-    "@storybook/addon-docs": "7.0.9",
-    "@storybook/addon-essentials": "7.0.9",
-    "@storybook/addon-storyshots": "7.0.9",
-    "@storybook/addon-storyshots-puppeteer": "7.0.9",
-    "@storybook/addon-viewport": "7.0.9",
-    "@storybook/builder-webpack5": "7.0.9",
-    "@storybook/theming": "7.0.9",
-    "@storybook/vue": "7.0.9",
-    "@storybook/vue-webpack5": "7.0.9",
-    "@storybook/vue3": "7.0.9",
-    "@storybook/vue3-webpack5": "7.0.9",
+    "@storybook/addon-a11y": "7.0.11",
+    "@storybook/addon-docs": "7.0.11",
+    "@storybook/addon-essentials": "7.0.11",
+    "@storybook/addon-storyshots": "7.0.11",
+    "@storybook/addon-storyshots-puppeteer": "7.0.11",
+    "@storybook/addon-viewport": "7.0.11",
+    "@storybook/builder-webpack5": "7.0.11",
+    "@storybook/theming": "7.0.11",
+    "@storybook/vue": "7.0.11",
+    "@storybook/vue-webpack5": "7.0.11",
+    "@storybook/vue3": "7.0.11",
+    "@storybook/vue3-webpack5": "7.0.11",
     "@vue/compat": "^3.2.40",
     "@vue/compiler-sfc": "^3.2.40",
     "@vue/test-utils": "1.3.0",
@@ -116,7 +116,7 @@
     "babel-loader": "^8.0.5",
     "babel-plugin-require-context-hook": "^1.0.0",
     "bootstrap": "4.6.2",
-    "cypress": "12.11.0",
+    "cypress": "12.12.0",
     "emoji-regex": "^10.0.0",
     "eslint": "8.40.0",
     "eslint-import-resolver-jest": "3.0.2",

package/src/components/base/filtered_search/filtered_search.scss

@@ -1,21 +1,31 @@
-.gl-filtered-search-scrollable {
+.gl-filtered-search-scrollable-container {
   @include gl-bg-white;
   @include gl-display-flex;
   @include gl-flex-grow-1;
   @include gl-flex-basis-0;
-  @include gl-overflow-y-auto;
+  @include gl-overflow-hidden;
   @include gl-align-items-center;
-  @include gl-p-2;
+  @include gl-py-2;
   @include gl-pl-4;
+  @include gl-pr-7;
   @include gl-inset-border-1-gray-400;
   @include gl-border-none;
   @include gl-rounded-top-left-base;
   @include gl-rounded-bottom-left-base;
 }
 
+.gl-filtered-search-scrollable {
+  @include gl-display-flex;
+  @include gl-overflow-y-auto;
+}
+
 .gl-filtered-search-item {
   @include gl-display-flex;
   @include gl-px-1;
+
+  &:first-child {
+    @include gl-pl-0;
+  }
 }
 
 .gl-filtered-search-last-item {

package/src/components/base/filtered_search/filtered_search.vue

@@ -397,38 +397,40 @@ export default {
     </template>
     <template #input>
       <div
-        class="gl-filtered-search-scrollable"
+        class="gl-filtered-search-scrollable-container"
         :class="{ 'gl-bg-gray-10! gl-inset-border-1-gray-100!': viewOnly }"
       >
-        <component
-          :is="getTokenComponent(token.type)"
-          v-for="(token, idx) in tokens"
-          ref="tokens"
-          :key="token.id"
-          v-model="token.value"
-          :config="getTokenEntry(token.type)"
-          :active="activeTokenIdx === idx"
-          :cursor-position="intendedCursorPosition"
-          :available-tokens="currentAvailableTokens"
-          :current-value="tokens"
-          :index="idx"
-          :placeholder="termPlaceholder"
-          :show-friendly-text="showFriendlyText"
-          :search-input-attributes="searchInputAttributes"
-          :view-only="viewOnly"
-          :is-last-token="isLastToken(idx)"
-          :class="getTokenClassList(idx)"
-          :search-text-option-label="searchTextOptionLabel"
-          @activate="activate(idx)"
-          @deactivate="deactivate(token)"
-          @destroy="destroyToken(idx, $event)"
-          @replace="replaceToken(idx, $event)"
-          @complete="completeToken"
-          @submit="submit"
-          @split="createTokens(idx, $event)"
-          @previous="activatePreviousToken"
-          @next="activateNextToken"
-        />
+        <div class="gl-filtered-search-scrollable">
+          <component
+            :is="getTokenComponent(token.type)"
+            v-for="(token, idx) in tokens"
+            ref="tokens"
+            :key="token.id"
+            v-model="token.value"
+            :config="getTokenEntry(token.type)"
+            :active="activeTokenIdx === idx"
+            :cursor-position="intendedCursorPosition"
+            :available-tokens="currentAvailableTokens"
+            :current-value="tokens"
+            :index="idx"
+            :placeholder="termPlaceholder"
+            :show-friendly-text="showFriendlyText"
+            :search-input-attributes="searchInputAttributes"
+            :view-only="viewOnly"
+            :is-last-token="isLastToken(idx)"
+            :class="getTokenClassList(idx)"
+            :search-text-option-label="searchTextOptionLabel"
+            @activate="activate(idx)"
+            @deactivate="deactivate(token)"
+            @destroy="destroyToken(idx, $event)"
+            @replace="replaceToken(idx, $event)"
+            @complete="completeToken"
+            @submit="submit"
+            @split="createTokens(idx, $event)"
+            @previous="activatePreviousToken"
+            @next="activateNextToken"
+          />
+        </div>
       </div>
       <portal-target
         ref="menu"

package/src/components/base/new_dropdowns/listbox/listbox.md

@@ -71,6 +71,7 @@ type Option = {
 type Group = {
   text: string
   options: Array<Option>
+  textSrOnly?: boolean
 }
 
 type ItemsProp = Array<Option> | Array<Group>
@@ -104,7 +105,9 @@ template. If you want to render a custom template for items, use the
 Options can be contained within groups. A group has a required `text`
 property, which must be unique across all groups within the listbox, as
 it's used as a primary key. It also has a required property `items` that
-must be an array of options.
+must be an array of options. Optionally, you can hide the group heading
+by setting `textSrOnly` to `true`. In this case the `text` is only used
+for accessibility purposes.
 
 Groups can be at most one level deep: a group can only contain options.
 Options and groups _cannot_ be siblings. Either all items are options,

package/src/components/base/new_dropdowns/listbox/listbox.spec.js

@@ -387,6 +387,20 @@ describe('GlCollapsibleListbox', () => {
         expect(findListboxItems(groups.at(i))).toHaveLength(group.options.length);
       });
     });
+
+    it('passes the `textSrOnly` prop', () => {
+      const mockGroupsWithTextSrOnly = JSON.parse(JSON.stringify(mockGroups));
+      mockGroupsWithTextSrOnly[0].textSrOnly = true;
+      mockGroupsWithTextSrOnly[1].textSrOnly = false;
+      buildWrapper({ items: mockGroupsWithTextSrOnly });
+
+      const groups = findListboxGroups();
+
+      const expectedTextSrOnlyProps = mockGroupsWithTextSrOnly.map((group) => group.textSrOnly);
+      const actualTextSrOnlyProps = groups.wrappers.map((group) => group.props('textSrOnly'));
+
+      expect(actualTextSrOnlyProps).toEqual(expectedTextSrOnlyProps);
+    });
   });
 
   describe('when `searchable` is enabled', () => {

package/src/components/base/new_dropdowns/listbox/listbox.vue

@@ -686,7 +686,12 @@ export default {
         </template>
 
         <template v-else>
-          <gl-listbox-group :key="item.text" :name="item.text" :class="groupClasses(index)">
+          <gl-listbox-group
+            :key="item.text"
+            :name="item.text"
+            :text-sr-only="item.textSrOnly"
+            :class="groupClasses(index)"
+          >
             <template v-if="$scopedSlots['group-label']" #group-label>
               <!-- @slot Custom template for group names -->
               <slot name="group-label" :group="item"></slot>

package/src/components/base/new_dropdowns/listbox/listbox_group.spec.js

@@ -44,4 +44,18 @@ describe('GlListboxGroup', () => {
 
     expect(findByTestId('custom-name', findLabelElement()).exists()).toBe(true);
   });
+
+  describe('`textSrOnly` is true', () => {
+    beforeEach(() => {
+      buildWrapper({
+        propsData: {
+          textSrOnly: true,
+        },
+      });
+    });
+
+    it('adds `gl-sr-only` class', () => {
+      expect(findLabelElement().classes('gl-sr-only')).toBe(true);
+    });
+  });
 });

package/src/components/base/new_dropdowns/listbox/listbox_group.vue

@@ -8,6 +8,11 @@ export default {
       type: String,
       required: true,
     },
+    textSrOnly: {
+      type: Boolean,
+      required: false,
+      default: false,
+    },
   },
   created() {
     this.nameId = uniqueId('gl-listbox-group-');
@@ -21,6 +26,7 @@ export default {
       :id="nameId"
       role="presentation"
       class="gl-pl-4 gl-pt-3 gl-pb-2 gl-font-sm gl-font-weight-bold"
+      :class="{ 'gl-sr-only': textSrOnly }"
     >
       <slot name="group-label">{{ name }}</slot>
     </li>