@gitlab/ui 59.3.0 → 59.3.1

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [59.3.1](https://gitlab.com/gitlab-org/gitlab-ui/compare/v59.3.0...v59.3.1) (2023-04-05)
+
+
+### Bug Fixes
+
+* **base_dropdown:** conditional chaining to destroy popper ([05cf79e](https://gitlab.com/gitlab-org/gitlab-ui/commit/05cf79e0fdaf55d9403fcdaba062d416294b3815))
+
 # [59.3.0](https://gitlab.com/gitlab-org/gitlab-ui/compare/v59.2.0...v59.3.0) (2023-04-04)
 
 

package/dist/components/base/new_dropdowns/base_dropdown/base_dropdown.js

@@ -200,7 +200,8 @@ var script = {
     this.checkToggleFocusable();
   },
   beforeDestroy() {
-    this.popper.destroy();
+    var _this$popper;
+    (_this$popper = this.popper) === null || _this$popper === void 0 ? void 0 : _this$popper.destroy();
   },
   methods: {
     checkToggleFocusable() {
@@ -212,7 +213,7 @@ var script = {
     async toggle() {
       this.visible = !this.visible;
       if (this.visible) {
-        var _this$popper;
+        var _this$popper2;
         /* Initially dropdown is hidden with `display="none"`.
           When `visible` prop is toggled ON, with the `nextTick` we wait for the DOM update -
           dropdown's `display="block"` is set (adding CSS class `show`).
@@ -224,7 +225,7 @@ var script = {
           e.g. set focus.
          */
         await this.$nextTick();
-        await ((_this$popper = this.popper) === null || _this$popper === void 0 ? void 0 : _this$popper.update());
+        await ((_this$popper2 = this.popper) === null || _this$popper2 === void 0 ? void 0 : _this$popper2.update());
         this.$emit(GL_DROPDOWN_SHOWN);
       } else {
         this.$emit(GL_DROPDOWN_HIDDEN);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/ui",
-  "version": "59.3.0",
+  "version": "59.3.1",
   "description": "GitLab UI Components",
   "license": "MIT",
   "main": "dist/index.js",

package/src/components/base/new_dropdowns/base_dropdown/base_dropdown.spec.js

@@ -92,6 +92,13 @@ describe('base dropdown', () => {
       wrapper.destroy();
       expect(destroyPopper).toHaveBeenCalled();
     });
+
+    it('should not destroy popper instance when component is not initiated', async () => {
+      buildWrapper();
+      wrapper.destroy();
+      await nextTick();
+      expect(destroyPopper).not.toHaveBeenCalled();
+    });
   });
 
   describe('renders content to the default slot', () => {

package/src/components/base/new_dropdowns/base_dropdown/base_dropdown.vue

@@ -214,7 +214,7 @@ export default {
     this.checkToggleFocusable();
   },
   beforeDestroy() {
-    this.popper.destroy();
+    this.popper?.destroy();
   },
   methods: {
     checkToggleFocusable() {