@gitlab/ui 56.2.1 → 56.3.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/ui",
-  "version": "56.2.1",
+  "version": "56.3.0",
   "description": "GitLab UI Components",
   "license": "MIT",
   "main": "dist/index.js",
@@ -61,7 +61,7 @@
   },
   "dependencies": {
     "@popperjs/core": "^2.11.2",
-    "bootstrap-vue": "2.20.1",
+    "bootstrap-vue": "2.23.1",
     "dompurify": "^2.4.5",
     "echarts": "^5.3.2",
     "iframe-resizer": "^4.3.2",
@@ -113,7 +113,7 @@
     "babel-loader": "^8.0.5",
     "babel-plugin-require-context-hook": "^1.0.0",
     "babel-preset-vue": "^2.0.2",
-    "bootstrap": "4.5.3",
+    "bootstrap": "4.6.2",
     "bootstrap-vue-vue3": "npm:bootstrap-vue@2.23.1",
     "cypress": "^11.2.0",
     "emoji-regex": "^10.0.0",

package/scss_to_js/scss_variables.js

@@ -341,6 +341,7 @@ export const modalTitleLineHeight = '1.25rem'
 export const modalBackdropBg = '#000'
 export const modalBackdropOpacity = '0.64'
 export const bodyColor = '#333238'
+export const enableValidationIcons = 'false'
 export const secondary = '#ececef'
 export const success = '#108548'
 export const info = '#1f75cb'

package/scss_to_js/scss_variables.json

@@ -1815,6 +1815,11 @@
       "value": "$gl-text-color",
       "compiledValue": "#333238"
     },
+    {
+      "name": "$enable-validation-icons",
+      "value": "false",
+      "compiledValue": "false"
+    },
     {
       "name": "$secondary",
       "value": "$gray-50",

package/src/components/base/form/form_checkbox/form_checkbox_group.vue

@@ -1,6 +1,6 @@
 <script>
 import { BFormCheckboxGroup } from 'bootstrap-vue';
-import formOptionsMixin from 'bootstrap-vue/src/mixins/form-options';
+import { formOptionsMixin } from 'bootstrap-vue/src/mixins/form-options';
 import { SafeHtmlDirective as SafeHtml } from '../../../../directives/safe_html/safe_html';
 import GlFormCheckbox from './form_checkbox.vue';
 

package/src/components/base/form/form_input/form_input.scss

@@ -31,17 +31,12 @@
 
   &.is-invalid {
     @include gl-inset-border-1-red-500;
-    background-image: none;
 
     &:focus {
       @include gl-focus($color: $red-500);
     }
   }
 
-  &.is-valid {
-    background-image: none;
-  }
-
   &::placeholder {
     @include gl-text-gray-400;
   }

package/src/components/base/form/form_radio_group/form_radio_group.vue

@@ -1,6 +1,6 @@
 <script>
 import { BFormRadioGroup } from 'bootstrap-vue';
-import formOptionsMixin from 'bootstrap-vue/src/mixins/form-options';
+import { formOptionsMixin } from 'bootstrap-vue/src/mixins/form-options';
 import { SafeHtmlDirective as SafeHtml } from '../../../../directives/safe_html/safe_html';
 import GlFormRadio from '../form_radio/form_radio.vue';
 

package/src/components/base/form/form_select/form_select.scss

@@ -16,6 +16,7 @@ See: https://gitlab.com/gitlab-org/gitlab/issues/30055
   @include gl-line-height-normal;
   @include gl-py-3;
   @include gl-pl-4;
+  padding-right: $gl-spacing-scale-2 + $gl-spacing-scale-6;
   @include gl-h-auto;
   @include gl-inset-border-1-gray-400;
   @include gl-border-none;
@@ -36,12 +37,6 @@ See: https://gitlab.com/gitlab-org/gitlab/issues/30055
     @include gl-cursor-not-allowed;
   }
 
-  &.is-valid,
-  &.is-invalid {
-    padding-right: $gl-spacing-scale-2 + $gl-spacing-scale-6;
-    background-image: url($gl-icon-select-chevron-down);
-  }
-
   &.is-invalid:not(:disabled) {
     @include gl-inset-border-1-red-400;
 

package/src/components/base/popover/popover.vue

@@ -45,6 +45,11 @@ export default {
       required: false,
       default: popoverPlacements.top,
     },
+    boundaryPadding: {
+      type: [Number, String],
+      required: false,
+      default: 5,
+    },
   },
   computed: {
     customClass() {
@@ -74,6 +79,7 @@ export default {
     :triggers="triggers"
     :title="title"
     :placement="placement"
+    :boundary-padding="boundaryPadding"
     v-bind="$attrs"
     v-on="$listeners"
   >

package/src/components/base/table/table.spec.js

@@ -1,4 +1,5 @@
 import { shallowMount } from '@vue/test-utils';
+import { BTable } from 'bootstrap-vue';
 import { logWarning } from '../../../utils/utils';
 import { waitForAnimationFrame } from '../../../utils/test_utils';
 import { glTableLiteWarning } from './constants';
@@ -10,18 +11,22 @@ jest.mock('../../../utils/utils', () => ({
 }));
 
 describe('GlTable', () => {
+  let wrapper;
+
   const slotsTemplate = {
     empty: `
       <p>Placeholder empty text</p>`,
   };
 
   const factory = ({ props = {}, scopedSlots = {} } = {}) => {
-    shallowMount(Table, {
+    wrapper = shallowMount(Table, {
       scopedSlots,
       propsData: props,
     });
   };
 
+  const findBTable = () => wrapper.findComponent(BTable);
+
   afterEach(() => {
     logWarning.mockClear();
   });
@@ -46,4 +51,10 @@ describe('GlTable', () => {
 
     expect(logWarning).not.toHaveBeenCalled();
   });
+
+  it('adds gl-table class to tableClass prop', () => {
+    factory({ props: { tableClass: 'test-class' } });
+
+    expect(findBTable().props().tableClass).toEqual(['gl-table', 'test-class']);
+  });
 });

package/src/components/base/table/table.vue

@@ -11,11 +11,21 @@ const shouldUseFullTable = ({ $attrs, $scopedSlots }) => {
   );
 };
 
+const { tableClass } = BTable.options.props;
+
 export default {
   components: {
     BTable,
   },
   inheritAttrs: false,
+  props: {
+    tableClass,
+  },
+  computed: {
+    localTableClass() {
+      return ['gl-table', this.tableClass];
+    },
+  },
   mounted() {
     // logWarning will call isDev before logging any message
     // this additional call to isDev is being made to exit the condition early when run in production
@@ -27,7 +37,7 @@ export default {
 </script>
 
 <template>
-  <b-table class="gl-table" v-bind="$attrs" v-on="$listeners">
+  <b-table :table-class="localTableClass" v-bind="$attrs" v-on="$listeners">
     <template v-for="slot in Object.keys($scopedSlots)" #[slot]="scope">
       <slot :name="slot" v-bind="scope"></slot>
     </template>

package/src/components/base/table_lite/table_lite.spec.js

@@ -0,0 +1,21 @@
+import { shallowMount } from '@vue/test-utils';
+import { BTableLite } from 'bootstrap-vue';
+import GlTableLite from './table_lite.vue';
+
+describe('GlTableLite', () => {
+  let wrapper;
+
+  const factory = (propsData) => {
+    wrapper = shallowMount(GlTableLite, {
+      propsData,
+    });
+  };
+
+  const findBTableLite = () => wrapper.findComponent(BTableLite);
+
+  it('adds gl-table class to tableClass prop', () => {
+    factory({ tableClass: 'test-class' });
+
+    expect(findBTableLite().props().tableClass).toEqual(['gl-table', 'test-class']);
+  });
+});

package/src/components/base/table_lite/table_lite.vue

@@ -1,16 +1,24 @@
 <script>
 import { BTableLite } from 'bootstrap-vue';
 
+const { tableClass } = BTableLite.options.props;
+
 export default {
   components: {
     BTableLite,
   },
   inheritAttrs: false,
+  props: { tableClass },
+  computed: {
+    localTableClass() {
+      return ['gl-table', this.tableClass];
+    },
+  },
 };
 </script>
 
 <template>
-  <b-table-lite class="gl-table" v-bind="$attrs" v-on="$listeners">
+  <b-table-lite :table-class="localTableClass" v-bind="$attrs" v-on="$listeners">
     <template v-for="slot in Object.keys($scopedSlots)" #[slot]="scope">
       <!-- @slot See https://bootstrap-vue.org/docs/components/table#comp-ref-b-table-lite-slots for available slots. -->
       <slot :name="slot" v-bind="scope"></slot>

package/src/scss/variables.scss

@@ -484,6 +484,7 @@ $modal-backdrop-opacity: 0.64;
 // these should ideally be moved further up in the file to the compoent-relevant sections
 // but they can wait here for now
 $body-color: $gl-text-color !default;
+$enable-validation-icons: false;
 
 $secondary: $gray-50;
 $success: $green-500;