@gitlab/ui 56.1.0 → 56.1.1

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [56.1.1](https://gitlab.com/gitlab-org/gitlab-ui/compare/v56.1.0...v56.1.1) (2023-02-20)
+
+
+### Performance Improvements
+
+* **GlCollapsibleDropdown:** avoid unnecessary loop ([2d13b6e](https://gitlab.com/gitlab-org/gitlab-ui/commit/2d13b6ecc80154e70a4d637974b8434d50e53928))
+
 # [56.1.0](https://gitlab.com/gitlab-org/gitlab-ui/compare/v56.0.1...v56.1.0) (2023-02-20)
 
 

package/dist/components/base/new_dropdowns/disclosure/utils.js

@@ -25,7 +25,11 @@ const hasOnlyListItems = _ref => {
     return false;
   }
   const nodes = defaultSlot();
-  return Array.isArray(nodes) && nodes.filter(vNode => vNode.tag).length && (nodes.filter(vNode => vNode.tag).every(isValidSlotTagVue2) || nodes.filter(vNode => vNode.tag).every(isValidSlotTag));
+  if (!Array.isArray(nodes)) {
+    return false;
+  }
+  const tags = nodes.filter(vNode => vNode.tag);
+  return tags.length && tags.every(tag => isValidSlotTag(tag) || isValidSlotTagVue2(tag));
 };
 
 export { hasOnlyListItems, isGroup, isItem, itemsValidator };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/ui",
-  "version": "56.1.0",
+  "version": "56.1.1",
   "description": "GitLab UI Components",
   "license": "MIT",
   "main": "dist/index.js",

package/src/components/base/new_dropdowns/disclosure/disclosure_dropdown.spec.js

@@ -277,5 +277,20 @@ describe('GlDisclosureDropdown', () => {
       buildWrapper({}, { default: 'Some other content' });
       expect(findDisclosureContent().element.tagName).toBe('DIV');
     });
+
+    describe('discouraged usage', () => {
+      it('should render `ul` as content tag when default slot contains LI tags', () => {
+        const slots = {
+          default: `
+            <li>Item</li>
+            <li>Item</li>
+            <li>Item</li>
+          `,
+        };
+
+        buildWrapper({}, slots);
+        expect(findDisclosureContent().element.tagName).toBe('UL');
+      });
+    });
   });
 });

package/src/components/base/new_dropdowns/disclosure/disclosure_dropdown.stories.js

@@ -52,15 +52,15 @@ function openDisclosure(component) {
   });
 }
 
-const template = (content, { bindingOverrides = {} } = {}, after) => `
+const template = (content = '', { bindingOverrides = {}, after = '' } = {}) => `
   <div>
     <gl-disclosure-dropdown
       ref="disclosure"
       ${makeBindings(bindingOverrides)}
     >
-      ${content || ''}
+      ${content}
     </gl-disclosure-dropdown>
-    ${after || ''}
+    ${after}
   </div>
 `;
 
@@ -252,12 +252,13 @@ export const CustomGroupsItemsAndToggle = makeGroupedExample({
       </gl-disclosure-dropdown-group>
       <gl-disclosure-dropdown-group bordered :group="$options.groups[1]"/>
     `,
-    {},
-    `
+    {
+      after: `
       <gl-modal :visible="feedBackModalVisible" @change="toggleModalVisibility" modal-id="feedbackModal" size="sm">
         <textarea class="gl-w-full">Tell us what you think!</textarea>
       </gl-modal>
-    `
+    `,
+    }
   ),
   data() {
     return {

package/src/components/base/new_dropdowns/disclosure/utils.js

@@ -31,12 +31,14 @@ const hasOnlyListItems = ({ default: defaultSlot }) => {
     return false;
   }
   const nodes = defaultSlot();
-  return (
-    Array.isArray(nodes) &&
-    nodes.filter((vNode) => vNode.tag).length &&
-    (nodes.filter((vNode) => vNode.tag).every(isValidSlotTagVue2) ||
-      nodes.filter((vNode) => vNode.tag).every(isValidSlotTag))
-  );
+
+  if (!Array.isArray(nodes)) {
+    return false;
+  }
+
+  const tags = nodes.filter((vNode) => vNode.tag);
+
+  return tags.length && tags.every((tag) => isValidSlotTag(tag) || isValidSlotTagVue2(tag));
 };
 
 export { itemsValidator, isItem, isGroup, hasOnlyListItems };