@gitlab/ui 54.3.0 → 54.4.1

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+## [54.4.1](https://gitlab.com/gitlab-org/gitlab-ui/compare/v54.4.0...v54.4.1) (2023-02-06)
+
+
+### Bug Fixes
+
+* **GlListbox:** Stop listbox ENTER event prop ([944b7f9](https://gitlab.com/gitlab-org/gitlab-ui/commit/944b7f9baf67fc71787d14d614fb51b722083820))
+
+# [54.4.0](https://gitlab.com/gitlab-org/gitlab-ui/compare/v54.3.0...v54.4.0) (2023-02-02)
+
+
+### Features
+
+* **GlDisclosureDropdown:** Add support for item wrapper class ([8b575af](https://gitlab.com/gitlab-org/gitlab-ui/commit/8b575af03dcdeb9206ef3caf65f2519b9628b1ae))
+
 # [54.3.0](https://gitlab.com/gitlab-org/gitlab-ui/compare/v54.2.3...v54.3.0) (2023-02-02)
 
 

package/dist/components/base/new_dropdowns/constants.js

@@ -12,11 +12,11 @@ const GL_DROPDOWN_SHOWN = 'shown';
 const GL_DROPDOWN_HIDDEN = 'hidden';
 
 // KEY Codes
-const HOME = 'Home';
-const END = 'End';
-const ARROW_UP = 'ArrowUp';
 const ARROW_DOWN = 'ArrowDown';
+const ARROW_UP = 'ArrowUp';
+const END = 'End';
 const ENTER = 'Enter';
+const HOME = 'Home';
 const SPACE = 'Space';
 
 export { ARROW_DOWN, ARROW_UP, END, ENTER, GL_DROPDOWN_HIDDEN, GL_DROPDOWN_SHOWN, HOME, POPPER_CONFIG, SPACE };

package/dist/components/base/new_dropdowns/disclosure/disclosure_dropdown.js

@@ -1,6 +1,6 @@
 import _uniqueId from 'lodash/uniqueId';
 import _clamp from 'lodash/clamp';
-import { stopEvent } from '../../../../utils/utils';
+import { stopEvent, filterVisible } from '../../../../utils/utils';
 import { GL_DROPDOWN_SHOWN, GL_DROPDOWN_HIDDEN, HOME, END, ARROW_UP, ARROW_DOWN } from '../constants';
 import { buttonCategoryOptions, dropdownVariantOptions, buttonSizeOptions, dropdownPlacements } from '../../../../utils/constants';
 import GlBaseDropdown from '../base_dropdown/base_dropdown';
@@ -104,7 +104,7 @@ var script = {
     toggleId: {
       type: String,
       required: false,
-      default: () => _uniqueId('dropdown-toggle-btn-')
+      default: _uniqueId('dropdown-toggle-btn-')
     },
     /**
      * Additional CSS classes to customize toggle appearance
@@ -231,7 +231,7 @@ var script = {
     getFocusableListItemElements() {
       var _this$$refs$content;
       const items = (_this$$refs$content = this.$refs.content) === null || _this$$refs$content === void 0 ? void 0 : _this$$refs$content.querySelectorAll(`.${ITEM_CLASS}`);
-      return Array.from(items || []);
+      return filterVisible(Array.from(items || []));
     },
     focusNextItem(event, elements, offset) {
       const {

package/dist/components/base/new_dropdowns/disclosure/disclosure_dropdown_item.js

@@ -26,12 +26,14 @@ var script = {
       const {
         item
       } = this;
+      if (!item) return null;
       if (this.isLink) return {
         is: 'a',
         attrs: {
           href: item.href,
           ...item.extraAttrs
         },
+        wrapperClass: item.wrapperClass,
         listeners: {}
       };
       return {
@@ -45,7 +47,8 @@ var script = {
             var _item$action;
             return (_item$action = item.action) === null || _item$action === void 0 ? void 0 : _item$action.call(undefined, item);
           }
-        }
+        },
+        wrapperClass: item.wrapperClass
       };
     }
   },
@@ -78,7 +81,7 @@ var script = {
 const __vue_script__ = script;
 
 /* template */
-var __vue_render__ = function () {var _vm=this;var _h=_vm.$createElement;var _c=_vm._self._c||_h;return _c('li',{staticClass:"gl-new-dropdown-item",class:_vm.$options.ITEM_CLASS,attrs:{"tabindex":"0","data-testid":"disclosure-dropdown-item"},on:{"click":_vm.action,"keydown":_vm.onKeydown}},[(_vm.isCustomContent)?_c('div',{staticClass:"gl-new-dropdown-item-content"},[_c('div',{staticClass:"gl-new-dropdown-item-text-wrapper"},[_vm._t("default")],2)]):[_c(_vm.itemComponent.is,_vm._g(_vm._b({ref:"item",tag:"component",staticClass:"gl-new-dropdown-item-content",attrs:{"tabindex":"-1"}},'component',_vm.itemComponent.attrs,false),_vm.itemComponent.listeners),[_c('span',{staticClass:"gl-new-dropdown-item-text-wrapper"},[_vm._v("\n        "+_vm._s(_vm.item.text)+"\n      ")])])]],2)};
+var __vue_render__ = function () {var _vm=this;var _h=_vm.$createElement;var _c=_vm._self._c||_h;return _c('li',{class:[_vm.$options.ITEM_CLASS, _vm.itemComponent && _vm.itemComponent.wrapperClass],attrs:{"tabindex":"0","data-testid":"disclosure-dropdown-item"},on:{"click":_vm.action,"keydown":_vm.onKeydown}},[(_vm.isCustomContent)?_c('div',{staticClass:"gl-new-dropdown-item-content"},[_c('div',{staticClass:"gl-new-dropdown-item-text-wrapper"},[_vm._t("default")],2)]):(_vm.itemComponent && _vm.item)?[_c(_vm.itemComponent.is,_vm._g(_vm._b({ref:"item",tag:"component",staticClass:"gl-new-dropdown-item-content",attrs:{"tabindex":"-1"}},'component',_vm.itemComponent.attrs,false),_vm.itemComponent.listeners),[_c('span',{staticClass:"gl-new-dropdown-item-text-wrapper"},[_vm._v("\n        "+_vm._s(_vm.item.text)+"\n      ")])])]:_vm._e()],2)};
 var __vue_staticRenderFns__ = [];
 
   /* style */

package/dist/components/base/new_dropdowns/disclosure/mock_data.js

@@ -41,6 +41,13 @@ const mockItemsCustomItem = [{
     target: '_blank',
     rel: 'nofollow'
   }
+}, {
+  text: 'I am only visible on mobile!',
+  action: () => {
+    // eslint-disable-next-line no-console
+    console.log('clicked!');
+  },
+  wrapperClass: 'gl-sm-display-none!'
 }];
 const mockGroupsCustomItem = [{
   name: 'Merge requests',

package/dist/components/base/new_dropdowns/listbox/listbox.js

@@ -536,7 +536,7 @@ var script = {
 const __vue_script__ = script;
 
 /* template */
-var __vue_render__ = function () {var _vm=this;var _h=_vm.$createElement;var _c=_vm._self._c||_h;return _c('gl-base-dropdown',{ref:"baseDropdown",attrs:{"aria-haspopup":"listbox","aria-labelledby":_vm.toggleAriaLabelledBy,"block":_vm.block,"toggle-id":_vm.toggleId,"toggle-text":_vm.listboxToggleText,"toggle-class":_vm.toggleClass,"text-sr-only":_vm.textSrOnly,"category":_vm.category,"variant":_vm.variant,"size":_vm.size,"icon":_vm.icon,"disabled":_vm.disabled,"loading":_vm.loading,"no-caret":_vm.noCaret,"placement":_vm.placement},on:_vm._d({},[_vm.$options.events.GL_DROPDOWN_SHOWN,_vm.onShow,_vm.$options.events.GL_DROPDOWN_HIDDEN,_vm.onHide]),scopedSlots:_vm._u([(_vm.hasCustomToggle)?{key:"toggle",fn:function(){return [_vm._t("toggle")]},proxy:true}:null],null,true)},[_vm._v(" "),(_vm.headerText)?_c('div',{staticClass:"gl-display-flex gl-align-items-center gl-p-4! gl-min-h-8",class:_vm.$options.HEADER_ITEMS_BORDER_CLASSES},[_c('div',{staticClass:"gl-flex-grow-1 gl-font-weight-bold gl-font-sm gl-pr-2",attrs:{"id":_vm.headerId,"data-testid":"listbox-header-text"}},[_vm._v("\n      "+_vm._s(_vm.headerText)+"\n    ")]),_vm._v(" "),(_vm.showResetButton)?_c('gl-button',{staticClass:"gl-focus-inset-border-2-blue-400! gl-flex-shrink-0 gl-font-sm! gl-px-2! gl-py-2! gl-w-auto! gl-m-0!",attrs:{"category":"tertiary","data-testid":"listbox-reset-button"},on:{"click":_vm.onResetButtonClicked}},[_vm._v("\n      "+_vm._s(_vm.resetButtonLabel)+"\n    ")]):_vm._e()],1):_vm._e(),_vm._v(" "),(_vm.searchable)?_c('div',{class:_vm.$options.HEADER_ITEMS_BORDER_CLASSES},[_c('gl-listbox-search-input',{ref:"searchBox",attrs:{"aria-owns":_vm.listboxId,"data-testid":"listbox-search-input","placeholder":_vm.searchPlaceholder},on:{"input":_vm.search,"keydown":_vm.onKeydown},model:{value:(_vm.searchStr),callback:function ($$v) {_vm.searchStr=$$v;},expression:"searchStr"}}),_vm._v(" "),(_vm.searching)?_c('gl-loading-icon',{staticClass:"gl-my-3",attrs:{"data-testid":"listbox-search-loader","size":"md"}}):_vm._e()],1):_vm._e(),_vm._v(" "),(_vm.showList)?_c(_vm.listboxTag,{ref:"list",tag:"component",staticClass:"gl-new-dropdown-contents",attrs:{"id":_vm.listboxId,"aria-labelledby":_vm.listAriaLabelledBy || _vm.headerId || _vm.toggleId,"role":"listbox","tabindex":"-1"},on:{"keydown":_vm.onKeydown}},[_vm._l((_vm.items),function(item,index){return [(_vm.isOption(item))?[_c('gl-listbox-item',_vm._b({key:item.value,attrs:{"data-testid":("listbox-item-" + (item.value)),"is-selected":_vm.isSelected(item),"is-focused":_vm.isFocused(item),"is-check-centered":_vm.isCheckCentered},on:{"select":function($event){return _vm.onSelect(item, $event)}}},'gl-listbox-item',_vm.listboxItemMoreItemsAriaAttributes(index),false),[_vm._t("list-item",function(){return [_vm._v("\n            "+_vm._s(item.text)+"\n          ")]},{"item":item})],2)]:[_c('gl-listbox-group',{key:item.text,class:_vm.groupClasses(index),attrs:{"name":item.text},scopedSlots:_vm._u([(_vm.$scopedSlots['group-label'])?{key:"group-label",fn:function(){return [_vm._t("group-label",null,{"group":item})]},proxy:true}:null],null,true)},[_vm._v(" "),_vm._l((item.options),function(option){return _c('gl-listbox-item',{key:option.value,attrs:{"data-testid":("listbox-item-" + (option.value)),"is-selected":_vm.isSelected(option),"is-focused":_vm.isFocused(option),"is-check-centered":_vm.isCheckCentered},on:{"select":function($event){return _vm.onSelect(option, $event)}}},[_vm._t("list-item",function(){return [_vm._v("\n              "+_vm._s(option.text)+"\n            ")]},{"item":option})],2)})],2)]]}),_vm._v(" "),(_vm.infiniteScrollLoading)?_c(_vm.listboxTag === 'ul' ? 'li' : 'div',{tag:"component"},[_c('gl-loading-icon',{staticClass:"gl-my-3",attrs:{"data-testid":"listbox-infinite-scroll-loader","size":"md"}})],1):_vm._e(),_vm._v(" "),(_vm.showIntersectionObserver)?_c('gl-intersection-observer',{on:{"appear":_vm.onIntersectionObserverAppear}}):_vm._e()],2):_vm._e(),_vm._v(" "),(_vm.announceSRSearchResults)?_c('span',{staticClass:"gl-sr-only",attrs:{"data-testid":"listbox-number-of-results","aria-live":"assertive"}},[_vm._t("search-summary-sr-only")],2):(_vm.showNoResultsText)?_c('div',{staticClass:"gl-pl-7 gl-pr-5 gl-py-3 gl-font-base gl-text-gray-600",attrs:{"aria-live":"assertive","data-testid":"listbox-no-results-text"}},[_vm._v("\n    "+_vm._s(_vm.noResultsText)+"\n  ")]):_vm._e(),_vm._v(" "),_vm._t("footer")],2)};
+var __vue_render__ = function () {var _vm=this;var _h=_vm.$createElement;var _c=_vm._self._c||_h;return _c('gl-base-dropdown',{ref:"baseDropdown",attrs:{"aria-haspopup":"listbox","aria-labelledby":_vm.toggleAriaLabelledBy,"block":_vm.block,"toggle-id":_vm.toggleId,"toggle-text":_vm.listboxToggleText,"toggle-class":_vm.toggleClass,"text-sr-only":_vm.textSrOnly,"category":_vm.category,"variant":_vm.variant,"size":_vm.size,"icon":_vm.icon,"disabled":_vm.disabled,"loading":_vm.loading,"no-caret":_vm.noCaret,"placement":_vm.placement},on:_vm._d({},[_vm.$options.events.GL_DROPDOWN_SHOWN,_vm.onShow,_vm.$options.events.GL_DROPDOWN_HIDDEN,_vm.onHide]),scopedSlots:_vm._u([(_vm.hasCustomToggle)?{key:"toggle",fn:function(){return [_vm._t("toggle")]},proxy:true}:null],null,true)},[_vm._v(" "),(_vm.headerText)?_c('div',{staticClass:"gl-display-flex gl-align-items-center gl-p-4! gl-min-h-8",class:_vm.$options.HEADER_ITEMS_BORDER_CLASSES},[_c('div',{staticClass:"gl-flex-grow-1 gl-font-weight-bold gl-font-sm gl-pr-2",attrs:{"id":_vm.headerId,"data-testid":"listbox-header-text"}},[_vm._v("\n      "+_vm._s(_vm.headerText)+"\n    ")]),_vm._v(" "),(_vm.showResetButton)?_c('gl-button',{staticClass:"gl-focus-inset-border-2-blue-400! gl-flex-shrink-0 gl-font-sm! gl-px-2! gl-py-2! gl-w-auto! gl-m-0!",attrs:{"category":"tertiary","data-testid":"listbox-reset-button"},on:{"click":_vm.onResetButtonClicked}},[_vm._v("\n      "+_vm._s(_vm.resetButtonLabel)+"\n    ")]):_vm._e()],1):_vm._e(),_vm._v(" "),(_vm.searchable)?_c('div',{class:_vm.$options.HEADER_ITEMS_BORDER_CLASSES},[_c('gl-listbox-search-input',{ref:"searchBox",attrs:{"aria-owns":_vm.listboxId,"data-testid":"listbox-search-input","placeholder":_vm.searchPlaceholder},on:{"input":_vm.search,"keydown":[function($event){if(!$event.type.indexOf('key')&&_vm._k($event.keyCode,"enter",13,$event.key,"Enter")){ return null; }$event.preventDefault();},_vm.onKeydown]},model:{value:(_vm.searchStr),callback:function ($$v) {_vm.searchStr=$$v;},expression:"searchStr"}}),_vm._v(" "),(_vm.searching)?_c('gl-loading-icon',{staticClass:"gl-my-3",attrs:{"data-testid":"listbox-search-loader","size":"md"}}):_vm._e()],1):_vm._e(),_vm._v(" "),(_vm.showList)?_c(_vm.listboxTag,{ref:"list",tag:"component",staticClass:"gl-new-dropdown-contents",attrs:{"id":_vm.listboxId,"aria-labelledby":_vm.listAriaLabelledBy || _vm.headerId || _vm.toggleId,"role":"listbox","tabindex":"-1"},on:{"keydown":_vm.onKeydown}},[_vm._l((_vm.items),function(item,index){return [(_vm.isOption(item))?[_c('gl-listbox-item',_vm._b({key:item.value,attrs:{"data-testid":("listbox-item-" + (item.value)),"is-selected":_vm.isSelected(item),"is-focused":_vm.isFocused(item),"is-check-centered":_vm.isCheckCentered},on:{"select":function($event){return _vm.onSelect(item, $event)}}},'gl-listbox-item',_vm.listboxItemMoreItemsAriaAttributes(index),false),[_vm._t("list-item",function(){return [_vm._v("\n            "+_vm._s(item.text)+"\n          ")]},{"item":item})],2)]:[_c('gl-listbox-group',{key:item.text,class:_vm.groupClasses(index),attrs:{"name":item.text},scopedSlots:_vm._u([(_vm.$scopedSlots['group-label'])?{key:"group-label",fn:function(){return [_vm._t("group-label",null,{"group":item})]},proxy:true}:null],null,true)},[_vm._v(" "),_vm._l((item.options),function(option){return _c('gl-listbox-item',{key:option.value,attrs:{"data-testid":("listbox-item-" + (option.value)),"is-selected":_vm.isSelected(option),"is-focused":_vm.isFocused(option),"is-check-centered":_vm.isCheckCentered},on:{"select":function($event){return _vm.onSelect(option, $event)}}},[_vm._t("list-item",function(){return [_vm._v("\n              "+_vm._s(option.text)+"\n            ")]},{"item":option})],2)})],2)]]}),_vm._v(" "),(_vm.infiniteScrollLoading)?_c(_vm.listboxTag === 'ul' ? 'li' : 'div',{tag:"component"},[_c('gl-loading-icon',{staticClass:"gl-my-3",attrs:{"data-testid":"listbox-infinite-scroll-loader","size":"md"}})],1):_vm._e(),_vm._v(" "),(_vm.showIntersectionObserver)?_c('gl-intersection-observer',{on:{"appear":_vm.onIntersectionObserverAppear}}):_vm._e()],2):_vm._e(),_vm._v(" "),(_vm.announceSRSearchResults)?_c('span',{staticClass:"gl-sr-only",attrs:{"data-testid":"listbox-number-of-results","aria-live":"assertive"}},[_vm._t("search-summary-sr-only")],2):(_vm.showNoResultsText)?_c('div',{staticClass:"gl-pl-7 gl-pr-5 gl-py-3 gl-font-base gl-text-gray-600",attrs:{"aria-live":"assertive","data-testid":"listbox-no-results-text"}},[_vm._v("\n    "+_vm._s(_vm.noResultsText)+"\n  ")]):_vm._e(),_vm._v(" "),_vm._t("footer")],2)};
 var __vue_staticRenderFns__ = [];
 
   /* style */

package/dist/utils/utils.js

@@ -1,3 +1,4 @@
+import { isVisible } from 'bootstrap-vue/esm/utils/dom';
 import { COMMA, labelColorOptions, focusableTags } from './constants';
 
 function debounceByAnimationFrame(fn) {
@@ -134,4 +135,11 @@ function stopEvent(event) {
   }
 }
 
-export { colorFromBackground, debounceByAnimationFrame, focusFirstFocusableElement, hexToRgba, isDev, isElementFocusable, logWarning, rgbFromHex, rgbFromString, stopEvent, throttle, uid };
+/**
+ * Return an Array of visible items
+ */
+function filterVisible(els) {
+  return (els || []).filter(isVisible);
+}
+
+export { colorFromBackground, debounceByAnimationFrame, filterVisible, focusFirstFocusableElement, hexToRgba, isDev, isElementFocusable, logWarning, rgbFromHex, rgbFromString, stopEvent, throttle, uid };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/ui",
-  "version": "54.3.0",
+  "version": "54.4.1",
   "description": "GitLab UI Components",
   "license": "MIT",
   "main": "dist/index.js",
@@ -29,9 +29,9 @@
     "clean": "rm -r dist storybook scss_to_js/scss_variables.* src/scss/utilities.scss",
     "cy:run": "cypress run --browser firefox",
     "start": "yarn storybook",
-    "storybook": "yarn storybook-prep && start-storybook --ci --host localhost --port 9001 -c .storybook -s ./static",
+    "storybook": "yarn storybook-prep && start-storybook --ci --host localhost --port 9001 -c .storybook",
     "storybook-prep": "run-s generate-utilities build-scss-variables copy-fonts",
-    "storybook-static": "yarn storybook-prep && build-storybook -c .storybook -o storybook  -s ./static",
+    "storybook-static": "yarn storybook-prep && build-storybook -c .storybook -o storybook",
     "pretest:unit": "yarn build-scss-variables",
     "test": "run-s test:unit test:visual",
     "test:integration": "NODE_ENV=test start-server-and-test start http://localhost:9001 cy:run",

package/src/components/base/new_dropdowns/constants.js

@@ -14,9 +14,9 @@ export const GL_DROPDOWN_SHOWN = 'shown';
 export const GL_DROPDOWN_HIDDEN = 'hidden';
 
 // KEY Codes
-export const HOME = 'Home';
-export const END = 'End';
-export const ARROW_UP = 'ArrowUp';
 export const ARROW_DOWN = 'ArrowDown';
+export const ARROW_UP = 'ArrowUp';
+export const END = 'End';
 export const ENTER = 'Enter';
+export const HOME = 'Home';
 export const SPACE = 'Space';

package/src/components/base/new_dropdowns/disclosure/disclosure_dropdown.md

@@ -5,10 +5,7 @@ to make sure this is the right dropdown component for you.
 ### Basic usage
 
 ```html
-<gl-disclosure-dropdown-dropdown
-  toggle-text="Actions"
-  :items="items"
-/>
+<gl-disclosure-dropdown-dropdown toggle-text="Actions" :items="items" />
 ```
 
 ### Icon-only disclosure dropdown
@@ -58,17 +55,28 @@ Below are the expected shapes of these objects:
 
 ```typescript
 type Item = {
-  text: string
-  href?: string,
-  action?: (item: Item) => void,
-}
+  // The item text
+  text: string;
+  // href link
+  href?: string;
+  // Item action
+  action?: (item: Item) => void;
+  // Set of extra attributes applied directly to the element
+  extraAttrs?: Object;
+  // Additional class/classes applied to the item wrapper
+  wrapperClass?: string;
+};
 
 type Group = {
-  name?: string
-  items: Array<Item>
-}
-
-type ItemsProp = Array<Item> | Array<Group>
+  // Name of the group, used as a header
+  name?: string;
+  // Items of the group
+  items: Array<Item>;
+  // Set of extra attributes applied directly to the element
+  extraAttrs?: Object;
+};
+
+type ItemsProp = Array<Item> | Array<Group>;
 ```
 
 #### Actions/links

package/src/components/base/new_dropdowns/disclosure/disclosure_dropdown.spec.js

@@ -1,4 +1,5 @@
 import { mount } from '@vue/test-utils';
+import * as utils from '../../../../utils/utils';
 import GlBaseDropdown from '../base_dropdown/base_dropdown.vue';
 import {
   GL_DROPDOWN_SHOWN,
@@ -32,6 +33,8 @@ describe('GlDisclosureDropdown', () => {
   const findDisclosureGroups = () => wrapper.findAllComponents(GlDisclosureDropdownGroup);
   const findListItem = (index) => findDisclosureItems().at(index).findComponent(ITEM_SELECTOR);
 
+  jest.spyOn(utils, 'filterVisible').mockImplementation((items) => items);
+
   describe('toggle text', () => {
     it('should pass toggle text to the base dropdown', () => {
       const toggleText = 'Merge requests';
@@ -147,6 +150,23 @@ describe('GlDisclosureDropdown', () => {
       await thirdItem.trigger('keydown', { code: HOME });
       expect(firstItem.element).toHaveFocus();
     });
+
+    describe('when an element is hidden', () => {
+      beforeEach(() => {
+        jest.spyOn(utils, 'filterVisible').mockReturnValue([firstItem.element, thirdItem.element]);
+      });
+
+      it('should skip over it', async () => {
+        expect(firstItem.element).toHaveFocus();
+        await firstItem.trigger('keydown', { code: ARROW_DOWN });
+
+        expect(secondItem.element).not.toHaveFocus();
+        expect(thirdItem.element).toHaveFocus();
+
+        await thirdItem.trigger('keydown', { code: ARROW_UP });
+        expect(firstItem.element).toHaveFocus();
+      });
+    });
   });
 
   describe('slot content', () => {

package/src/components/base/new_dropdowns/disclosure/disclosure_dropdown.vue

@@ -1,7 +1,7 @@
 <!-- eslint-disable vue/multi-word-component-names -->
 <script>
 import { clamp, uniqueId } from 'lodash';
-import { stopEvent } from '../../../../utils/utils';
+import { stopEvent, filterVisible } from '../../../../utils/utils';
 import {
   GL_DROPDOWN_SHOWN,
   GL_DROPDOWN_HIDDEN,
@@ -116,7 +116,7 @@ export default {
     toggleId: {
       type: String,
       required: false,
-      default: () => uniqueId('dropdown-toggle-btn-'),
+      default: uniqueId('dropdown-toggle-btn-'),
     },
     /**
      * Additional CSS classes to customize toggle appearance
@@ -246,7 +246,7 @@ export default {
     },
     getFocusableListItemElements() {
       const items = this.$refs.content?.querySelectorAll(`.${ITEM_CLASS}`);
-      return Array.from(items || []);
+      return filterVisible(Array.from(items || []));
     },
     focusNextItem(event, elements, offset) {
       const { target } = event;

package/src/components/base/new_dropdowns/disclosure/disclosure_dropdown_item.spec.js

@@ -56,6 +56,26 @@ describe('GlDisclosureDropdownItem', () => {
       expect(findLink().attributes('href')).toBe(mockItems[0].href);
       expect(findLink().attributes()).toMatchObject(mockItems[0].extraAttrs);
     });
+
+    it('should apply the default classes to the item wrapper', () => {
+      expect(findItem().classes()).toEqual(['gl-new-dropdown-item']);
+    });
+
+    describe('when item has wrapperClass', () => {
+      const TEST_CLASS = 'just-a-test-class';
+      beforeEach(() => {
+        buildWrapper({
+          item: {
+            ...mockItems[0],
+            wrapperClass: TEST_CLASS,
+          },
+        });
+      });
+
+      it('should add the extra class to the item wrapper', () => {
+        expect(findItem().classes()).toContain(TEST_CLASS);
+      });
+    });
   });
 
   describe('when item has an `action`', () => {
@@ -102,5 +122,35 @@ describe('GlDisclosureDropdownItem', () => {
       trigger();
       expect(wrapper.emitted('action')).toEqual([[item]]);
     });
+
+    it('should apply the default classes to the item wrapper', () => {
+      expect(findItem().classes()).toEqual(['gl-new-dropdown-item']);
+    });
+
+    describe('when item has wrapperClass', () => {
+      const TEST_CLASS = 'just-a-test-class';
+      beforeEach(() => {
+        buildWrapper({
+          item: {
+            ...mockItems[1],
+            wrapperClass: TEST_CLASS,
+          },
+        });
+      });
+
+      it('should add the extra class to the item wrapper', () => {
+        expect(findItem().classes()).toContain(TEST_CLASS);
+      });
+    });
+  });
+
+  describe('when item is null', () => {
+    beforeEach(() => {
+      buildWrapper({ item: null });
+    });
+
+    it('should not render anything', () => {
+      expect(wrapper.text()).toBe('');
+    });
   });
 });

package/src/components/base/new_dropdowns/disclosure/disclosure_dropdown_item.vue

@@ -25,6 +25,8 @@ export default {
     itemComponent() {
       const { item } = this;
 
+      if (!item) return null;
+
       if (this.isLink)
         return {
           is: 'a',
@@ -32,6 +34,7 @@ export default {
             href: item.href,
             ...item.extraAttrs,
           },
+          wrapperClass: item.wrapperClass,
           listeners: {},
         };
 
@@ -44,6 +47,7 @@ export default {
         listeners: {
           click: () => item.action?.call(undefined, item),
         },
+        wrapperClass: item.wrapperClass,
       };
     },
   },
@@ -72,8 +76,7 @@ export default {
 <template>
   <li
     tabindex="0"
-    :class="$options.ITEM_CLASS"
-    class="gl-new-dropdown-item"
+    :class="[$options.ITEM_CLASS, itemComponent && itemComponent.wrapperClass]"
     data-testid="disclosure-dropdown-item"
     @click="action"
     @keydown="onKeydown"
@@ -84,7 +87,7 @@ export default {
       </div>
     </div>
 
-    <template v-else>
+    <template v-else-if="itemComponent && item">
       <component
         :is="itemComponent.is"
         v-bind="itemComponent.attrs"

package/src/components/base/new_dropdowns/disclosure/mock_data.js

@@ -49,6 +49,14 @@ export const mockItemsCustomItem = [
       rel: 'nofollow',
     },
   },
+  {
+    text: 'I am only visible on mobile!',
+    action: () => {
+      // eslint-disable-next-line no-console
+      console.log('clicked!');
+    },
+    wrapperClass: 'gl-sm-display-none!',
+  },
 ];
 
 export const mockGroupsCustomItem = [

package/src/components/base/new_dropdowns/listbox/listbox.spec.js

@@ -9,6 +9,7 @@ import {
   ARROW_UP,
   HOME,
   END,
+  ENTER,
 } from '../constants';
 import GlIntersectionObserver from '../../../utilities/intersection_observer/intersection_observer.vue';
 import GlListbox, { ITEM_SELECTOR } from './listbox.vue';
@@ -273,6 +274,27 @@ describe('GlListbox', () => {
         firstItem.trigger('keydown', { code: ARROW_UP });
         expect(searchboxInput.element).toHaveFocus();
       });
+
+      describe('pressing Enter on the input', () => {
+        const keydownSpy = jest.fn();
+
+        beforeEach(() => {
+          keydownSpy.mockClear();
+          wrapper.element.addEventListener('keydown', keydownSpy);
+        });
+
+        afterEach(() => {
+          wrapper.element.removeEventListener('keydown', keydownSpy);
+        });
+
+        it('does not submit any ancestor form', async () => {
+          searchboxInput.trigger('keydown', { key: ENTER });
+
+          const [event] = keydownSpy.mock.calls[0];
+          expect(event.key).toBe(ENTER);
+          expect(event.defaultPrevented).toBe(true);
+        });
+      });
     });
   });
 

package/src/components/base/new_dropdowns/listbox/listbox.vue

@@ -608,6 +608,7 @@ export default {
         data-testid="listbox-search-input"
         :placeholder="searchPlaceholder"
         @input="search"
+        @keydown.enter.prevent
         @keydown="onKeydown"
       />
       <gl-loading-icon

package/src/scss/fonts.scss

@@ -14,7 +14,7 @@ Usage:
   font-display: block;
   font-style: normal;
   font-named-instance: 'Regular'; /* stylelint-disable property-no-unknown */
-  src: url('/fonts/GitLabSans.woff2') format('woff2');
+  src: url('../../static/fonts/GitLabSans.woff2') format('woff2');
 }
 
 /* -------------------------------------------------------
@@ -31,5 +31,5 @@ Usage:
    */
   font-display: block;
   font-style: normal;
-  src: url('/fonts/JetBrainsMono.woff2') format('woff2');
+  src: url('../../static/fonts/JetBrainsMono.woff2') format('woff2');
 }

package/src/utils/utils.js

@@ -1,3 +1,4 @@
+import { isVisible } from 'bootstrap-vue/src/utils/dom';
 import { COMMA, labelColorOptions, focusableTags } from './constants';
 
 export function debounceByAnimationFrame(fn) {
@@ -140,3 +141,10 @@ export function stopEvent(
     event.stopImmediatePropagation();
   }
 }
+
+/**
+ * Return an Array of visible items
+ */
+export function filterVisible(els) {
+  return (els || []).filter(isVisible);
+}