@gitlab/ui 52.6.0 → 52.7.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/ui",
-  "version": "52.6.0",
+  "version": "52.7.0",
   "description": "GitLab UI Components",
   "license": "MIT",
   "main": "dist/index.js",
@@ -85,9 +85,9 @@
     "@babel/core": "^7.20.5",
     "@babel/preset-env": "^7.20.2",
     "@gitlab/eslint-plugin": "18.1.0",
-    "@gitlab/fonts": "^1.0.0",
+    "@gitlab/fonts": "^1.0.1",
     "@gitlab/stylelint-config": "4.1.0",
-    "@gitlab/svgs": "3.13.0",
+    "@gitlab/svgs": "3.14.0",
     "@rollup/plugin-commonjs": "^11.1.0",
     "@rollup/plugin-node-resolve": "^7.1.3",
     "@rollup/plugin-replace": "^2.3.2",

package/src/components/base/accordion/accordion.stories.js

@@ -1,4 +1,3 @@
-import { disableControls } from '../../../utils/stories_utils';
 import readme from './accordion.md';
 import GlAccordion from './accordion.vue';
 import GlAccordionItem from './accordion_item.vue';
@@ -9,11 +8,11 @@ const template = `
         Each accordion can be expanded or collapsed independently of others.
       </gl-accordion-item>
 
-      <gl-accordion-item title="Item 2" :header-level="headerLevel">
+      <gl-accordion-item title="Item 2" :header-level="headerLevel" :visible="true">
         If you want to have an accordion item to be initially visible, please see
         <code>Initially Expanded</code> example for the <code>GLAccordionItem</code>.
       </gl-accordion-item>
-      
+
       <gl-accordion-item title="Item 3" :header-level="headerLevel" :visible="autoCollapse">
         If you want the other accordion items to collapse when one is open, please see
         <code>Auto Collapse</code> example.
@@ -40,15 +39,11 @@ const Template = (args) => ({
 export const Default = Template.bind({});
 Default.args = generateProps();
 
-export const AutoCollapse = Template.bind({});
-AutoCollapse.args = generateProps({ autoCollapse: true });
-
 export default {
   title: 'base/accordion',
   component: GlAccordion,
   parameters: {
     bootstrapComponent: 'b-collapse',
-    storyshots: { disable: true },
     docs: {
       description: {
         component: readme,
@@ -60,6 +55,5 @@ export default {
       options: [1, 2, 3, 4, 5, 6],
       control: 'select',
     },
-    ...disableControls(['autoCollapse']),
   },
 };

package/src/components/base/accordion/accordion_item.stories.js

@@ -4,7 +4,7 @@ import GlAccordionItem from './accordion_item.vue';
 const template = `
     <gl-accordion-item :title="title" :titleVisible="titleVisible" :visible="visible" :header-level="headerLevel">
         Lorem ipsum dolor sit amet consectetur adipisicing elit. Delectus, maiores.
-      </gl-accordion-item>
+    </gl-accordion-item>
     `;
 
 const defaultValue = (prop) => GlAccordionItem.props[prop].default;
@@ -34,10 +34,7 @@ const Template = (args) => ({
 });
 
 export const Default = Template.bind({});
-Default.args = generateProps({ titleVisible: 'Accordion Item Title Expanded' });
-
-export const InitiallyExpanded = Template.bind({});
-InitiallyExpanded.args = generateProps({ visible: true, title: 'Item Content Initially Expanded' });
+Default.args = generateProps({ visible: true, titleVisible: 'Accordion Item Title Expanded' });
 
 export default {
   title: 'base/accordion/accordion-item',

package/src/components/base/accordion/accordion_item.vue

@@ -20,32 +20,32 @@ export default {
     event: 'input',
   },
   props: {
-    /*
-    Used to set the title of accordion link
-    */
+    /**
+     * Used to set the title of accordion link
+     */
     title: {
       type: String,
       required: true,
     },
-    /*
-    Used to set the title of accordion link when the content is visible
-    */
+    /**
+     * Used to set the title of accordion link when the content is visible
+     * */
     titleVisible: {
       type: String,
       default: null,
       required: false,
     },
-    /*
-When set, it will ensure the accordion item is initially visible
- */
+    /**
+     * When set, it will ensure the accordion item is initially visible
+     */
     visible: {
       type: Boolean,
       default: false,
       required: false,
     },
-    /*
-        The header tag used in the accordion (h1/h2/h3/h4/h5/h6). This overrides the value provided by GlAccordion. For accessibility this should be set to an appropriate value in the context where the accordion is used.,
-*/
+    /**
+     * The header tag used in the accordion (h1/h2/h3/h4/h5/h6). This overrides the value provided by GlAccordion. For accessibility this should be set to an appropriate value in the context where the accordion is used.,
+     */
     headerLevel: {
       type: Number,
       required: false,
@@ -55,7 +55,7 @@ When set, it will ensure the accordion item is initially visible
       },
     },
     /**
-     * Additional CSS class(es) to be applied to the header.
+     * Additional CSS class(es) to be applied to the header
      */
     headerClass: {
       type: [String, Object, Array],

package/src/components/base/new_dropdowns/listbox/listbox.spec.js

@@ -1,5 +1,6 @@
 import { mount } from '@vue/test-utils';
 import { nextTick } from 'vue';
+import { useMockIntersectionObserver } from '~/utils/use_mock_intersection_observer';
 import GlBaseDropdown from '../base_dropdown/base_dropdown.vue';
 import {
   GL_DROPDOWN_SHOWN,
@@ -9,6 +10,7 @@ import {
   HOME,
   END,
 } from '../constants';
+import GlIntersectionObserver from '../../../utilities/intersection_observer/intersection_observer.vue';
 import GlListbox, { ITEM_SELECTOR } from './listbox.vue';
 import GlListboxItem from './listbox_item.vue';
 import GlListboxGroup from './listbox_group.vue';
@@ -25,6 +27,8 @@ describe('GlListbox', () => {
     });
   };
 
+  useMockIntersectionObserver();
+
   const findBaseDropdown = () => wrapper.findComponent(GlBaseDropdown);
   const findListContainer = () => wrapper.find('[role="listbox"]');
   const findListboxItems = (root = wrapper) => root.findAllComponents(GlListboxItem);
@@ -36,6 +40,7 @@ describe('GlListbox', () => {
   const findLoadingIcon = () => wrapper.find("[data-testid='listbox-search-loader']");
   const findSRNumberOfResultsText = () => wrapper.find("[data-testid='listbox-number-of-results']");
   const findResetButton = () => wrapper.find("[data-testid='listbox-reset-button']");
+  const findIntersectionObserver = () => wrapper.findComponent(GlIntersectionObserver);
 
   describe('toggle text', () => {
     describe.each`
@@ -435,4 +440,125 @@ describe('GlListbox', () => {
       expect(wrapper.vm.closeAndFocus).toHaveBeenCalled();
     });
   });
+
+  describe('when `infiniteScroll` prop is `true`', () => {
+    it('should throw an error when items are groups', () => {
+      expect(() => {
+        buildWrapper({
+          items: mockGroups,
+          infiniteScroll: true,
+        });
+      }).toThrow(
+        'Infinite scroll does not support groups. Please set the "infiniteScroll" prop to "false"'
+      );
+      expect(wrapper).toHaveLoggedVueErrors();
+    });
+
+    it('renders `GlIntersectionObserver` component', () => {
+      buildWrapper({
+        headerText: 'Select assignee',
+        items: mockOptions,
+        infiniteScroll: true,
+      });
+
+      expect(findIntersectionObserver().exists()).toBe(true);
+    });
+
+    describe('when bottom of listbox is reached', () => {
+      it('emits `bottom-reached` event', () => {
+        buildWrapper({
+          items: mockOptions,
+          infiniteScroll: true,
+        });
+
+        findIntersectionObserver().vm.$emit('appear');
+
+        expect(wrapper.emitted('bottom-reached')).toEqual([[]]);
+      });
+    });
+
+    describe('when `loading` prop is `true`', () => {
+      it('does not render `GlIntersectionObserver` component', () => {
+        buildWrapper({
+          items: mockOptions,
+          infiniteScroll: true,
+          loading: true,
+        });
+
+        expect(findIntersectionObserver().exists()).toBe(false);
+      });
+    });
+
+    describe('when `searching` prop is `true`', () => {
+      it('does not render `GlIntersectionObserver` component', () => {
+        buildWrapper({
+          items: mockOptions,
+          infiniteScroll: true,
+          searching: true,
+        });
+
+        expect(findIntersectionObserver().exists()).toBe(false);
+      });
+    });
+
+    describe('when `infiniteScrollLoading` prop is `true`', () => {
+      beforeEach(() => {
+        buildWrapper({
+          items: mockOptions,
+          infiniteScroll: true,
+          infiniteScrollLoading: true,
+        });
+      });
+
+      it('shows loading icon', () => {
+        expect(wrapper.find('[data-testid="listbox-infinite-scroll-loader"]').exists()).toBe(true);
+      });
+
+      it('does not render `GlIntersectionObserver` component', () => {
+        expect(findIntersectionObserver().exists()).toBe(false);
+      });
+    });
+
+    describe('when `totalItems` prop is set', () => {
+      it('adds `aria-setsize` and `aria-posinset` attributes to listbox items', () => {
+        const totalItems = mockOptions.length;
+
+        buildWrapper({
+          items: mockOptions,
+          infiniteScroll: true,
+          totalItems,
+        });
+
+        findListboxItems().wrappers.forEach((listboxItem, index) => {
+          expect(listboxItem.attributes('aria-setsize')).toBe(totalItems.toString());
+          expect(listboxItem.attributes('aria-posinset')).toBe((index + 1).toString());
+        });
+      });
+    });
+
+    describe('when `totalItems` prop is not set', () => {
+      it('does not add `aria-setsize` and `aria-posinset` attributes to listbox items', () => {
+        buildWrapper({
+          items: mockOptions,
+          infiniteScroll: true,
+        });
+
+        findListboxItems().wrappers.forEach((listboxItem) => {
+          expect(listboxItem.attributes('aria-setsize')).toBe(undefined);
+          expect(listboxItem.attributes('aria-posinset')).toBe(undefined);
+        });
+      });
+    });
+  });
+
+  describe('when `infiniteScroll` prop is `false`', () => {
+    it('does not render `GlIntersectionObserver` component', () => {
+      buildWrapper({
+        items: mockOptions,
+        infiniteScroll: false,
+      });
+
+      expect(findIntersectionObserver().exists()).toBe(false);
+    });
+  });
 });

package/src/components/base/new_dropdowns/listbox/listbox.stories.js

@@ -13,6 +13,8 @@ import {
   GlAvatar,
 } from '../../../../index';
 import { makeContainer } from '../../../../utils/story_decorators/container';
+import { disableControls } from '../../../../utils/stories_utils';
+import { setStoryTimeout } from '../../../../utils/test_utils';
 import readme from './listbox.md';
 import { mockOptions, mockGroups } from './mock_data';
 import { flattenedOptions } from './utils';
@@ -28,6 +30,8 @@ const generateProps = ({
   loading = defaultValue('loading'),
   searchable = defaultValue('searchable'),
   searching = defaultValue('searching'),
+  infiniteScroll = defaultValue('infiniteScroll'),
+  infiniteScrollLoading = defaultValue('infiniteScrollLoading'),
   noResultsText = defaultValue('noResultsText'),
   searchPlaceholder = defaultValue('searchPlaceholder'),
   noCaret = defaultValue('noCaret'),
@@ -51,6 +55,8 @@ const generateProps = ({
   loading,
   searchable,
   searching,
+  infiniteScroll,
+  infiniteScrollLoading,
   noResultsText,
   searchPlaceholder,
   noCaret,
@@ -77,6 +83,8 @@ const makeBindings = (overrides = {}) =>
     ':loading': 'loading',
     ':searchable': 'searchable',
     ':searching': 'searching',
+    ':infinite-scroll': 'infiniteScroll',
+    ':infinite-scroll-loading': 'infiniteScrollLoading',
     ':no-results-text': 'noResultsText',
     ':search-placeholder': 'searchPlaceholder',
     ':no-caret': 'noCaret',
@@ -534,3 +542,53 @@ SearchableGroups.args = generateProps({
   items: mockGroups,
 });
 SearchableGroups.decorators = [makeContainer({ height: '370px' })];
+
+export const InfiniteScroll = (
+  args,
+  { argTypes: { infiniteScroll, infiniteScrollLoading, items, ...argTypes } }
+) => ({
+  props: Object.keys(argTypes),
+  components: {
+    GlListbox,
+  },
+  data() {
+    return {
+      selected: mockOptions[1].value,
+      items: mockOptions.slice(0, 10),
+      infiniteScrollLoading: false,
+      infiniteScroll: true,
+    };
+  },
+  mounted() {
+    if (this.startOpened) {
+      openListbox(this);
+    }
+  },
+  methods: {
+    onBottomReached() {
+      this.infiniteScrollLoading = true;
+
+      setStoryTimeout(() => {
+        this.items.push(...mockOptions.slice(10, 12));
+        this.infiniteScrollLoading = false;
+        this.infiniteScroll = false;
+      }, 1000);
+    },
+  },
+  template: template('', {
+    label: `<span class="gl-my-0" id="listbox-label">Select a department</span>`,
+    bindingOverrides: {
+      ':items': 'items',
+      ':infinite-scroll': 'infiniteScroll',
+      ':infinite-scroll-loading': 'infiniteScrollLoading',
+      ':total-items': 12,
+      '@bottom-reached': 'onBottomReached',
+    },
+  }),
+});
+
+InfiniteScroll.argTypes = {
+  ...disableControls(['infiniteScroll', 'infiniteScrollLoading', 'items']),
+};
+InfiniteScroll.args = generateProps();
+InfiniteScroll.decorators = [makeContainer({ height: '370px' })];

package/src/components/base/new_dropdowns/listbox/listbox.vue

@@ -17,6 +17,7 @@ import {
 } from '../../../../utils/constants';
 import GlButton from '../../button/button.vue';
 import GlLoadingIcon from '../../loading_icon/loading_icon.vue';
+import GlIntersectionObserver from '../../../utilities/intersection_observer/intersection_observer.vue';
 import GlSearchBoxByType from '../../search_box_by_type/search_box_by_type.vue';
 import GlBaseDropdown from '../base_dropdown/base_dropdown.vue';
 import GlListboxItem from './listbox_item.vue';
@@ -43,6 +44,7 @@ export default {
     GlSearchBoxByType,
     GlListboxSearchInput,
     GlLoadingIcon,
+    GlIntersectionObserver,
   },
   model: {
     prop: 'selected',
@@ -215,6 +217,37 @@ export default {
       required: false,
       default: false,
     },
+    /**
+     * Enables infinite scroll.
+     * When set to `true`, the `@bottom-reached` event will be fired when
+     * the bottom of the listbox is scrolled to.
+     * Does not support groups.
+     */
+    infiniteScroll: {
+      type: Boolean,
+      required: false,
+      default: false,
+    },
+    /**
+     * This prop is used for infinite scroll.
+     * It represents the total number of items that exist,
+     * even if they have not yet been loaded.
+     * Do not set this prop if the total number of items is unknown.
+     */
+    totalItems: {
+      type: Number,
+      required: false,
+      default: null,
+    },
+    /**
+     * This prop is used for infinite scroll.
+     * Set to `true` when more items are being loaded.
+     */
+    infiniteScrollLoading: {
+      type: Boolean,
+      required: false,
+      default: false,
+    },
     /**
      * Message to be displayed when filtering produced no results
      */
@@ -298,6 +331,9 @@ export default {
       }
       return Boolean(this.selected);
     },
+    showIntersectionObserver() {
+      return this.infiniteScroll && !this.infiniteScrollLoading && !this.loading && !this.searching;
+    },
   },
   watch: {
     selected: {
@@ -324,6 +360,17 @@ export default {
       },
     },
   },
+  created() {
+    if (
+      process.env.NODE_ENV !== 'production' &&
+      this.infiniteScroll &&
+      this.items.some((item) => !isOption(item))
+    ) {
+      throw new Error(
+        'Infinite scroll does not support groups. Please set the "infiniteScroll" prop to "false"'
+      );
+    }
+  },
   methods: {
     open() {
       this.$refs.baseDropdown.open();
@@ -467,6 +514,25 @@ export default {
     closeAndFocus() {
       this.$refs.baseDropdown.closeAndFocus();
     },
+    onIntersectionObserverAppear() {
+      /**
+       * Emitted when bottom of listbox has been scrolled to.
+       * Used for infinite scroll.
+       *
+       * @event bottom-reached
+       */
+      this.$emit('bottom-reached');
+    },
+    listboxItemMoreItemsAriaAttributes(index) {
+      if (this.totalItems === null) {
+        return {};
+      }
+
+      return {
+        'aria-setsize': this.totalItems,
+        'aria-posinset': index + 1,
+      };
+    },
     isOption,
   },
 };
@@ -551,6 +617,7 @@ export default {
             :is-selected="isSelected(item)"
             :is-focused="isFocused(item)"
             :is-check-centered="isCheckCentered"
+            v-bind="listboxItemMoreItemsAriaAttributes(index)"
             @select="onSelect(item, $event)"
           >
             <!-- @slot Custom template of the listbox item -->
@@ -583,8 +650,17 @@ export default {
           </gl-listbox-group>
         </template>
       </template>
+      <gl-intersection-observer
+        v-if="showIntersectionObserver"
+        @appear="onIntersectionObserverAppear"
+      />
     </component>
-
+    <gl-loading-icon
+      v-if="infiniteScrollLoading"
+      data-testid="listbox-infinite-scroll-loader"
+      size="md"
+      class="gl-my-3"
+    />
     <span
       v-if="announceSRSearchResults"
       data-testid="listbox-number-of-results"

package/src/scss/utilities.scss

@@ -7789,10 +7789,12 @@
 }
 .gl-font-monospace {
   font-family: $gl-monospace-font;
+  font-variant-ligatures: none;
 }
 
 .gl-font-monospace\! {
   font-family: $gl-monospace-font !important;
+  font-variant-ligatures: none !important;
 }
 
 .gl-font-regular {

package/src/scss/utility-mixins/typography.scss

@@ -7,6 +7,7 @@
 */
 @mixin gl-font-monospace {
   font-family: $gl-monospace-font;
+  font-variant-ligatures: none;
 }
 
 @mixin gl-font-regular {