@gitlab/ui 52.13.1 → 53.0.1

package/CHANGELOG.md

@@ -1,3 +1,24 @@
+## [53.0.1](https://gitlab.com/gitlab-org/gitlab-ui/compare/v53.0.0...v53.0.1) (2023-01-23)
+
+
+### Bug Fixes
+
+* **GlDisclosureDropdown:** Always set button type ([595d6a2](https://gitlab.com/gitlab-org/gitlab-ui/commit/595d6a25835a42425f3a3b68080d70dcf24fbd08))
+
+# [53.0.0](https://gitlab.com/gitlab-org/gitlab-ui/compare/v52.13.1...v53.0.0) (2023-01-20)
+
+
+### Features
+
+* **GlDisclosureDropdown:** Add support for a placement prop ([06e789c](https://gitlab.com/gitlab-org/gitlab-ui/commit/06e789cdfd1f41a32c19a4ce19305cd4029777dd))
+
+
+### BREAKING CHANGES
+
+* **GlDisclosureDropdown:** `right` boolean prop replaced with `placement` string
+prop on base_dropdown.vue used by `GlCollapsibleListbox` and
+`GlDisclosureDropdown`
+
 ## [52.13.1](https://gitlab.com/gitlab-org/gitlab-ui/compare/v52.13.0...v52.13.1) (2023-01-19)
 
 

package/dist/components/base/new_dropdowns/base_dropdown/base_dropdown.js

@@ -1,6 +1,6 @@
 import _uniqueId from 'lodash/uniqueId';
 import { createPopper } from '@popperjs/core';
-import { buttonCategoryOptions, dropdownVariantOptions, buttonSizeOptions } from '../../../../utils/constants';
+import { buttonCategoryOptions, dropdownVariantOptions, buttonSizeOptions, dropdownPlacements } from '../../../../utils/constants';
 import { POPPER_CONFIG, GL_DROPDOWN_SHOWN, GL_DROPDOWN_HIDDEN, ENTER, SPACE } from '../constants';
 import GlButton from '../../button/button';
 import GlIcon from '../../icon/icon';
@@ -74,13 +74,11 @@ var script = {
       required: false,
       default: false
     },
-    /**
-     * Right align dropdown menu with respect to the toggle button
-     */
-    right: {
-      type: Boolean,
+    placement: {
+      type: String,
       required: false,
-      default: false
+      default: 'left',
+      validator: value => Object.keys(dropdownPlacements).includes(value)
     },
     // ARIA props
     ariaHaspopup: {
@@ -174,7 +172,7 @@ var script = {
     },
     popperConfig() {
       return {
-        placement: this.right ? 'bottom-end' : 'bottom-start',
+        placement: dropdownPlacements[this.placement],
         ...POPPER_CONFIG
       };
     }

package/dist/components/base/new_dropdowns/disclosure/disclosure_dropdown.js

@@ -2,7 +2,7 @@ import _uniqueId from 'lodash/uniqueId';
 import _clamp from 'lodash/clamp';
 import { stopEvent } from '../../../../utils/utils';
 import { GL_DROPDOWN_SHOWN, GL_DROPDOWN_HIDDEN, HOME, END, ARROW_UP, ARROW_DOWN } from '../constants';
-import { buttonCategoryOptions, dropdownVariantOptions, buttonSizeOptions } from '../../../../utils/constants';
+import { buttonCategoryOptions, dropdownVariantOptions, buttonSizeOptions, dropdownPlacements } from '../../../../utils/constants';
 import GlBaseDropdown from '../base_dropdown/base_dropdown';
 import GlDisclosureDropdownItem, { ITEM_CLASS } from './disclosure_dropdown_item';
 import GlDisclosureDropdownGroup from './disclosure_dropdown_group';
@@ -114,12 +114,13 @@ var script = {
       default: false
     },
     /**
-     * Right align disclosure dropdown with respect to the toggle button
+     * Align disclosure dropdown with respect to the toggle button
      */
-    right: {
-      type: Boolean,
+    placement: {
+      type: String,
       required: false,
-      default: false
+      default: 'left',
+      validator: value => Object.keys(dropdownPlacements).includes(value)
     },
     /**
      * The `aria-labelledby` attribute value for the toggle button
@@ -256,7 +257,7 @@ var script = {
 const __vue_script__ = script;
 
 /* template */
-var __vue_render__ = function () {var _vm=this;var _h=_vm.$createElement;var _c=_vm._self._c||_h;return _c('gl-base-dropdown',{ref:"baseDropdown",staticClass:"gl-disclosure-dropdown",attrs:{"aria-labelledby":_vm.toggleAriaLabelledBy,"toggle-id":_vm.toggleId,"toggle-text":_vm.toggleText,"toggle-class":_vm.toggleClass,"text-sr-only":_vm.textSrOnly,"category":_vm.category,"variant":_vm.variant,"size":_vm.size,"icon":_vm.icon,"disabled":_vm.disabled,"loading":_vm.loading,"no-caret":_vm.noCaret,"right":_vm.right},on:_vm._d({},[_vm.$options.events.GL_DROPDOWN_SHOWN,_vm.onShow,_vm.$options.events.GL_DROPDOWN_HIDDEN,_vm.onHide]),scopedSlots:_vm._u([(_vm.hasCustomToggle)?{key:"toggle",fn:function(){return [_vm._t("toggle")]},proxy:true}:null],null,true)},[_vm._v(" "),_vm._t("header"),_vm._v(" "),_c(_vm.disclosureOptions.tag,{ref:"content",tag:"component",staticClass:"gl-dropdown-contents gl-list-style-none gl-pl-0 gl-mb-0",attrs:{"id":_vm.disclosureId,"role":_vm.disclosureOptions.role,"aria-labelledby":_vm.listAriaLabelledBy || _vm.toggleId,"data-testid":"disclosure-content","tabindex":"-1"},on:{"keydown":_vm.onKeydown}},[_vm._t("default",function(){return [_vm._l((_vm.items),function(item,index){return [(_vm.isItem(item))?[_c('gl-disclosure-dropdown-item',{key:item.text,attrs:{"item":item},on:{"action":_vm.handleAction}},[_vm._t("list-item",null,{"item":item})],2)]:[_c('gl-disclosure-dropdown-group',{key:item.name,attrs:{"bordered":index !== 0,"group":item},on:{"action":_vm.handleAction},scopedSlots:_vm._u([(_vm.$scopedSlots['group-label'])?{key:"group-label",fn:function(){return [_vm._t("group-label",null,{"group":item})]},proxy:true}:null,{key:"list-item",fn:function(){return [_vm._t("list-item")]},proxy:true}],null,true)})]]})]})],2),_vm._v(" "),_vm._t("footer")],2)};
+var __vue_render__ = function () {var _vm=this;var _h=_vm.$createElement;var _c=_vm._self._c||_h;return _c('gl-base-dropdown',{ref:"baseDropdown",staticClass:"gl-disclosure-dropdown",attrs:{"aria-labelledby":_vm.toggleAriaLabelledBy,"toggle-id":_vm.toggleId,"toggle-text":_vm.toggleText,"toggle-class":_vm.toggleClass,"text-sr-only":_vm.textSrOnly,"category":_vm.category,"variant":_vm.variant,"size":_vm.size,"icon":_vm.icon,"disabled":_vm.disabled,"loading":_vm.loading,"no-caret":_vm.noCaret,"placement":_vm.placement},on:_vm._d({},[_vm.$options.events.GL_DROPDOWN_SHOWN,_vm.onShow,_vm.$options.events.GL_DROPDOWN_HIDDEN,_vm.onHide]),scopedSlots:_vm._u([(_vm.hasCustomToggle)?{key:"toggle",fn:function(){return [_vm._t("toggle")]},proxy:true}:null],null,true)},[_vm._v(" "),_vm._t("header"),_vm._v(" "),_c(_vm.disclosureOptions.tag,{ref:"content",tag:"component",staticClass:"gl-dropdown-contents gl-list-style-none gl-pl-0 gl-mb-0",attrs:{"id":_vm.disclosureId,"role":_vm.disclosureOptions.role,"aria-labelledby":_vm.listAriaLabelledBy || _vm.toggleId,"data-testid":"disclosure-content","tabindex":"-1"},on:{"keydown":_vm.onKeydown}},[_vm._t("default",function(){return [_vm._l((_vm.items),function(item,index){return [(_vm.isItem(item))?[_c('gl-disclosure-dropdown-item',{key:item.text,attrs:{"item":item},on:{"action":_vm.handleAction}},[_vm._t("list-item",null,{"item":item})],2)]:[_c('gl-disclosure-dropdown-group',{key:item.name,attrs:{"bordered":index !== 0,"group":item},on:{"action":_vm.handleAction},scopedSlots:_vm._u([(_vm.$scopedSlots['group-label'])?{key:"group-label",fn:function(){return [_vm._t("group-label",null,{"group":item})]},proxy:true}:null,{key:"list-item",fn:function(){return [_vm._t("list-item")]},proxy:true}],null,true)})]]})]})],2),_vm._v(" "),_vm._t("footer")],2)};
 var __vue_staticRenderFns__ = [];
 
   /* style */

package/dist/components/base/new_dropdowns/disclosure/disclosure_dropdown_item.js

@@ -26,7 +26,8 @@ var script = {
       if (this.isActionItem) return {
         is: 'button',
         attrs: {
-          ...this.item.extraAttrs
+          ...this.item.extraAttrs,
+          type: 'button'
         },
         listeners: {
           click: () => this.item.action()

package/dist/components/base/new_dropdowns/listbox/listbox.js

@@ -2,7 +2,7 @@ import _uniqueId from 'lodash/uniqueId';
 import _clamp from 'lodash/clamp';
 import { stopEvent } from '../../../../utils/utils';
 import { GL_DROPDOWN_SHOWN, GL_DROPDOWN_HIDDEN, HOME, END, ARROW_UP, ARROW_DOWN } from '../constants';
-import { buttonCategoryOptions, dropdownVariantOptions, buttonSizeOptions } from '../../../../utils/constants';
+import { buttonCategoryOptions, dropdownVariantOptions, buttonSizeOptions, dropdownPlacements } from '../../../../utils/constants';
 import GlButton from '../../button/button';
 import GlLoadingIcon from '../../loading_icon/loading_icon';
 import GlIntersectionObserver from '../../../utilities/intersection_observer/intersection_observer';
@@ -155,12 +155,13 @@ var script = {
       default: false
     },
     /**
-     * Right align listbox menu with respect to the toggle button
+     * Align listbox menu with respect to the toggle button
      */
-    right: {
-      type: Boolean,
+    placement: {
+      type: String,
       required: false,
-      default: false
+      default: 'left',
+      validator: value => Object.keys(dropdownPlacements).includes(value)
     },
     /**
      * Center selected item checkmark
@@ -535,7 +536,7 @@ var script = {
 const __vue_script__ = script;
 
 /* template */
-var __vue_render__ = function () {var _vm=this;var _h=_vm.$createElement;var _c=_vm._self._c||_h;return _c('gl-base-dropdown',{ref:"baseDropdown",attrs:{"aria-haspopup":"listbox","aria-labelledby":_vm.toggleAriaLabelledBy,"block":_vm.block,"toggle-id":_vm.toggleId,"toggle-text":_vm.listboxToggleText,"toggle-class":_vm.toggleClass,"text-sr-only":_vm.textSrOnly,"category":_vm.category,"variant":_vm.variant,"size":_vm.size,"icon":_vm.icon,"disabled":_vm.disabled,"loading":_vm.loading,"no-caret":_vm.noCaret,"right":_vm.right},on:_vm._d({},[_vm.$options.events.GL_DROPDOWN_SHOWN,_vm.onShow,_vm.$options.events.GL_DROPDOWN_HIDDEN,_vm.onHide]),scopedSlots:_vm._u([(_vm.hasCustomToggle)?{key:"toggle",fn:function(){return [_vm._t("toggle")]},proxy:true}:null],null,true)},[_vm._v(" "),(_vm.headerText)?_c('div',{staticClass:"gl-display-flex gl-align-items-center gl-p-4! gl-min-h-8",class:_vm.$options.HEADER_ITEMS_BORDER_CLASSES},[_c('div',{staticClass:"gl-flex-grow-1 gl-font-weight-bold gl-font-sm gl-pr-2",attrs:{"id":_vm.headerId,"data-testid":"listbox-header-text"}},[_vm._v("\n      "+_vm._s(_vm.headerText)+"\n    ")]),_vm._v(" "),(_vm.showResetButton)?_c('gl-button',{staticClass:"gl-focus-inset-border-2-blue-400! gl-flex-shrink-0 gl-font-sm! gl-px-2! gl-py-2!",attrs:{"category":"tertiary","data-testid":"listbox-reset-button"},on:{"click":_vm.onResetButtonClicked}},[_vm._v("\n      "+_vm._s(_vm.resetButtonLabel)+"\n    ")]):_vm._e()],1):_vm._e(),_vm._v(" "),(_vm.searchable)?_c('div',{class:_vm.$options.HEADER_ITEMS_BORDER_CLASSES},[_c('gl-listbox-search-input',{ref:"searchBox",attrs:{"aria-owns":_vm.listboxId,"data-testid":"listbox-search-input","placeholder":_vm.searchPlaceholder},on:{"input":_vm.search,"keydown":_vm.onKeydown},model:{value:(_vm.searchStr),callback:function ($$v) {_vm.searchStr=$$v;},expression:"searchStr"}}),_vm._v(" "),(_vm.searching)?_c('gl-loading-icon',{staticClass:"gl-my-3",attrs:{"data-testid":"listbox-search-loader","size":"md"}}):_vm._e()],1):_vm._e(),_vm._v(" "),(_vm.showList)?_c(_vm.listboxTag,{ref:"list",tag:"component",staticClass:"gl-dropdown-contents gl-list-style-none gl-pl-0 gl-mb-0",attrs:{"id":_vm.listboxId,"aria-labelledby":_vm.listAriaLabelledBy || _vm.headerId || _vm.toggleId,"role":"listbox","tabindex":"-1"},on:{"keydown":_vm.onKeydown}},[_vm._l((_vm.items),function(item,index){return [(_vm.isOption(item))?[_c('gl-listbox-item',_vm._b({key:item.value,attrs:{"data-testid":("listbox-item-" + (item.value)),"is-selected":_vm.isSelected(item),"is-focused":_vm.isFocused(item),"is-check-centered":_vm.isCheckCentered},on:{"select":function($event){return _vm.onSelect(item, $event)}}},'gl-listbox-item',_vm.listboxItemMoreItemsAriaAttributes(index),false),[_vm._t("list-item",function(){return [_vm._v("\n            "+_vm._s(item.text)+"\n          ")]},{"item":item})],2)]:[_c('gl-listbox-group',{key:item.text,class:_vm.groupClasses(index),attrs:{"name":item.text},scopedSlots:_vm._u([(_vm.$scopedSlots['group-label'])?{key:"group-label",fn:function(){return [_vm._t("group-label",null,{"group":item})]},proxy:true}:null],null,true)},[_vm._v(" "),_vm._l((item.options),function(option){return _c('gl-listbox-item',{key:option.value,attrs:{"data-testid":("listbox-item-" + (option.value)),"is-selected":_vm.isSelected(option),"is-focused":_vm.isFocused(option),"is-check-centered":_vm.isCheckCentered},on:{"select":function($event){return _vm.onSelect(option, $event)}}},[_vm._t("list-item",function(){return [_vm._v("\n              "+_vm._s(option.text)+"\n            ")]},{"item":option})],2)})],2)]]}),_vm._v(" "),(_vm.infiniteScrollLoading)?_c(_vm.listboxTag === 'ul' ? 'li' : 'div',{tag:"component"},[_c('gl-loading-icon',{staticClass:"gl-my-3",attrs:{"data-testid":"listbox-infinite-scroll-loader","size":"md"}})],1):_vm._e(),_vm._v(" "),(_vm.showIntersectionObserver)?_c('gl-intersection-observer',{on:{"appear":_vm.onIntersectionObserverAppear}}):_vm._e()],2):_vm._e(),_vm._v(" "),(_vm.announceSRSearchResults)?_c('span',{staticClass:"gl-sr-only",attrs:{"data-testid":"listbox-number-of-results","aria-live":"assertive"}},[_vm._t("search-summary-sr-only")],2):(_vm.showNoResultsText)?_c('div',{staticClass:"gl-pl-7 gl-pr-5 gl-pt-3 gl-font-base gl-text-gray-600",attrs:{"aria-live":"assertive","data-testid":"listbox-no-results-text"}},[_vm._v("\n    "+_vm._s(_vm.noResultsText)+"\n  ")]):_vm._e(),_vm._v(" "),_vm._t("footer")],2)};
+var __vue_render__ = function () {var _vm=this;var _h=_vm.$createElement;var _c=_vm._self._c||_h;return _c('gl-base-dropdown',{ref:"baseDropdown",attrs:{"aria-haspopup":"listbox","aria-labelledby":_vm.toggleAriaLabelledBy,"block":_vm.block,"toggle-id":_vm.toggleId,"toggle-text":_vm.listboxToggleText,"toggle-class":_vm.toggleClass,"text-sr-only":_vm.textSrOnly,"category":_vm.category,"variant":_vm.variant,"size":_vm.size,"icon":_vm.icon,"disabled":_vm.disabled,"loading":_vm.loading,"no-caret":_vm.noCaret,"placement":_vm.placement},on:_vm._d({},[_vm.$options.events.GL_DROPDOWN_SHOWN,_vm.onShow,_vm.$options.events.GL_DROPDOWN_HIDDEN,_vm.onHide]),scopedSlots:_vm._u([(_vm.hasCustomToggle)?{key:"toggle",fn:function(){return [_vm._t("toggle")]},proxy:true}:null],null,true)},[_vm._v(" "),(_vm.headerText)?_c('div',{staticClass:"gl-display-flex gl-align-items-center gl-p-4! gl-min-h-8",class:_vm.$options.HEADER_ITEMS_BORDER_CLASSES},[_c('div',{staticClass:"gl-flex-grow-1 gl-font-weight-bold gl-font-sm gl-pr-2",attrs:{"id":_vm.headerId,"data-testid":"listbox-header-text"}},[_vm._v("\n      "+_vm._s(_vm.headerText)+"\n    ")]),_vm._v(" "),(_vm.showResetButton)?_c('gl-button',{staticClass:"gl-focus-inset-border-2-blue-400! gl-flex-shrink-0 gl-font-sm! gl-px-2! gl-py-2!",attrs:{"category":"tertiary","data-testid":"listbox-reset-button"},on:{"click":_vm.onResetButtonClicked}},[_vm._v("\n      "+_vm._s(_vm.resetButtonLabel)+"\n    ")]):_vm._e()],1):_vm._e(),_vm._v(" "),(_vm.searchable)?_c('div',{class:_vm.$options.HEADER_ITEMS_BORDER_CLASSES},[_c('gl-listbox-search-input',{ref:"searchBox",attrs:{"aria-owns":_vm.listboxId,"data-testid":"listbox-search-input","placeholder":_vm.searchPlaceholder},on:{"input":_vm.search,"keydown":_vm.onKeydown},model:{value:(_vm.searchStr),callback:function ($$v) {_vm.searchStr=$$v;},expression:"searchStr"}}),_vm._v(" "),(_vm.searching)?_c('gl-loading-icon',{staticClass:"gl-my-3",attrs:{"data-testid":"listbox-search-loader","size":"md"}}):_vm._e()],1):_vm._e(),_vm._v(" "),(_vm.showList)?_c(_vm.listboxTag,{ref:"list",tag:"component",staticClass:"gl-dropdown-contents gl-list-style-none gl-pl-0 gl-mb-0",attrs:{"id":_vm.listboxId,"aria-labelledby":_vm.listAriaLabelledBy || _vm.headerId || _vm.toggleId,"role":"listbox","tabindex":"-1"},on:{"keydown":_vm.onKeydown}},[_vm._l((_vm.items),function(item,index){return [(_vm.isOption(item))?[_c('gl-listbox-item',_vm._b({key:item.value,attrs:{"data-testid":("listbox-item-" + (item.value)),"is-selected":_vm.isSelected(item),"is-focused":_vm.isFocused(item),"is-check-centered":_vm.isCheckCentered},on:{"select":function($event){return _vm.onSelect(item, $event)}}},'gl-listbox-item',_vm.listboxItemMoreItemsAriaAttributes(index),false),[_vm._t("list-item",function(){return [_vm._v("\n            "+_vm._s(item.text)+"\n          ")]},{"item":item})],2)]:[_c('gl-listbox-group',{key:item.text,class:_vm.groupClasses(index),attrs:{"name":item.text},scopedSlots:_vm._u([(_vm.$scopedSlots['group-label'])?{key:"group-label",fn:function(){return [_vm._t("group-label",null,{"group":item})]},proxy:true}:null],null,true)},[_vm._v(" "),_vm._l((item.options),function(option){return _c('gl-listbox-item',{key:option.value,attrs:{"data-testid":("listbox-item-" + (option.value)),"is-selected":_vm.isSelected(option),"is-focused":_vm.isFocused(option),"is-check-centered":_vm.isCheckCentered},on:{"select":function($event){return _vm.onSelect(option, $event)}}},[_vm._t("list-item",function(){return [_vm._v("\n              "+_vm._s(option.text)+"\n            ")]},{"item":option})],2)})],2)]]}),_vm._v(" "),(_vm.infiniteScrollLoading)?_c(_vm.listboxTag === 'ul' ? 'li' : 'div',{tag:"component"},[_c('gl-loading-icon',{staticClass:"gl-my-3",attrs:{"data-testid":"listbox-infinite-scroll-loader","size":"md"}})],1):_vm._e(),_vm._v(" "),(_vm.showIntersectionObserver)?_c('gl-intersection-observer',{on:{"appear":_vm.onIntersectionObserverAppear}}):_vm._e()],2):_vm._e(),_vm._v(" "),(_vm.announceSRSearchResults)?_c('span',{staticClass:"gl-sr-only",attrs:{"data-testid":"listbox-number-of-results","aria-live":"assertive"}},[_vm._t("search-summary-sr-only")],2):(_vm.showNoResultsText)?_c('div',{staticClass:"gl-pl-7 gl-pr-5 gl-pt-3 gl-font-base gl-text-gray-600",attrs:{"aria-live":"assertive","data-testid":"listbox-no-results-text"}},[_vm._v("\n    "+_vm._s(_vm.noResultsText)+"\n  ")]):_vm._e(),_vm._v(" "),_vm._t("footer")],2)};
 var __vue_staticRenderFns__ = [];
 
   /* style */

package/dist/utils/constants.js

@@ -104,6 +104,11 @@ const dropdownVariantOptions = {
   danger: 'danger',
   link: 'link'
 };
+const dropdownPlacements = {
+  left: 'bottom-start',
+  center: 'bottom',
+  right: 'bottom-end'
+};
 const buttonSizeOptions = {
   small: 'sm',
   medium: 'md'
@@ -252,4 +257,4 @@ const loadingIconSizes = {
   'xl (64x64)': 'xl'
 };
 
-export { COMMA, LEFT_MOUSE_BUTTON, alertVariantIconMap, alertVariantOptions, alignOptions, avatarShapeOptions, avatarSizeOptions, avatarsInlineSizeOptions, badgeForButtonOptions, badgeIconSizeOptions, badgeSizeOptions, badgeVariantOptions, bannerVariants, buttonCategoryOptions, buttonSizeOptions, buttonVariantOptions, colorThemes, columnOptions, datepickerSizeOptionsMap, defaultDateFormat, drawerVariants, dropdownVariantOptions, focusableTags, formInputSizes, formStateOptions, glThemes, iconSizeOptions, keyboard, labelColorOptions, labelSizeOptions, loadingIconSizes, maxZIndex, modalButtonDefaults, modalSizeOptions, popoverPlacements, resizeDebounceTime, tabsButtonDefaults, targetOptions, toggleLabelPosition, tokenVariants, tooltipActionEvents, tooltipDelay, tooltipPlacements, triggerVariantOptions, truncateOptions, variantCssColorMap, variantOptions, variantOptionsWithNoDefault, viewModeOptions };
+export { COMMA, LEFT_MOUSE_BUTTON, alertVariantIconMap, alertVariantOptions, alignOptions, avatarShapeOptions, avatarSizeOptions, avatarsInlineSizeOptions, badgeForButtonOptions, badgeIconSizeOptions, badgeSizeOptions, badgeVariantOptions, bannerVariants, buttonCategoryOptions, buttonSizeOptions, buttonVariantOptions, colorThemes, columnOptions, datepickerSizeOptionsMap, defaultDateFormat, drawerVariants, dropdownPlacements, dropdownVariantOptions, focusableTags, formInputSizes, formStateOptions, glThemes, iconSizeOptions, keyboard, labelColorOptions, labelSizeOptions, loadingIconSizes, maxZIndex, modalButtonDefaults, modalSizeOptions, popoverPlacements, resizeDebounceTime, tabsButtonDefaults, targetOptions, toggleLabelPosition, tokenVariants, tooltipActionEvents, tooltipDelay, tooltipPlacements, triggerVariantOptions, truncateOptions, variantCssColorMap, variantOptions, variantOptionsWithNoDefault, viewModeOptions };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/ui",
-  "version": "52.13.1",
+  "version": "53.0.1",
   "description": "GitLab UI Components",
   "license": "MIT",
   "main": "dist/index.js",
@@ -87,7 +87,7 @@
     "@gitlab/eslint-plugin": "18.1.0",
     "@gitlab/fonts": "^1.1.0",
     "@gitlab/stylelint-config": "4.1.0",
-    "@gitlab/svgs": "3.16.0",
+    "@gitlab/svgs": "3.17.0",
     "@rollup/plugin-commonjs": "^11.1.0",
     "@rollup/plugin-node-resolve": "^7.1.3",
     "@rollup/plugin-replace": "^2.3.2",

package/src/components/base/new_dropdowns/base_dropdown/base_dropdown.spec.js

@@ -57,8 +57,17 @@ describe('base dropdown', () => {
       );
     });
 
+    it('should initialize popper.js instance with toggle and menu elements and config for center-aligned menu', async () => {
+      await buildWrapper({ placement: 'center' });
+      expect(mockCreatePopper).toHaveBeenCalledWith(
+        findDefaultDropdownToggle().element,
+        findDropdownMenu().element,
+        { ...POPPER_CONFIG, placement: 'bottom' }
+      );
+    });
+
     it('should initialize popper.js instance with toggle and menu elements and config for right-aligned menu', async () => {
-      await buildWrapper({ right: true });
+      await buildWrapper({ placement: 'right' });
       expect(mockCreatePopper).toHaveBeenCalledWith(
         findDefaultDropdownToggle().element,
         findDropdownMenu().element,

package/src/components/base/new_dropdowns/base_dropdown/base_dropdown.vue

@@ -4,6 +4,7 @@ import { createPopper } from '@popperjs/core';
 import {
   buttonCategoryOptions,
   buttonSizeOptions,
+  dropdownPlacements,
   dropdownVariantOptions,
 } from '../../../../utils/constants';
 import { POPPER_CONFIG, GL_DROPDOWN_SHOWN, GL_DROPDOWN_HIDDEN, ENTER, SPACE } from '../constants';
@@ -77,13 +78,11 @@ export default {
       required: false,
       default: false,
     },
-    /**
-     * Right align dropdown menu with respect to the toggle button
-     */
-    right: {
-      type: Boolean,
+    placement: {
+      type: String,
       required: false,
-      default: false,
+      default: 'left',
+      validator: (value) => Object.keys(dropdownPlacements).includes(value),
     },
     // ARIA props
     ariaHaspopup: {
@@ -179,7 +178,7 @@ export default {
     },
     popperConfig() {
       return {
-        placement: this.right ? 'bottom-end' : 'bottom-start',
+        placement: dropdownPlacements[this.placement],
         ...POPPER_CONFIG,
       };
     },

package/src/components/base/new_dropdowns/disclosure/disclosure_dropdown.md

@@ -45,7 +45,12 @@ After closing, `GlDisclosureDropdown` emits a `hidden` event.
 ### Setting disclosure dropdown items
 
 Use the `items` prop to provide actions/links to the disclosure dropdown. Each item can be
-either an item or a group. Below are the expected shapes of these objects:
+either an item or a group. For `Item`s, either the `href` or the `action` may be null, but not both.
+A <!-- markdownlint-disable-next-line line-length -->
+[validation error](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/6cbff4f908b429cc01f17a4cc2868e881db1aa31/src/components/base/new_dropdowns/disclosure/utils.js#L1)
+will be triggered if neither field is set.
+
+Below are the expected shapes of these objects:
 
 ```typescript
 type Item = {

package/src/components/base/new_dropdowns/disclosure/disclosure_dropdown.stories.js

@@ -2,6 +2,7 @@ import {
   buttonCategoryOptions,
   buttonSizeOptions,
   buttonVariantOptions,
+  dropdownPlacements,
 } from '../../../../utils/constants';
 import {
   GlDisclosureDropdown,
@@ -27,7 +28,7 @@ const generateProps = ({
   disabled = defaultValue('disabled'),
   loading = defaultValue('loading'),
   noCaret = defaultValue('noCaret'),
-  right = defaultValue('right'),
+  placement = defaultValue('placement'),
   toggleText,
   textSrOnly = defaultValue('textSrOnly'),
   icon = '',
@@ -42,7 +43,7 @@ const generateProps = ({
   disabled,
   loading,
   noCaret,
-  right,
+  placement,
   toggleText,
   textSrOnly,
   icon,
@@ -60,7 +61,7 @@ const makeBindings = (overrides = {}) =>
     ':disabled': 'disabled',
     ':loading': 'loading',
     ':no-caret': 'noCaret',
-    ':right': 'right',
+    ':placement': 'placement',
     ':toggle-text': 'toggleText',
     ':text-sr-only': 'textSrOnly',
     ':icon': 'icon',
@@ -127,19 +128,24 @@ export const CustomListItem = (args, { argTypes }) => ({
       <template #list-item="{ item }">
         <a ref="link" class="gl-display-flex gl-align-items-center gl-justify-content-space-between gl-hover-text-gray-900 gl-hover-text-decoration-none gl-text-gray-900" :href="item.href" v-bind="item.extraAttrs">
           {{item.text}}
-          <gl-badge pill variant="info" v-if="item.count">{{item.count}}</gl-badge>
+          <gl-badge v-if="item.count" pill size="sm">{{item.count}}</gl-badge>
         </a>
       </template>
     `,
     {
       bindingOverrides: {
         '@action': 'navigate',
+        class: 'gl-display-block gl-text-center',
       },
     }
   ),
 });
 
-CustomListItem.args = generateProps({ items: mockItemsCustomItem, toggleText: 'Merge requests' });
+CustomListItem.args = generateProps({
+  items: mockItemsCustomItem,
+  toggleText: 'Merge requests',
+  placement: 'center',
+});
 CustomListItem.decorators = [makeContainer({ height: '200px' })];
 
 const makeGroupedExample = (changes) => {
@@ -302,5 +308,11 @@ export default {
         options: Object.keys(buttonSizeOptions),
       },
     },
+    placement: {
+      control: {
+        type: 'select',
+        options: Object.keys(dropdownPlacements),
+      },
+    },
   },
 };

package/src/components/base/new_dropdowns/disclosure/disclosure_dropdown.vue

@@ -13,6 +13,7 @@ import {
 import {
   buttonCategoryOptions,
   buttonSizeOptions,
+  dropdownPlacements,
   dropdownVariantOptions,
 } from '../../../../utils/constants';
 import GlBaseDropdown from '../base_dropdown/base_dropdown.vue';
@@ -125,12 +126,13 @@ export default {
       default: false,
     },
     /**
-     * Right align disclosure dropdown with respect to the toggle button
+     * Align disclosure dropdown with respect to the toggle button
      */
-    right: {
-      type: Boolean,
+    placement: {
+      type: String,
       required: false,
-      default: false,
+      default: 'left',
+      validator: (value) => Object.keys(dropdownPlacements).includes(value),
     },
     /**
      * The `aria-labelledby` attribute value for the toggle button
@@ -281,7 +283,7 @@ export default {
     :disabled="disabled"
     :loading="loading"
     :no-caret="noCaret"
-    :right="right"
+    :placement="placement"
     class="gl-disclosure-dropdown"
     @[$options.events.GL_DROPDOWN_SHOWN]="onShow"
     @[$options.events.GL_DROPDOWN_HIDDEN]="onHide"

package/src/components/base/new_dropdowns/disclosure/disclosure_dropdown_item.spec.js

@@ -62,7 +62,7 @@ describe('GlDisclosureDropdownItem', () => {
       action.mockClear();
     });
 
-    const findButton = () => wrapper.find('button.dropdown-item');
+    const findButton = () => wrapper.find('button[type="button"].dropdown-item');
 
     it('should render a button', () => {
       expect(findButton().exists()).toBe(true);

package/src/components/base/new_dropdowns/disclosure/disclosure_dropdown_item.vue

@@ -28,6 +28,7 @@ export default {
           is: 'button',
           attrs: {
             ...this.item.extraAttrs,
+            type: 'button',
           },
           listeners: {
             click: () => this.item.action(),

package/src/components/base/new_dropdowns/listbox/listbox.stories.js

@@ -2,6 +2,7 @@ import {
   buttonCategoryOptions,
   buttonSizeOptions,
   buttonVariantOptions,
+  dropdownPlacements,
 } from '../../../../utils/constants';
 import {
   GlIcon,
@@ -43,7 +44,7 @@ const generateProps = ({
   noResultsText = defaultValue('noResultsText'),
   searchPlaceholder = defaultValue('searchPlaceholder'),
   noCaret = defaultValue('noCaret'),
-  right = defaultValue('right'),
+  placement = defaultValue('placement'),
   toggleText,
   textSrOnly = defaultValue('textSrOnly'),
   headerText = defaultValue('headerText'),
@@ -69,7 +70,7 @@ const generateProps = ({
   noResultsText,
   searchPlaceholder,
   noCaret,
-  right,
+  placement,
   toggleText,
   textSrOnly,
   headerText,
@@ -98,7 +99,7 @@ const makeBindings = (overrides = {}) =>
     ':no-results-text': 'noResultsText',
     ':search-placeholder': 'searchPlaceholder',
     ':no-caret': 'noCaret',
-    ':right': 'right',
+    ':placement': 'placement',
     ':toggle-text': 'toggleText',
     ':text-sr-only': 'textSrOnly',
     ':header-text': 'headerText',
@@ -429,12 +430,21 @@ export default {
         subcategory: ARG_TYPE_SUBCATEGORY_LOOK_AND_FEEL,
       },
     },
+    block: {
+      table: {
+        subcategory: ARG_TYPE_SUBCATEGORY_LOOK_AND_FEEL,
+      },
+    },
     noCaret: {
       table: {
         subcategory: ARG_TYPE_SUBCATEGORY_LOOK_AND_FEEL,
       },
     },
-    right: {
+    placement: {
+      control: {
+        type: 'select',
+        options: Object.keys(dropdownPlacements),
+      },
       table: {
         subcategory: ARG_TYPE_SUBCATEGORY_LOOK_AND_FEEL,
       },

package/src/components/base/new_dropdowns/listbox/listbox.vue

@@ -13,6 +13,7 @@ import {
 import {
   buttonCategoryOptions,
   buttonSizeOptions,
+  dropdownPlacements,
   dropdownVariantOptions,
 } from '../../../../utils/constants';
 import GlButton from '../../button/button.vue';
@@ -167,12 +168,13 @@ export default {
       default: false,
     },
     /**
-     * Right align listbox menu with respect to the toggle button
+     * Align listbox menu with respect to the toggle button
      */
-    right: {
-      type: Boolean,
+    placement: {
+      type: String,
       required: false,
-      default: false,
+      default: 'left',
+      validator: (value) => Object.keys(dropdownPlacements).includes(value),
     },
     /**
      * Center selected item checkmark
@@ -566,7 +568,7 @@ export default {
     :disabled="disabled"
     :loading="loading"
     :no-caret="noCaret"
-    :right="right"
+    :placement="placement"
     @[$options.events.GL_DROPDOWN_SHOWN]="onShow"
     @[$options.events.GL_DROPDOWN_HIDDEN]="onHide"
   >

package/src/utils/constants.js

@@ -122,6 +122,12 @@ export const dropdownVariantOptions = {
   link: 'link',
 };
 
+export const dropdownPlacements = {
+  left: 'bottom-start',
+  center: 'bottom',
+  right: 'bottom-end',
+};
+
 export const buttonSizeOptions = {
   small: 'sm',
   medium: 'md',