@gitlab/ui 41.8.0 → 41.10.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/ui",
-  "version": "41.8.0",
+  "version": "41.10.0",
   "description": "GitLab UI Components",
   "license": "MIT",
   "main": "dist/index.js",
@@ -83,19 +83,18 @@
     "@babel/preset-env": "^7.10.2",
     "@gitlab/eslint-plugin": "12.3.0",
     "@gitlab/stylelint-config": "4.0.0",
-    "@gitlab/svgs": "2.18.0",
+    "@gitlab/svgs": "2.19.0",
     "@rollup/plugin-commonjs": "^11.1.0",
     "@rollup/plugin-node-resolve": "^7.1.3",
     "@rollup/plugin-replace": "^2.3.2",
-    "@storybook/addon-a11y": "6.5.8",
-    "@storybook/addon-docs": "6.5.8",
-    "@storybook/addon-essentials": "6.5.8",
-    "@storybook/addon-knobs": "6.4.0",
-    "@storybook/addon-storyshots": "6.5.8",
-    "@storybook/addon-storyshots-puppeteer": "6.5.8",
-    "@storybook/addon-viewport": "6.5.8",
-    "@storybook/theming": "6.5.8",
-    "@storybook/vue": "6.5.8",
+    "@storybook/addon-a11y": "6.5.9",
+    "@storybook/addon-docs": "6.5.9",
+    "@storybook/addon-essentials": "6.5.9",
+    "@storybook/addon-storyshots": "6.5.9",
+    "@storybook/addon-storyshots-puppeteer": "6.5.9",
+    "@storybook/addon-viewport": "6.5.9",
+    "@storybook/theming": "6.5.9",
+    "@storybook/vue": "6.5.9",
     "@vue/test-utils": "1.3.0",
     "autoprefixer": "^9.7.6",
     "babel-jest": "^26.6.3",

package/src/components/base/accordion/accordion.stories.js

@@ -50,7 +50,6 @@ export default {
   parameters: {
     bootstrapComponent: 'b-collapse',
     storyshots: { disable: true },
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/accordion/accordion_item.stories.js

@@ -45,7 +45,6 @@ export default {
   bootstrapComponent: 'b-collapse',
   parameters: {
     storyshots: { disable: true },
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/avatar/avatar.stories.js

@@ -108,7 +108,6 @@ export default {
   title: 'base/avatar',
   component: GlAvatar,
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/avatar_labeled/avatar_labeled.stories.js

@@ -113,7 +113,6 @@ export default {
   title: 'base/avatar/labeled',
   component: GlAvatarLabeled,
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/avatar_link/avatar_link.stories.js

@@ -65,7 +65,6 @@ export default {
   title: 'base/avatar/avatar-link',
   component: GlAvatarLink,
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/avatars_inline/avatars_inline.stories.js

@@ -65,7 +65,6 @@ export default {
   title: 'base/avatar/avatars-inline',
   component: GlAvatarsInline,
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/banner/banner.stories.js

@@ -89,7 +89,6 @@ export default {
   title: 'base/banner',
   component: GlBanner,
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/breadcrumb/breadcrumb.stories.js

@@ -53,7 +53,6 @@ export default {
   component: GlBreadcrumb,
   parameters: {
     bootstrapComponent: 'b-breadcrumb',
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/broadcast_message/broadcast_message.stories.js

@@ -69,7 +69,6 @@ export default {
   title: 'base/broadcast message',
   component: GlBroadcastMessage,
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/button/button.stories.js

@@ -505,9 +505,6 @@ export default {
         component: readme,
       },
     },
-    knobs: {
-      disable: true,
-    },
   },
   argTypes: {
     category: {

package/src/components/base/button_group/button_group.stories.js

@@ -33,8 +33,5 @@ export default {
         component: readme,
       },
     },
-    knobs: {
-      disable: true,
-    },
   },
 };

package/src/components/base/card/card.stories.js

@@ -29,7 +29,6 @@ export default {
   title: 'base/card',
   component: GlCard,
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/carousel/carousel.stories.js

@@ -41,7 +41,6 @@ export default {
   component: GlCarousel,
   parameters: {
     bootstrapComponent: 'b-carousel',
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/collapse/collapse.stories.js

@@ -36,8 +36,5 @@ export default {
         component: readme,
       },
     },
-    knobs: {
-      disabled: true,
-    },
   },
 };

package/src/components/base/daterange_picker/daterange_picker.stories.js

@@ -116,7 +116,6 @@ export default {
   component: GlDaterangePicker,
   decorators: [makeContainer({ height: '300px' })],
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/drawer/drawer.stories.js

@@ -156,7 +156,6 @@ export default {
     },
   },
   parameters: {
-    knobs: { disabled: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/form/form.stories.js

@@ -94,7 +94,6 @@ export default {
   component: GlForm,
   parameters: {
     bootstrapComponent: 'b-form',
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/form/form_checkbox/form_checkbox.stories.js

@@ -31,7 +31,6 @@ export default {
   title: 'base/form/form checkbox',
   component: GlFormCheckbox,
   parameters: {
-    knobs: { disable: true },
     bootstrapComponent: 'b-form-checkbox',
     docs: {
       description: {

package/src/components/base/form/form_combobox/form_combobox.stories.js

@@ -31,7 +31,6 @@ export default {
   title: 'base/form/form-combobox',
   component: GlFormCombobox,
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/form/form_input/form_input.stories.js

@@ -81,7 +81,6 @@ export default {
   component: GlFormInput,
   parameters: {
     bootstrapComponent: 'b-form-input',
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/form/form_input_group/form_input_group.stories.js

@@ -59,7 +59,6 @@ PredefinedOptions.args = generateProps({
 export default {
   title: 'base/form/form-input-group',
   component: GlFormInputGroup,
-  knobs: { disabled: true },
   parameters: {
     bootstrapComponent: 'b-form-input',
     docs: {
@@ -67,7 +66,6 @@ export default {
         component: readme,
       },
     },
-    knobs: { disabled: true },
   },
   argTypes: {
     ...disableControls(['value']),

package/src/components/base/form/form_radio/form_radio.stories.js

@@ -42,7 +42,6 @@ export default {
   component: GlFormRadio,
   parameters: {
     bootstrapComponent: 'b-form-radio',
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/form/form_radio_group/form_radio_group.stories.js

@@ -47,7 +47,6 @@ export default {
   title: 'base/form/form-radio-group',
   component: GlFormRadioGroup,
   parameters: {
-    knobs: { disable: true },
     bootstrapComponent: 'b-form-radio-group',
     docs: {
       description: {

package/src/components/base/form/form_select/form_select.stories.js

@@ -82,7 +82,6 @@ export default {
   component: GlFormSelect,
   parameters: {
     bootstrapComponent: 'b-form-select',
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/form/form_text/form_text.stories.js

@@ -18,7 +18,6 @@ export default {
   title: 'base/form/form-text',
   component: GlFormText,
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/form/form_textarea/form_textarea.stories.js

@@ -34,7 +34,6 @@ export default {
   component: GlFormTextarea,
   parameters: {
     bootstrapComponent: 'b-form-textarea',
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/form/input_group_text/input_group_text.stories.js

@@ -21,7 +21,6 @@ export default {
   component: GlInputGroupText,
   parameters: {
     controls: { disable: true },
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/icon/icon.stories.js

@@ -33,7 +33,6 @@ export default {
   title: 'base/icon',
   component: GlIcon,
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/infinite_scroll/infinite_scroll.stories.js

@@ -84,7 +84,6 @@ export default {
   title: 'base/infinite-scroll',
   component: GlInfiniteScroll,
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/keyset_pagination/keyset_pagination.stories.js

@@ -57,7 +57,6 @@ export default {
   component: GlKeysetPagination,
   parameters: {
     bootstrapComponent: false,
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/label/label.stories.js

@@ -58,7 +58,6 @@ export default {
   title: 'base/label',
   component: GlLabel,
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/loading_icon/loading_icon.stories.js

@@ -40,9 +40,6 @@ export default {
         component: readme,
       },
     },
-    knobs: {
-      disabled: true,
-    },
   },
   argTypes: {
     color: {

package/src/components/base/markdown/markdown.stories.js

@@ -29,6 +29,5 @@ export default {
         component: readme,
       },
     },
-    knobs: { disabled: true },
   },
 };

package/src/components/base/modal/modal.stories.js

@@ -106,7 +106,6 @@ export default {
   directives: { GlModalDirective },
   bootstrapComponent: 'b-modal',
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/nav/nav.stories.js

@@ -50,7 +50,6 @@ export default {
   },
   parameters: {
     bootstrapComponent: 'b-nav',
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/new_dropdowns/listbox/listbox.stories.js

@@ -254,7 +254,6 @@ export default {
   title: 'base/new-dropdowns/listbox',
   component: GlListbox,
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/paginated_list/paginated_list.stories.js

@@ -197,7 +197,6 @@ export default {
   title: 'base/paginated-list',
   component: GlPaginatedList,
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/pagination/pagination.stories.js

@@ -117,7 +117,6 @@ export default {
   title: 'base/pagination',
   component: GlPagination,
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/path/path.stories.js

@@ -65,7 +65,6 @@ export default {
   title: 'base/path',
   component: GlPath,
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/popover/popover.stories.js

@@ -81,7 +81,6 @@ export default {
   title: 'base/popover',
   component: GlPopover,
   parameters: {
-    knobs: { disable: true },
     bootstrapComponent: 'b-popover',
   },
   argTypes: {

package/src/components/base/progress_bar/progress_bar.stories.js

@@ -23,7 +23,6 @@ export default {
   title: 'base/progress-bar',
   component: GlProgressBar,
   parameters: {
-    knobs: { disable: true },
     bootstrapComponent: 'b-progress',
   },
   argTypes: {

package/src/components/base/search_box_by_click/search_box_by_click.stories.js

@@ -82,7 +82,6 @@ export default {
   title: 'base/search-box-by-click',
   component: GlSearchBoxByClick,
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/search_box_by_type/search_box_by_type.stories.js

@@ -41,7 +41,6 @@ export default {
   title: 'base/search-box-by-type',
   component: GlSearchBoxByType,
   parameters: {
-    knobs: { disable: true },
     bootstrapComponent: 'b-form-input',
     docs: {
       description: {

package/src/components/base/segmented_control/segmented_control.stories.js

@@ -39,7 +39,6 @@ export default {
   component: GlSegmentedControl,
   parameters: {
     bootstrapComponent: 'b-form-radio-group',
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/skeleton_loader/skeleton_loader.stories.js

@@ -77,7 +77,6 @@ export default {
   title: 'base/skeleton-loader',
   component: GlSkeletonLoader,
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/skeleton_loading/skeleton_loading.stories.js

@@ -31,7 +31,6 @@ export default {
         component: readme,
       },
     },
-    knobs: { disable: true },
   },
   argTypes: {
     lines: {

package/src/components/base/sorting/sorting.stories.js

@@ -56,7 +56,6 @@ export default {
   component: GlSorting,
   decorators: [makeContainer({ height: '100px', paddingLeft: '100px' })],
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/sorting/sorting_item.stories.js

@@ -40,7 +40,6 @@ export default {
   component: GlSortingItem,
   decorators: [makeContainer({ height: '50px', paddingLeft: '100px' })],
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/table/table.stories.js

@@ -98,7 +98,6 @@ export default {
   component: GlTable,
   parameters: {
     bootstrapComponent: 'b-table',
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/table_lite/table_lite.stories.js

@@ -53,7 +53,6 @@ export default {
   title: 'base/table/table_lite',
   component: GlTableLite,
   parameters: {
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/tabs/tab/tab.spec.js

@@ -1,5 +1,4 @@
 import { shallowMount } from '@vue/test-utils';
-import { BTab } from 'bootstrap-vue';
 import { DEFAULT_TAB_TITLE_LINK_CLASS } from '../constants';
 import GlTab from './tab.vue';
 
@@ -7,7 +6,9 @@ describe('Tab component', () => {
   let wrapper;
 
   const createComponent = (options) => {
-    wrapper = shallowMount(GlTab, { ...options });
+    wrapper = shallowMount(GlTab, {
+      ...options,
+    });
   };
 
   it.each`
@@ -21,25 +22,14 @@ describe('Tab component', () => {
     'computed title link class is $expectedProp when titleLinkClass is $titleLinkClass',
     ({ titleLinkClass, expectedProp }) => {
       createComponent({
-        propsData: { titleLinkClass },
+        propsData: {
+          titleLinkClass,
+        },
       });
 
-      expect(wrapper.findComponent(BTab).props('titleLinkClass')).toEqual(expectedProp);
+      expect(wrapper.html()).toBe(
+        `<b-tab-stub tag="div" title="" titlelinkclass="${expectedProp}"></b-tab-stub>`
+      );
     }
   );
-
-  it('passes title-link-attributes to b-tab when href is explicitly passed', () => {
-    const titleLinkAttributes = 'href-example';
-    const expectedProp = { href: titleLinkAttributes };
-    createComponent({
-      propsData: { href: titleLinkAttributes },
-    });
-    expect(wrapper.findComponent(BTab).props('titleLinkAttributes')).toEqual(expectedProp);
-  });
-
-  it('passes # as href to b-tab when href is not passed', () => {
-    const expectedProp = { href: '#' };
-    createComponent();
-    expect(wrapper.findComponent(BTab).props('titleLinkAttributes')).toEqual(expectedProp);
-  });
 });

package/src/components/base/tabs/tab/tab.vue

@@ -24,14 +24,6 @@ export default {
       required: false,
       default: null,
     },
-    /**
-     * Provide an `href` for the tab, for example to associate the tab with the tab panel's ID
-     */
-    href: {
-      type: String,
-      required: false,
-      default: '#',
-    },
   },
   computed: {
     linkClass() {
@@ -54,7 +46,6 @@ export default {
     :title-link-class="linkClass"
     :query-param-value="queryParamValue"
     v-bind="$attrs"
-    :title-link-attributes="{ href }"
     v-on="$listeners"
   >
     <template v-for="slot in Object.keys($slots)" #[slot]>

package/src/components/base/tabs/tabs/tabs.stories.js

@@ -226,20 +226,6 @@ WithScrollAndGrowing.parameters = {
   storyshots: { disable: true },
 };
 
-export const WithHref = (_args, { argTypes }) => ({
-  props: Object.keys(argTypes),
-  components: { ...components, GlBadge },
-  template: wrap(`
-    <gl-tab href="#tab-1" title="Tab 1">
-      <h2 id="tab-1">Tab panel 1</h2>
-      <p>Some paragraph text<p>
-    </gl-tab>
-    <gl-tab href="#tab-2" title="Tab 2">
-      <h2 id="tab-2">Tab panel 2</h2>
-      <p>Some paragraph text<p>
-    </gl-tab>`),
-});
-
 export default {
   title: 'base/tabs',
   component: GlTabs,

package/src/components/base/toast/toast.stories.js

@@ -74,7 +74,6 @@ export default {
   component: GlToast,
   parameters: {
     bootstrapComponent: 'toast',
-    knobs: { disable: true },
     docs: {
       description: {
         component: readme,

package/src/components/base/token_selector/token_container.spec.js

@@ -62,6 +62,15 @@ describe('GlTokenContainer', () => {
       });
     });
 
+    describe('viewOnly', () => {
+      it('passes viewOnly prop to tokens correctly', () => {
+        createComponent({ propsData: { viewOnly: true } });
+        const tokenWrappers = wrapper.findAllComponents(GlToken);
+
+        expect(tokenWrappers.wrappers.every((token) => token.props('viewOnly'))).toBe(true);
+      });
+    });
+
     describe('state', () => {
       describe('when `state` is `false`', () => {
         it('adds `aria-invalid="true"` attribute`', () => {

package/src/components/base/token_selector/token_container.vue

@@ -21,6 +21,11 @@ export default {
       type: Function,
       required: true,
     },
+    viewOnly: {
+      type: Boolean,
+      required: false,
+      default: false,
+    },
   },
   data() {
     return {
@@ -143,6 +148,7 @@ export default {
         class="gl-cursor-default"
         :class="token.class"
         :style="token.style"
+        :view-only="viewOnly"
         @close="handleClose(token)"
       >
         <slot name="token-content" :token="token">