@gitlab/ui 37.9.0 → 37.9.1

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [37.9.1](https://gitlab.com/gitlab-org/gitlab-ui/compare/v37.9.0...v37.9.1) (2022-03-16)
+
+
+### Bug Fixes
+
+* **GlFilteredSearch:** Keep active state on backspace on first token ([bd241df](https://gitlab.com/gitlab-org/gitlab-ui/commit/bd241dfbbd87064c10a67f0a0857b54542362605))
+
 # [37.9.0](https://gitlab.com/gitlab-org/gitlab-ui/compare/v37.8.0...v37.9.0) (2022-03-15)
 
 

package/dist/components/base/filtered_search/filtered_search.js

@@ -241,8 +241,8 @@ var script = {
       // possible, make sure no token is active.
 
       if (intent === INTENT_ACTIVATE_PREVIOUS) {
-        // If there is a previous token, activate it; else, deactivate all tokens
-        this.activeTokenIdx = idx > 0 ? idx - 1 : null;
+        // If there is a previous token, activate it; else, activate the first token
+        this.activeTokenIdx = Math.max(idx - 1, 0);
       } else if (idx < this.activeTokenIdx) {
         // Preserve the active token's active status (it shifted down one index)
         this.activeTokenIdx -= 1;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/ui",
-  "version": "37.9.0",
+  "version": "37.9.1",
   "description": "GitLab UI Components",
   "license": "MIT",
   "main": "dist/index.js",

package/src/components/base/filtered_search/filtered_search.spec.js

@@ -211,7 +211,7 @@ describe('Filtered search', () => {
       expect(wrapper.findComponent(FakeToken).props('active')).toBe(true);
     });
 
-    it('makes no token active if user intends it on first token destruction', async () => {
+    it('keeps first token active on first token destruction with backspace', async () => {
       createComponent({
         value: ['foo', { type: 'faketoken', value: '' }],
       });
@@ -228,7 +228,7 @@ describe('Filtered search', () => {
 
       await nextTick();
 
-      expect(wrapper.findComponent(FakeToken).props('active')).toBe(false);
+      expect(wrapper.findComponent(FakeToken).props('active')).toBe(true);
     });
 
     it('keeps active token active if later one destroyed', async () => {

package/src/components/base/filtered_search/filtered_search.vue

@@ -222,8 +222,8 @@ export default {
       // active state for the token that was active at the time. If that's not
       // possible, make sure no token is active.
       if (intent === INTENT_ACTIVATE_PREVIOUS) {
-        // If there is a previous token, activate it; else, deactivate all tokens
-        this.activeTokenIdx = idx > 0 ? idx - 1 : null;
+        // If there is a previous token, activate it; else, activate the first token
+        this.activeTokenIdx = Math.max(idx - 1, 0);
       } else if (idx < this.activeTokenIdx) {
         // Preserve the active token's active status (it shifted down one index)
         this.activeTokenIdx -= 1;