@gitlab/ui 134.0.0 → 134.1.1

package/dist/utils/string_utils.js

@@ -29,7 +29,6 @@ const splitAfterSymbols = (symbols, string) => {
     for (let j = 0; j < symbols.length; j += 1) {
       const symbol = symbols[j];
       if (!symbol) {
-        // eslint-disable-next-line no-continue
         continue;
       }
       symbolFound = string.slice(i, i + symbol.length) === symbol;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/ui",
-  "version": "134.0.0",
+  "version": "134.1.1",
   "description": "GitLab UI Components",
   "license": "MIT",
   "main": "dist/index.js",
@@ -91,8 +91,8 @@
   "resolutions": {
     "chokidar": "^4.0.3",
     "sane": "^5.0.1",
-    "jackspeak": "2.1.1",
-    "postcss": "8.5.13",
+    "jackspeak": "2.3.6",
+    "postcss": "8.5.14",
     "json5": "2.2.3",
     "rollup-plugin-vue/@vue/component-compiler/postcss-modules-sync/generic-names/loader-utils": "3.3.1"
   },
@@ -101,14 +101,14 @@
     "@babel/core": "^7.29.0",
     "@babel/plugin-proposal-nullish-coalescing-operator": "^7.18.6",
     "@babel/plugin-proposal-optional-chaining": "^7.21.0",
-    "@babel/preset-env": "^7.29.3",
+    "@babel/preset-env": "^7.29.5",
     "@babel/preset-react": "^7.28.5",
     "@cypress/grep": "^4.1.1",
-    "@figma/code-connect": "^1.4.4",
+    "@figma/code-connect": "^1.4.5",
     "@gitlab/fonts": "^1.3.1",
-    "@gitlab/hybrid-vue": "npm:@vue/compat@3.5.30",
+    "@gitlab/hybrid-vue": "npm:@vue/compat@3.5.34",
     "@gitlab/svgs": "*",
-    "@jest/test-sequencer": "30.3.0",
+    "@jest/test-sequencer": "30.4.1",
     "@rollup/plugin-commonjs": "^28.0.9",
     "@rollup/plugin-node-resolve": "^16.0.3",
     "@rollup/plugin-replace": "^6.0.3",
@@ -139,7 +139,7 @@
     "autoprefixer": "10.5.0",
     "axe-playwright": "^2.2.2",
     "babel-loader": "^9.2.1",
-    "cypress": "15.14.2",
+    "cypress": "15.15.0",
     "cypress-real-events": "^1.15.0",
     "dompurify": "^3.1.2",
     "emoji-regex": "^10.6.0",
@@ -154,9 +154,9 @@
     "mockdate": "^3.0.5",
     "module-alias": "^2.3.4",
     "pikaday": "^1.8.0",
-    "playwright": "^1.59.1",
-    "playwright-core": "^1.59.1",
-    "postcss": "8.5.13",
+    "playwright": "^1.60.0",
+    "playwright-core": "^1.60.0",
+    "postcss": "8.5.14",
     "postcss-loader": "8.2.1",
     "postcss-scss": "4.0.9",
     "react": "18.3.1",

package/src/components/base/avatars_inline/avatars_inline.vue

@@ -84,6 +84,10 @@ export default {
         }[this.avatarSize] || 'lg'
       );
     },
+    rootClass() {
+      // eslint-disable-next-line @gitlab/tailwind-no-interpolation
+      return ['gl-avatars-inline', `gl-avatars-inline-${this.badgeSize}`];
+    },
     badgeLabel() {
       return `+${this.hiddenAvatars.length}`;
     },
@@ -106,7 +110,7 @@ export default {
 };
 </script>
 <template>
-  <div class="gl-avatars-inline" :class="`gl-avatars-inline-${badgeSize}`">
+  <div :class="rootClass">
     <div v-for="(avatar, index) in visibleAvatars" :key="index" class="gl-avatars-inline-child">
       <!-- @slot Custom avatar rendering. Provide avatar object as slot prop. -->
       <slot name="avatar" :avatar="avatar">

package/src/components/base/breadcrumb/breadcrumb.vue

@@ -119,6 +119,10 @@ export default {
       }
       return '';
     },
+    dropdownItemClass() {
+      // eslint-disable-next-line @gitlab/tailwind-no-interpolation
+      return ['gl-breadcrumb-item', `gl-breadcrumb-item-${this.size}`];
+    },
     dropdownSize() {
       return this.size === 'sm' ? 'small' : 'medium';
     },
@@ -257,11 +261,7 @@ export default {
 <template>
   <nav class="gl-breadcrumbs" :aria-label="ariaLabel" :style="breadcrumbStyle">
     <ol class="gl-breadcrumb-list breadcrumb" v-bind="$attrs" v-on="$listeners">
-      <li
-        v-if="hasCollapsible || !resizeDone"
-        ref="dropdown"
-        :class="`gl-breadcrumb-item gl-breadcrumb-item-${size}`"
-      >
+      <li v-if="hasCollapsible || !resizeDone" ref="dropdown" :class="dropdownItemClass">
         <gl-disclosure-dropdown
           :items="overflowingItems"
           :toggle-text="showMoreLabel"

package/src/components/base/breadcrumb/breadcrumb_item.vue

@@ -54,12 +54,18 @@ export default {
       validator: (value) => Object.keys(breadCrumbSizeOptions).includes(value),
     },
   },
+  computed: {
+    itemClass() {
+      // eslint-disable-next-line @gitlab/tailwind-no-interpolation
+      return ['gl-breadcrumb-item', `gl-breadcrumb-item-${this.size}`];
+    },
+  },
   linkVariantUnstyled,
 };
 </script>
 
 <template>
-  <li :class="`gl-breadcrumb-item gl-breadcrumb-item-${size}`">
+  <li :class="itemClass">
     <gl-link
       :href="href"
       :to="to"

package/src/components/base/button/button.vue

@@ -9,7 +9,7 @@ import {
 import { logWarning, stopEvent } from '../../../utils/utils';
 import { isSlotEmpty } from '../../../utils/is_slot_empty';
 import { SafeLinkMixin } from '../../mixins/safe_link_mixin';
-import { isEvent } from '../../../vendor/bootstrap-vue/src/utils/inspect';
+import { glButtonConfig } from '../../../config';
 import GlIcon from '../icon/icon.vue';
 import GlLoadingIcon from '../loading_icon/loading_icon.vue';
 import { ENTER, SPACE } from '../new_dropdowns/constants';
@@ -122,6 +122,14 @@ export default {
       required: false,
       default: false,
     },
+    /**
+     * Keep the button accessible while `disabled` is `true`. Uses `aria-disabled` so the element remains focusable and is announced by assistive technology.
+     */
+    accessibleDisabled: {
+      type: Boolean,
+      required: false,
+      default: () => glButtonConfig.accessibleDisabledButton,
+    },
     /**
      * Denotes the target URL of the link for standard links.
      */
@@ -237,9 +245,20 @@ export default {
     hasIconOnly() {
       return isSlotEmpty(this, 'default') && this.hasIcon && this.count == null;
     },
-    isButtonAriaDisabled() {
+    isDisabledOrLoading() {
+      if (this.accessibleDisabled) {
+        return this.disabled || (this.isButton && this.loading);
+      }
       return this.isButton && this.loading;
     },
+    ariaDisabled() {
+      if (this.isDisabledOrLoading) return 'true';
+      // Non-standard tags need an explicit aria-disabled value to convey interactive state.
+      if (this.isNonStandardTag) {
+        return this.accessibleDisabled ? 'false' : String(this.disabled);
+      }
+      return null;
+    },
     buttonClasses() {
       const classes = ['btn', 'gl-button', `btn-${this.variant}`, `btn-${this.buttonSize}`];
 
@@ -252,7 +271,7 @@ export default {
         'button-ellipsis-horizontal': this.hasIconOnly && this.icon === 'ellipsis_h',
         selected: this.selected,
         'btn-block': this.displayBlock,
-        disabled: this.disabled || this.isButtonAriaDisabled,
+        disabled: this.disabled || this.isDisabledOrLoading,
       });
 
       if (this.label) {
@@ -284,27 +303,24 @@ export default {
       return !this.isLink && !this.isButton;
     },
     tabindex() {
-      // When disabled remove links and non-standard tags from tab order
-      if (this.disabled) {
+      // Legacy: remove disabled links and non-standard tags from tab order.
+      if (!this.accessibleDisabled && this.disabled) {
         return this.isLink || this.isNonStandardTag ? '-1' : this.$attrs.tabindex;
       }
-
-      // Add hash links and non-standard tags to tab order
+      // Inactive elements stay in tab order so assistive technology can discover them;
+      // aria-disabled communicates the inactive state instead of removing the element.
       return this.isNonStandardTag || this.isHashLink ? '0' : this.$attrs.tabindex;
     },
     computedPropsAndAttributes() {
       const base = {
         // Type only used for "real" buttons
         type: this.isButton ? this.type : null,
-        // Disabled only set on "real" buttons
-        disabled: this.isButton ? this.disabled : null,
+        // Legacy: native disabled attribute on real buttons.
+        ...(!this.accessibleDisabled && this.isButton ? { disabled: this.disabled } : {}),
         // We add a role of button when the tag is not a link or button or when link has `href` of `#`
         role: this.isNonStandardTag || this.isHashLink ? 'button' : this.$attrs?.role,
-        // We set the `aria-disabled` state for non-standard tags
-        ...(this.isNonStandardTag ? { 'aria-disabled': String(this.disabled) } : {}),
         tabindex: this.tabindex,
-        // We set the `aria-disabled` state for buttons while loading
-        ...(this.isButtonAriaDisabled ? { 'aria-disabled': 'true' } : {}),
+        ...(this.ariaDisabled !== null ? { 'aria-disabled': this.ariaDisabled } : {}),
       };
 
       if (this.isLink) {
@@ -333,7 +349,7 @@ export default {
         ...this.$listeners,
       };
 
-      if (this.isButtonAriaDisabled) {
+      if (this.isDisabledOrLoading) {
         delete listeners.click;
       }
       return listeners;
@@ -366,7 +382,11 @@ export default {
       // Skip if disabled
       // Add SPACE keydown handler for link has `href` of `#`
       // Add ENTER handler for non-standard tags
-      if (!this.disabled && (this.isNonStandardTag || this.isHashLink)) {
+      if (
+        !this.disabled &&
+        !this.isDisabledOrLoading &&
+        (this.isNonStandardTag || this.isHashLink)
+      ) {
         const { code } = event;
 
         if (code === SPACE || (code === ENTER && this.isNonStandardTag)) {
@@ -377,7 +397,8 @@ export default {
       }
     },
     maybeStopEvent(event) {
-      if (this.isButtonAriaDisabled && isEvent(event)) {
+      const eventIsEvent = event instanceof Event;
+      if (this.isDisabledOrLoading && eventIsEvent) {
         stopEvent(event);
       }
     },

package/src/components/base/new_dropdowns/dropdown.scss

@@ -3,8 +3,10 @@
   @apply gl-align-middle;
 
   .gl-new-dropdown-custom-toggle {
-    *:first-child {
-      @apply gl-cursor-pointer;
+    > *:first-child {
+      &:not(:disabled) {
+        @apply gl-cursor-pointer;
+      }
 
       &:focus {
         @apply gl-focus;

package/src/components/utilities/sprintf/sprintf.vue

@@ -1,5 +1,4 @@
 <script>
-/* eslint-disable no-continue */
 import { has, isString } from 'lodash-es';
 
 const PREFIX = '%{';

package/src/config.js

@@ -6,6 +6,8 @@ export const defaultConfig = {
   firstDayOfWeek: 0, // Defaults to 0 (Sunday)
 };
 
+export const glButtonConfig = {};
+
 let configured = false;
 
 /**
@@ -15,10 +17,10 @@ let configured = false;
  * @template TValue=string
  * @property {undefined | Object} translations Generic translations for component labels to fall back to.
  * @property {undefined | Number} firstDayOfWeek Configured first day of the week, from 0 (Sunday) to 6 (Saturday).
- * @property {boolean} [accessibleLoadingButton] Temporary flag to enable accessible loading button.
+ * @property {boolean} [accessibleDisabledButton] Temporary flag to enable the accessible disabled button.
  *
  */
-const setConfigs = ({ translations, firstDayOfWeek } = {}) => {
+const setConfigs = ({ translations, firstDayOfWeek, accessibleDisabledButton = false } = {}) => {
   if (configured) {
     if (process.env.NODE_ENV === 'development') {
       throw new Error('GitLab UI can only be configured once!');
@@ -52,6 +54,23 @@ const setConfigs = ({ translations, firstDayOfWeek } = {}) => {
 
     Object.assign(i18n, translations);
   }
+
+  // Temporary flag to enable the accessible disabled button feature.
+  // This flag allows the feature to be opt-in during the rollout phase,
+  // giving us the flexibility to test and validate its impact on user experience.
+
+  // The global variable `accessibleDisabledButton` is set to a boolean value
+  // to indicate whether the button should use aria-disabled while disabled.
+
+  // Future Plan:
+  // Once the accessible disabled button feature is validated and stable,
+  // we will remove this temporary flag and make the feature the default behavior.
+  // At that point, there will be no need for opt-in or opt-out mechanisms for this feature.
+  if (typeof accessibleDisabledButton === 'boolean') {
+    Object.assign(glButtonConfig, {
+      accessibleDisabledButton,
+    });
+  }
 };
 
 export default setConfigs;

package/src/utils/string_utils.js

@@ -33,7 +33,6 @@ export const splitAfterSymbols = (symbols, string) => {
       const symbol = symbols[j];
 
       if (!symbol) {
-        // eslint-disable-next-line no-continue
         continue;
       }