@gitlab/ui 134.0.0 → 134.1.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -82,6 +82,10 @@ var script = {
82
82
  32: 'lg'
83
83
  }[this.avatarSize] || 'lg';
84
84
  },
85
+ rootClass() {
86
+ // eslint-disable-next-line @gitlab/tailwind-no-interpolation
87
+ return ['gl-avatars-inline', `gl-avatars-inline-${this.badgeSize}`];
88
+ },
85
89
  badgeLabel() {
86
90
  return `+${this.hiddenAvatars.length}`;
87
91
  },
@@ -104,7 +108,7 @@ var script = {
104
108
  const __vue_script__ = script;
105
109
 
106
110
  /* template */
107
- var __vue_render__ = function () {var _vm=this;var _h=_vm.$createElement;var _c=_vm._self._c||_h;return _c('div',{staticClass:"gl-avatars-inline",class:("gl-avatars-inline-" + _vm.badgeSize)},[_vm._l((_vm.visibleAvatars),function(avatar,index){return _c('div',{key:index,staticClass:"gl-avatars-inline-child"},[_vm._t("avatar",function(){return [_c('gl-avatar',_vm._b({attrs:{"size":_vm.avatarSize}},'gl-avatar',avatar,false))]},{"avatar":avatar})],2)}),_vm._v(" "),(_vm.collapsed && _vm.collapsable)?_c('div',{staticClass:"gl-avatars-inline-child"},[(_vm.badgeTooltipProp)?_c('gl-tooltip',{attrs:{"target":function () { return _vm.$refs.badge; }}},[_vm._v("\n "+_vm._s(_vm.badgeTooltipTitle)+"\n ")]):_vm._e(),_vm._v(" "),_c('span',{ref:"badge",class:['gl-avatars-inline-badge', _vm.badgeSize],attrs:{"data-testid":"collapsed-avatars-badge","aria-hidden":"true"}},[_vm._v("\n "+_vm._s(_vm.badgeLabel)+"\n ")]),_vm._v(" "),_c('span',{staticClass:"gl-sr-only",attrs:{"data-testid":"badge-sr-only-text"}},[_vm._v(_vm._s(_vm.badgeSrOnlyText))])],1):_vm._e()],2)};
111
+ var __vue_render__ = function () {var _vm=this;var _h=_vm.$createElement;var _c=_vm._self._c||_h;return _c('div',{class:_vm.rootClass},[_vm._l((_vm.visibleAvatars),function(avatar,index){return _c('div',{key:index,staticClass:"gl-avatars-inline-child"},[_vm._t("avatar",function(){return [_c('gl-avatar',_vm._b({attrs:{"size":_vm.avatarSize}},'gl-avatar',avatar,false))]},{"avatar":avatar})],2)}),_vm._v(" "),(_vm.collapsed && _vm.collapsable)?_c('div',{staticClass:"gl-avatars-inline-child"},[(_vm.badgeTooltipProp)?_c('gl-tooltip',{attrs:{"target":function () { return _vm.$refs.badge; }}},[_vm._v("\n "+_vm._s(_vm.badgeTooltipTitle)+"\n ")]):_vm._e(),_vm._v(" "),_c('span',{ref:"badge",class:['gl-avatars-inline-badge', _vm.badgeSize],attrs:{"data-testid":"collapsed-avatars-badge","aria-hidden":"true"}},[_vm._v("\n "+_vm._s(_vm.badgeLabel)+"\n ")]),_vm._v(" "),_c('span',{staticClass:"gl-sr-only",attrs:{"data-testid":"badge-sr-only-text"}},[_vm._v(_vm._s(_vm.badgeSrOnlyText))])],1):_vm._e()],2)};
108
112
  var __vue_staticRenderFns__ = [];
109
113
 
110
114
  /* style */
@@ -128,6 +128,10 @@ var script = {
128
128
  }
129
129
  return '';
130
130
  },
131
+ dropdownItemClass() {
132
+ // eslint-disable-next-line @gitlab/tailwind-no-interpolation
133
+ return ['gl-breadcrumb-item', `gl-breadcrumb-item-${this.size}`];
134
+ },
131
135
  dropdownSize() {
132
136
  return this.size === 'sm' ? 'small' : 'medium';
133
137
  },
@@ -247,7 +251,7 @@ var script = {
247
251
  const __vue_script__ = script;
248
252
 
249
253
  /* template */
250
- var __vue_render__ = function () {var _vm=this;var _h=_vm.$createElement;var _c=_vm._self._c||_h;return _c('nav',{staticClass:"gl-breadcrumbs",style:(_vm.breadcrumbStyle),attrs:{"aria-label":_vm.ariaLabel}},[_c('ol',_vm._g(_vm._b({staticClass:"gl-breadcrumb-list breadcrumb"},'ol',_vm.$attrs,false),_vm.$listeners),[(_vm.hasCollapsible || !_vm.resizeDone)?_c('li',{ref:"dropdown",class:("gl-breadcrumb-item gl-breadcrumb-item-" + _vm.size)},[_c('gl-disclosure-dropdown',{attrs:{"items":_vm.overflowingItems,"toggle-text":_vm.showMoreLabel,"fluid-width":"","text-sr-only":"","no-caret":"","icon":"ellipsis_h","size":_vm.dropdownSize}})],1):_vm._e(),_vm._v(" "),_vm._l((_vm.fittingItems),function(item,index){return _c('gl-breadcrumb-item',{key:index,ref:"breadcrumbs",refInFor:true,class:_vm.itemClass,attrs:{"text":item.text,"href":item.href,"to":item.to,"size":_vm.size,"aria-current":_vm.getAriaCurrentAttr(index)},scopedSlots:_vm._u([{key:"default",fn:function(){return [(item.avatarPath)?_c('gl-avatar',{staticClass:"gl-breadcrumb-avatar-tile gl-border gl-mr-2",attrs:{"src":item.avatarPath,"size":_vm.avatarSize,"aria-hidden":"true","shape":"rect","data-testid":"avatar"}}):_vm._e(),_c('span',{staticClass:"gl-align-middle"},[_vm._v(_vm._s(item.text))])]},proxy:true}],null,true)})}),_vm._v(" "),(_vm.showClipboardButton)?_c('li',{staticClass:"gl-breadcrumb-clipboard-button"},[_c('clipboard-button',_vm._b({ref:"clipboardButton",staticClass:"gl-ml-2",attrs:{"data-testid":"copy-to-clipboard-button","text":_vm.clipboardButtonText,"size":_vm.dropdownSize}},'clipboard-button',_vm.clipboardTooltipText ? { title: _vm.clipboardTooltipText } : {},false))],1):_vm._e()],2)])};
254
+ var __vue_render__ = function () {var _vm=this;var _h=_vm.$createElement;var _c=_vm._self._c||_h;return _c('nav',{staticClass:"gl-breadcrumbs",style:(_vm.breadcrumbStyle),attrs:{"aria-label":_vm.ariaLabel}},[_c('ol',_vm._g(_vm._b({staticClass:"gl-breadcrumb-list breadcrumb"},'ol',_vm.$attrs,false),_vm.$listeners),[(_vm.hasCollapsible || !_vm.resizeDone)?_c('li',{ref:"dropdown",class:_vm.dropdownItemClass},[_c('gl-disclosure-dropdown',{attrs:{"items":_vm.overflowingItems,"toggle-text":_vm.showMoreLabel,"fluid-width":"","text-sr-only":"","no-caret":"","icon":"ellipsis_h","size":_vm.dropdownSize}})],1):_vm._e(),_vm._v(" "),_vm._l((_vm.fittingItems),function(item,index){return _c('gl-breadcrumb-item',{key:index,ref:"breadcrumbs",refInFor:true,class:_vm.itemClass,attrs:{"text":item.text,"href":item.href,"to":item.to,"size":_vm.size,"aria-current":_vm.getAriaCurrentAttr(index)},scopedSlots:_vm._u([{key:"default",fn:function(){return [(item.avatarPath)?_c('gl-avatar',{staticClass:"gl-breadcrumb-avatar-tile gl-border gl-mr-2",attrs:{"src":item.avatarPath,"size":_vm.avatarSize,"aria-hidden":"true","shape":"rect","data-testid":"avatar"}}):_vm._e(),_c('span',{staticClass:"gl-align-middle"},[_vm._v(_vm._s(item.text))])]},proxy:true}],null,true)})}),_vm._v(" "),(_vm.showClipboardButton)?_c('li',{staticClass:"gl-breadcrumb-clipboard-button"},[_c('clipboard-button',_vm._b({ref:"clipboardButton",staticClass:"gl-ml-2",attrs:{"data-testid":"copy-to-clipboard-button","text":_vm.clipboardButtonText,"size":_vm.dropdownSize}},'clipboard-button',_vm.clipboardTooltipText ? { title: _vm.clipboardTooltipText } : {},false))],1):_vm._e()],2)])};
251
255
  var __vue_staticRenderFns__ = [];
252
256
 
253
257
  /* style */
@@ -54,6 +54,12 @@ var script = {
54
54
  validator: value => Object.keys(breadCrumbSizeOptions).includes(value)
55
55
  }
56
56
  },
57
+ computed: {
58
+ itemClass() {
59
+ // eslint-disable-next-line @gitlab/tailwind-no-interpolation
60
+ return ['gl-breadcrumb-item', `gl-breadcrumb-item-${this.size}`];
61
+ }
62
+ },
57
63
  linkVariantUnstyled
58
64
  };
59
65
 
@@ -61,7 +67,7 @@ var script = {
61
67
  const __vue_script__ = script;
62
68
 
63
69
  /* template */
64
- var __vue_render__ = function () {var _vm=this;var _h=_vm.$createElement;var _c=_vm._self._c||_h;return _c('li',{class:("gl-breadcrumb-item gl-breadcrumb-item-" + _vm.size)},[_c('gl-link',{attrs:{"href":_vm.href,"to":_vm.to,"aria-current":_vm.ariaCurrent,"variant":_vm.$options.linkVariantUnstyled}},[_vm._t("default",function(){return [_vm._v(_vm._s(_vm.text))]})],2)],1)};
70
+ var __vue_render__ = function () {var _vm=this;var _h=_vm.$createElement;var _c=_vm._self._c||_h;return _c('li',{class:_vm.itemClass},[_c('gl-link',{attrs:{"href":_vm.href,"to":_vm.to,"aria-current":_vm.ariaCurrent,"variant":_vm.$options.linkVariantUnstyled}},[_vm._t("default",function(){return [_vm._v(_vm._s(_vm.text))]})],2)],1)};
65
71
  var __vue_staticRenderFns__ = [];
66
72
 
67
73
  /* style */
@@ -3,7 +3,7 @@ import { buttonCategoryOptions, buttonVariantOptions, buttonSizeOptions, linkVar
3
3
  import { logWarning, stopEvent } from '../../../utils/utils';
4
4
  import { isSlotEmpty } from '../../../utils/is_slot_empty';
5
5
  import { SafeLinkMixin } from '../../mixins/safe_link_mixin';
6
- import { isEvent } from '../../../vendor/bootstrap-vue/src/utils/inspect';
6
+ import { glButtonConfig } from '../../../config';
7
7
  import GlIcon from '../icon/icon';
8
8
  import GlLoadingIcon from '../loading_icon/loading_icon';
9
9
  import { SPACE, ENTER } from '../new_dropdowns/constants';
@@ -117,6 +117,14 @@ var script = {
117
117
  required: false,
118
118
  default: false
119
119
  },
120
+ /**
121
+ * Keep the button accessible while `disabled` is `true`. Uses `aria-disabled` so the element remains focusable and is announced by assistive technology.
122
+ */
123
+ accessibleDisabled: {
124
+ type: Boolean,
125
+ required: false,
126
+ default: () => glButtonConfig.accessibleDisabledButton
127
+ },
120
128
  /**
121
129
  * Denotes the target URL of the link for standard links.
122
130
  */
@@ -232,9 +240,20 @@ var script = {
232
240
  hasIconOnly() {
233
241
  return isSlotEmpty(this, 'default') && this.hasIcon && this.count == null;
234
242
  },
235
- isButtonAriaDisabled() {
243
+ isDisabledOrLoading() {
244
+ if (this.accessibleDisabled) {
245
+ return this.disabled || this.isButton && this.loading;
246
+ }
236
247
  return this.isButton && this.loading;
237
248
  },
249
+ ariaDisabled() {
250
+ if (this.isDisabledOrLoading) return 'true';
251
+ // Non-standard tags need an explicit aria-disabled value to convey interactive state.
252
+ if (this.isNonStandardTag) {
253
+ return this.accessibleDisabled ? 'false' : String(this.disabled);
254
+ }
255
+ return null;
256
+ },
238
257
  buttonClasses() {
239
258
  const classes = ['btn', 'gl-button', `btn-${this.variant}`, `btn-${this.buttonSize}`];
240
259
  if (this.category !== buttonCategoryOptions.primary) {
@@ -245,7 +264,7 @@ var script = {
245
264
  'button-ellipsis-horizontal': this.hasIconOnly && this.icon === 'ellipsis_h',
246
265
  selected: this.selected,
247
266
  'btn-block': this.displayBlock,
248
- disabled: this.disabled || this.isButtonAriaDisabled
267
+ disabled: this.disabled || this.isDisabledOrLoading
249
268
  });
250
269
  if (this.label) {
251
270
  classes.push('btn', 'btn-label');
@@ -274,12 +293,12 @@ var script = {
274
293
  return !this.isLink && !this.isButton;
275
294
  },
276
295
  tabindex() {
277
- // When disabled remove links and non-standard tags from tab order
278
- if (this.disabled) {
296
+ // Legacy: remove disabled links and non-standard tags from tab order.
297
+ if (!this.accessibleDisabled && this.disabled) {
279
298
  return this.isLink || this.isNonStandardTag ? '-1' : this.$attrs.tabindex;
280
299
  }
281
-
282
- // Add hash links and non-standard tags to tab order
300
+ // Inactive elements stay in tab order so assistive technology can discover them;
301
+ // aria-disabled communicates the inactive state instead of removing the element.
283
302
  return this.isNonStandardTag || this.isHashLink ? '0' : this.$attrs.tabindex;
284
303
  },
285
304
  computedPropsAndAttributes() {
@@ -287,18 +306,15 @@ var script = {
287
306
  const base = {
288
307
  // Type only used for "real" buttons
289
308
  type: this.isButton ? this.type : null,
290
- // Disabled only set on "real" buttons
291
- disabled: this.isButton ? this.disabled : null,
309
+ // Legacy: native disabled attribute on real buttons.
310
+ ...(!this.accessibleDisabled && this.isButton ? {
311
+ disabled: this.disabled
312
+ } : {}),
292
313
  // We add a role of button when the tag is not a link or button or when link has `href` of `#`
293
314
  role: this.isNonStandardTag || this.isHashLink ? 'button' : (_this$$attrs = this.$attrs) === null || _this$$attrs === void 0 ? void 0 : _this$$attrs.role,
294
- // We set the `aria-disabled` state for non-standard tags
295
- ...(this.isNonStandardTag ? {
296
- 'aria-disabled': String(this.disabled)
297
- } : {}),
298
315
  tabindex: this.tabindex,
299
- // We set the `aria-disabled` state for buttons while loading
300
- ...(this.isButtonAriaDisabled ? {
301
- 'aria-disabled': 'true'
316
+ ...(this.ariaDisabled !== null ? {
317
+ 'aria-disabled': this.ariaDisabled
302
318
  } : {})
303
319
  };
304
320
  if (this.isLink) {
@@ -328,7 +344,7 @@ var script = {
328
344
  const listeners = {
329
345
  ...this.$listeners
330
346
  };
331
- if (this.isButtonAriaDisabled) {
347
+ if (this.isDisabledOrLoading) {
332
348
  delete listeners.click;
333
349
  }
334
350
  return listeners;
@@ -359,7 +375,7 @@ var script = {
359
375
  // Skip if disabled
360
376
  // Add SPACE keydown handler for link has `href` of `#`
361
377
  // Add ENTER handler for non-standard tags
362
- if (!this.disabled && (this.isNonStandardTag || this.isHashLink)) {
378
+ if (!this.disabled && !this.isDisabledOrLoading && (this.isNonStandardTag || this.isHashLink)) {
363
379
  const code = event.code;
364
380
  if (code === SPACE || code === ENTER && this.isNonStandardTag) {
365
381
  const target = event.currentTarget || event.target;
@@ -371,7 +387,8 @@ var script = {
371
387
  }
372
388
  },
373
389
  maybeStopEvent(event) {
374
- if (this.isButtonAriaDisabled && isEvent(event)) {
390
+ const eventIsEvent = event instanceof Event;
391
+ if (this.isDisabledOrLoading && eventIsEvent) {
375
392
  stopEvent(event);
376
393
  }
377
394
  }
package/dist/config.js CHANGED
@@ -4,6 +4,7 @@ const i18n = translationKeys;
4
4
  const defaultConfig = {
5
5
  firstDayOfWeek: 0 // Defaults to 0 (Sunday)
6
6
  };
7
+ const glButtonConfig = {};
7
8
  let configured = false;
8
9
 
9
10
  /**
@@ -13,13 +14,15 @@ let configured = false;
13
14
  * @template TValue=string
14
15
  * @property {undefined | Object} translations Generic translations for component labels to fall back to.
15
16
  * @property {undefined | Number} firstDayOfWeek Configured first day of the week, from 0 (Sunday) to 6 (Saturday).
16
- * @property {boolean} [accessibleLoadingButton] Temporary flag to enable accessible loading button.
17
+ * @property {boolean} [accessibleDisabledButton] Temporary flag to enable the accessible disabled button.
17
18
  *
18
19
  */
19
20
  const setConfigs = function () {
20
21
  let _ref = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {},
21
22
  translations = _ref.translations,
22
- firstDayOfWeek = _ref.firstDayOfWeek;
23
+ firstDayOfWeek = _ref.firstDayOfWeek,
24
+ _ref$accessibleDisabl = _ref.accessibleDisabledButton,
25
+ accessibleDisabledButton = _ref$accessibleDisabl === void 0 ? false : _ref$accessibleDisabl;
23
26
  if (configured) {
24
27
  if (process.env.NODE_ENV === 'development') {
25
28
  throw new Error('GitLab UI can only be configured once!');
@@ -47,6 +50,23 @@ const setConfigs = function () {
47
50
  }
48
51
  Object.assign(i18n, translations);
49
52
  }
53
+
54
+ // Temporary flag to enable the accessible disabled button feature.
55
+ // This flag allows the feature to be opt-in during the rollout phase,
56
+ // giving us the flexibility to test and validate its impact on user experience.
57
+
58
+ // The global variable `accessibleDisabledButton` is set to a boolean value
59
+ // to indicate whether the button should use aria-disabled while disabled.
60
+
61
+ // Future Plan:
62
+ // Once the accessible disabled button feature is validated and stable,
63
+ // we will remove this temporary flag and make the feature the default behavior.
64
+ // At that point, there will be no need for opt-in or opt-out mechanisms for this feature.
65
+ if (typeof accessibleDisabledButton === 'boolean') {
66
+ Object.assign(glButtonConfig, {
67
+ accessibleDisabledButton
68
+ });
69
+ }
50
70
  };
51
71
 
52
- export { setConfigs as default, defaultConfig, i18n };
72
+ export { setConfigs as default, defaultConfig, glButtonConfig, i18n };
@@ -29,7 +29,6 @@ const splitAfterSymbols = (symbols, string) => {
29
29
  for (let j = 0; j < symbols.length; j += 1) {
30
30
  const symbol = symbols[j];
31
31
  if (!symbol) {
32
- // eslint-disable-next-line no-continue
33
32
  continue;
34
33
  }
35
34
  symbolFound = string.slice(i, i + symbol.length) === symbol;
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@gitlab/ui",
3
- "version": "134.0.0",
3
+ "version": "134.1.0",
4
4
  "description": "GitLab UI Components",
5
5
  "license": "MIT",
6
6
  "main": "dist/index.js",
@@ -91,8 +91,8 @@
91
91
  "resolutions": {
92
92
  "chokidar": "^4.0.3",
93
93
  "sane": "^5.0.1",
94
- "jackspeak": "2.1.1",
95
- "postcss": "8.5.13",
94
+ "jackspeak": "2.3.6",
95
+ "postcss": "8.5.14",
96
96
  "json5": "2.2.3",
97
97
  "rollup-plugin-vue/@vue/component-compiler/postcss-modules-sync/generic-names/loader-utils": "3.3.1"
98
98
  },
@@ -101,14 +101,14 @@
101
101
  "@babel/core": "^7.29.0",
102
102
  "@babel/plugin-proposal-nullish-coalescing-operator": "^7.18.6",
103
103
  "@babel/plugin-proposal-optional-chaining": "^7.21.0",
104
- "@babel/preset-env": "^7.29.3",
104
+ "@babel/preset-env": "^7.29.5",
105
105
  "@babel/preset-react": "^7.28.5",
106
106
  "@cypress/grep": "^4.1.1",
107
- "@figma/code-connect": "^1.4.4",
107
+ "@figma/code-connect": "^1.4.5",
108
108
  "@gitlab/fonts": "^1.3.1",
109
- "@gitlab/hybrid-vue": "npm:@vue/compat@3.5.30",
109
+ "@gitlab/hybrid-vue": "npm:@vue/compat@3.5.34",
110
110
  "@gitlab/svgs": "*",
111
- "@jest/test-sequencer": "30.3.0",
111
+ "@jest/test-sequencer": "30.4.1",
112
112
  "@rollup/plugin-commonjs": "^28.0.9",
113
113
  "@rollup/plugin-node-resolve": "^16.0.3",
114
114
  "@rollup/plugin-replace": "^6.0.3",
@@ -139,7 +139,7 @@
139
139
  "autoprefixer": "10.5.0",
140
140
  "axe-playwright": "^2.2.2",
141
141
  "babel-loader": "^9.2.1",
142
- "cypress": "15.14.2",
142
+ "cypress": "15.15.0",
143
143
  "cypress-real-events": "^1.15.0",
144
144
  "dompurify": "^3.1.2",
145
145
  "emoji-regex": "^10.6.0",
@@ -154,9 +154,9 @@
154
154
  "mockdate": "^3.0.5",
155
155
  "module-alias": "^2.3.4",
156
156
  "pikaday": "^1.8.0",
157
- "playwright": "^1.59.1",
158
- "playwright-core": "^1.59.1",
159
- "postcss": "8.5.13",
157
+ "playwright": "^1.60.0",
158
+ "playwright-core": "^1.60.0",
159
+ "postcss": "8.5.14",
160
160
  "postcss-loader": "8.2.1",
161
161
  "postcss-scss": "4.0.9",
162
162
  "react": "18.3.1",
@@ -84,6 +84,10 @@ export default {
84
84
  }[this.avatarSize] || 'lg'
85
85
  );
86
86
  },
87
+ rootClass() {
88
+ // eslint-disable-next-line @gitlab/tailwind-no-interpolation
89
+ return ['gl-avatars-inline', `gl-avatars-inline-${this.badgeSize}`];
90
+ },
87
91
  badgeLabel() {
88
92
  return `+${this.hiddenAvatars.length}`;
89
93
  },
@@ -106,7 +110,7 @@ export default {
106
110
  };
107
111
  </script>
108
112
  <template>
109
- <div class="gl-avatars-inline" :class="`gl-avatars-inline-${badgeSize}`">
113
+ <div :class="rootClass">
110
114
  <div v-for="(avatar, index) in visibleAvatars" :key="index" class="gl-avatars-inline-child">
111
115
  <!-- @slot Custom avatar rendering. Provide avatar object as slot prop. -->
112
116
  <slot name="avatar" :avatar="avatar">
@@ -119,6 +119,10 @@ export default {
119
119
  }
120
120
  return '';
121
121
  },
122
+ dropdownItemClass() {
123
+ // eslint-disable-next-line @gitlab/tailwind-no-interpolation
124
+ return ['gl-breadcrumb-item', `gl-breadcrumb-item-${this.size}`];
125
+ },
122
126
  dropdownSize() {
123
127
  return this.size === 'sm' ? 'small' : 'medium';
124
128
  },
@@ -257,11 +261,7 @@ export default {
257
261
  <template>
258
262
  <nav class="gl-breadcrumbs" :aria-label="ariaLabel" :style="breadcrumbStyle">
259
263
  <ol class="gl-breadcrumb-list breadcrumb" v-bind="$attrs" v-on="$listeners">
260
- <li
261
- v-if="hasCollapsible || !resizeDone"
262
- ref="dropdown"
263
- :class="`gl-breadcrumb-item gl-breadcrumb-item-${size}`"
264
- >
264
+ <li v-if="hasCollapsible || !resizeDone" ref="dropdown" :class="dropdownItemClass">
265
265
  <gl-disclosure-dropdown
266
266
  :items="overflowingItems"
267
267
  :toggle-text="showMoreLabel"
@@ -54,12 +54,18 @@ export default {
54
54
  validator: (value) => Object.keys(breadCrumbSizeOptions).includes(value),
55
55
  },
56
56
  },
57
+ computed: {
58
+ itemClass() {
59
+ // eslint-disable-next-line @gitlab/tailwind-no-interpolation
60
+ return ['gl-breadcrumb-item', `gl-breadcrumb-item-${this.size}`];
61
+ },
62
+ },
57
63
  linkVariantUnstyled,
58
64
  };
59
65
  </script>
60
66
 
61
67
  <template>
62
- <li :class="`gl-breadcrumb-item gl-breadcrumb-item-${size}`">
68
+ <li :class="itemClass">
63
69
  <gl-link
64
70
  :href="href"
65
71
  :to="to"
@@ -9,7 +9,7 @@ import {
9
9
  import { logWarning, stopEvent } from '../../../utils/utils';
10
10
  import { isSlotEmpty } from '../../../utils/is_slot_empty';
11
11
  import { SafeLinkMixin } from '../../mixins/safe_link_mixin';
12
- import { isEvent } from '../../../vendor/bootstrap-vue/src/utils/inspect';
12
+ import { glButtonConfig } from '../../../config';
13
13
  import GlIcon from '../icon/icon.vue';
14
14
  import GlLoadingIcon from '../loading_icon/loading_icon.vue';
15
15
  import { ENTER, SPACE } from '../new_dropdowns/constants';
@@ -122,6 +122,14 @@ export default {
122
122
  required: false,
123
123
  default: false,
124
124
  },
125
+ /**
126
+ * Keep the button accessible while `disabled` is `true`. Uses `aria-disabled` so the element remains focusable and is announced by assistive technology.
127
+ */
128
+ accessibleDisabled: {
129
+ type: Boolean,
130
+ required: false,
131
+ default: () => glButtonConfig.accessibleDisabledButton,
132
+ },
125
133
  /**
126
134
  * Denotes the target URL of the link for standard links.
127
135
  */
@@ -237,9 +245,20 @@ export default {
237
245
  hasIconOnly() {
238
246
  return isSlotEmpty(this, 'default') && this.hasIcon && this.count == null;
239
247
  },
240
- isButtonAriaDisabled() {
248
+ isDisabledOrLoading() {
249
+ if (this.accessibleDisabled) {
250
+ return this.disabled || (this.isButton && this.loading);
251
+ }
241
252
  return this.isButton && this.loading;
242
253
  },
254
+ ariaDisabled() {
255
+ if (this.isDisabledOrLoading) return 'true';
256
+ // Non-standard tags need an explicit aria-disabled value to convey interactive state.
257
+ if (this.isNonStandardTag) {
258
+ return this.accessibleDisabled ? 'false' : String(this.disabled);
259
+ }
260
+ return null;
261
+ },
243
262
  buttonClasses() {
244
263
  const classes = ['btn', 'gl-button', `btn-${this.variant}`, `btn-${this.buttonSize}`];
245
264
 
@@ -252,7 +271,7 @@ export default {
252
271
  'button-ellipsis-horizontal': this.hasIconOnly && this.icon === 'ellipsis_h',
253
272
  selected: this.selected,
254
273
  'btn-block': this.displayBlock,
255
- disabled: this.disabled || this.isButtonAriaDisabled,
274
+ disabled: this.disabled || this.isDisabledOrLoading,
256
275
  });
257
276
 
258
277
  if (this.label) {
@@ -284,27 +303,24 @@ export default {
284
303
  return !this.isLink && !this.isButton;
285
304
  },
286
305
  tabindex() {
287
- // When disabled remove links and non-standard tags from tab order
288
- if (this.disabled) {
306
+ // Legacy: remove disabled links and non-standard tags from tab order.
307
+ if (!this.accessibleDisabled && this.disabled) {
289
308
  return this.isLink || this.isNonStandardTag ? '-1' : this.$attrs.tabindex;
290
309
  }
291
-
292
- // Add hash links and non-standard tags to tab order
310
+ // Inactive elements stay in tab order so assistive technology can discover them;
311
+ // aria-disabled communicates the inactive state instead of removing the element.
293
312
  return this.isNonStandardTag || this.isHashLink ? '0' : this.$attrs.tabindex;
294
313
  },
295
314
  computedPropsAndAttributes() {
296
315
  const base = {
297
316
  // Type only used for "real" buttons
298
317
  type: this.isButton ? this.type : null,
299
- // Disabled only set on "real" buttons
300
- disabled: this.isButton ? this.disabled : null,
318
+ // Legacy: native disabled attribute on real buttons.
319
+ ...(!this.accessibleDisabled && this.isButton ? { disabled: this.disabled } : {}),
301
320
  // We add a role of button when the tag is not a link or button or when link has `href` of `#`
302
321
  role: this.isNonStandardTag || this.isHashLink ? 'button' : this.$attrs?.role,
303
- // We set the `aria-disabled` state for non-standard tags
304
- ...(this.isNonStandardTag ? { 'aria-disabled': String(this.disabled) } : {}),
305
322
  tabindex: this.tabindex,
306
- // We set the `aria-disabled` state for buttons while loading
307
- ...(this.isButtonAriaDisabled ? { 'aria-disabled': 'true' } : {}),
323
+ ...(this.ariaDisabled !== null ? { 'aria-disabled': this.ariaDisabled } : {}),
308
324
  };
309
325
 
310
326
  if (this.isLink) {
@@ -333,7 +349,7 @@ export default {
333
349
  ...this.$listeners,
334
350
  };
335
351
 
336
- if (this.isButtonAriaDisabled) {
352
+ if (this.isDisabledOrLoading) {
337
353
  delete listeners.click;
338
354
  }
339
355
  return listeners;
@@ -366,7 +382,11 @@ export default {
366
382
  // Skip if disabled
367
383
  // Add SPACE keydown handler for link has `href` of `#`
368
384
  // Add ENTER handler for non-standard tags
369
- if (!this.disabled && (this.isNonStandardTag || this.isHashLink)) {
385
+ if (
386
+ !this.disabled &&
387
+ !this.isDisabledOrLoading &&
388
+ (this.isNonStandardTag || this.isHashLink)
389
+ ) {
370
390
  const { code } = event;
371
391
 
372
392
  if (code === SPACE || (code === ENTER && this.isNonStandardTag)) {
@@ -377,7 +397,8 @@ export default {
377
397
  }
378
398
  },
379
399
  maybeStopEvent(event) {
380
- if (this.isButtonAriaDisabled && isEvent(event)) {
400
+ const eventIsEvent = event instanceof Event;
401
+ if (this.isDisabledOrLoading && eventIsEvent) {
381
402
  stopEvent(event);
382
403
  }
383
404
  },
@@ -1,5 +1,4 @@
1
1
  <script>
2
- /* eslint-disable no-continue */
3
2
  import { has, isString } from 'lodash-es';
4
3
 
5
4
  const PREFIX = '%{';
package/src/config.js CHANGED
@@ -6,6 +6,8 @@ export const defaultConfig = {
6
6
  firstDayOfWeek: 0, // Defaults to 0 (Sunday)
7
7
  };
8
8
 
9
+ export const glButtonConfig = {};
10
+
9
11
  let configured = false;
10
12
 
11
13
  /**
@@ -15,10 +17,10 @@ let configured = false;
15
17
  * @template TValue=string
16
18
  * @property {undefined | Object} translations Generic translations for component labels to fall back to.
17
19
  * @property {undefined | Number} firstDayOfWeek Configured first day of the week, from 0 (Sunday) to 6 (Saturday).
18
- * @property {boolean} [accessibleLoadingButton] Temporary flag to enable accessible loading button.
20
+ * @property {boolean} [accessibleDisabledButton] Temporary flag to enable the accessible disabled button.
19
21
  *
20
22
  */
21
- const setConfigs = ({ translations, firstDayOfWeek } = {}) => {
23
+ const setConfigs = ({ translations, firstDayOfWeek, accessibleDisabledButton = false } = {}) => {
22
24
  if (configured) {
23
25
  if (process.env.NODE_ENV === 'development') {
24
26
  throw new Error('GitLab UI can only be configured once!');
@@ -52,6 +54,23 @@ const setConfigs = ({ translations, firstDayOfWeek } = {}) => {
52
54
 
53
55
  Object.assign(i18n, translations);
54
56
  }
57
+
58
+ // Temporary flag to enable the accessible disabled button feature.
59
+ // This flag allows the feature to be opt-in during the rollout phase,
60
+ // giving us the flexibility to test and validate its impact on user experience.
61
+
62
+ // The global variable `accessibleDisabledButton` is set to a boolean value
63
+ // to indicate whether the button should use aria-disabled while disabled.
64
+
65
+ // Future Plan:
66
+ // Once the accessible disabled button feature is validated and stable,
67
+ // we will remove this temporary flag and make the feature the default behavior.
68
+ // At that point, there will be no need for opt-in or opt-out mechanisms for this feature.
69
+ if (typeof accessibleDisabledButton === 'boolean') {
70
+ Object.assign(glButtonConfig, {
71
+ accessibleDisabledButton,
72
+ });
73
+ }
55
74
  };
56
75
 
57
76
  export default setConfigs;
@@ -33,7 +33,6 @@ export const splitAfterSymbols = (symbols, string) => {
33
33
  const symbol = symbols[j];
34
34
 
35
35
  if (!symbol) {
36
- // eslint-disable-next-line no-continue
37
36
  continue;
38
37
  }
39
38