@gitlab/ui 128.4.0 → 128.5.0

package/dist/components/base/button/button.js

@@ -7,7 +7,6 @@ import { isEvent } from '../../../vendor/bootstrap-vue/src/utils/inspect';
 import GlIcon from '../icon/icon';
 import GlLoadingIcon from '../loading_icon/loading_icon';
 import { SPACE, ENTER } from '../new_dropdowns/constants';
-import { glButtonConfig } from '../../../config';
 import __vue_normalize__ from 'vue-runtime-helpers/dist/normalize-component.js';
 
 var script = {
@@ -77,14 +76,6 @@ var script = {
       required: false,
       default: false
     },
-    /**
-     * Keep the button accessible when `loading` is `true`.
-     */
-    accessibleLoading: {
-      type: Boolean,
-      required: false,
-      default: () => glButtonConfig.accessibleLoadingButton
-    },
     /**
      * CSS classes to add to the button text.
      */
@@ -242,10 +233,10 @@ var script = {
       return isSlotEmpty(this, 'default') && this.hasIcon && this.count == null;
     },
     isButtonDisabled() {
-      return this.disabled || this.loading;
+      return this.disabled;
     },
     isButtonAriaDisabled() {
-      return this.accessibleLoading && this.isButton && this.loading;
+      return this.isButton && this.loading;
     },
     buttonClasses() {
       const classes = ['btn', 'gl-button', `btn-${this.variant}`, `btn-${this.buttonSize}`];
@@ -310,8 +301,7 @@ var script = {
         tabindex: this.tabindex,
         // We set the `aria-disabled` state for buttons while loading
         ...(this.isButtonAriaDisabled ? {
-          'aria-disabled': 'true',
-          disabled: null
+          'aria-disabled': 'true'
         } : {})
       };
       if (this.isLink) {

package/dist/config.js

@@ -35,7 +35,6 @@ const i18n = translationKeys;
 const defaultConfig = {
   firstDayOfWeek: 0 // Defaults to 0 (Sunday)
 };
-const glButtonConfig = {};
 let configured = false;
 
 /**
@@ -51,8 +50,7 @@ let configured = false;
 const setConfigs = function () {
   let {
     translations,
-    firstDayOfWeek,
-    accessibleLoadingButton = false
+    firstDayOfWeek
   } = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {};
   if (configured) {
     if (process.env.NODE_ENV === 'development') {
@@ -87,23 +85,6 @@ const setConfigs = function () {
     }
     Object.assign(i18n, translations);
   }
-
-  // Temporary flag to enable the accessible loading button feature.
-  // This flag allows the feature to be opt-in during the rollout phase,
-  // giving us the flexibility to test and validate its impact on user experience.
-
-  // The global variable `accessibleLoadingButton` is set to a boolean value
-  // to indicate whether the button should be disabled while loading.
-
-  // Future Plan:
-  // Once the accessible loading button feature is validated and stable,
-  // we will remove this temporary flag and make the feature the default behavior.
-  // At that point, there will be no need for opt-in or opt-out mechanisms for this feature.
-  if (typeof accessibleLoadingButton === 'boolean') {
-    Object.assign(glButtonConfig, {
-      accessibleLoadingButton
-    });
-  }
 };
 
-export { setConfigs as default, defaultConfig, glButtonConfig, i18n };
+export { setConfigs as default, defaultConfig, i18n };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/ui",
-  "version": "128.4.0",
+  "version": "128.5.0",
   "description": "GitLab UI Components",
   "license": "MIT",
   "main": "dist/index.js",

package/src/components/base/button/button.vue

@@ -13,7 +13,6 @@ import { isEvent } from '../../../vendor/bootstrap-vue/src/utils/inspect';
 import GlIcon from '../icon/icon.vue';
 import GlLoadingIcon from '../loading_icon/loading_icon.vue';
 import { ENTER, SPACE } from '../new_dropdowns/constants';
-import { glButtonConfig } from '../../../config';
 
 export default {
   name: 'GlButton',
@@ -82,14 +81,6 @@ export default {
       required: false,
       default: false,
     },
-    /**
-     * Keep the button accessible when `loading` is `true`.
-     */
-    accessibleLoading: {
-      type: Boolean,
-      required: false,
-      default: () => glButtonConfig.accessibleLoadingButton,
-    },
     /**
      * CSS classes to add to the button text.
      */
@@ -247,10 +238,10 @@ export default {
       return isSlotEmpty(this, 'default') && this.hasIcon && this.count == null;
     },
     isButtonDisabled() {
-      return this.disabled || this.loading;
+      return this.disabled;
     },
     isButtonAriaDisabled() {
-      return this.accessibleLoading && this.isButton && this.loading;
+      return this.isButton && this.loading;
     },
     buttonClasses() {
       const classes = ['btn', 'gl-button', `btn-${this.variant}`, `btn-${this.buttonSize}`];
@@ -316,7 +307,7 @@ export default {
         ...(this.isNonStandardTag ? { 'aria-disabled': String(this.disabled) } : {}),
         tabindex: this.tabindex,
         // We set the `aria-disabled` state for buttons while loading
-        ...(this.isButtonAriaDisabled ? { 'aria-disabled': 'true', disabled: null } : {}),
+        ...(this.isButtonAriaDisabled ? { 'aria-disabled': 'true' } : {}),
       };
 
       if (this.isLink) {

package/src/config.js

@@ -39,8 +39,6 @@ export const defaultConfig = {
   firstDayOfWeek: 0, // Defaults to 0 (Sunday)
 };
 
-export const glButtonConfig = {};
-
 let configured = false;
 
 /**
@@ -53,7 +51,7 @@ let configured = false;
  * @property {boolean} [accessibleLoadingButton] Temporary flag to enable accessible loading button.
  *
  */
-const setConfigs = ({ translations, firstDayOfWeek, accessibleLoadingButton = false } = {}) => {
+const setConfigs = ({ translations, firstDayOfWeek } = {}) => {
   if (configured) {
     if (process.env.NODE_ENV === 'development') {
       throw new Error('GitLab UI can only be configured once!');
@@ -94,23 +92,6 @@ const setConfigs = ({ translations, firstDayOfWeek, accessibleLoadingButton = fa
 
     Object.assign(i18n, translations);
   }
-
-  // Temporary flag to enable the accessible loading button feature.
-  // This flag allows the feature to be opt-in during the rollout phase,
-  // giving us the flexibility to test and validate its impact on user experience.
-
-  // The global variable `accessibleLoadingButton` is set to a boolean value
-  // to indicate whether the button should be disabled while loading.
-
-  // Future Plan:
-  // Once the accessible loading button feature is validated and stable,
-  // we will remove this temporary flag and make the feature the default behavior.
-  // At that point, there will be no need for opt-in or opt-out mechanisms for this feature.
-  if (typeof accessibleLoadingButton === 'boolean') {
-    Object.assign(glButtonConfig, {
-      accessibleLoadingButton,
-    });
-  }
 };
 
 export default setConfigs;