@gitlab/ui 123.3.0 → 123.3.1

package/dist/components/base/new_dropdowns/disclosure/disclosure_dropdown.js

@@ -324,7 +324,15 @@ var script = {
       });
     },
     handleAutoClose(e) {
-      if (this.autoClose && e.target.closest(ITEM_SELECTOR) && this.$refs.baseDropdown.containsElement(e.target)) {
+      var _this$$refs$baseDropd, _this$$refs$baseDropd2;
+      if (this.autoClose && e.target.closest(ITEM_SELECTOR) && // The optional chaining here is to accommodate specs that use shallow mounting.
+      // Ideally, those specs would either:
+      //  - stub out the `BaseDropdown` component to include a stub `containsElement` method, or
+      //  - use a full mount.
+      //
+      // Unfortunately, GitLab has many specs which do neither of these. So the simpler thing to do
+      // is to optionally chain the method call here.
+      (_this$$refs$baseDropd = (_this$$refs$baseDropd2 = this.$refs.baseDropdown).containsElement) !== null && _this$$refs$baseDropd !== void 0 && _this$$refs$baseDropd.call(_this$$refs$baseDropd2, e.target)) {
         this.closeAndFocus();
       }
     },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/ui",
-  "version": "123.3.0",
+  "version": "123.3.1",
   "description": "GitLab UI Components",
   "license": "MIT",
   "main": "dist/index.js",
@@ -120,9 +120,9 @@
     "@storybook/vue3": "^7.6.20",
     "@storybook/vue3-webpack5": "^7.6.20",
     "@types/jest-image-snapshot": "^6.4.0",
-    "@vue/compat": "^3.5.21",
-    "@vue/compiler-sfc": "^3.5.21",
-    "@vue/server-renderer": "^3.5.21",
+    "@vue/compat": "^3.5.22",
+    "@vue/compiler-sfc": "^3.5.22",
+    "@vue/server-renderer": "^3.5.22",
     "@vue/test-utils": "1.3.6",
     "@vue/test-utils-vue3": "npm:@vue/test-utils@^2.4.6",
     "@vue/vue2-jest": "29.2.6",

package/src/components/base/new_dropdowns/disclosure/disclosure_dropdown.vue

@@ -347,7 +347,14 @@ export default {
       if (
         this.autoClose &&
         e.target.closest(ITEM_SELECTOR) &&
-        this.$refs.baseDropdown.containsElement(e.target)
+        // The optional chaining here is to accommodate specs that use shallow mounting.
+        // Ideally, those specs would either:
+        //  - stub out the `BaseDropdown` component to include a stub `containsElement` method, or
+        //  - use a full mount.
+        //
+        // Unfortunately, GitLab has many specs which do neither of these. So the simpler thing to do
+        // is to optionally chain the method call here.
+        this.$refs.baseDropdown.containsElement?.(e.target)
       ) {
         this.closeAndFocus();
       }