@gitlab/ui 109.0.0 → 109.2.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/ui",
-  "version": "109.0.0",
+  "version": "109.2.0",
   "description": "GitLab UI Components",
   "license": "MIT",
   "main": "dist/index.js",
@@ -144,7 +144,7 @@
     "axe-playwright": "^2.1.0",
     "babel-jest": "29.0.1",
     "babel-loader": "^8.0.5",
-    "cypress": "14.0.2",
+    "cypress": "14.1.0",
     "cypress-axe": "^1.4.0",
     "cypress-real-events": "^1.11.0",
     "dompurify": "^3.1.2",

package/src/components/base/new_dropdowns/dropdown_item.scss

@@ -93,6 +93,13 @@
     }
   }
 
+  // Used in Listbox to visually highlight the first item after search
+  &.gl-new-dropdown-item-highlighted .gl-new-dropdown-item-content {
+    color: var(--gl-dropdown-option-text-color-focus);
+    background-color: var(--gl-dropdown-option-background-color-unselected-focus);
+    @include gl-focus($inset: true);
+  }
+
   .gl-new-dropdown-item-content {
     @apply gl-rounded-base;
     @apply gl-border-0;

package/src/components/base/new_dropdowns/listbox/listbox.vue

@@ -7,6 +7,7 @@ import { stopEvent } from '../../../../utils/utils';
 import {
   GL_DROPDOWN_SHOWN,
   GL_DROPDOWN_HIDDEN,
+  ENTER,
   HOME,
   END,
   ARROW_DOWN,
@@ -389,6 +390,9 @@ export default {
     flattenedOptions() {
       return flattenedOptions(this.items);
     },
+    searchHasOptions() {
+      return this.flattenedOptions.length > 0 && this.searchStr;
+    },
     hasItems() {
       return this.items.length > 0;
     },
@@ -503,6 +507,16 @@ export default {
           /* Every time the list of items changes (on search),
            * the observed elements are recreated, thus we need to start obesrving them again */
           this.observeScroll();
+
+          /**
+           * Every time the list of items changes, and there is a search string,
+           * we want to visually highlight the first item
+           */
+          if (this.searchHasOptions) {
+            this.nextFocusedItemIndex = 0;
+          } else {
+            this.nextFocusedItemIndex = null;
+          }
         });
       },
     },
@@ -564,6 +578,13 @@ export default {
     onShow() {
       if (this.searchable) {
         this.focusSearchInput();
+
+        /**
+         * If the search string is not empty, highlight the first item
+         */
+        if (this.searchHasOptions) {
+          this.nextFocusedItemIndex = 0;
+        }
       } else {
         this.focusItem(this.selectedIndices[0] ?? 0, this.getFocusableListItemElements());
       }
@@ -608,6 +629,9 @@ export default {
         }
         if (this.searchable && elements.indexOf(target) === 0) {
           this.focusSearchInput();
+          if (!this.searchHasOptions) {
+            this.nextFocusedItemIndex = null;
+          }
         } else {
           this.focusNextItem(event, elements, -1);
         }
@@ -617,6 +641,11 @@ export default {
         } else {
           this.focusNextItem(event, elements, 1);
         }
+      } else if (code === ENTER && isSearchInput) {
+        if (this.searchHasOptions && elements.length > 0) {
+          this.onSelect(this.flattenedOptions[0], true);
+        }
+        stop = true;
       } else {
         stop = false;
       }
@@ -651,6 +680,9 @@ export default {
         this.onSingleSelect(item.value, isSelected);
       }
     },
+    isHighlighted(item) {
+      return this.nextFocusedItemIndex === this.flattenedOptions.indexOf(item);
+    },
     isSelected(item) {
       return this.selectedValues.some((value) => value === item.value);
     },
@@ -666,7 +698,6 @@ export default {
          */
         this.$emit('select', value);
       }
-
       this.closeAndFocus();
     },
     onMultiSelect(value, isSelected) {
@@ -866,6 +897,7 @@ export default {
           <gl-listbox-item
             :key="item.value"
             :data-testid="`listbox-item-${item.value}`"
+            :is-highlighted="isHighlighted(item)"
             :is-selected="isSelected(item)"
             :is-focused="isFocused(item)"
             :is-check-centered="isCheckCentered"
@@ -895,6 +927,7 @@ export default {
               v-for="option in item.options"
               :key="option.value"
               :data-testid="`listbox-item-${option.value}`"
+              :is-highlighted="isHighlighted(option)"
               :is-selected="isSelected(option)"
               :is-focused="isFocused(option)"
               :is-check-centered="isCheckCentered"

package/src/components/base/new_dropdowns/listbox/listbox_item.vue

@@ -24,6 +24,11 @@ export default {
       required: false,
       default: false,
     },
+    isHighlighted: {
+      type: Boolean,
+      default: false,
+      required: false,
+    },
   },
   computed: {
     checkedClasses() {
@@ -52,7 +57,7 @@ export default {
 
 <template>
   <li
-    class="gl-new-dropdown-item"
+    :class="['gl-new-dropdown-item', { 'gl-new-dropdown-item-highlighted': isHighlighted }]"
     role="option"
     :tabindex="isFocused ? 0 : -1"
     :aria-selected="isSelected"

package/src/components/charts/chart/chart.vue

@@ -41,16 +41,6 @@ export default {
       type: Object,
       required: true,
     },
-    /**
-     * Warning: this prop is deprecated and will soon be removed
-     * Please do not utilize `disableTheme` for formatting
-     * Use the `options` prop to set desired echarts formatting
-     */
-    disableTheme: {
-      type: Boolean,
-      required: false,
-      default: false,
-    },
     width: {
       type: [Number, String],
       required: false,
@@ -120,14 +110,12 @@ export default {
     },
   },
   created() {
-    if (!this.disableTheme) {
-      echarts.registerTheme(themeName, createTheme(this.options));
-    }
+    echarts.registerTheme(themeName, createTheme(this.options));
   },
   async mounted() {
     await this.$nextTick();
 
-    const chart = echarts.init(this.$refs.chart, this.disableTheme ? null : themeName, {
+    const chart = echarts.init(this.$refs.chart, themeName, {
       renderer: this.renderer,
       width: defaultWidth,
       height: defaultHeight,