@gitlab/ui 108.8.0 → 108.8.1

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [108.8.1](https://gitlab.com/gitlab-org/gitlab-ui/compare/v108.8.0...v108.8.1) (2025-02-27)
+
+
+### Bug Fixes
+
+* **GlTruncate:** Prevent total whitespace collapse ([2811b7e](https://gitlab.com/gitlab-org/gitlab-ui/commit/2811b7e7e9a7fc37bd17042063ee3e4504cb380d))
+
 # [108.8.0](https://gitlab.com/gitlab-org/gitlab-ui/compare/v108.7.0...v108.8.0) (2025-02-27)
 
 

package/dist/components/utilities/truncate/constants.js

@@ -3,5 +3,6 @@ const POSITION = {
   MIDDLE: 'middle',
   END: 'end'
 };
+const ZERO_WIDTH_SPACE = '\u200b';
 
-export { POSITION };
+export { POSITION, ZERO_WIDTH_SPACE };

package/dist/components/utilities/truncate/truncate.js

@@ -1,6 +1,6 @@
 import { GlTooltipDirective } from '../../../directives/tooltip';
 import { GlResizeObserverDirective } from '../../../directives/resize_observer/resize_observer';
-import { POSITION } from './constants';
+import { POSITION, ZERO_WIDTH_SPACE } from './constants';
 import __vue_normalize__ from 'vue-runtime-helpers/dist/normalize-component.js';
 
 //
@@ -46,8 +46,49 @@ var script = {
     middleIndex() {
       return Math.floor(this.text.length / 2);
     },
+    preventWhitespaceCollapse() {
+      // We don't use `\s` here since it includes non-breaking spaces and other
+      // non-collapsible whitespace characters.
+      // See https://infra.spec.whatwg.org/#strip-and-collapse-ascii-whitespace
+      // and https://infra.spec.whatwg.org/#ascii-whitespace.
+      const collapsibleWhitespaceChar = /^[ \n\t\r\f]$/;
+      const {
+        text,
+        middleIndex
+      } = this;
+      const lastCharOfFirstIsCollapsibleWhitespace = collapsibleWhitespaceChar.test(text.charAt(middleIndex - 1));
+      const firstCharOfLastIsCollapsibleWhitespace = collapsibleWhitespaceChar.test(text.charAt(middleIndex));
+      return lastCharOfFirstIsCollapsibleWhitespace && !firstCharOfLastIsCollapsibleWhitespace;
+    },
     first() {
-      return this.text.slice(0, this.middleIndex);
+      const first = this.text.slice(0, this.middleIndex);
+      if (this.preventWhitespaceCollapse) {
+        // Because this component's root element has an internal flex layout,
+        // whitespace at the end of the first child span and at the beginning
+        // of the second child span would be ignored (i.e., totally collapsed).
+        //
+        // This means that strings with a space character in the middle would
+        // render as if there were no space, which would be incorrect (e.g.,
+        // "Gap here" would render as "Gaphere").
+        //
+        // So, in that case, we insert a zero-width space at the end of the
+        // first child span to prevent that whitespace from being totally
+        // collapsed. In other words:
+        // 'first-part-with-space ' → 'first-part-with-space ​'
+        //
+        // If there's a whitespace character at the begging of the second child
+        // span, we do *not* do this, since the left-to-right mark (‎) just
+        // before `{{ last }}` in the template prevents the collapse of any
+        // whitespace at the start of `last`. If we ignored this edge case,
+        // we'd render a double space, which wouldn't correspond to how the
+        // string would normally render.
+        //
+        // See
+        // https://developer.mozilla.org/en-US/docs/Web/API/Document_Object_Model/Whitespace#whitespace_in_block_formatting_contexts
+        // for more information on how browsers treat whitespace.
+        return `${first}${ZERO_WIDTH_SPACE}`;
+      }
+      return first;
     },
     last() {
       return this.text.slice(this.middleIndex);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/ui",
-  "version": "108.8.0",
+  "version": "108.8.1",
   "description": "GitLab UI Components",
   "license": "MIT",
   "main": "dist/index.js",
@@ -144,7 +144,7 @@
     "axe-playwright": "^2.1.0",
     "babel-jest": "29.0.1",
     "babel-loader": "^8.0.5",
-    "cypress": "14.0.0",
+    "cypress": "14.0.2",
     "cypress-axe": "^1.4.0",
     "cypress-real-events": "^1.11.0",
     "dompurify": "^3.1.2",

package/src/components/utilities/truncate/constants.js

@@ -3,3 +3,5 @@ export const POSITION = {
   MIDDLE: 'middle',
   END: 'end',
 };
+
+export const ZERO_WIDTH_SPACE = '\u200b';

package/src/components/utilities/truncate/truncate.vue

@@ -2,7 +2,7 @@
 <script>
 import { GlTooltipDirective } from '../../../directives/tooltip';
 import { GlResizeObserverDirective } from '../../../directives/resize_observer/resize_observer';
-import { POSITION } from './constants';
+import { POSITION, ZERO_WIDTH_SPACE } from './constants';
 
 export default {
   name: 'GlTruncate',
@@ -47,8 +47,53 @@ export default {
       return Math.floor(this.text.length / 2);
     },
 
+    preventWhitespaceCollapse() {
+      // We don't use `\s` here since it includes non-breaking spaces and other
+      // non-collapsible whitespace characters.
+      // See https://infra.spec.whatwg.org/#strip-and-collapse-ascii-whitespace
+      // and https://infra.spec.whatwg.org/#ascii-whitespace.
+      const collapsibleWhitespaceChar = /^[ \n\t\r\f]$/;
+      const { text, middleIndex } = this;
+      const lastCharOfFirstIsCollapsibleWhitespace = collapsibleWhitespaceChar.test(
+        text.charAt(middleIndex - 1)
+      );
+      const firstCharOfLastIsCollapsibleWhitespace = collapsibleWhitespaceChar.test(
+        text.charAt(middleIndex)
+      );
+
+      return lastCharOfFirstIsCollapsibleWhitespace && !firstCharOfLastIsCollapsibleWhitespace;
+    },
     first() {
-      return this.text.slice(0, this.middleIndex);
+      const first = this.text.slice(0, this.middleIndex);
+
+      if (this.preventWhitespaceCollapse) {
+        // Because this component's root element has an internal flex layout,
+        // whitespace at the end of the first child span and at the beginning
+        // of the second child span would be ignored (i.e., totally collapsed).
+        //
+        // This means that strings with a space character in the middle would
+        // render as if there were no space, which would be incorrect (e.g.,
+        // "Gap here" would render as "Gaphere").
+        //
+        // So, in that case, we insert a zero-width space at the end of the
+        // first child span to prevent that whitespace from being totally
+        // collapsed. In other words:
+        // 'first-part-with-space ' → 'first-part-with-space &ZeroWidthSpace;'
+        //
+        // If there's a whitespace character at the begging of the second child
+        // span, we do *not* do this, since the left-to-right mark (&lrm;) just
+        // before `{{ last }}` in the template prevents the collapse of any
+        // whitespace at the start of `last`. If we ignored this edge case,
+        // we'd render a double space, which wouldn't correspond to how the
+        // string would normally render.
+        //
+        // See
+        // https://developer.mozilla.org/en-US/docs/Web/API/Document_Object_Model/Whitespace#whitespace_in_block_formatting_contexts
+        // for more information on how browsers treat whitespace.
+        return `${first}${ZERO_WIDTH_SPACE}`;
+      }
+
+      return first;
     },
     last() {
       return this.text.slice(this.middleIndex);