@gitlab/eslint-plugin 21.5.0 → 23.0.0

package/lib/flat-configs/typescript.js

@@ -0,0 +1,136 @@
+const js = require('@eslint/js');
+const tsPlugin = require('@typescript-eslint/eslint-plugin');
+const tsParser = require('@typescript-eslint/parser');
+const importPlugin = require('eslint-plugin-import-x');
+const globals = require('globals');
+
+const base = require('./base');
+
+/*
+  Rules related to the GitLab TypeScript style guide.
+  Base JavaScript rules live in lib/flat-configs/base.js
+
+  Two things here are load-bearing:
+
+  1. base is spread first and the `.ts` layer second, so eslint:recommended and
+     the TypeScript preset win over eslint-config-prettier inside .ts files,
+     as eslintrc's `overrides` did. Putting prettier last would not.
+
+  2. `flat/eslint-recommended` is spread alongside `strict`, because eslintrc's
+     `plugin:@typescript-eslint/strict` extended it. Without it, 19 core rules
+     that a TypeScript-aware replacement or the compiler already covers stay
+     enabled.
+*/
+const tsEslintRecommended = tsPlugin.configs['flat/eslint-recommended'];
+const tsStrict = tsPlugin.configs.strict;
+/*
+  Mirrors eslint-plugin-import's `typescript` preset. import-x's own
+  `flatConfigs.typescript` isn't used because its resolver needs
+  eslint-import-resolver-typescript.
+
+  Unlike base, this sets a resolver: import-x's default one doesn't know the
+  TypeScript extensions, so `import './foo'` wouldn't find `foo.ts`. Consumers
+  who need `paths` aliases replace it with eslint-import-resolver-typescript,
+  which also resolves everything this one does.
+*/
+const TS_EXTENSIONS = ['.ts', '.cts', '.mts', '.tsx'];
+const ALL_EXTENSIONS = [...TS_EXTENSIONS, '.js', '.jsx', '.mjs', '.cjs'];
+const importTypescriptSettings = {
+  'import-x/extensions': ALL_EXTENSIONS,
+  'import-x/external-module-folders': ['node_modules', 'node_modules/@types'],
+  'import-x/parsers': { '@typescript-eslint/parser': TS_EXTENSIONS },
+  'import-x/resolver-next': [importPlugin.createNodeResolver({ extensions: ALL_EXTENSIONS })],
+};
+
+module.exports = [
+  ...base,
+  {
+    name: '@gitlab/typescript/setup',
+    languageOptions: {
+      globals: {
+        ...globals.mocha,
+        ...globals.jest,
+      },
+    },
+    rules: {
+      'import-x/extensions': [
+        'error',
+        'ignorePackages',
+        { js: 'never', jsx: 'never', ts: 'never', tsx: 'never' },
+      ],
+    },
+  },
+  {
+    name: '@gitlab/typescript/ts',
+    files: ['**/*.ts'],
+    languageOptions: {
+      parser: tsParser,
+      parserOptions: {
+        project: ['./tsconfig.json'],
+      },
+    },
+    plugins: {
+      '@typescript-eslint': tsPlugin,
+      'import-x': importPlugin,
+    },
+    linterOptions: {
+      reportUnusedDisableDirectives: true,
+    },
+    settings: importTypescriptSettings,
+    rules: {
+      ...js.configs.recommended.rules,
+      ...tsEslintRecommended.rules,
+      ...tsStrict.rules,
+      'import-x/named': 'off',
+      semi: [2, 'always'],
+      'max-params': 'off',
+      'no-throw-literal': 'off',
+      'no-shadow': 'off',
+      'no-empty-function': 'off',
+      'no-plusplus': 'off',
+      'unicorn/no-array-callback-reference': 'off',
+      '@typescript-eslint/only-throw-error': 'error',
+      '@typescript-eslint/no-unused-vars': 'error',
+      '@typescript-eslint/no-shadow': 'error',
+      '@typescript-eslint/return-await': 'error',
+      '@typescript-eslint/no-floating-promises': 'error',
+      '@typescript-eslint/explicit-member-accessibility': ['error', { accessibility: 'no-public' }],
+      'class-methods-use-this': 'off',
+      'import-x/no-cycle': 'error',
+      'promise/param-names': 'off',
+      'no-use-before-define': ['warn', 'nofunc'],
+      'no-restricted-syntax': [
+        'error',
+        {
+          selector: ':matches(PropertyDefinition, MethodDefinition)[accessibility="private"]',
+          message: 'Use # prefix instead of `private` to indicate private class members.',
+        },
+        {
+          selector: 'ForInStatement',
+          message:
+            'for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array.',
+        },
+        {
+          selector: 'LabeledStatement',
+          message:
+            'Labels are a form of GOTO; using them makes code confusing and hard to maintain and understand.',
+        },
+        {
+          selector: 'WithStatement',
+          message:
+            '`with` is disallowed in strict mode because it makes code impossible to predict and optimize.',
+        },
+      ],
+    },
+  },
+  {
+    // Recursive: eslintrc matched a bare `*.test.ts` at any depth, flat globs
+    // are path-relative.
+    name: '@gitlab/typescript/tests',
+    files: ['**/*.test.ts', '**/*.test.js'],
+    rules: {
+      'max-classes-per-file': 'off',
+      '@typescript-eslint/no-non-null-assertion': 'off',
+    },
+  },
+];

package/lib/flat-configs/vue.js

@@ -0,0 +1,16 @@
+const prettierRules = require('../prettier-rules');
+const { presetAndSetup, gitlabRules } = require('../vue-fragments');
+
+/*
+  Rules related to the GitLab Vue style guide.
+  Base JavaScript rules live in lib/flat-configs/base.js
+
+  eslint-config-prettier sits between the preset and this package's rules,
+  switching the preset's formatting rules off. lib/flat-configs/default.js
+  orders it the other way -- see the note there.
+*/
+module.exports = [
+  ...presetAndSetup,
+  { name: '@gitlab/vue/prettier', rules: prettierRules },
+  ...gitlabRules,
+];

package/lib/index.js

@@ -1,46 +1,37 @@
 /**
  * This file is GENERATED, please run `yarn update` after adding or renaming a rule
  */
+const plugin = require('./plugin.js');
+
+/*
+  Getters, so requiring the plugin never loads a config the consumer is not
+  using: `typescript` pulls in optional peer dependencies, and eagerly
+  requiring it would throw for anyone without the TypeScript toolchain. Getters
+  in an object literal are enumerable, so `Object.keys(configs)` is unaffected.
+*/
 module.exports = {
-  rules: {
-    'no-global-event-off': require('./rules/no-global-event-off.js'),
-    'no-hardcoded-urls': require('./rules/no-hardcoded-urls.js'),
-    'no-runtime-template-compiler': require('./rules/no-runtime-template-compiler.js'),
-    'require-i18n-strings': require('./rules/require-i18n-strings.js'),
-    'require-valid-i18n-helpers': require('./rules/require-valid-i18n-helpers.js'),
-    'tailwind-no-interpolation': require('./rules/tailwind-no-interpolation.js'),
-    'tailwind-no-max-width-media-queries': require('./rules/tailwind-no-max-width-media-queries.js'),
-    'vtu-no-explicit-wrapper-destroy': require('./rules/vtu-no-explicit-wrapper-destroy.js'),
-    'vtu-no-wrapper-vm': require('./rules/vtu-no-wrapper-vm.js'),
-    'vue-no-data-toggle': require('./rules/vue-no-data-toggle.js'),
-    'vue-no-hardcoded-urls': require('./rules/vue-no-hardcoded-urls.js'),
-    'vue-no-new-non-primitive-in-template': require('./rules/vue-no-new-non-primitive-in-template.js'),
-    'vue-no-popover-target-dollar-el': require('./rules/vue-no-popover-target-dollar-el.js'),
-    'vue-no-undef-apollo-properties': require('./rules/vue-no-undef-apollo-properties.js'),
-    'vue-prefer-dollar-scopedslots': require('./rules/vue-prefer-dollar-scopedslots.js'),
-    'vue-require-i18n-attribute-strings': require('./rules/vue-require-i18n-attribute-strings.js'),
-    'vue-require-i18n-strings': require('./rules/vue-require-i18n-strings.js'),
-    'vue-require-required-key': require('./rules/vue-require-required-key.js'),
-    'vue-require-valid-i18n-helpers': require('./rules/vue-require-valid-i18n-helpers.js'),
-    'vue-slot-name-casing': require('./rules/vue-slot-name-casing.js'),
-    'vue-tailwind-no-interpolation': require('./rules/vue-tailwind-no-interpolation.js'),
-    'vue-tailwind-no-max-width-media-queries': require('./rules/vue-tailwind-no-max-width-media-queries.js'),
-  },
+  ...plugin,
   configs: {
-    base: require('./configs/base.js'),
-    'best-practices': require('./configs/base/best-practices.js'),
-    errors: require('./configs/base/errors.js'),
-    es6: require('./configs/base/es6.js'),
-    imports: require('./configs/base/imports.js'),
-    node: require('./configs/base/node.js'),
-    strict: require('./configs/base/strict.js'),
-    style: require('./configs/base/style.js'),
-    variables: require('./configs/base/variables.js'),
-    default: require('./configs/default.js'),
-    i18n: require('./configs/i18n.js'),
-    jest: require('./configs/jest.js'),
-    tailwind: require('./configs/tailwind.js'),
-    typescript: require('./configs/typescript.js'),
-    vue: require('./configs/vue.js'),
+    get base() {
+      return require('./flat-configs/base.js');
+    },
+    get default() {
+      return require('./flat-configs/default.js');
+    },
+    get i18n() {
+      return require('./flat-configs/i18n.js');
+    },
+    get jest() {
+      return require('./flat-configs/jest.js');
+    },
+    get tailwind() {
+      return require('./flat-configs/tailwind.js');
+    },
+    get typescript() {
+      return require('./flat-configs/typescript.js');
+    },
+    get vue() {
+      return require('./flat-configs/vue.js');
+    },
   },
 };

package/lib/plugin.js

@@ -0,0 +1,32 @@
+/**
+ * This file is GENERATED, please run `yarn update` after adding or renaming a rule
+ */
+const { name, version } = require('../package.json');
+
+module.exports = {
+  meta: { name, version },
+  rules: {
+    'no-global-event-off': require('./rules/no-global-event-off.js'),
+    'no-hardcoded-urls': require('./rules/no-hardcoded-urls.js'),
+    'no-runtime-template-compiler': require('./rules/no-runtime-template-compiler.js'),
+    'require-i18n-strings': require('./rules/require-i18n-strings.js'),
+    'require-valid-i18n-helpers': require('./rules/require-valid-i18n-helpers.js'),
+    'tailwind-no-interpolation': require('./rules/tailwind-no-interpolation.js'),
+    'tailwind-no-max-width-media-queries': require('./rules/tailwind-no-max-width-media-queries.js'),
+    'vtu-no-explicit-wrapper-destroy': require('./rules/vtu-no-explicit-wrapper-destroy.js'),
+    'vtu-no-wrapper-vm': require('./rules/vtu-no-wrapper-vm.js'),
+    'vue-no-data-toggle': require('./rules/vue-no-data-toggle.js'),
+    'vue-no-hardcoded-urls': require('./rules/vue-no-hardcoded-urls.js'),
+    'vue-no-new-non-primitive-in-template': require('./rules/vue-no-new-non-primitive-in-template.js'),
+    'vue-no-popover-target-dollar-el': require('./rules/vue-no-popover-target-dollar-el.js'),
+    'vue-no-undef-apollo-properties': require('./rules/vue-no-undef-apollo-properties.js'),
+    'vue-prefer-dollar-scopedslots': require('./rules/vue-prefer-dollar-scopedslots.js'),
+    'vue-require-i18n-attribute-strings': require('./rules/vue-require-i18n-attribute-strings.js'),
+    'vue-require-i18n-strings': require('./rules/vue-require-i18n-strings.js'),
+    'vue-require-required-key': require('./rules/vue-require-required-key.js'),
+    'vue-require-valid-i18n-helpers': require('./rules/vue-require-valid-i18n-helpers.js'),
+    'vue-slot-name-casing': require('./rules/vue-slot-name-casing.js'),
+    'vue-tailwind-no-interpolation': require('./rules/vue-tailwind-no-interpolation.js'),
+    'vue-tailwind-no-max-width-media-queries': require('./rules/vue-tailwind-no-max-width-media-queries.js'),
+  },
+};

package/lib/prettier-rules.js

@@ -0,0 +1,10 @@
+const prettierConfig = require('eslint-config-prettier');
+
+/*
+  eslint-config-prettier v10 also turns off `@stylistic/*` rules. This package
+  does not register that plugin, so those 180 entries are dropped. Consumers
+  using `@stylistic` should apply eslint-config-prettier themselves.
+*/
+module.exports = Object.fromEntries(
+  Object.entries(prettierConfig.rules).filter(([rule]) => !rule.startsWith('@stylistic/')),
+);

package/lib/rules/no-runtime-template-compiler.js

@@ -2,7 +2,7 @@
 // Requirements
 // ------------------------------------------------------------------------------
 const { DOCS_BASE_URL } = require('../constants');
-const utils = require('eslint-plugin-vue/lib/utils');
+const utils = require('eslint-plugin-vue/dist/utils').default;
 
 // ------------------------------------------------------------------------------
 // Rule Definition
@@ -30,7 +30,10 @@ module.exports = {
 
     return {
       ...utils.executeOnVue(context, (node, type) => {
-        if (type === 'definition' && utils.getVueComponentDefinitionType(node) === 'mixin') {
+        if (
+          type === 'definition' &&
+          utils.getVueComponentDefinitionType(context, node) === 'mixin'
+        ) {
           return;
         }
 
@@ -43,7 +46,7 @@ module.exports = {
           hasRenderFn,
         });
       }),
-      'Program:exit'(node) {
+      'Program:exit'() {
         for (const { node, templateOption, hasRenderFn } of vues) {
           if (templateOption) {
             // Components can define a render function _and_ a template option,

package/lib/rules/require-i18n-strings.js

@@ -92,7 +92,7 @@ module.exports = {
     }
 
     function stripVariables(value) {
-      return value ? value.replace(/(\%{[\w-]+})/g, '') : '';
+      return value ? value.replace(/(%{[\w-]+})/g, '') : '';
     }
 
     function getCallExpressionString(node, callee) {
@@ -143,7 +143,7 @@ module.exports = {
 
     function isMemberExpressionIdentifier(expression) {
       if (expression.type !== 'MemberExpression') return false;
-      if (!!expression.property.quasis) {
+      if (expression.property.quasis) {
         return /^\w+$/.test(getTemplateLiteralString(expression.property));
       }
       return /^\w+$/.test(expression.property.value);
@@ -164,14 +164,14 @@ module.exports = {
     }
 
     function isObjectMethod(node) {
-      if (!!node.callee.property) {
+      if (node.callee.property) {
         return objectMethods.has(node.callee.property.name);
       }
       return false;
     }
 
     function isHtmlCall(node) {
-      if (!!node.callee.property) {
+      if (node.callee.property) {
         return htmlCalls.has(node.callee.property.name);
       }
       return htmlCalls.has(node.callee.name);

package/lib/rules/vtu-no-explicit-wrapper-destroy.js

@@ -13,7 +13,7 @@ class Rule {
   #context;
 
   constructor(context, options) {
-    this.#vmWrapperNameParts = options.wrapperNames || commonVmWrapperNameParts;
+    this.#vmWrapperNameParts = options.wrapperNames;
     this.#context = context;
   }
 

package/lib/rules/vue-no-new-non-primitive-in-template.js

@@ -1,7 +1,7 @@
 // ------------------------------------------------------------------------------
 // Requirements
 // ------------------------------------------------------------------------------
-const utils = require('eslint-plugin-vue/lib/utils');
+const utils = require('eslint-plugin-vue/dist/utils').default;
 const { pickBy, identity } = require('lodash');
 const { DOCS_BASE_URL } = require('../constants');
 const { closest, NODE_TYPES } = require('../utils/rule-utils');

package/lib/rules/vue-no-undef-apollo-properties.js

@@ -2,7 +2,7 @@
 // Requirements
 // ------------------------------------------------------------------------------
 const { DOCS_BASE_URL } = require('../constants');
-const utils = require('eslint-plugin-vue/lib/utils');
+const utils = require('eslint-plugin-vue/dist/utils').default;
 
 // ------------------------------------------------------------------------------
 //   Helpers

package/lib/rules/vue-prefer-dollar-scopedslots.js

@@ -4,7 +4,7 @@
 
 const { DOCS_BASE_URL } = require('../constants');
 const { defineTemplateBodyVisitor } = require('../utils/index');
-const utils = require('eslint-plugin-vue/lib/utils');
+const utils = require('eslint-plugin-vue/dist/utils').default;
 
 // ------------------------------------------------------------------------------
 //   Helpers

package/lib/rules/vue-require-required-key.js

@@ -13,7 +13,7 @@ const NATIVE_TYPES = new Set([
   'Symbol',
 ]);
 
-const utils = require('eslint-plugin-vue/lib/utils');
+const utils = require('eslint-plugin-vue/dist/utils').default;
 
 module.exports = {
   meta: {

package/lib/rules/vue-slot-name-casing.js

@@ -4,8 +4,8 @@
 // Requirements
 // ------------------------------------------------------------------------------
 
-const utils = require('eslint-plugin-vue/lib/utils');
-const casing = require('eslint-plugin-vue/lib/utils/casing');
+const utils = require('eslint-plugin-vue/dist/utils').default;
+const casing = require('eslint-plugin-vue/dist/utils/casing');
 const { DOCS_BASE_URL } = require('../constants');
 
 // ------------------------------------------------------------------------------
@@ -24,7 +24,6 @@ module.exports = {
   },
 
   create(context) {
-    const sourceCode = context.getSourceCode();
     const caseType = 'kebab-case';
 
     let hasInvalidEOF = false;

package/lib/utils/hardcoded-urls.js

@@ -96,7 +96,7 @@ function isHardCodedUrl(context, value) {
 
   // Check for path-like patterns:
   // Starts with / followed by word characters
-  const urlPathPattern = /^\/(?![#?])[\/\.a-zA-Z0-9_-]+/;
+  const urlPathPattern = /^\/(?![#?])[/.a-zA-Z0-9_-]+/;
 
   return urlPathPattern.test(value);
 }

package/lib/utils/string-utils.js

@@ -6,13 +6,11 @@ function isFileName(value) {
 }
 
 function isPath(value) {
-  return /^([\w-_]*|\.{1,2})[\/\~]+[\w-_\/]*/.test(value);
+  return /^([\w-_]*|\.{1,2})[/~]+[\w-_/]*/.test(value);
 }
 
 function isUrl(value) {
-  return (
-    /[a-zA-Z0-9]*(:\/\/)+[a-zA-Z0-9\.]*/.test(value) || /(http){1}[s:\/a-zA-Z0-9.]*/.test(value)
-  );
+  return /[a-zA-Z0-9]*(:\/\/)+[a-zA-Z0-9.]*/.test(value) || /(http){1}[s:/a-zA-Z0-9.]*/.test(value);
 }
 
 function isMailto(str) {
@@ -39,11 +37,11 @@ function isListOfCssProperties(value) {
 
 function isCssSelector(value) {
   return (
-    /^,?\s?[\.\#\*\@]\w+.*/.test(value) ||
-    /^[a-zA-Z]+[a-zA-Z-]*[\.\#\*]+[a-zA-Z]+[a-zA-Z-]*/.test(value) ||
+    /^,?\s?[.#*@]\w+.*/.test(value) ||
+    /^[a-zA-Z]+[a-zA-Z-]*[.#*]+[a-zA-Z]+[a-zA-Z-]*/.test(value) ||
     /[a-zA-Z][a-zA-Z-]+[a-zA-Z]\.\w/.test(value) ||
     /([a-zA-Z]+[a-zA-Z-]*|\*)\[.*\]/.test(value) ||
-    /^[a-zA-Z]+[a-zA-Z-]*[\#\*]$/.test(value) ||
+    /^[a-zA-Z]+[a-zA-Z-]*[#*]$/.test(value) ||
     /^(?:[0-9]+[a-z]|[a-z]+[0-9])[a-z0-9]*\s[a-z0-9][a-z0-9]+-[a-z0-9-]*$/.test(value) ||
     isListOfCssProperties(value) ||
     isListOfHtmlElements(value)
@@ -104,7 +102,7 @@ function containsAssignment(value) {
 }
 
 function isSpecial(value) {
-  return /^[\:\%\_\&\#\?\[\$].*[^.]/.test(value) || /.*[\*\+]+$/.test(value);
+  return /^[:%_&#?[$].*[^.]/.test(value) || /.*[*+]+$/.test(value);
 }
 
 function isVariableName(value) {

package/lib/vue-fragments.js

@@ -0,0 +1,111 @@
+const vuePlugin = require('eslint-plugin-vue');
+const vueParser = require('vue-eslint-parser');
+const globals = require('globals');
+const unicornPlugin = require('eslint-plugin-unicorn');
+const promisePlugin = require('eslint-plugin-promise');
+const importPlugin = require('eslint-plugin-import-x');
+
+const gitlabPlugin = require('./plugin.js');
+
+/*
+  The Vue config in two halves, so lib/flat-configs/vue.js and
+  lib/flat-configs/default.js can each place eslint-config-prettier where it
+  belongs for them: after the preset in the former, before it in the latter.
+
+  vue2-recommended, not the identically-named 'flat/recommended', which targets
+  Vue 3. The two names have never pointed at the same preset, and retargeting
+  would move 33 rules onto consumers -- a product decision, not a config-format
+  one.
+*/
+const presetAndSetup = [
+  ...vuePlugin.configs['flat/vue2-recommended'],
+  {
+    name: '@gitlab/vue/setup',
+    languageOptions: {
+      parser: vueParser,
+      parserOptions: {
+        parser: require.resolve('espree'),
+      },
+      globals: {
+        ...globals.browser,
+        ...globals.es2020,
+      },
+      ecmaVersion: 'latest',
+      sourceType: 'module',
+    },
+    plugins: {
+      unicorn: unicornPlugin,
+      promise: promisePlugin,
+      'import-x': importPlugin,
+      '@gitlab': gitlabPlugin,
+    },
+  },
+];
+
+const gitlabRules = [
+  {
+    name: '@gitlab/vue/rules',
+    rules: {
+      'vue/html-self-closing': [
+        'error',
+        {
+          html: { void: 'any', normal: 'never', component: 'always' },
+          svg: 'always',
+          math: 'always',
+        },
+      ],
+      'vue/block-order': ['error', { order: ['script', 'template', 'style'] }],
+      // Turning this off for now as we violate this rule in many places.
+      'vue/max-attributes-per-line': 'off',
+      'vue/component-options-name-casing': ['error', 'PascalCase'],
+      'vue/component-name-in-template-casing': ['error', 'kebab-case'],
+      '@gitlab/vue-require-required-key': 'error',
+      'vue/v-slot-style': ['error', { atComponent: 'shorthand' }],
+      '@gitlab/vue-no-data-toggle': 'error',
+      '@gitlab/vue-no-popover-target-dollar-el': 'warn',
+      '@gitlab/vue-prefer-dollar-scopedslots': 'error',
+      '@gitlab/vue-slot-name-casing': 'error',
+      '@gitlab/no-runtime-template-compiler': 'error',
+      'import-x/order': [
+        'error',
+        {
+          groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'index'],
+        },
+      ],
+      // See https://gitlab.com/gitlab-org/frontend/eslint-plugin/-/issues/52.
+      'vue/component-api-style': ['error', ['options']],
+      // We might not want to enable vue/singleline-html-element-content-newline and
+      // vue/multiline-html-element-content-newline just yet as they might cause
+      // regression depending on how the consumers compile Vue templates.
+      'vue/singleline-html-element-content-newline': 'off',
+      'vue/multiline-html-element-content-newline': 'off',
+      // Disabling these as they might conflict with prettier.
+      'vue/html-indent': 'off',
+      'vue/html-closing-bracket-newline': 'off',
+      // BEGIN rules to aid migration from Vue 2.x to 3.x.
+      // See https://gitlab.com/groups/gitlab-org/-/epics/3174 for more details.
+      'vue/no-deprecated-data-object-declaration': 'error',
+      'vue/no-deprecated-events-api': 'error',
+      'vue/no-deprecated-filter': 'error',
+      'vue/no-deprecated-functional-template': 'error',
+      'vue/no-deprecated-html-element-is': 'error',
+      'vue/no-deprecated-inline-template': 'error',
+      'vue/no-deprecated-props-default-this': 'error',
+      'vue/no-deprecated-scope-attribute': 'error',
+      'vue/no-deprecated-slot-attribute': 'error',
+      'vue/no-deprecated-slot-scope-attribute': 'error',
+      'vue/no-deprecated-v-on-number-modifiers': 'error',
+      'vue/no-deprecated-vue-config-keycodes': 'error',
+      // END rules to aid migration from Vue 2.x to 3.x.
+    },
+  },
+  {
+    name: '@gitlab/vue/sfc-overrides',
+    files: ['**/*.vue'],
+    rules: {
+      'import-x/no-default-export': 'off',
+    },
+  },
+];
+
+module.exports = { presetAndSetup, gitlabRules };

package/package.json

@@ -1,12 +1,13 @@
 {
   "name": "@gitlab/eslint-plugin",
-  "version": "21.5.0",
+  "version": "23.0.0",
   "description": "GitLab package for our custom eslint rules",
   "main": "lib/index.js",
   "scripts": {
     "createRule": "./scripts/createRule.js && yarn update",
-    "update": "./scripts/updateFiles.js && prettier --write lib/index.js",
+    "update": "./scripts/updateFiles.js && prettier --write lib/plugin.js lib/index.js",
     "commit": "npx git-cz",
+    "lint": "eslint .",
     "test": "mocha"
   },
   "repository": "https://gitlab.com/gitlab-org/frontend/eslint-plugin.git",
@@ -27,30 +28,48 @@
   },
   "homepage": "https://gitlab.com/gitlab-org/frontend/eslint-plugin#readme",
   "engines": {
-    "node": ">=14"
+    "node": "^20.12.0 || ^22.0.0 || >=24.0.0"
   },
   "dependencies": {
-    "@typescript-eslint/eslint-plugin": "^7.14.1",
-    "confusing-browser-globals": "^1.0.11",
-    "eslint-config-prettier": "^9.1.0",
-    "eslint-plugin-import": "^2.29.1",
-    "eslint-plugin-jest": "^28.6.0",
+    "@eslint/js": "^9.0.0",
+    "eslint-config-prettier": "^10.0.0",
+    "eslint-plugin-import-x": "^4.17.1",
+    "eslint-plugin-jest": "^29.0.0",
     "eslint-plugin-promise": "^7.0.0",
     "eslint-plugin-tailwindcss": "^3.18.3",
     "eslint-plugin-unicorn": "^55.0.0",
-    "eslint-plugin-vue": "^9.33.0",
+    "eslint-plugin-vue": "^10.0.0",
+    "globals": "^17.0.0",
     "lodash": "^4.18.1",
-    "vue-eslint-parser": "^9.4.3"
+    "semver": "^7.0.0",
+    "vue-eslint-parser": "^10.3.0"
   },
   "peerDependencies": {
-    "eslint": "^8.57.0 || ^9.0.0"
+    "@typescript-eslint/eslint-plugin": "^8.0.0",
+    "@typescript-eslint/parser": "^8.0.0",
+    "eslint": "^9.0.0",
+    "typescript": ">=4.8.4"
+  },
+  "peerDependenciesMeta": {
+    "@typescript-eslint/eslint-plugin": {
+      "optional": true
+    },
+    "@typescript-eslint/parser": {
+      "optional": true
+    },
+    "typescript": {
+      "optional": true
+    }
   },
   "devDependencies": {
     "@changesets/cli": "^2.29.8",
-    "eslint": "^8.57.0",
+    "@typescript-eslint/eslint-plugin": "^8.0.0",
+    "@typescript-eslint/parser": "^8.0.0",
+    "eslint": "^9.0.0",
     "glob": "^7.2.0",
     "mocha": "^11.7.5",
     "prettier": "^2.6.1",
+    "typescript": "^5.0.0",
     "yarn-deduplicate": "^6.0.2"
   }
 }

package/scripts/benchmarking/checkAllStrings.js

@@ -37,7 +37,7 @@ for (let i = 0, len = allStrings.length; i < len; i++) {
 
   try {
     result = testFn(allStrings[i]) ? 'TRUE' : 'FALSE';
-  } catch (e) {
+  } catch {
     result = 'TIMEOUT';
   }