@gitlab/eslint-plugin 20.7.1 → 21.1.0

package/lib/configs/base.js

@@ -1,6 +1,4 @@
-const [, ...restrictedGlobals] = require('eslint-config-airbnb-base/rules/variables').rules[
-  'no-restricted-globals'
-];
+const confusingBrowserGlobals = require('confusing-browser-globals');
 
 /*
   This plugin contains rules related to GitLab JavaScript style guide
@@ -11,7 +9,20 @@ module.exports = {
     browser: true,
     es2020: true,
   },
-  extends: ['airbnb-base', 'prettier', 'plugin:promise/recommended'],
+  extends: [
+    ...[
+      './base/best-practices.js',
+      './base/errors',
+      './base/node',
+      './base/style',
+      './base/variables',
+      './base/es6',
+      './base/imports',
+      './base/strict',
+    ].map((f) => require.resolve(f)),
+    'prettier',
+    'plugin:promise/recommended',
+  ],
   parserOptions: {
     parser: 'espree',
     ecmaVersion: 'latest',
@@ -71,7 +82,16 @@ module.exports = {
     ],
     'no-restricted-globals': [
       'error',
-      ...restrictedGlobals,
+      {
+        name: 'isFinite',
+        message:
+          'Use Number.isFinite instead https://github.com/airbnb/javascript#standard-library--isfinite',
+      },
+      {
+        name: 'isNaN',
+        message:
+          'Use Number.isNaN instead https://github.com/airbnb/javascript#standard-library--isnan',
+      },
       {
         name: 'escape',
         message:
@@ -82,7 +102,7 @@ module.exports = {
         message:
           "The global `unescape` function is unsafe. Did you mean to use `decodeURI`, `decodeURIComponent` or lodash's `unescape` instead?",
       },
-    ],
+    ].concat(confusingBrowserGlobals),
     'import/order': [
       'error',
       {
@@ -90,6 +110,6 @@ module.exports = {
       },
     ],
     // https://docs.gitlab.com/ee/development/fe_guide/style/javascript.html#limit-number-of-parameters
-    'max-params': ['error', { max: 3 }]
+    'max-params': ['error', { max: 3 }],
   },
 };

package/lib/configs/default.js

@@ -4,7 +4,7 @@ const vueConfig = require('./vue');
 module.exports = {
   ...baseConfig,
   extends: [
-    'airbnb-base',
+    ...baseConfig.extends,
     'prettier',
     'plugin:promise/recommended',
     'plugin:vue/recommended',

package/lib/configs/jest.js

@@ -9,9 +9,12 @@ module.exports = {
         ignoreTypeOfDescribeName: true,
       },
     ],
-    'jest/no-restricted-matchers': ['error', {
-      toBeFalsy: 'Prefer a stronger matcher like `toBe(false)`',
-      toBeTruthy: 'Prefer a stronger matcher like `toBe(true)`'
-    }]
+    'jest/no-restricted-matchers': [
+      'error',
+      {
+        toBeFalsy: 'Prefer a stronger matcher like `toBe(false)`',
+        toBeTruthy: 'Prefer a stronger matcher like `toBe(true)`',
+      },
+    ],
   },
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/eslint-plugin",
-  "version": "20.7.1",
+  "version": "21.1.0",
   "description": "GitLab package for our custom eslint rules",
   "main": "lib/index.js",
   "scripts": {
@@ -31,7 +31,7 @@
   },
   "dependencies": {
     "@typescript-eslint/eslint-plugin": "^7.14.1",
-    "eslint-config-airbnb-base": "^15.0.0",
+    "confusing-browser-globals": "^1.0.11",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-import": "^2.29.1",
     "eslint-plugin-jest": "^28.6.0",