@gitlab/eslint-plugin 20.4.1 → 20.6.0

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+# [20.6.0](https://gitlab.com/gitlab-org/frontend/eslint-plugin/compare/v20.5.0...v20.6.0) (2024-11-11)
+
+
+### Features
+
+* **i18n:** Ignore typenames in rule ([07c67d8](https://gitlab.com/gitlab-org/frontend/eslint-plugin/commit/07c67d8ef85594bcb2ba18fbe92749548fc6a0e7))
+
+# [20.5.0](https://gitlab.com/gitlab-org/frontend/eslint-plugin/compare/v20.4.1...v20.5.0) (2024-10-29)
+
+
+### Features
+
+* make the package compatible with ESLint 9 ([350a8c1](https://gitlab.com/gitlab-org/frontend/eslint-plugin/commit/350a8c12abffae3072e6ad57b3ea918767906bc5))
+
 ## [20.4.1](https://gitlab.com/gitlab-org/frontend/eslint-plugin/compare/v20.4.0...v20.4.1) (2024-10-11)
 
 

package/lib/rules/no-runtime-template-compiler.js

@@ -18,7 +18,7 @@ module.exports = {
   },
   create(context) {
     const vues = [];
-    const { getDocumentFragment } = context.parserServices;
+    const { getDocumentFragment } = context?.sourceCode?.parserServices ?? context.parserServices;
     const documentFragment = getDocumentFragment ? getDocumentFragment() : null;
 
     const hasTemplateTag = () =>

package/lib/rules/require-i18n-strings.js

@@ -192,6 +192,25 @@ module.exports = {
       return node.callee && node.callee.name === 'RegExp';
     }
 
+    /**
+     *
+     * In Objects like { __typename: 'Foobar' } for GraphQL mutations /
+     * optimistic responses, etc. We don't need to translate the type name.
+     *
+     * @param node
+     * @returns {boolean}
+     */
+    function isGraphQLTypeName(node) {
+      // For object definitions
+      if (node.parent?.type === 'Property') {
+        return node.parent?.key?.name === '__typename';
+      }
+      return (
+        node.parent?.left?.type === 'MemberExpression' &&
+        node.parent?.left?.property?.name === '__typename'
+      );
+    }
+
     function canSkipLiteral(node) {
       return (
         isNewRegExp(node.parent) ||
@@ -199,6 +218,7 @@ module.exports = {
         (node.parent.left && isHtmlProperty(node.parent.left)) ||
         (node.parent.id && isHtmlProperty(node.parent.id)) ||
         (node.parent.key && isHtmlProperty(node.parent.key)) ||
+        isGraphQLTypeName(node) ||
         isTrueConstant(node.parent.parent, node.parent) ||
         isKeyList(node.parent.parent, node.parent) ||
         isMemberExpressionIdentifier(node.parent)

package/lib/utils/index.js

@@ -21,7 +21,9 @@ module.exports = {
    * @returns {Object} The merged visitor.
    */
   defineTemplateBodyVisitor(context, templateBodyVisitor, scriptVisitor) {
-    if (context.parserServices.defineTemplateBodyVisitor == null) {
+    const parserServices = context.sourceCode?.parserServices ?? context.parserServices;
+
+    if (parserServices.defineTemplateBodyVisitor == null) {
       context.report({
         loc: { line: 1, column: 0 },
         message:
@@ -29,6 +31,6 @@ module.exports = {
       });
       return {};
     }
-    return context.parserServices.defineTemplateBodyVisitor(templateBodyVisitor, scriptVisitor);
+    return parserServices.defineTemplateBodyVisitor(templateBodyVisitor, scriptVisitor);
   },
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/eslint-plugin",
-  "version": "20.4.1",
+  "version": "20.6.0",
   "description": "GitLab package for our custom eslint rules",
   "main": "lib/index.js",
   "scripts": {