@gitlab/eslint-plugin 11.0.0 → 12.1.0

package/.editorconfig

@@ -0,0 +1,18 @@
+# top-most EditorConfig file
+root = true
+
+# Unix-style newlines with a newline ending every file
+[*]
+end_of_line = lf
+trim_trailing_whitespace = true
+insert_final_newline = true
+
+[*.{js,json,vue,scss,rb,haml,yml}]
+indent_size = 2
+
+[*.{js,json,vue,scss,rb,haml,yml,md}]
+indent_style = space
+charset = utf-8
+
+[*.{md,markdown,js.snap}]
+trim_trailing_whitespace = false

package/.tool-versions

@@ -0,0 +1,2 @@
+nodejs 16.14.0
+yarn 1.22.17

package/CHANGELOG.md

@@ -1,3 +1,31 @@
+# [12.1.0](https://gitlab.com/gitlab-org/frontend/eslint-plugin/compare/v12.0.1...v12.1.0) (2022-04-07)
+
+
+### Features
+
+* update eslint-plugin-vue to 8.5.0 ([37ac645](https://gitlab.com/gitlab-org/frontend/eslint-plugin/commit/37ac645f4421ce06b083625c53356e9f6c7c5679))
+
+## [12.0.1](https://gitlab.com/gitlab-org/frontend/eslint-plugin/compare/v12.0.0...v12.0.1) (2022-03-28)
+
+
+### Bug Fixes
+
+* remove duplicate rule camelcase ([9f0523a](https://gitlab.com/gitlab-org/frontend/eslint-plugin/commit/9f0523a5cc6d0d94c8df9618e567c4a4a847287e))
+
+# [12.0.0](https://gitlab.com/gitlab-org/frontend/eslint-plugin/compare/v11.0.0...v12.0.0) (2022-03-28)
+
+
+### Features
+
+* migrate to @babel/eslint-parser ([cbaa880](https://gitlab.com/gitlab-org/frontend/eslint-plugin/commit/cbaa8803dfdd9295bf0334868fe0a0100806aa33))
+* replace plugin-filenames with plugin-unicorn ([1e4df68](https://gitlab.com/gitlab-org/frontend/eslint-plugin/commit/1e4df689311ccdc4c46e6d9889069133a109255a))
+
+
+### BREAKING CHANGES
+
+* - `babel/camelcase` rule is builtin in ESLint now as `camelcase`.
+- The minimum required Node.js version is 14.
+
 # [11.0.0](https://gitlab.com/gitlab-org/frontend/eslint-plugin/compare/v10.0.2...v11.0.0) (2022-02-22)
 
 

package/README.md

@@ -1,4 +1,4 @@
-[![pipeline status](https://gitlab.com/gitlab-org/frontend/eslint-plugin/badges/master/pipeline.svg)](https://gitlab.com/gitlab-org/frontend/eslint-plugin/commits/master)
+[![pipeline status](https://gitlab.com/gitlab-org/frontend/eslint-plugin/badges/main/pipeline.svg)](https://gitlab.com/gitlab-org/frontend/eslint-plugin/commits/main)
 [![code style: prettier](https://img.shields.io/badge/code_style-prettier-ff69b4.svg?style=flat-square)](https://github.com/prettier/prettier)
 
 # @gitlab/eslint-plugin

package/docs/development.md

@@ -32,4 +32,4 @@ All the current rule tests are available in the `tests/lib/rules` directory.
 
 ### Util tests
 
-These utilities are useful to simplify writing new tests and can be found in the `test/lib/utils` directory.
+These utilities are useful to simplify writing new tests and can be found in the `test/lib/utils` directory.

package/docs/rules/require-i18n-strings.md

@@ -90,5 +90,5 @@ If you don't need to externalize string literals in your project.
 
 ## Further Reading
 
-- Code implementation of valid and invalid examples being tested: https://gitlab.com/gitlab-org/frontend/eslint-plugin/blob/master/tests/lib/rules/require-i18n-strings.js
+- Code implementation of valid and invalid examples being tested: https://gitlab.com/gitlab-org/frontend/eslint-plugin/blob/main/tests/lib/rules/require-i18n-strings.js
 - Original GitLab CE issue which triggered this: https://gitlab.com/gitlab-org/gitlab-ce/issues/57970

package/lib/configs/default.js

@@ -15,19 +15,18 @@ module.exports = {
     'plugin:promise/recommended',
   ],
   parserOptions: {
-    parser: 'babel-eslint',
+    parser: '@babel/eslint-parser',
   },
-  plugins: ['babel', 'filenames', 'promise', 'import', '@gitlab'],
+  plugins: ['@babel', 'unicorn', 'promise', 'import', '@gitlab'],
   rules: {
-    'babel/camelcase': [
+    camelcase: [
       'error',
       {
         properties: 'never',
         ignoreDestructuring: true,
       },
     ],
-    camelcase: 'off',
-    'filenames/match-regex': ['error', '^[a-z0-9_]+$'],
+    'unicorn/filename-case': ['error', { case: 'snakeCase' }],
     'import/prefer-default-export': 'off',
     'import/no-default-export': 'error',
     'import/no-deprecated': 'error',

package/lib/constants.js

@@ -1,3 +1,3 @@
 module.exports = {
-  DOCS_BASE_URL: 'https://gitlab.com/gitlab-org/frontend/eslint-plugin/blob/master/docs/rules/',
+  DOCS_BASE_URL: 'https://gitlab.com/gitlab-org/frontend/eslint-plugin/blob/main/docs/rules/',
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/eslint-plugin",
-  "version": "11.0.0",
+  "version": "12.1.0",
   "description": "GitLab package for our custom eslint rules",
   "main": "lib/index.js",
   "scripts": {
@@ -27,32 +27,37 @@
   },
   "homepage": "https://gitlab.com/gitlab-org/frontend/eslint-plugin#readme",
   "engines": {
-    "node": ">=8.10.0"
+    "node": ">=14"
   },
   "dependencies": {
-    "babel-eslint": "^10.0.3",
+    "@babel/core": "^7.17.0",
+    "@babel/eslint-parser": "^7.17.0",
+    "@babel/eslint-plugin": "^7.17.7",
     "eslint-config-airbnb-base": "^14.2.1",
     "eslint-config-prettier": "^6.10.0",
     "eslint-plugin-babel": "^5.3.0",
-    "eslint-plugin-filenames": "^1.3.2",
     "eslint-plugin-import": "^2.22.1",
     "eslint-plugin-jest": "^23.8.2",
     "eslint-plugin-promise": "^4.2.1",
-    "eslint-plugin-vue": "^7.5.0",
-    "lodash": "^4.17.21",
-    "vue-eslint-parser": "^7.0.0"
+    "eslint-plugin-unicorn": "^40.1.0",
+    "eslint-plugin-vue": "^8.5.0",
+    "lodash": "^4.17.21"
   },
   "peerDependencies": {
     "eslint": "^7.27.0"
   },
   "devDependencies": {
     "eslint": "^7.27.0",
-    "glob": "^7.1.3",
-    "jest": "^26.6.3",
-    "prettier": "^2.2.1",
-    "pretty-quick": "^3.1.0"
+    "glob": "^7.2.0",
+    "jest": "^27.5.1",
+    "prettier": "^2.6.1",
+    "pretty-quick": "^3.1.3",
+    "vue-eslint-parser": "^8.0.1"
   },
   "release": {
+    "branches": [
+      "main"
+    ],
     "verifyConditions": [
       "@semantic-release/changelog",
       "@semantic-release/npm",

package/scripts/integration_test/bootstrap.sh

@@ -0,0 +1,38 @@
+#!/usr/bin/env bash
+# Use the unofficial bash strict mode: http://redsymbol.net/articles/unofficial-bash-strict-mode/
+set -euo pipefail; export FS=$'\n\t'
+
+SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
+SRC_DIR="$SCRIPT_DIR/../../src"
+
+if [ "$CI" != "true" ]; then
+    echo "This script is meant to run in CI"
+    exit 1
+fi
+
+if [ -d "$SRC_DIR" ]; then
+    cd "$SRC_DIR" || exit 1
+    REMOTE=$(git remote)
+    DEFAULT_BRANCH=$(git symbolic-ref "refs/remotes/${REMOTE}/HEAD" | rev | cut -d '/' -f1 | rev)
+    echo "src/ already exists, pulling default branch (${DEFAULT_BRANCH})"
+    git pull "$REMOTE" "$DEFAULT_BRANCH"
+else
+    echo "Cloning ${TARGET_REPO} into src/"
+    git clone --depth 1 "${TARGET_REPO}" "$SRC_DIR";
+    cd "$SRC_DIR" || exit 1
+fi
+
+
+echo "Installing dependencies"
+yarn install --frozen-lockfile
+
+if [ -n "${CI_MERGE_REQUEST_SOURCE_BRANCH_SHA:-}" ]; then
+    echo "We seem to be on a Merge Request..."
+    SHA="$CI_MERGE_REQUEST_SOURCE_BRANCH_SHA"
+else
+    echo "We seem to be on a branch..."
+    SHA="$CI_COMMIT_SHA"
+fi
+
+echo "Installing $CI_REPOSITORY_URL#$SHA"
+yarn add --dev "${CI_REPOSITORY_URL}#${SHA}"