@gitlab/eslint-plugin 10.0.2 → 12.0.1

package/.tool-versions

@@ -0,0 +1,2 @@
+nodejs 16.14.0
+yarn 1.22.17

package/CHANGELOG.md

@@ -1,3 +1,36 @@
+## [12.0.1](https://gitlab.com/gitlab-org/frontend/eslint-plugin/compare/v12.0.0...v12.0.1) (2022-03-28)
+
+
+### Bug Fixes
+
+* remove duplicate rule camelcase ([9f0523a](https://gitlab.com/gitlab-org/frontend/eslint-plugin/commit/9f0523a5cc6d0d94c8df9618e567c4a4a847287e))
+
+# [12.0.0](https://gitlab.com/gitlab-org/frontend/eslint-plugin/compare/v11.0.0...v12.0.0) (2022-03-28)
+
+
+### Features
+
+* migrate to @babel/eslint-parser ([cbaa880](https://gitlab.com/gitlab-org/frontend/eslint-plugin/commit/cbaa8803dfdd9295bf0334868fe0a0100806aa33))
+* replace plugin-filenames with plugin-unicorn ([1e4df68](https://gitlab.com/gitlab-org/frontend/eslint-plugin/commit/1e4df689311ccdc4c46e6d9889069133a109255a))
+
+
+### BREAKING CHANGES
+
+* - `babel/camelcase` rule is builtin in ESLint now as `camelcase`.
+- The minimum required Node.js version is 14.
+
+# [11.0.0](https://gitlab.com/gitlab-org/frontend/eslint-plugin/compare/v10.0.2...v11.0.0) (2022-02-22)
+
+
+### Features
+
+* remove unused rule vue-emit-events-with-two-args ([f9a4ddc](https://gitlab.com/gitlab-org/frontend/eslint-plugin/commit/f9a4ddc967f163bd6aa9503b5c0cf86be28617dc))
+
+
+### BREAKING CHANGES
+
+* rule 'vue-emit-events-with-two-args' was removed.
+
 ## [10.0.2](https://gitlab.com/gitlab-org/frontend/eslint-plugin/compare/v10.0.1...v10.0.2) (2022-01-12)
 
 

package/README.md

@@ -1,4 +1,4 @@
-[![pipeline status](https://gitlab.com/gitlab-org/frontend/eslint-plugin/badges/master/pipeline.svg)](https://gitlab.com/gitlab-org/frontend/eslint-plugin/commits/master)
+[![pipeline status](https://gitlab.com/gitlab-org/frontend/eslint-plugin/badges/main/pipeline.svg)](https://gitlab.com/gitlab-org/frontend/eslint-plugin/commits/main)
 [![code style: prettier](https://img.shields.io/badge/code_style-prettier-ff69b4.svg?style=flat-square)](https://github.com/prettier/prettier)
 
 # @gitlab/eslint-plugin

package/docs/development.md

@@ -32,4 +32,4 @@ All the current rule tests are available in the `tests/lib/rules` directory.
 
 ### Util tests
 
-These utilities are useful to simplify writing new tests and can be found in the `test/lib/utils` directory.
+These utilities are useful to simplify writing new tests and can be found in the `test/lib/utils` directory.

package/docs/rules/require-i18n-strings.md

@@ -90,5 +90,5 @@ If you don't need to externalize string literals in your project.
 
 ## Further Reading
 
-- Code implementation of valid and invalid examples being tested: https://gitlab.com/gitlab-org/frontend/eslint-plugin/blob/master/tests/lib/rules/require-i18n-strings.js
+- Code implementation of valid and invalid examples being tested: https://gitlab.com/gitlab-org/frontend/eslint-plugin/blob/main/tests/lib/rules/require-i18n-strings.js
 - Original GitLab CE issue which triggered this: https://gitlab.com/gitlab-org/gitlab-ce/issues/57970

package/docs/rules.md

@@ -8,7 +8,6 @@ Available rules:
 - [no-runtime-template-compiler](./rules/no-runtime-template-compiler.md): Disallow components which rely on a runtime template compiler.
 - [require-i18n-strings](./rules/require-i18n-strings.md): Detect a string which has been hard coded and requires externalization.
 - [require-valid-i18n-helpers](./rules/require-valid-i18n-helpers.md): Enforces valid usage of translation helpers in JavaScript.
-- [vue-emit-events-with-two-args](./rules/vue-emit-events-with-two-args.md): Throw an error when emit is called with more than two arguments.
 - [vue-no-data-toggle](./rules/vue-no-data-toggle.md): Restrict the use of `data-toggle` bootstrap behaviors within Vue templates
 - [vue-no-new-non-primitive-in-template](./rules/vue-no-new-non-primitive-in-template.md): Prevents non-primitive values from being declared in templates
 - [vue-require-i18n-attribute-strings](./rules/vue-require-i18n-attribute-strings.md): Detect non externalized strings in vue `<template>` attributes

package/lib/configs/default.js

@@ -15,19 +15,18 @@ module.exports = {
     'plugin:promise/recommended',
   ],
   parserOptions: {
-    parser: 'babel-eslint',
+    parser: '@babel/eslint-parser',
   },
-  plugins: ['babel', 'filenames', 'promise', 'import', '@gitlab'],
+  plugins: ['@babel', 'unicorn', 'promise', 'import', '@gitlab'],
   rules: {
-    'babel/camelcase': [
+    camelcase: [
       'error',
       {
         properties: 'never',
         ignoreDestructuring: true,
       },
     ],
-    camelcase: 'off',
-    'filenames/match-regex': ['error', '^[a-z0-9_]+$'],
+    'unicorn/filename-case': ['error', { case: 'snakeCase' }],
     'import/prefer-default-export': 'off',
     'import/no-default-export': 'error',
     'import/no-deprecated': 'error',

package/lib/constants.js

@@ -1,3 +1,3 @@
 module.exports = {
-  DOCS_BASE_URL: 'https://gitlab.com/gitlab-org/frontend/eslint-plugin/blob/master/docs/rules/',
+  DOCS_BASE_URL: 'https://gitlab.com/gitlab-org/frontend/eslint-plugin/blob/main/docs/rules/',
 };

package/lib/index.js

@@ -7,7 +7,6 @@ module.exports = {
     'no-runtime-template-compiler': require('./rules/no-runtime-template-compiler.js'),
     'require-i18n-strings': require('./rules/require-i18n-strings.js'),
     'require-valid-i18n-helpers': require('./rules/require-valid-i18n-helpers.js'),
-    'vue-emit-events-with-two-args': require('./rules/vue-emit-events-with-two-args.js'),
     'vue-no-data-toggle': require('./rules/vue-no-data-toggle.js'),
     'vue-no-new-non-primitive-in-template': require('./rules/vue-no-new-non-primitive-in-template.js'),
     'vue-require-i18n-attribute-strings': require('./rules/vue-require-i18n-attribute-strings.js'),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/eslint-plugin",
-  "version": "10.0.2",
+  "version": "12.0.1",
   "description": "GitLab package for our custom eslint rules",
   "main": "lib/index.js",
   "scripts": {
@@ -27,17 +27,19 @@
   },
   "homepage": "https://gitlab.com/gitlab-org/frontend/eslint-plugin#readme",
   "engines": {
-    "node": ">=8.10.0"
+    "node": ">=14"
   },
   "dependencies": {
-    "babel-eslint": "^10.0.3",
+    "@babel/core": "^7.17.0",
+    "@babel/eslint-parser": "^7.17.0",
+    "@babel/eslint-plugin": "^7.17.7",
     "eslint-config-airbnb-base": "^14.2.1",
     "eslint-config-prettier": "^6.10.0",
     "eslint-plugin-babel": "^5.3.0",
-    "eslint-plugin-filenames": "^1.3.2",
     "eslint-plugin-import": "^2.22.1",
     "eslint-plugin-jest": "^23.8.2",
     "eslint-plugin-promise": "^4.2.1",
+    "eslint-plugin-unicorn": "^40.1.0",
     "eslint-plugin-vue": "^7.5.0",
     "lodash": "^4.17.21",
     "vue-eslint-parser": "^7.0.0"
@@ -47,12 +49,15 @@
   },
   "devDependencies": {
     "eslint": "^7.27.0",
-    "glob": "^7.1.3",
-    "jest": "^26.6.3",
-    "prettier": "^2.2.1",
-    "pretty-quick": "^3.1.0"
+    "glob": "^7.2.0",
+    "jest": "^27.5.1",
+    "prettier": "^2.6.1",
+    "pretty-quick": "^3.1.3"
   },
   "release": {
+    "branches": [
+      "main"
+    ],
     "verifyConditions": [
       "@semantic-release/changelog",
       "@semantic-release/npm",

package/docs/rules/vue-emit-events-with-two-args.md

@@ -1,38 +0,0 @@
-# @gitlab/vue-emit-events-with-two-args
-
-Throw an error when emit is called with more than two arguments.
-
-## Rule Details
-
-It has been decided to use `mitt` as an event bus implementation and this library does not support argument list as the event arguments, [it expects two arguments only](https://github.com/developit/mitt#emit).
-
-To pass an argument list, an object should be used as the second argument.
-
-### Examples of **incorrect** code for this rule
-
-`emit` method called with more than two arguments.
-
-```javascript
-vm.$emit('keyspressed', 'enter', '1');
-vm.emit('keyspressed', 'enter', '1');
-```
-
-### Examples of **correct** code for this rule
-
-Pass an object as the second argument to `emit`.
-
-```javascript
-vm.$emit('keyspressed', { keys: ['enter', '1'] });
-vm.emit('keyspressed', { keys: ['enter', '1'] });
-```
-
-`emit` method called with one argument.
-
-```javascript
-vm.$emit('focus');
-vm.emit('focus');
-```
-
-## Options
-
-Nothing